Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

XHCI: Round TD Size up instead of down.

Browse Source 
This is what the specification dictates.
This commit is contained in:
Augustin Cavalier 2020-02-19 12:26:35 -05:00
parent 0c9e6791d8
commit 0d3250fdb5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/add-ons/kernel/busses/usb/xhci.cpp
View File

@ -822,6 +822,7 @@ XHCI::SubmitNormalRequest(Transfer *transfer)
return B_NO_MEMORY; return B_NO_MEMORY;
// Normal Stage // Normal Stage
const size_t maxPacketSize = pipe->MaxPacketSize();
size_t remaining = transfer->DataLength(); size_t remaining = transfer->DataLength();
for (int32 i = 0; i < trbCount; i++) { for (int32 i = 0; i < trbCount; i++) {
int32 trbLength = (remaining < trbSize) ? remaining : trbSize; int32 trbLength = (remaining < trbSize) ? remaining : trbSize;
@ -831,7 +832,7 @@ XHCI::SubmitNormalRequest(Transfer *transfer)
// remaining maximum-size *packets* in this TD, *not* including the // remaining maximum-size *packets* in this TD, *not* including the
// packets in the current TRB, and capped at 31 if there are more // packets in the current TRB, and capped at 31 if there are more
// than 31 packets remaining in the TD. (XHCI 1.2 § 4.11.2.4 p218.) // than 31 packets remaining in the TD. (XHCI 1.2 § 4.11.2.4 p218.)
int32 tdSize = remaining / pipe->MaxPacketSize(); int32 tdSize = (remaining + maxPacketSize - 1) / maxPacketSize;
if (tdSize > 31) if (tdSize > 31)
tdSize = 31; tdSize = 31;