Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel_extreme: fix regression introduced in hrev55419.

Browse Source 
Apparently my comment about the width and height being swapped in this
register was not visible enough, so I make it a bit more obvious by
adding some uppercase.

Change-Id: I27621032d071ed09f82aa109f37482178351db04
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4664
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Adrien Destugues 2021-10-27 14:43:21 +02:00 committed by waddlesplash
parent a1f7cb5d4e
commit 0cabd8891f
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/add-ons/accelerants/intel_extreme/Pipes.cpp
View File

@ -209,11 +209,13 @@ Pipe::ConfigureScalePos(display_mode* target)
if (gInfo->shared_info->device_type.Generation() <= 4) {
// This is "reserved" on G35 and GMA965, but needed on 945 (for which
// there is no public documentation), and I assume earlier devices as
// well. Note that the height and width are swapped when compared to
// the other registers.
// well.
//
// IMPORTANT WARNING: height and width are swapped when compared to the other registers!
// Be careful when editing this code and don't accidentally swap them!
write32(INTEL_DISPLAY_A_IMAGE_SIZE + fPipeOffset,
((uint32)(target->timing.h_display - 1) << 16)
| ((uint32)target->timing.v_display - 1));
((uint32)(target->timing.v_display - 1) << 16)
| ((uint32)target->timing.h_display - 1));
}
}