Aren
/
haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed leaks. CID 893 and 894. There are still some leaks in this file, but the code is too complex and I won't touch it. I'd feel better if someone who knows it better would have a look 

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27739 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini 2008-09-25 13:12:19 +00:00
parent 8ddfb2fdb5
commit 02de38b077
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/apps/mail/Content.cpp
View File

@ -1216,6 +1216,7 @@ TTextView::MessageReceived(BMessage *msg)
} }
if (file.Read(text, size) < B_OK) { if (file.Read(text, size) < B_OK) {
puts("could not read from file"); puts("could not read from file");
free(text);
continue; continue;
} }
if (!inserted) { if (!inserted) {
@ -2515,8 +2516,7 @@ TTextView::Reader::Run(void *_this)
header = eol; header = eol;
} }
if (buffer) free(buffer);
free(buffer);
reader->Process("\r\n", 2, true); reader->Process("\r\n", 2, true);
} }
else if (!reader->Process(msg, len, true)) else if (!reader->Process(msg, len, true))
@ -2597,8 +2597,7 @@ done:
reader->Unlock(); reader->Unlock();
delete reader; delete reader;
if (msg) free(msg);
free(msg);
return B_NO_ERROR; return B_NO_ERROR;
} }
@ -3120,9 +3119,11 @@ TTextView::AddQuote(int32 start, int32 finish)
int32 lineLength = index - lastLine + 1; int32 lineLength = index - lastLine + 1;
target = (char *)realloc(target, targetLength + lineLength + quoteLength); target = (char *)realloc(target, targetLength + lineLength + quoteLength);
if (target == NULL) if (target == NULL) {
// free the old buffer? // free the old buffer?
free(text);
return; return;
}
// copy the quote sign // copy the quote sign
memcpy(&target[targetLength], QUOTE, quoteLength); memcpy(&target[targetLength], QUOTE, quoteLength);