Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
09a8f74d70
haiku/headers/os/interface/ControlLook.h

459 lines
15 KiB
C
Raw Normal View History

Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
/*
IK: Update scroll bars for alternative control look Scroll bars should look and work identically to before on HaikuControlLook. Add DrawScrollBarButton() and DrawScrollBarThumb() and DrawScrollBarBorder() methods. These methods are used to draw scroll bars in a generic way so that they can be drawn differently by alternative control look's (e.g. BeControlLook). Also it gives us back drawing of scroll bar knobs. However the knob setting is not exposed in the interface in this commit. These methods are in addition to the 2 existing DrawScrollBarBackground() methods that draw the scroll bar background. One draws the area above and below the thumb and the other is called by the first to actually draw the area. The rest of the drawing besides the backgrounds was being done in BScrollBar before. To draw the scroll bar arrows and thumb we were recyling other ControlLook methods, while this worked well enough on HaikuControlLook it wasn't flexible enough for alternative control looks. DrawScrollBarButton() is used to draw the four scroll buttons and is typically (so far) used in combination with DrawArrowShape(). DrawScrollBarThumb() draws the scroll bar thumb. DrawScrollBarBorder() draws a 1px border around the entire scroll bar, potentially B_KEYBOARD_NAVIGATION_COLOR if focused (although this is feature not currently used.) Draw unscrollable scroll bars as if they were disabled including the buttons with their arrow shapes, background, and thumb. Add FBC backwords compatibility macros in ControlLook.cpp Change-Id: I9237c5ce45d17d674785111d51de951e5686306b Reviewed-on: https://review.haiku-os.org/c/haiku/+/351 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-03-04 13:03:47 +03:00
* Copyright 2009-2020 Haiku, Inc. All rights reserved.
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
* Distributed under the terms of the MIT License.
*/
#ifndef _CONTROL_LOOK_H
#define _CONTROL_LOOK_H
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
#include <Alignment.h>
#include <Font.h>
#include <Rect.h>
#include <Slider.h>
BControlLook: Add DrawLabel() variants with icon A label, a bitmap, or both can be specified.
2013-12-22 05:01:13 +04:00
class BBitmap;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
class BControl;
class BGradientLinear;
class BView;
Finished unifying the Interface Kit headers: * Fixed copyrights (puncuation and capitalization, removed authors from headers) * Updated indentation style * Unified pointer/reference style * Re-ordered some methods for better grouping where it could be done (abd adopted source accordingly) * Small coding style fixes here and there No functional change intended. +alphabranch git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-27 15:12:41 +04:00
// WARNING! This is experimental API and may change! Be prepared to
// recompile your software in a next version of haiku.
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
namespace BPrivate {
class BControlLook {
public:
BControlLook();
virtual ~BControlLook();
Added TODO about possibly better way to name some constants. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36081 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-04-08 14:03:43 +04:00
// TODO: Probably more convenient to pull these enums into global
// namespace and rename them to e.g. "B_CONTROL_LOOK_FOCUSED" instead of
// "BControlLook::B_FOCUSED".
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
enum frame_type {
B_BUTTON_FRAME,
BControlLook: Add methods for getting insets * Update the previously unused frame_type and background_type enums. * Add methods GetFrameInsets(), GetBackgroundInsets(), GetInsets() to get the insets for a given frame type, background type, or both respectively.
2013-12-22 04:57:36 +04:00
B_GROUP_FRAME,
B_MENU_FIELD_FRAME,
B_SCROLL_VIEW_FRAME,
B_TEXT_CONTROL_FRAME,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
};
enum background_type {
B_BUTTON_BACKGROUND,
BButton: Add optional pop-up marker * Add behavior constant B_POP_UP_BEHAVIOR which adds a pop-up marker to the button (similar to that of BMenuField). * Add methods [Set]PopUpMessage(). To set/get the the message that is sent to the button's target when the pop-up marker is clicked.
2013-12-30 07:42:52 +04:00
B_BUTTON_WITH_POP_UP_BACKGROUND,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
B_MENU_BACKGROUND,
BControlLook: Add methods for getting insets * Update the previously unused frame_type and background_type enums. * Add methods GetFrameInsets(), GetBackgroundInsets(), GetInsets() to get the insets for a given frame type, background type, or both respectively.
2013-12-22 04:57:36 +04:00
B_MENU_BAR_BACKGROUND,
B_MENU_FIELD_BACKGROUND,
B_MENU_ITEM_BACKGROUND,
B_HORIZONTAL_SCROLL_BAR_BACKGROUND,
B_VERTICAL_SCROLL_BAR_BACKGROUND,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
};
enum {
B_LEFT_BORDER = 1 << 0,
B_RIGHT_BORDER = 1 << 1,
B_TOP_BORDER = 1 << 2,
B_BOTTOM_BORDER = 1 << 3,
B_ALL_BORDERS = B_LEFT_BORDER | B_RIGHT_BORDER
| B_TOP_BORDER | B_BOTTOM_BORDER
};
Added method to draw an arrow shape like that of the BScrollBar. TODO: Adjust BScrollBar to use it. TODO: Make it virtual like the others, but I don't want to break Vision and other native Haiku apps just now. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29630 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-21 20:22:56 +03:00
enum {
B_LEFT_ARROW = 0,
B_RIGHT_ARROW = 1,
B_UP_ARROW = 2,
Add diagonal arrows to ControlLook DrawArrowShape() method
2013-04-07 08:34:13 +04:00
B_DOWN_ARROW = 3,
B_LEFT_UP_ARROW = 4,
B_RIGHT_UP_ARROW = 5,
B_RIGHT_DOWN_ARROW = 6,
B_LEFT_DOWN_ARROW = 7
Added method to draw an arrow shape like that of the BScrollBar. TODO: Adjust BScrollBar to use it. TODO: Make it virtual like the others, but I don't want to break Vision and other native Haiku apps just now. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29630 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-21 20:22:56 +03:00
};
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
enum {
BCheckBox: Add tri-state support * Add possible control state B_CONTROL_PARTIALLY_ON and support it in BCheckBox and BControlLook. * BCheckBox: Add partialStateToOff property defining whether the partial state should transition to off. Defaults to false (i.e. partial to on).
2013-12-21 05:06:59 +04:00
B_FOCUSED = 1 << 0,
B_CLICKED = 1 << 1, // some controls activate on mouse up
B_ACTIVATED = 1 << 2,
B_HOVER = 1 << 3,
B_DISABLED = 1 << 4,
B_DEFAULT_BUTTON = 1 << 5,
B_IGNORE_OUTLINE = 1 << 6,
B_PARTIALLY_ACTIVATED = 1 << 7, // like B_ACTIVATED, but for tri-state
BButton: Add flat property * Add methods SetFlat()/IsFlat(). A flat button doesn't draw its frame, unless the mouse is hovering over it or it is otherwise activated. * As a side effect this change also activates the hover glow that was already implemented in BControlLook, but not activated in BButton.
2013-12-29 03:02:35 +04:00
B_FLAT = 1 << 8, // flat look (e.g. button background)
Introduce "invalid" text controls. * MarkAsInvalid is used to enable or disable the mark * The B_INVALID BControlLook flag is used * invalid BTextControls are drawn with a red border. * You ar encouraged to let the user know more precisely what's wrong, by showing an helpful error message next to the control or in a tooltip.
2014-10-01 14:09:27 +04:00
B_INVALID = 1 << 9, // invalid value, use B_FAILURE_COLOR
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
B_IS_CONTROL = 1 << 10, // use control colors
Introduce the possiblity to draw certain frames with alpha blending on top of an existing background. It's not supported by many frame types yet, but BButton and TextControl frames work as well as the soft recessed frame which many controls use. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29762 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-28 22:37:43 +03:00
Introduce "invalid" text controls. * MarkAsInvalid is used to enable or disable the mark * The B_INVALID BControlLook flag is used * invalid BTextControls are drawn with a red border. * You ar encouraged to let the user know more precisely what's wrong, by showing an helpful error message next to the control or in a tooltip.
2014-10-01 14:09:27 +04:00
B_BLEND_FRAME = 1 << 16,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
};
IK: Update scroll bars for alternative control look Scroll bars should look and work identically to before on HaikuControlLook. Add DrawScrollBarButton() and DrawScrollBarThumb() and DrawScrollBarBorder() methods. These methods are used to draw scroll bars in a generic way so that they can be drawn differently by alternative control look's (e.g. BeControlLook). Also it gives us back drawing of scroll bar knobs. However the knob setting is not exposed in the interface in this commit. These methods are in addition to the 2 existing DrawScrollBarBackground() methods that draw the scroll bar background. One draws the area above and below the thumb and the other is called by the first to actually draw the area. The rest of the drawing besides the backgrounds was being done in BScrollBar before. To draw the scroll bar arrows and thumb we were recyling other ControlLook methods, while this worked well enough on HaikuControlLook it wasn't flexible enough for alternative control looks. DrawScrollBarButton() is used to draw the four scroll buttons and is typically (so far) used in combination with DrawArrowShape(). DrawScrollBarThumb() draws the scroll bar thumb. DrawScrollBarBorder() draws a 1px border around the entire scroll bar, potentially B_KEYBOARD_NAVIGATION_COLOR if focused (although this is feature not currently used.) Draw unscrollable scroll bars as if they were disabled including the buttons with their arrow shapes, background, and thumb. Add FBC backwords compatibility macros in ControlLook.cpp Change-Id: I9237c5ce45d17d674785111d51de951e5686306b Reviewed-on: https://review.haiku-os.org/c/haiku/+/351 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-03-04 13:03:47 +03:00
enum {
B_KNOB_NONE = 0,
B_KNOB_DOTS,
B_KNOB_LINES
};
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
virtual BAlignment DefaultLabelAlignment() const = 0;
virtual float DefaultLabelSpacing() const = 0;
* Added a (to be virtual) DefaultItemSpacing() method to control look. This is what you should use in for example BGroupLayout as spacing/inset. * Changed the label spacing to be dependent on the font size, too (and enlarged it a bit as well). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33621 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-10-17 21:01:22 +04:00
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
virtual float DefaultItemSpacing() const = 0;
* Add new spacing/inset constants for the layout API. For now, leave B_USE_DEFAULT_SPACING, but this will go soon. * Rename BControlLook::ComposeItemSpacing() to ComposeSpacing(), and extend it to handle the new constants. * Adjust users of BControlLook::ComposeItemSpacing() accordingly. * part of #7447 git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42025 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-06-08 00:40:56 +04:00
static float ComposeSpacing(float spacing);
* Added a (to be virtual) DefaultItemSpacing() method to control look. This is what you should use in for example BGroupLayout as spacing/inset. * Changed the label spacing to be dependent on the font size, too (and enlarged it a bit as well). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33621 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-10-17 21:01:22 +04:00
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
virtual uint32 Flags(BControl* control) const = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
* Stronger BMenuField popup indicator. * Softer recessed frame for BMenuField to distinguish more from BButton and make it slightly more similar to BTextControl. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29235 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-16 16:57:31 +03:00
virtual void DrawButtonFrame(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
The button and menu field draw routines take a background color into account, which makes the resessed frame blend better with the surroundings. This can be seen best in Keymap, where a different color is set on some buttons, but the resessed frame should still be the same across all those buttons. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29716 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-26 02:34:19 +03:00
const rgb_color& background,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawButtonFrame(BView* view, BRect& rect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
const BRect& updateRect,
float radius,
const rgb_color& base,
const rgb_color& background,
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawButtonFrame(BView* view, BRect& rect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
const BRect& updateRect,
float leftTopRadius,
float rightTopRadius,
float leftBottomRadius,
float rightBottomRadius,
const rgb_color& base,
const rgb_color& background,
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawButtonBackground(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawButtonBackground(BView* view, BRect& rect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
const BRect& updateRect,
float radius,
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawButtonBackground(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
float leftTopRadius,
float rightTopRadius,
float leftBottomRadius,
float rightBottomRadius,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawMenuBarBackground(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
Make BMenuBar background drawing more flexible and also support an "activated" state. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29597 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-18 20:18:06 +03:00
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
* Stronger BMenuField popup indicator. * Softer recessed frame for BMenuField to distinguish more from BButton and make it slightly more similar to BTextControl. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29235 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-16 16:57:31 +03:00
virtual void DrawMenuFieldFrame(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base,
The button and menu field draw routines take a background color into account, which makes the resessed frame blend better with the surroundings. This can be seen best in Keymap, where a different color is set on some buttons, but the resessed frame should still be the same across all those buttons. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29716 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-26 02:34:19 +03:00
const rgb_color& background,
* Stronger BMenuField popup indicator. * Softer recessed frame for BMenuField to distinguish more from BButton and make it slightly more similar to BTextControl. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29235 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-16 16:57:31 +03:00
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawMenuFieldFrame(BView* view, BRect& rect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
const BRect& updateRect,
float radius,
const rgb_color& base,
const rgb_color& background,
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawMenuFieldFrame(BView* view, BRect& rect,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
const BRect& updateRect,
float leftTopRadius,
float rightTopRadius,
float leftBottomRadius,
float rightBottomRadius,
const rgb_color& base,
const rgb_color& background,
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
* Stronger BMenuField popup indicator. * Softer recessed frame for BMenuField to distinguish more from BButton and make it slightly more similar to BTextControl. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29235 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-16 16:57:31 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawMenuFieldBackground(BView* view,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect& rect, const BRect& updateRect,
const rgb_color& base, bool popupIndicator,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 flags = 0) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawMenuFieldBackground(BView* view,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
BRect& rect, const BRect& updateRect,
float radius, const rgb_color& base,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
bool popupIndicator, uint32 flags = 0) = 0;
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawMenuFieldBackground(BView* view,
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
BRect& rect, const BRect& updateRect,
float leftTopRadius,
float rightTopRadius,
float leftBottomRadius,
float rightBottomRadius,
const rgb_color& base,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
bool popupIndicator, uint32 flags = 0) = 0;
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawMenuFieldBackground(BView* view,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect& rect, const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawMenuBackground(BView* view,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect& rect, const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawMenuItemBackground(BView* view,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect& rect, const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawStatusBar(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
const rgb_color& barColor,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
float progressPosition) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawCheckBox(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 flags = 0) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawRadioButton(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 flags = 0) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Revert "BScrollBar: Add lines and dots knob styles to scroll bar" This reverts commit ec1b18c58ae632444200f7e1f952ddd2e31048fa. This was not well enough reviewed, and it seems that at least some consumers of the old API (e.g. WebPositive) need more than the new one provides. Change-Id: Ie7ad1fc70dab889922424298661504b00f66d31d
2018-07-22 21:24:47 +03:00
virtual void DrawScrollBarBackground(BView* view,
BRect& rect1, BRect& rect2,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags,
Revert "BScrollBar: Add lines and dots knob styles to scroll bar" This reverts commit ec1b18c58ae632444200f7e1f952ddd2e31048fa. This was not well enough reviewed, and it seems that at least some consumers of the old API (e.g. WebPositive) need more than the new one provides. Change-Id: Ie7ad1fc70dab889922424298661504b00f66d31d
2018-07-22 21:24:47 +03:00
orientation orientation) = 0;
virtual void DrawScrollBarBackground(BView* view,
BRect& rect, const BRect& updateRect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const rgb_color& base, uint32 flags,
Revert "BScrollBar: Add lines and dots knob styles to scroll bar" This reverts commit ec1b18c58ae632444200f7e1f952ddd2e31048fa. This was not well enough reviewed, and it seems that at least some consumers of the old API (e.g. WebPositive) need more than the new one provides. Change-Id: Ie7ad1fc70dab889922424298661504b00f66d31d
2018-07-22 21:24:47 +03:00
orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawScrollViewFrame(BView* view,
Moved the BScrollView frame drawing entirely into BControlLook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29661 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-23 14:19:31 +03:00
BRect& rect, const BRect& updateRect,
BRect verticalScrollBarFrame,
BRect horizontalScrollBarFrame,
const rgb_color& base,
ControlLook: Rename border param to borderStyle border vs. borders is confusing. BTabView: Rename border param to borderStyle BTabView docs: rename border param to borderStyle enumerate border styles in docs
2016-04-29 23:57:50 +03:00
border_style borderStyle,
Moved the BScrollView frame drawing entirely into BControlLook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29661 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-23 14:19:31 +03:00
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Moved the BScrollView frame drawing entirely into BControlLook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29661 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-23 14:19:31 +03:00
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawArrowShape(BView* view,
Added method to draw an arrow shape like that of the BScrollBar. TODO: Adjust BScrollBar to use it. TODO: Make it virtual like the others, but I don't want to break Vision and other native Haiku apps just now. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29630 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-21 20:22:56 +03:00
BRect& rect, const BRect& updateRect,
const rgb_color& base, uint32 direction,
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
float tint = B_DARKEN_MAX_TINT) = 0;
Added method to draw an arrow shape like that of the BScrollBar. TODO: Adjust BScrollBar to use it. TODO: Make it virtual like the others, but I don't want to break Vision and other native Haiku apps just now. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29630 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-03-21 20:22:56 +03:00
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
virtual rgb_color SliderBarColor(const rgb_color& base) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawSliderBar(BView* view, BRect rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
rgb_color leftFillColor,
rgb_color rightFillColor,
float sliderScale, uint32 flags,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
virtual void DrawSliderBar(BView* view, BRect rect,
const BRect& updateRect,
const rgb_color& base, rgb_color fillColor,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 flags, orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
virtual void DrawSliderThumb(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base, uint32 flags,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawSliderTriangle(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation) = 0;
Improved the look of the slider triangle thumb. Still missing is the vertical version. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29311 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-24 14:09:27 +03:00
virtual void DrawSliderTriangle(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base,
const rgb_color& fill, uint32 flags,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
virtual void DrawSliderHashMarks(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base, int32 count,
hash_mark_location location,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 flags, orientation orientation) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawActiveTab(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
ControlLook: Add side parameter to tab drawing functions. * This allows drawing tabs on any side of the view. Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2017-01-21 19:22:16 +03:00
uint32 borders = B_ALL_BORDERS,
BeControlLook: Fix app integration drawing issues Update BTab::DrawTab() to pass the current index, the index of the selected tab, and the index of the first and last tabs into BControlLook::DrawActiveTab() and BControlLook::DrawInactiveTab(). This allows you to draw tabs differently in your BTab or BControlLook subclass in many different circumstances. Modify BControlLook API to add indexes to DrawActiveTab() and DrawInactiveTab() like so: void DrawActiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); void DrawInactiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); These extra indexes are not used by HaikuControlLook which relies only on if the tab is active or inactive to draw. Add IndexOf(BTab* tab) method to BTabView and document it to get the index of the current tab in BTab::DrawTab(). Also add a warning in the BTabView::DrawTab() method not to use the position and full parameters anymore, use BTabView::IndexOf(), BTabView::Selection(), and BTabView::TabCount() to get the info you need. Using a dynamic_cast to a BTabView in BeControlLook to determine if the view is derived from a BTabView didn't work in the case of WebPositive. Furthermore, WebPositive does custom tab drawing which needed to be updated for alternative control look. These index parameters passed from BTab to BeControlLook allow us to draw the tab like BeOS without relying on a dynamic_cast to BTabView to get the info. Reproduce the functionality described above for BTab in WebPositive's custom tabs. Eliminate no longer needed code in favor of using indexes. Update WebPositive custom tabs to use BControlLook::DrawTabFrame() instead of BControlLook::DrawInactiveTab() matching the update made in BTabView. In BeControlLook::DrawTabFrame() fill rect with base color, WebPositive doesn't draw any tab background, so it expects this work to be done for it. Eliminate hasFrames variable from WebPositive. Rename TabSelected(index) to UpdateSelection(index) in WebPositive to better reflect its purpose. Adjusted HaikuControlLook::DrawInactiveTab() to draw the tab borders more selectively. Only draw border if left border is set for top and bottom tabs or top border is set for left and right tabs. Undo no longer needed frame manipulation border drawing workaround in HaikuControlLook::DrawTabFrame(). Draw scroll bar triangle without using DrawArrowShape(). Unlike in HaikuControlLook, DrawArrowShape() is used to draw arrows in BOutlineListView and menus distinctly from how it draws arrows in scroll bars. Draw our distinct arrows in DrawSrollBarButtons() instead. This fixes overflow of time edit up-down arrows in Clock prefs and the collapse-expand arrow in Deskbar not being vertically centered. In DrawBorders() only inset if we actually draw the border. Fix alignment issues with DrawSliderThumb dots for example in MediaPlayer volume knobs. Draw using line arrays calling AddLine instead of StrokeLine in several places. DrawMenuBar() extends to draw final pixel which eliminates an extra lines at the end of menu bars. Truncate button labels better fixing a few issues for example keymap keyboard layout button labels. Button insets has been updated a bit to fix drawing issues with buttons missing a border. Using a dynamic_cast to a BButton to determine if a view is a button in BeControlLook didn't work in the case of the keymap label. Look for B_FLAT, B_HOVER, or B_DEFAULT_BUTTON flag in BeControlLook::DrawLabel() to draw the label inverted on click. Pass the B_FLAT flag from Keymap keys when drawing using BControlLook so that the label is inverted. Change-Id: I07631f4b006bdb9aeca2adc9cbdf2da54dae8e92 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2866 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-02 00:15:29 +03:00
uint32 side = B_TOP_BORDER,
int32 index = 0, int32 selected = -1,
int32 first = 0, int32 last = 0) = 0;
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawInactiveTab(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
ControlLook: Add side parameter to tab drawing functions. * This allows drawing tabs on any side of the view. Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2017-01-21 19:22:16 +03:00
uint32 borders = B_ALL_BORDERS,
BeControlLook: Fix app integration drawing issues Update BTab::DrawTab() to pass the current index, the index of the selected tab, and the index of the first and last tabs into BControlLook::DrawActiveTab() and BControlLook::DrawInactiveTab(). This allows you to draw tabs differently in your BTab or BControlLook subclass in many different circumstances. Modify BControlLook API to add indexes to DrawActiveTab() and DrawInactiveTab() like so: void DrawActiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); void DrawInactiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); These extra indexes are not used by HaikuControlLook which relies only on if the tab is active or inactive to draw. Add IndexOf(BTab* tab) method to BTabView and document it to get the index of the current tab in BTab::DrawTab(). Also add a warning in the BTabView::DrawTab() method not to use the position and full parameters anymore, use BTabView::IndexOf(), BTabView::Selection(), and BTabView::TabCount() to get the info you need. Using a dynamic_cast to a BTabView in BeControlLook to determine if the view is derived from a BTabView didn't work in the case of WebPositive. Furthermore, WebPositive does custom tab drawing which needed to be updated for alternative control look. These index parameters passed from BTab to BeControlLook allow us to draw the tab like BeOS without relying on a dynamic_cast to BTabView to get the info. Reproduce the functionality described above for BTab in WebPositive's custom tabs. Eliminate no longer needed code in favor of using indexes. Update WebPositive custom tabs to use BControlLook::DrawTabFrame() instead of BControlLook::DrawInactiveTab() matching the update made in BTabView. In BeControlLook::DrawTabFrame() fill rect with base color, WebPositive doesn't draw any tab background, so it expects this work to be done for it. Eliminate hasFrames variable from WebPositive. Rename TabSelected(index) to UpdateSelection(index) in WebPositive to better reflect its purpose. Adjusted HaikuControlLook::DrawInactiveTab() to draw the tab borders more selectively. Only draw border if left border is set for top and bottom tabs or top border is set for left and right tabs. Undo no longer needed frame manipulation border drawing workaround in HaikuControlLook::DrawTabFrame(). Draw scroll bar triangle without using DrawArrowShape(). Unlike in HaikuControlLook, DrawArrowShape() is used to draw arrows in BOutlineListView and menus distinctly from how it draws arrows in scroll bars. Draw our distinct arrows in DrawSrollBarButtons() instead. This fixes overflow of time edit up-down arrows in Clock prefs and the collapse-expand arrow in Deskbar not being vertically centered. In DrawBorders() only inset if we actually draw the border. Fix alignment issues with DrawSliderThumb dots for example in MediaPlayer volume knobs. Draw using line arrays calling AddLine instead of StrokeLine in several places. DrawMenuBar() extends to draw final pixel which eliminates an extra lines at the end of menu bars. Truncate button labels better fixing a few issues for example keymap keyboard layout button labels. Button insets has been updated a bit to fix drawing issues with buttons missing a border. Using a dynamic_cast to a BButton to determine if a view is a button in BeControlLook didn't work in the case of the keymap label. Look for B_FLAT, B_HOVER, or B_DEFAULT_BUTTON flag in BeControlLook::DrawLabel() to draw the label inverted on click. Pass the B_FLAT flag from Keymap keys when drawing using BControlLook so that the label is inverted. Change-Id: I07631f4b006bdb9aeca2adc9cbdf2da54dae8e92 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2866 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-06-02 00:15:29 +03:00
uint32 side = B_TOP_BORDER,
int32 index = 0, int32 selected = -1,
int32 first = 0, int32 last = 0) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawSplitter(BView* view, BRect& rect,
* Added BSplitView drawing code to ControlLook. * BSplitView uses ControlLook to draw itself. * Small refactoring in SplitLayout to implement IsAboveSplitter(BPoint). * BSplitView updates the view cursor when the mouse is above a splitter. * Standard splitter size is now 6 pixels, which is a bit easer to hit. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31137 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-06-20 19:03:33 +04:00
const BRect& updateRect,
const rgb_color& base,
Remove enum elaborated type specifier ...from orientation params. Elaborated type specifiers are not needed for C++ code and removing them makes doxygen happy. Verified working on both gcc2h and gcc4h builds.
2013-07-09 02:27:55 +04:00
orientation orientation,
* Added BSplitView drawing code to ControlLook. * BSplitView uses ControlLook to draw itself. * Small refactoring in SplitLayout to implement IsAboveSplitter(BPoint). * BSplitView updates the view cursor when the mouse is above a splitter. * Standard splitter size is now 6 pixels, which is a bit easer to hit. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31137 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-06-20 19:03:33 +04:00
uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
* Added BSplitView drawing code to ControlLook. * BSplitView uses ControlLook to draw itself. * Small refactoring in SplitLayout to implement IsAboveSplitter(BPoint). * BSplitView updates the view cursor when the mouse is above a splitter. * Standard splitter size is now 6 pixels, which is a bit easer to hit. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31137 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-06-20 19:03:33 +04:00
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
// various borders
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawBorder(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
ControlLook: Rename border param to borderStyle border vs. borders is confusing. BTabView: Rename border param to borderStyle BTabView docs: rename border param to borderStyle enumerate border styles in docs
2016-04-29 23:57:50 +03:00
border_style borderStyle, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawRaisedBorder(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawGroupFrame(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawTextControlBorder(BView* view, BRect& rect,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
uint32 borders = B_ALL_BORDERS) = 0;
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
// aligned labels
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawLabel(BView* view, const char* label,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect rect, const BRect& updateRect,
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
const rgb_color& base, uint32 flags,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
const rgb_color* textColor = NULL) = 0;
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
virtual void DrawLabel(BView* view, const char* label,
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
BRect rect, const BRect& updateRect,
const rgb_color& base, uint32 flags,
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
const BAlignment& alignment,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
const rgb_color* textColor = NULL) = 0;
* Refactored a method to draw a label when the location is already known. (This one takes care of setting up the correct color.) * Added TODO about using either B_CONTROL_TEXT_COLOR, or elliminating that constant (which I am in favor of...). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35260 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-23 15:48:18 +03:00
// TODO: Would be nice to have a (non-virtual) version of this method
// which takes an array of labels and locations. That would save some
// setup with the view graphics state.
BControlLook: Make all public methods virtual. Solves a "TODO before R1". Breaks ABI, but almost nothing outside the tree uses it.
2017-09-10 22:22:29 +03:00
virtual void DrawLabel(BView* view, const char* label,
* Refactored a method to draw a label when the location is already known. (This one takes care of setting up the correct color.) * Added TODO about using either B_CONTROL_TEXT_COLOR, or elliminating that constant (which I am in favor of...). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35260 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-23 15:48:18 +03:00
const rgb_color& base, uint32 flags,
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
const BPoint& where,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
const rgb_color* textColor = NULL) = 0;
* Refactored a method to draw a label when the location is already known. (This one takes care of setting up the correct color.) * Added TODO about using either B_CONTROL_TEXT_COLOR, or elliminating that constant (which I am in favor of...). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35260 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-23 15:48:18 +03:00
BControlLook: Add DrawLabel() variants with icon A label, a bitmap, or both can be specified.
2013-12-22 05:01:13 +04:00
void DrawLabel(BView* view, const char* label,
const BBitmap* icon, BRect rect,
const BRect& updateRect,
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
const rgb_color& base, uint32 flags,
const rgb_color* textColor = NULL);
BControlLook: Add DrawLabel() variants with icon A label, a bitmap, or both can be specified.
2013-12-22 05:01:13 +04:00
virtual void DrawLabel(BView* view, const char* label,
const BBitmap* icon, BRect rect,
const BRect& updateRect,
const rgb_color& base, uint32 flags,
Set*UIColor, etc. The inseparable changes necessary to support live color updating across the system in a sane, safe, and performant manner. BView gains: HasSystemColors() HasDefaultColors() AdoptSystemColors() AdoptParentColors() AdoptViewColor(BView*) SetViewUIColor(color_which, float tint) SetHighUIColor(... SetLowUIColor(... ViewUIColor(float* tint) HighUIColor(... LowUIColor(... DelayedInvalidate() BWindow gains a simple helper method: IsOffscreenWindow() BMessage gains: AddColor() FindColor() GetColor() HasColor() * allegedly this API is deprecated, but I implemented it anyway ReplaceColor() SetColor() Previous private ColorTools methods are made public and moved into GraphicsDefs: mix_color, blend_color, disable_color These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup of BeOS example code under the OpenTracker license. In addition, four new colors are created: B_LINK_TEXT_COLOR B_LINK_HOVER_COLOR B_LINK_ACTIVE_COLOR B_LINK_VISITED_COLOR These changes are documented in their proper user documentation files. In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit. On the app_server side, the following has changed: Add DelayedMessage - a system by which messages can be sent at a scheduled time, and can also be merged according to set rules. A single thread is used to service the message queue and multiple recipients can be set for each message. Desktop gains the ability to add message ports to a DelayedMessage so that said messages can target either all applications or all windows, as needed. Desktop maintains a BMessage which is used to queue up all pending color changes and the delayed messaging system is used to enact these changes after a short period of time has passed. This prevents abuse and allows the system to merge repeated set_ui_color events into one event for client applications, improving performance drastically. In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message to each BWindow. This is done to improve performance over having the app_server independently informing each window. Decorator changes are live now, which required some reworking. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
2015-12-10 21:52:48 +03:00
const BAlignment& alignment,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
const rgb_color* textColor = NULL) = 0;
BControlLook: Add DrawLabel() variants with icon A label, a bitmap, or both can be specified.
2013-12-22 05:01:13 +04:00
BControlLook: Add methods for getting insets * Update the previously unused frame_type and background_type enums. * Add methods GetFrameInsets(), GetBackgroundInsets(), GetInsets() to get the insets for a given frame type, background type, or both respectively.
2013-12-22 04:57:36 +04:00
virtual void GetFrameInsets(frame_type frameType,
uint32 flags, float& _left, float& _top,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
float& _right, float& _bottom) = 0;
BControlLook: Add methods for getting insets * Update the previously unused frame_type and background_type enums. * Add methods GetFrameInsets(), GetBackgroundInsets(), GetInsets() to get the insets for a given frame type, background type, or both respectively.
2013-12-22 04:57:36 +04:00
virtual void GetBackgroundInsets(
background_type backgroundType,
uint32 flags, float& _left, float& _top,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
float& _right, float& _bottom) = 0;
BControlLook: Add methods for getting insets * Update the previously unused frame_type and background_type enums. * Add methods GetFrameInsets(), GetBackgroundInsets(), GetInsets() to get the insets for a given frame type, background type, or both respectively.
2013-12-22 04:57:36 +04:00
void GetInsets(frame_type frameType,
background_type backgroundType,
uint32 flags, float& _left, float& _top,
float& _right, float& _bottom);
BButton: Add optional pop-up marker * Add behavior constant B_POP_UP_BEHAVIOR which adds a pop-up marker to the button (similar to that of BMenuField). * Add methods [Set]PopUpMessage(). To set/get the the message that is sent to the button's target when the pop-up marker is clicked.
2013-12-30 07:42:52 +04:00
virtual void DrawButtonWithPopUpBackground(BView* view,
BRect& rect, const BRect& updateRect,
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
BButton: Add optional pop-up marker * Add behavior constant B_POP_UP_BEHAVIOR which adds a pop-up marker to the button (similar to that of BMenuField). * Add methods [Set]PopUpMessage(). To set/get the the message that is sent to the button's target when the pop-up marker is clicked.
2013-12-30 07:42:52 +04:00
virtual void DrawButtonWithPopUpBackground(BView* view,
BRect& rect, const BRect& updateRect,
float radius,
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
BButton: Add optional pop-up marker * Add behavior constant B_POP_UP_BEHAVIOR which adds a pop-up marker to the button (similar to that of BMenuField). * Add methods [Set]PopUpMessage(). To set/get the the message that is sent to the button's target when the pop-up marker is clicked.
2013-12-30 07:42:52 +04:00
virtual void DrawButtonWithPopUpBackground(BView* view,
BRect& rect, const BRect& updateRect,
float leftTopRadius,
float rightTopRadius,
float leftBottomRadius,
float rightBottomRadius,
const rgb_color& base,
uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
Interface Kit: Make BControlLook a proper pure-virtual base class. All of its prior functionality has been moved into HaikuControlLook. This paves the way for customizeable control looks, which I intend to implement in the future as part of decorators. This is being pushed now because libbe ABI was already broken due to the Notifications changes, so this is riding that so we only have to do a mass rebuild once.
2017-09-11 05:15:07 +03:00
orientation orientation = B_HORIZONTAL) = 0;
BButton: Add optional pop-up marker * Add behavior constant B_POP_UP_BEHAVIOR which adds a pop-up marker to the button (similar to that of BMenuField). * Add methods [Set]PopUpMessage(). To set/get the the message that is sent to the button's target when the pop-up marker is clicked.
2013-12-30 07:42:52 +04:00
Added some reserved fields to BControlLook. * This makes future changes less troublesome, although we should also add some virtual slots there (probably just dozens of it, though, that's why I was being lazy). * Don't pass messages by value; they are copied twice this way. * Minor coding style corrections, automatic whitespace cleanup.
2012-02-26 17:58:52 +04:00
void SetBackgroundInfo(
const BMessage& backgroundInfo);
Outline of labels/strings drawn to desktop * Rather than duplicating the decision taking logic involving wheter or not to draw the outline or glow in every replicant, update be_control_look to make it more generic. * The Monitoring of the background preferences is now only done in Tracker (where it was already being done). * Add a BControlLook::B_IGNORE_OUTLINE flag to avoid this new behaviour. * Remove that said logic from ActivityMonitor and use be_control_look. * Use the ignore flag in DeskCalc to avoid the outline in its case. Should fix #7716, #7291.
2012-02-23 04:06:22 +04:00
BControlLook: Move tab frame drawing into DrawTabFrame() The tab frame is drawn behind the tabs. Create a new DrawTabFrame method in BControlLook and HaikuControlLook that draws the tab frame background. Until now we've been reusing the DrawInactiveTab method to draw the tab frame in BTabView. While this works on HaikuControlLook, it doesn't work on other ControlLook's (such as BeControlLook) that draw their tab frame differently. Add FBC method to preserve binary compatibility on gcc2 and gcc4. Move DrawTabFrame method to where _ReservedControlLook1 was in header. Set rect to area of tab frame in TabView instead of doing the calculation in HaikuControlLook so that others may benefit. Change-Id: I513e238914f6d680f495659b6ec902df15555015 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1936 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2019-08-15 05:31:13 +03:00
virtual void DrawTabFrame(BView* view, BRect& rect,
const BRect& updateRect,
const rgb_color& base, uint32 flags = 0,
uint32 borders = B_ALL_BORDERS,
border_style borderStyle = B_FANCY_BORDER,
uint32 side = B_TOP_BORDER) = 0;
IK: Update scroll bars for alternative control look Scroll bars should look and work identically to before on HaikuControlLook. Add DrawScrollBarButton() and DrawScrollBarThumb() and DrawScrollBarBorder() methods. These methods are used to draw scroll bars in a generic way so that they can be drawn differently by alternative control look's (e.g. BeControlLook). Also it gives us back drawing of scroll bar knobs. However the knob setting is not exposed in the interface in this commit. These methods are in addition to the 2 existing DrawScrollBarBackground() methods that draw the scroll bar background. One draws the area above and below the thumb and the other is called by the first to actually draw the area. The rest of the drawing besides the backgrounds was being done in BScrollBar before. To draw the scroll bar arrows and thumb we were recyling other ControlLook methods, while this worked well enough on HaikuControlLook it wasn't flexible enough for alternative control looks. DrawScrollBarButton() is used to draw the four scroll buttons and is typically (so far) used in combination with DrawArrowShape(). DrawScrollBarThumb() draws the scroll bar thumb. DrawScrollBarBorder() draws a 1px border around the entire scroll bar, potentially B_KEYBOARD_NAVIGATION_COLOR if focused (although this is feature not currently used.) Draw unscrollable scroll bars as if they were disabled including the buttons with their arrow shapes, background, and thumb. Add FBC backwords compatibility macros in ControlLook.cpp Change-Id: I9237c5ce45d17d674785111d51de951e5686306b Reviewed-on: https://review.haiku-os.org/c/haiku/+/351 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-03-04 13:03:47 +03:00
virtual void DrawScrollBarButton(BView* view,
BRect rect, const BRect& updateRect,
const rgb_color& base, uint32 flags,
int32 direction, orientation orientation,
bool down = false) = 0;
virtual void DrawScrollBarThumb(BView* view,
BRect& rect, const BRect& updateRect,
const rgb_color& base, uint32 flags,
orientation orientation,
uint32 knobStyle = B_KNOB_NONE) = 0;
virtual void DrawScrollBarBorder(BView* view,
BRect rect, const BRect& updateRect,
const rgb_color& base, uint32 flags,
orientation orientation) = 0;
Decorator: Introduce Scroll bar size call Change-Id: I07f08c2893d832e431c29ae753e0a93d6e619701 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3892 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> Reviewed-by: X512 <danger_mail@list.ru>
2021-05-01 23:38:33 +03:00
virtual float GetScrollBarWidth(
orientation orientation = B_VERTICAL);
IK: Update scroll bars for alternative control look Scroll bars should look and work identically to before on HaikuControlLook. Add DrawScrollBarButton() and DrawScrollBarThumb() and DrawScrollBarBorder() methods. These methods are used to draw scroll bars in a generic way so that they can be drawn differently by alternative control look's (e.g. BeControlLook). Also it gives us back drawing of scroll bar knobs. However the knob setting is not exposed in the interface in this commit. These methods are in addition to the 2 existing DrawScrollBarBackground() methods that draw the scroll bar background. One draws the area above and below the thumb and the other is called by the first to actually draw the area. The rest of the drawing besides the backgrounds was being done in BScrollBar before. To draw the scroll bar arrows and thumb we were recyling other ControlLook methods, while this worked well enough on HaikuControlLook it wasn't flexible enough for alternative control looks. DrawScrollBarButton() is used to draw the four scroll buttons and is typically (so far) used in combination with DrawArrowShape(). DrawScrollBarThumb() draws the scroll bar thumb. DrawScrollBarBorder() draws a 1px border around the entire scroll bar, potentially B_KEYBOARD_NAVIGATION_COLOR if focused (although this is feature not currently used.) Draw unscrollable scroll bars as if they were disabled including the buttons with their arrow shapes, background, and thumb. Add FBC backwords compatibility macros in ControlLook.cpp Change-Id: I9237c5ce45d17d674785111d51de951e5686306b Reviewed-on: https://review.haiku-os.org/c/haiku/+/351 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-03-04 13:03:47 +03:00
BControlLook: Add FBC padding. Fixes #14295.
2018-08-14 20:38:18 +03:00
private:
// FBC padding
virtual void _ReservedControlLook6();
virtual void _ReservedControlLook7();
virtual void _ReservedControlLook8();
virtual void _ReservedControlLook9();
virtual void _ReservedControlLook10();
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
protected:
Outline of labels/strings drawn to desktop * Rather than duplicating the decision taking logic involving wheter or not to draw the outline or glow in every replicant, update be_control_look to make it more generic. * The Monitoring of the background preferences is now only done in Tracker (where it was already being done). * Add a BControlLook::B_IGNORE_OUTLINE flag to avoid this new behaviour. * Remove that said logic from ActivityMonitor and use be_control_look. * Use the ignore flag in DeskCalc to avoid the outline in its case. Should fix #7716, #7291.
2012-02-23 04:06:22 +04:00
int32 fCachedWorkspace;
BMessage fBackgroundInfo;
Added some reserved fields to BControlLook. * This makes future changes less troublesome, although we should also add some virtual slots there (probably just dozens of it, though, that's why I was being lazy). * Don't pass messages by value; they are copied twice this way. * Minor coding style corrections, automatic whitespace cleanup.
2012-02-26 17:58:52 +04:00
uint32 _reserved[20];
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
};
extern BControlLook* be_control_look;
Add basic support for loading ControlLook add-ons app_server just passes the add-on path around. Maybe we should make sure the add-on can be loaded when setting it. Change-Id: I3acd3299782a22c1666bd5435dbf3d8053e359fa Reviewed-on: https://review.haiku-os.org/c/1430 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2019-05-02 03:45:48 +03:00
extern "C" _EXPORT BControlLook *instantiate_control_look(image_id id);
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
} // namespace BPrivate
using BPrivate::BControlLook;
using BPrivate::be_control_look;
Added support for buttons and menuframes with rounded corners. * Not turned on for default buttons and menuframes right now. * Updated Deskcalc and Keymap to use buttons with rounded corners. * Overloaded methods with radium parameters are not virtual right now so as to not break vtables. Added /*virtual*/ before each method that should be made virtual in ControlLook.h * Added a light line to the left border of the down arrow frame on menu frames as a small visual tweak. * Replace StrokeRect() with StrokeRoundRect() when drawing the default button indicator. This gives them a rounded appearance if the button is also rounded. * Added protected methods _DrawMenuFieldBackgroundOutside and _DrawMenuFieldBackgroundInside. * Created some protected methods to get the edge, frame, and bevel colors from a passed in base color because it was a mess and I needed to calculate the colors from mutiple methods. It is much cleaner now. * Added myself to ControlLook.cpp authors list. Assigned copyright to Haiku, Inc. Stippi also retains his copyright. * Tons of style fixes. - Change all instances of `if (flags & B_FLAG)` to `if ((flags & B_FLAG) != 0)` - Reorder some methods. - Reorder includes. - Spacing. - Updated comments.
2012-03-20 04:30:22 +04:00
Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-02-15 21:23:19 +03:00
#endif // _CONTROL_LOOK_H
Reference in New Issue Copy Permalink