NetBSD/sys/dev/pci/toshide.c
dyoung d3e53912d2 Neither pci_dma64_available(), pci_probe_device(), pci_mapreg_map(9),
pci_find_rom(), pci_intr_map(9), pci_enumerate_bus(), nor the match
predicate passed to pciide_compat_intr_establish() should ever modify
their pci_attach_args argument, so make their pci_attach_args arguments
const and deal with the fallout throughout the kernel.

For the most part, these changes add a 'const' where there was no
'const' before, however, some drivers and MD code used to modify
pci_attach_args.  Now those drivers either copy their pci_attach_args
and modify the copy, or refrain from modifying pci_attach_args:

Xen: according to Manuel Bouyer, writing to pci_attach_args in
    pci_intr_map() was a leftover from Xen 2.  Probably a bug.  I
    stopped writing it.  I have not tested this change.

siside(4): sis_hostbr_match() needlessly wrote to pci_attach_args.
    Probably a bug.  I use a temporary variable.  I have not tested this
    change.

slide(4): sl82c105_chip_map() overwrote the caller's pci_attach_args.
    Probably a bug.  Use a local pci_attach_args.  I have not tested
    this change.

viaide(4): via_sata_chip_map() and via_sata_chip_map_new() overwrote the
    caller's pci_attach_args.  Probably a bug.  Make a local copy of the
    caller's pci_attach_args and modify the copy.  I have not tested
    this change.

While I'm here, make pci_mapreg_submap() static.

With these changes in place, I have tested the compilation of these
kernels:

alpha GENERIC
amd64 GENERIC XEN3_DOM0
arc GENERIC
atari HADES MILAN-PCIIDE
bebox GENERIC
cats GENERIC
cobalt GENERIC
evbarm-eb NSLU2
evbarm-el ADI_BRH ARMADILLO9 CP3100 GEMINI GEMINI_MASTER GEMINI_SLAVE GUMSTIX
	HDL_G IMX31LITE INTEGRATOR IQ31244 IQ80310 IQ80321 IXDP425 IXM1200
	KUROBOX_PRO LUBBOCK MARVELL_NAS NAPPI SHEEVAPLUG SMDK2800 TEAMASA_NPWR
	TEAMASA_NPWR_FC TS7200 TWINTAIL ZAO425
evbmips-el AP30 DBAU1500 DBAU1550 MALTA MERAKI MTX-1 OMSAL400 RB153 WGT624V3
evbmips64-el XLSATX
evbppc EV64260 MPC8536DS MPC8548CDS OPENBLOCKS200 OPENBLOCKS266
	OPENBLOCKS266_OPT P2020RDB PMPPC RB800 WALNUT
hp700 GENERIC
i386 ALL XEN3_DOM0 XEN3_DOMU
ibmnws GENERIC
macppc GENERIC
mvmeppc GENERIC
netwinder GENERIC
ofppc GENERIC
prep GENERIC
sandpoint GENERIC
sgimips GENERIC32_IP2x
sparc GENERIC_SUN4U KRUPS
sparc64 GENERIC

As of Sun Apr 3 15:26:26 CDT 2011, I could not compile these kernels
with or without my patches in place:

### evbmips-el GDIUM

nbmake: nbmake: don't know how to make /home/dyoung/pristine-nbsd/src/sys/arch/mips/mips/softintr.c. Stop

### evbarm-el MPCSA_GENERIC
src/sys/arch/evbarm/conf/MPCSA_GENERIC:318: ds1672rtc*: unknown device `ds1672rtc'

### ia64 GENERIC

/tmp/genassym.28085/assym.c: In function 'f111':
/tmp/genassym.28085/assym.c:67: error: invalid application of 'sizeof' to incomplete type 'struct pcb'
/tmp/genassym.28085/assym.c:76: error: dereferencing pointer to incomplete type

### sgimips GENERIC32_IP3x

crmfb.o: In function `crmfb_attach':
crmfb.c:(.text+0x2304): undefined reference to `ddc_read_edid'
crmfb.c:(.text+0x2304): relocation truncated to fit: R_MIPS_26 against `ddc_read_edid'
crmfb.c:(.text+0x234c): undefined reference to `edid_parse'
crmfb.c:(.text+0x234c): relocation truncated to fit: R_MIPS_26 against `edid_parse'
crmfb.c:(.text+0x2354): undefined reference to `edid_print'
crmfb.c:(.text+0x2354): relocation truncated to fit: R_MIPS_26 against `edid_print'
2011-04-04 20:37:49 +00:00

271 lines
7.6 KiB
C

/* $NetBSD: toshide.c,v 1.4 2011/04/04 20:37:56 dyoung Exp $ */
/*-
* Copyright (c) 2009 The NetBSD Foundation, Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
* ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
* TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: toshide.c,v 1.4 2011/04/04 20:37:56 dyoung Exp $");
#include <sys/param.h>
#include <sys/systm.h>
#include <dev/pci/pcivar.h>
#include <dev/pci/pcidevs.h>
#include <dev/pci/pciidereg.h>
#include <dev/pci/pciidevar.h>
#include <dev/pci/pciide_piccolo_reg.h>
static void piccolo_chip_map(struct pciide_softc *,
const struct pci_attach_args *);
static void piccolo_setup_channel(struct ata_channel *);
static int piccolo_match(device_t, cfdata_t, void *);
static void piccolo_attach(device_t, device_t, void *);
CFATTACH_DECL_NEW(toshide, sizeof(struct pciide_softc),
piccolo_match, piccolo_attach, NULL, NULL);
static const struct pciide_product_desc pciide_toshiba2_products[] = {
{
PCI_PRODUCT_TOSHIBA2_PICCOLO,
0,
"Toshiba Piccolo IDE controller",
piccolo_chip_map,
},
{
PCI_PRODUCT_TOSHIBA2_PICCOLO2,
0,
"Toshiba Piccolo 2 IDE controller",
piccolo_chip_map,
},
{
PCI_PRODUCT_TOSHIBA2_PICCOLO3,
0,
"Toshiba Piccolo 3 IDE controller",
piccolo_chip_map,
},
{
PCI_PRODUCT_TOSHIBA2_PICCOLO5,
0,
"Toshiba Piccolo 5 IDE controller",
piccolo_chip_map,
},
{
0,
0,
NULL,
NULL,
}
};
static int
piccolo_match(device_t parent, cfdata_t match, void *aux)
{
struct pci_attach_args *pa = aux;
if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_TOSHIBA2) {
if (pciide_lookup_product(pa->pa_id, pciide_toshiba2_products))
return 2;
}
return 0;
}
static void
piccolo_attach(device_t parent, device_t self, void *aux)
{
struct pci_attach_args *pa = aux;
struct pciide_softc *sc = device_private(self);
const struct pciide_product_desc *pp;
sc->sc_wdcdev.sc_atac.atac_dev = self;
if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_TOSHIBA2)
pp = pciide_lookup_product(pa->pa_id, pciide_toshiba2_products);
else
pp = NULL;
if (pp == NULL)
panic("toshide_attach");
pciide_common_attach(sc, pa, pp);
}
static void
piccolo_chip_map(struct pciide_softc *sc, const struct pci_attach_args *pa)
{
struct pciide_channel *cp;
pcireg_t interface;
int channel;
if (pciide_chipen(sc, pa) == 0)
return;
aprint_verbose_dev(sc->sc_wdcdev.sc_atac.atac_dev,
"bus-master DMA support present");
pciide_mapreg_dma(sc, pa);
aprint_verbose("\n");
sc->sc_wdcdev.sc_atac.atac_cap = ATAC_CAP_DATA32 | ATAC_CAP_DATA16;
sc->sc_wdcdev.sc_atac.atac_pio_cap = 5;
if (sc->sc_dma_ok) {
sc->sc_wdcdev.sc_atac.atac_cap |= ATAC_CAP_DMA | ATAC_CAP_UDMA;
sc->sc_wdcdev.irqack = pciide_irqack;
sc->sc_wdcdev.sc_atac.atac_dma_cap = 3;
sc->sc_wdcdev.sc_atac.atac_udma_cap = 2;
}
sc->sc_wdcdev.sc_atac.atac_set_modes = piccolo_setup_channel;
sc->sc_wdcdev.sc_atac.atac_channels = sc->wdc_chanarray;
sc->sc_wdcdev.sc_atac.atac_nchannels = 1;
/*
* XXX one for now. We'll figure out how to talk to the second channel
* later, hopefully! Second interface config is via the
* "alternate PCI Configuration Space" whatever that is!
*/
interface = PCI_INTERFACE(pa->pa_class);
wdc_allocate_regs(&sc->sc_wdcdev);
for (channel = 0; channel < sc->sc_wdcdev.sc_atac.atac_nchannels;
channel++) {
cp = &sc->pciide_channels[channel];
if (pciide_chansetup(sc, channel, interface) == 0)
continue;
pciide_mapchan(pa, cp, interface, pciide_pci_intr);
}
}
static void
piccolo_setup_channel(struct ata_channel *chp)
{
struct ata_drive_datas *drvp;
struct pciide_channel *cp = CHAN_TO_PCHAN(chp);
struct pciide_softc *sc = CHAN_TO_PCIIDE(chp);
u_int32_t idedma_ctl;
int drive, s;
pcireg_t pxdx;
#ifdef TOSHIDE_DEBUG
pcireg_t pxdx_prime;
#endif
idedma_ctl = 0;
/* Set up DMA if needed. */
pciide_channel_dma_setup(cp);
for (drive = 0; drive < 2; drive++) {
drvp = &chp->ch_drive[drive];
/* If no drive, skip */
if ((drvp->drive_flags & DRIVE) == 0)
continue;
if (drvp->drive_flags & DRIVE_UDMA) {
/* use Ultra/DMA */
s = splbio();
drvp->drive_flags &= ~DRIVE_DMA;
splx(s);
/*
* Use UDMA - we can go up to mode 2 so no need to
* check anything since nearly all drives with UDMA
* are mode 2 or faster
*/
pxdx = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING);
pxdx &= PICCOLO_UDMA_MASK;
pxdx |= piccolo_udma_times[2];
pci_conf_write(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING, pxdx);
#ifdef TOSHIDE_DEBUG
/* XXX sanity check */
pxdx_prime = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING);
aprint_verbose_dev(sc->sc_wdcdev.sc_atac.atac_dev,
"UDMA want %x, set %x, got %x\n",
piccolo_udma_times[2], pxdx, pxdx_prime);
#endif
idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
}
else if (drvp->drive_flags & DRIVE_DMA) {
/*
* Use Multiword DMA
*/
if (drvp->PIO_mode > (drvp->DMA_mode + 2))
drvp->PIO_mode = drvp->DMA_mode + 2;
if (drvp->DMA_mode + 2 > (drvp->PIO_mode))
drvp->DMA_mode = (drvp->PIO_mode > 2) ?
drvp->PIO_mode - 2 : 0;
pxdx = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING);
pxdx &= PICCOLO_DMA_MASK;
pxdx |= piccolo_mw_dma_times[drvp->DMA_mode];
pci_conf_write(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING, pxdx);
#ifdef TOSHIDE_DEBUG
/* XXX sanity check */
pxdx_prime = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_DMA_TIMING);
aprint_verbose_dev(sc->sc_wdcdev.sc_atac.atac_dev,
"DMA %d want %x, set %x, got %x\n",
drvp->DMA_mode,
piccolo_mw_dma_times[drvp->DMA_mode], pxdx,
pxdx_prime);
#endif
idedma_ctl |= IDEDMA_CTL_DRV_DMA(drive);
}
else {
pxdx = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_PIO_TIMING);
pxdx &= PICCOLO_PIO_MASK;
pxdx |= piccolo_pio_times[drvp->PIO_mode];
pci_conf_write(sc->sc_pc, sc->sc_tag,
PICCOLO_PIO_TIMING, pxdx);
#ifdef TOSHIDE_DEBUG
/* XXX sanity check */
pxdx_prime = pci_conf_read(sc->sc_pc, sc->sc_tag,
PICCOLO_PIO_TIMING);
aprint_verbose_dev(sc->sc_wdcdev.sc_atac.atac_dev,
"PIO %d want %x, set %x, got %x\n", drvp->PIO_mode,
piccolo_pio_times[drvp->PIO_mode], pxdx,
pxdx_prime);
#endif
}
}
if (idedma_ctl != 0) {
/* Add software bits in status register */
bus_space_write_1(sc->sc_dma_iot, cp->dma_iohs[IDEDMA_CTL], 0,
idedma_ctl);
}
}