NetBSD/lib/libpthread/pthread_barrier.c
ad 2bcb8bf1c4 PR lib/38741 priority inversion in libpthread breaks apps that use
SCHED_FIFO threads

- Change condvar sync so that we never take the condvar's spinlock without
  first holding the caller-provided mutex. Previously, the spinlock was only
  taken without the mutex in an error path, but it was enough to trigger the
  problem described in the PR.

- Even with this change, applications calling pthread_cond_signal/broadcast
  without holding the interlocking mutex are still subject to the problem
  described in the PR. POSIX discourages this saying that it leads to
  undefined scheduling behaviour, which seems good enough for the time being.

- Elsewhere, use a hash of mutexes instead of per-object spinlocks to
  synchronize entry/exit from sleep queues.

- Simplify how sleep queues are maintained.
2008-05-25 17:05:28 +00:00

202 lines
5.1 KiB
C

/* $NetBSD: pthread_barrier.c,v 1.18 2008/05/25 17:05:28 ad Exp $ */
/*-
* Copyright (c) 2001, 2003, 2006, 2007 The NetBSD Foundation, Inc.
* All rights reserved.
*
* This code is derived from software contributed to The NetBSD Foundation
* by Nathan J. Williams, by Jason R. Thorpe, and by Andrew Doran.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
* ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
* TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__RCSID("$NetBSD: pthread_barrier.c,v 1.18 2008/05/25 17:05:28 ad Exp $");
#include <errno.h>
#include "pthread.h"
#include "pthread_int.h"
int
pthread_barrier_init(pthread_barrier_t *barrier,
const pthread_barrierattr_t *attr, unsigned int count)
{
pthread_mutex_t *interlock;
#ifdef ERRORCHECK
if ((barrier == NULL) ||
(attr && (attr->ptba_magic != _PT_BARRIERATTR_MAGIC)))
return EINVAL;
#endif
if (count == 0)
return EINVAL;
if (barrier->ptb_magic == _PT_BARRIER_MAGIC) {
interlock = pthread__hashlock(barrier);
/*
* We're simply reinitializing the barrier to a
* new count.
*/
pthread_mutex_lock(interlock);
if (barrier->ptb_magic != _PT_BARRIER_MAGIC) {
pthread_mutex_unlock(interlock);
return EINVAL;
}
if (!PTQ_EMPTY(&barrier->ptb_waiters)) {
pthread_mutex_unlock(interlock);
return EBUSY;
}
barrier->ptb_initcount = count;
barrier->ptb_curcount = 0;
barrier->ptb_generation = 0;
pthread_mutex_unlock(interlock);
return 0;
}
barrier->ptb_magic = _PT_BARRIER_MAGIC;
PTQ_INIT(&barrier->ptb_waiters);
barrier->ptb_initcount = count;
barrier->ptb_curcount = 0;
barrier->ptb_generation = 0;
return 0;
}
int
pthread_barrier_destroy(pthread_barrier_t *barrier)
{
pthread_mutex_t *interlock;
#ifdef ERRORCHECK
if ((barrier == NULL) || (barrier->ptb_magic != _PT_BARRIER_MAGIC))
return EINVAL;
#endif
interlock = pthread__hashlock(barrier);
pthread_mutex_lock(interlock);
if (barrier->ptb_magic != _PT_BARRIER_MAGIC) {
pthread_mutex_unlock(interlock);
return EINVAL;
}
if (!PTQ_EMPTY(&barrier->ptb_waiters)) {
pthread_mutex_unlock(interlock);
return EBUSY;
}
barrier->ptb_magic = _PT_BARRIER_DEAD;
pthread_mutex_unlock(interlock);
return 0;
}
int
pthread_barrier_wait(pthread_barrier_t *barrier)
{
pthread_mutex_t *interlock;
pthread_t self;
unsigned int gen;
#ifdef ERRORCHECK
if ((barrier == NULL) || (barrier->ptb_magic != _PT_BARRIER_MAGIC))
return EINVAL;
#endif
self = pthread__self();
interlock = pthread__hashlock(barrier);
pthread_mutex_lock(interlock);
/*
* A single arbitrary thread is supposed to return
* PTHREAD_BARRIER_SERIAL_THREAD, and everone else
* is supposed to return 0. Since pthread_barrier_wait()
* is not a cancellation point, this is trivial; we
* simply elect that the thread that causes the barrier
* to be satisfied gets the special return value. Note
* that this final thread does not actually need to block,
* but instead is responsible for waking everyone else up.
*/
if (barrier->ptb_curcount + 1 == barrier->ptb_initcount) {
barrier->ptb_generation++;
pthread__unpark_all(&barrier->ptb_waiters, self,
interlock);
pthread_mutex_unlock(interlock);
return PTHREAD_BARRIER_SERIAL_THREAD;
}
barrier->ptb_curcount++;
gen = barrier->ptb_generation;
while (gen == barrier->ptb_generation) {
PTQ_INSERT_TAIL(&barrier->ptb_waiters, self, pt_sleep);
self->pt_sleepobj = &barrier->ptb_waiters;
(void)pthread__park(self, interlock, &barrier->ptb_waiters,
NULL, 0, __UNVOLATILE(&interlock->ptm_waiters));
pthread_mutex_lock(interlock);
}
pthread_mutex_unlock(interlock);
return 0;
}
int
pthread_barrierattr_init(pthread_barrierattr_t *attr)
{
#ifdef ERRORCHECK
if (attr == NULL)
return EINVAL;
#endif
attr->ptba_magic = _PT_BARRIERATTR_MAGIC;
return 0;
}
int
pthread_barrierattr_destroy(pthread_barrierattr_t *attr)
{
#ifdef ERRORCHECK
if ((attr == NULL) ||
(attr->ptba_magic != _PT_BARRIERATTR_MAGIC))
return EINVAL;
#endif
attr->ptba_magic = _PT_BARRIERATTR_DEAD;
return 0;
}