Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
164,341 Commits 606 Branches 0 Tags 3.1 GiB
f8082d9a50
Commit Graph

1439 Commits

Author SHA1 Message Date
seb
4a00cfc811 Typo. 2006-08-28 21:21:52 +00:00
christos
18b025cbc8 PR/34286: Gene ENonymous: Increase YYSTACKSIZE so that we can handle huge 
pools.
 2006-08-26 23:20:56 +00:00
jnemeth
50fe2341d5 force all assertions on when __COVERITY__ is set 2006-08-23 04:10:51 +00:00
thorpej
5da5f197c5 Use "unsigned int" rather than "u_int" to be consistent with the rest 
of file(1).
 2006-08-20 19:49:31 +00:00
christos
95ee253760 Print rejected rpc packet reason. 2006-08-11 19:01:18 +00:00
peter
a916e7d758 Document the "tos" keyword. Spotted by maxim bourmistrov, patch supplied by 
jared r r spiegel and forwarded by Thomas Klausner via Jason McIntyre.
 2006-08-10 12:30:49 +00:00
pavel
5145dd52fa Belatedly Bump date after my not-so-recent changes. 2006-08-07 20:57:56 +00:00
dyoung
cc94fcb6e9 Correct units on IEEE80211_RADIOTAP_DBM_ANTSIGNAL, 
IEEE80211_RADIOTAP_DBM_ANTNOISE.
 2006-08-06 17:52:17 +00:00
agc
9410ca204b mark VPD 0x80 (Unit Serial Number VPD Page) as being done 2006-08-03 20:50:45 +00:00
agc
72a3c3e7b9 Add support for Vital Product Data 0x80, Unit Serial Number, reported to be 
used by the beta FreeBSD initiator by Paul Dekkers.
 2006-08-03 20:49:11 +00:00
agc
66644e0749 + add support for IPv6 in the target (CIDR scoping has still to be 
implemented for IPv6, but works fine for IPv4)

+ now poll any connections opened in the target.  select is used if
poll is not available

+ remove ramdisk type of backing store, since it was never used, and
is of no use for our needs

+ bump version to 20060727
 2006-08-03 20:21:59 +00:00
christos
a6fd778155 don't zerodivide when "backoff-cutoff 0;" tested by zafer 2006-08-03 20:17:43 +00:00
kardel
a1291ab337 cope with struct timeval tv_sec being defined as long instead 
of the SUS mandated time_t.
 2006-07-29 19:22:25 +00:00
kardel
55fde488db using the correct type makes it compile on alpha too - found by Kurt Schreiner 2006-07-29 14:56:57 +00:00
kardel
af2ffb8cb1 backout change from import. 
was introduced within ntp and causing
grief there too (partly reason for p3).
this change is not necessary for NetBSD.
 2006-07-29 10:21:37 +00:00
kardel
f2de40854d merge 4.2.2p2 
signedness fixes
	fd re-allocation for stdio
	PPSAPI fixes in refclock_parse.c
while there clean up last signedness problems for gcc4 compilation
 2006-07-29 08:15:29 +00:00
kardel
36f7d8cda6 Import ntp 4.2.2p2 2006-07-29 07:10:38 +00:00
christos
407a09df84 strdup/strlcat/snprintf changes from Aleksey Cheusov 2006-07-26 20:46:37 +00:00
jnemeth
79d79919df Coverity CID: 682 -- remove dead code 2006-07-26 06:23:59 +00:00
christos
f45b14fd95 add ytab.[ch] 2006-07-25 21:25:55 +00:00
christos
cc3156aaa2 Change the meaning of state count to be the number allocated (like c does) 
instead of the highest number allocated (fortran). Fixes off-by-one errors.
Also change the overallocation of n * 5 / 4 + 10 to just n + 10.
 2006-07-25 20:52:57 +00:00
peter
3942d3e2ab Revert previous and fix properly. 
- The array must be NULL terminated because other code depends on it.
- Use this terminator to check if we're at the end of the array instead
  of doing sizeof(pf_timeouts) / sizeof(pf_timeouts[0]).
 2006-07-03 20:26:19 +00:00
christos
847ba49a2c fix typo. 2006-06-29 21:53:33 +00:00
christos
561776c05e resolve conflicts. 2006-06-29 21:50:16 +00:00
christos
1edf903634 Import pppd-2.4.4 2006-06-29 21:46:38 +00:00
christos
295eac6574 make the gototab unsigned int 2006-06-26 17:58:25 +00:00
christos
80f0134faf - widen gototab so NCHARS states fits. 
- don't allocate more space than we need.
From Aleksey Cheusov
 2006-06-26 13:10:47 +00:00
christos
a504bbc8d8 Don't forget to free gototab[i]; pointed out by Aleksey Cheusov 2006-06-25 22:37:45 +00:00
mrg
5609a371c9 make MKCRYPTO=no work again. 2006-06-25 03:02:19 +00:00
christos
ab7ad9579e PR/33392: Aleksey Cheusov: Incorrect matching due to hard-coded limit in 
number of states. Adapted from patch supplied.
 2006-06-22 21:25:14 +00:00
kardel
d66ddb6f9c use the version that is now in ntp-stable (4.2.2 release branch) 2006-06-18 22:48:51 +00:00
kardel
7d46a5bb55 NetBSD Coverity CID 3804: avoid file pointer leak 2006-06-18 21:35:57 +00:00
kardel
50fd338dac NetBSD Coverity CID 3799: overrun static array (off by one) fixed 2006-06-18 21:30:19 +00:00
kardel
e1a3a74084 NetBSD Coverity CID 3797: bad return code check for open(2) fixed 
(!fd replaced with fd < 0)
 2006-06-18 21:25:13 +00:00
kardel
b58f2a229e NetBSD Coverity CID 3796: possible NULL deref 2006-06-18 21:20:35 +00:00
kardel
d58917ea1c cope with situations where interface are UP and bound to 
INADDR_ANY - ntpd will ignore those interfaces
(bug 637 @bugs.ntp.isc.org)
 2006-06-17 12:11:55 +00:00
christos
b7414305ba Update the manual section 2006-06-14 16:23:46 +00:00
christos
3e2e64af97 Regen 2006-06-14 16:22:54 +00:00
christos
826ade140d Use /dev/tty if possible and only fall back to stdin/stderr if that is not 
available like getpass(3) does.
 2006-06-14 16:17:01 +00:00
christos
2e91d940da PR/33724: Scott Ellis: Building a release with MKINET6=no stops in libisc due 
to compiler warnings. Fixed misplaced and miscommented #endif
 2006-06-13 22:36:36 +00:00
christos
f503e58dd8 PR/33723: Arthur Townsend: file command doesn't show 'executable' for 
statically linked sun3 exec
 2006-06-13 22:20:20 +00:00
christos
d8cec01f6f PR/33722: Scott Presnell: pppd 2.4.3 active-filter functions botched 2006-06-13 22:12:37 +00:00
kardel
d5b727f28d correct pointer advances broken by previous fix 2006-06-13 21:03:53 +00:00
kardel
3dfb395215 sort out pointer types - found & fix by jmmv 2006-06-12 10:46:19 +00:00
kardel
b51cdf6b08 fix pointer deref - found by jmmv 2006-06-12 10:45:27 +00:00
kardel
8704ff927b import and integrate NTP 4.2.2 2006-06-11 19:34:07 +00:00
kardel
9c52afaf31 Import ntp 4.2.2 2006-06-11 14:57:12 +00:00
agc
2b1d5a0345 :g/%i/s//%d/gc 
Also make a first stab at implementing persistent reserve in SCSI command.
 2006-05-31 19:53:13 +00:00
chap
5d80ae61bf Clarify that to avoid ioctl(SIOCGNATS): Input/output error, ipf must be 
enabled (ipf -E) before ipnat is used; this detail is automated by the
rc scripts, but not by ipnat itself. ipf's author agrees this is a doc
bug.

Closes PR kern/33409.
 2006-05-29 16:09:46 +00:00
agc
c52b27c275 Bump version number for the portability fix, and the dynamic number of 
sessions.
 2006-05-27 21:29:32 +00:00
agc
36fad19155 Rather than hardcoding the maximum number of sessions that a target can 
serve simultaneously to DEFAULT_TARGET_MAX_SESSIONS, add a -s argument to
iscsi-target(8) to specify the maximum number of sessions.

Also bump default from 4 to 16.
 2006-05-27 21:21:04 +00:00
agc
6dff2af424 Include another header file - should make this compile on platforms where 
arpa/inet.h does not include netinet/in.h automatically.

Some people do just make life harder for themselves.
 2006-05-27 16:00:05 +00:00
chap
baa41845e1 Remove statement (incorrect as of ISC release 3.0.3) that the next-server 
value defaults to the server address. (This statement has been removed in
ISC release 3.0.4.)

Closes PR bin/33565.
 2006-05-26 19:22:03 +00:00
agc
2fa516b2eb Rewrite the way report_luns() works, after suspicion by Matt Green, and 
following Dan Carosone's suggestion of the uint64_t array.

Abstract a bit more from the HTOBE64() macro intrigue, for platforms
like Solaris/x86 which have fun in this part.

Tested only with little-endian initiators for now.

Bump version to 20060526.
 2006-05-26 16:34:43 +00:00
agc
8a1a8b8c5c Include compat.h for the definition of uuid_t, in the case where we don't 
have it from <uuid.h>
 2006-05-25 19:41:06 +00:00
mrg
5f6c58ab32 apply a few casts to quieten GCC4. 2006-05-25 09:04:37 +00:00
rpaulo
b28216dab7 Resolve conflicts for wpa_supplicant 0.4.9 import. 2006-05-25 04:07:22 +00:00
rpaulo
ed48ac28e7 Import of WPA supplicant 0.4.9 2006-05-25 04:01:24 +00:00
rpaulo
62355884c5 Import of hostapd 0.4.9 2006-05-25 03:53:38 +00:00
he
c6974f26a9 Use the value-returning variants of the 64-bit endian macros instead 
of the argument-tweaking variants (e.g. htobe64 instead of HTOBE64).
 2006-05-22 20:48:08 +00:00
christos
663ee5bb90 Coverity CID 2956: Avoid NULL deref. 2006-05-21 17:41:20 +00:00
christos
f84c1e59e0 Coverity CID 2958: Avoid NULL deref. 2006-05-21 17:39:10 +00:00
christos
a7631b82f6 Coverity CID 2974: Check for negative before assigning to unsigned variable 2006-05-21 17:35:23 +00:00
christos
884667d071 Coverity CID 3491, 3492: Plug memory leaks. 2006-05-21 17:32:23 +00:00
christos
555b8edb2d Coverity CID 3493: Comment out dead code. 2006-05-21 17:26:08 +00:00
christos
d159dc82e4 Coverity CID 3494: Plug memory leak. 2006-05-21 17:23:36 +00:00
agc
e32a776a5a Adjust the data VPD returns, to work around a problem in the Cisco 
initiator (used on Solaris 10 Update 1) - the initiator demands that a
UUID is returned, so give it one.

Add autoconf glue for that, and a compat uuid_create(3) and
uuid_to_string(3).

This still spews a lot of output via the target's syslog, but persevere,
since it does actually make the target work with the Solaris initiator:

	solaris10# format
	Searching for disks...done


	AVAILABLE DISK SELECTIONS:
	       0. c1d0 <DEFAULT cyl 29728 alt 2 hd 64 sec 63>
		  /pci@0,0/pci-ide@1f,1/ide@0/cmdk@0,0
	       1. c2t5d0 <DEFAULT cyl 96 alt 2 hd 64 sec 32>
		  /iscsi/disk@0000iqn.1994-04.org.netbsd.iscsi-target%3Atarget00001,0
	Specify disk (enter its number): ^D
	solaris10# df -k /mnt
	Filesystem            kbytes    used   avail capacity  Mounted on
	/dev/dsk/c2t5d0s0      91407    1041   81226     2%    /mnt
	solaris10# uname -a
	SunOS solaris10 5.10 Generic_118844-26 i86pc i386 i86pc
	solaris10#
 2006-05-21 09:26:37 +00:00
mrg
995cc7365d initialise tmp_clock() for GCC4. 2006-05-20 19:22:36 +00:00
drochner
65f32e5703 Make the optimizer use unsigned numbers as the kernel does. 
While it is not agreed on that purely unsigned arithmetics is nice,
different behaviour of optimized and unoptimized code is less desirable.
 2006-05-17 17:48:36 +00:00
christos
e4162ca0f8 XXX: GCC uninitialized. 2006-05-14 23:36:01 +00:00
christos
be1c3e616c XXX: GCC uninitialized. 2006-05-14 02:37:46 +00:00
christos
653a86901d XXX: GCC uninitialized 2006-05-14 02:10:41 +00:00
christos
e75e0ea2a7 another XXX: GCC uninitialized variable. 2006-05-14 01:31:14 +00:00
christos
9da0166ffa Another uninitialized variables XXX: GCC 2006-05-14 01:30:00 +00:00
christos
af2ae0aa2f Initialize rdataset. 2006-05-14 01:18:41 +00:00
christos
386c6259af Coverity CID 3497: Don't try to set the day/month if we did not get them 
from the clock.
 2006-05-13 23:55:23 +00:00
christos
19a2d0dbea Coverity CID 3197: Don't leak fp. 2006-05-13 22:50:24 +00:00
mrg
d1e102b605 match u_char * with u_char[]. 2006-05-11 09:29:39 +00:00
mrg
3394a47b32 move is_zone initialisation earlier to avoid a GCC warning. 2006-05-11 09:28:45 +00:00
mrg
0fa82c2792 move the extern for clktypes[]'s somewhere it's type is defined. 2006-05-11 00:11:25 +00:00
mrg
ebd6722e04 ctl_trap[] is not public so don't extern it. 2006-05-11 00:10:54 +00:00
mrg
0eaf0f8b7c #include <sys/param.h> since we want to check __NetBSD_Version__. 2006-05-11 00:08:44 +00:00
mrg
084c052803 quell GCC 4.1 uninitialised variable warnings. 
XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..
 2006-05-10 21:53:14 +00:00
skrll
a9f4c28a3d Fix a bunch of cast lvalues. 2006-05-10 06:24:02 +00:00
mrg
0c37c63edc change (mostly) int to socklen_t. GCC 4 doesn't like that int and 
socklen_t are different signness.
 2006-05-09 20:18:05 +00:00
kardel
e01a907378 NetBSD 22 CID 3049,3075: safeguard against (unlikely to impossible) NULL deref 2006-05-04 08:24:05 +00:00
tron
63cb4a87e2 Cast precision argument for sprintf() to int to fix build problems 
on 64-bit platforms.
 2006-05-02 10:09:18 +00:00
kardel
70ff37328f handle NULL return from d2i_X509() - NetBSD Run 21 Coverity CID 2979 2006-05-02 09:24:19 +00:00
christos
3e168a2a10 Use the sizeof the field instead of the #define constant. Fixes off-by-one 
error.
 2006-05-01 18:40:02 +00:00
uwe
ee952d9fc0 Use be64toh/htobe64 instead of upper-case versions. 
Thanks to lint that caught this on big-endian arches.  Little-endian
compiled, but I guess that converting your loop counter into
big-endian inside the loop is not exactly what you want to do.
 2006-04-30 01:07:59 +00:00
christos
70a262c03c Coverity CID 785: Prevent NULL pointer dereference if an appropriate group 
is not found.
 2006-04-28 19:49:13 +00:00
agc
62b10a5c9c Rather than hardcoding 8 LUNs per disk, use the number for the disc. 2006-04-26 20:31:43 +00:00
agc
84fba20a22 Use the correct opcode for the WRITE6 SCSI command 2006-04-26 20:29:56 +00:00
pavel
f705cb5488 We do not support pfsync, so: 
- remove xrefs to pfsync(4)
- remove the no-sync keyword from pf.conf(5)
- add a note to pf(4).

Approved by Peter Postma.
 2006-04-26 18:14:19 +00:00
pavel
e3b35bceeb The "group" keyword is not supported in NetBSD, so: 
- add a CAVEATS section to pf(4) and note it
- in the description in pf.conf(5) say it is unsupported
- remove it from the grammar in pf.conf(5).

Approved by Peter Postma.
 2006-04-26 17:55:33 +00:00
tron
27048c613e Add missing "const" keywords to match declarations in "pcap.h". 2006-04-26 09:24:33 +00:00
agc
000a68021a + Some minor formatting cleanup in the header files. 
+ Properly pad the names with spaces (with thanks to Bill Studenmund)
+ Use the official T10 vendor name, "NetBSD".
+ Minor cleanup in the INQUIRY command
+ Rather than just punting on the REPORT LUNs SCSI command, emulate it
properly.  This change makes the target work with the Solaris initiator:

	AVAILABLE DISK SELECTIONS:
	       0. c1d0 <DEFAULT cyl 29728 alt 2 hd 64 sec 63>
		  /pci@0,0/pci-ide@1f,1/ide@0/cmdk@0,0
	       1. c2t5d0 <DEFAULT cyl 97 alt 2 hd 64 sec 32>
		  /iscsi/disk@0000iqn.1994-04.org.netbsd.iscsi-target%3Atarget00001,0
	Specify disk (enter its number): 1
 2006-04-24 21:59:03 +00:00
elad
7cc919d464 fix typo. pr 33344. forwarded to paulus at samba dot org. 2006-04-23 19:01:08 +00:00
pavel
1cca0f0250 correct a typo: configruation -> configuration 2006-04-20 08:37:33 +00:00
darrenr
0df9b5fe68 ipf -Z returns junk and/or can cause a panic (seen on solaris.) 2006-04-18 12:40:49 +00:00
agc
339a11eb23 Bump version to 20060417 for the Mac OS X build fixes (thanks, Jason) 2006-04-18 06:52:59 +00:00
thorpej
e82413c3cf disk_read() / disk_write(): Make the temporary pointer a uint8_t *, rather 
than a char *.  Eliminates a GCC4 warning.
 2006-04-17 16:58:31 +00:00
thorpej
0c7787e9ae Let MD5Update() take a void *, rather than a uint8_t *. Gets rid of a 
GCC 4 warning.
 2006-04-17 16:49:16 +00:00
thorpej
01de58d459 Test HAVE_STDINT_H and bring in <stdint.h> if defined. 2006-04-17 16:45:02 +00:00
thorpej
57de6c70c3 Pull in config.h to get the definition of HAVE_STDINT_H 2006-04-17 16:44:42 +00:00
thorpej
7dd6393f48 Check for <libkern/OSByteOrder.h>. If it exists, use it to get the 
OSSwapBigToHostInt64() definition for HTOBE64().  This now builds on
Mac OS X 10.4.6.
 2006-04-17 16:30:00 +00:00
agc
f27a3c2c6b Commit regenerated config.h so that the correct version strings are picked 
up for NetBSD.
 2006-04-16 17:19:50 +00:00
agc
7a2241d682 Regenerate with new version number (20060416) 2006-04-15 23:45:30 +00:00
agc
4819a3749d Fix two other bugs which would manifest themselves on architectures which 
aren't quite as forgiving as i386 - when using a 16 bit value, use 16 bit
alignment6, not 32 bit. Makes the NetBSD iSCSI target function perfectly
with the Microsoft initiator when run on Solaris 9 on Sparc.
 2006-04-15 23:44:08 +00:00
agc
147705130b Bump version number to 20060415 for the bug-fix on big-endian Solaris 
platforms.
 2006-04-15 08:48:42 +00:00
agc
975cee31c1 Fix a bug found when running the NetBSD iSCSI target on big-endian (i.e. 
Sparc) Solaris hosts - check that the stored username is not NULL before
freeing it.

Some minor formatting cleanup.
 2006-04-15 08:46:23 +00:00
rpaulo
f2fdc155a3 stdlib.h and stdio.h should be in crypto.c not common.h 2006-04-13 19:07:08 +00:00
rpaulo
3bffa8df53 Include opensslv.h. 2006-04-12 15:40:03 +00:00
rpaulo
a20cc430b3 Include stdio.h and stdlib.h. 2006-04-12 15:39:39 +00:00
rpaulo
21617491ff information about upgrades 2006-04-12 15:22:56 +00:00
rpaulo
d70157382a Import of hostapd 0.4.8 2006-04-12 15:19:32 +00:00
rpaulo
0865712a46 resolve conflicts 2006-04-12 15:15:34 +00:00
rpaulo
6951c2edba Import of WPA supplicant 0.4.8 2006-04-12 15:07:34 +00:00
rpaulo
38619605fc Add new files from 0.4.8 that we won't need. 2006-04-10 20:43:00 +00:00
hubertf
f5ffa47293 Add missing .TP 
Patch sent to tech-net@ by Patrick Welche <prlw1@newn.cam.ac.uk>
 2006-04-05 18:07:30 +00:00
christos
825f80c59c Fix use after free. 2006-04-05 14:59:29 +00:00
martti
10531caa29 Removed file. 2006-04-04 16:18:56 +00:00
martti
9ea58d54bc Upgraded IPFilter to 4.1.13 2006-04-04 16:17:18 +00:00
martti
983a2072ce Import IPFilter 4.1.13 2006-04-04 16:08:18 +00:00
tls
1189bd8566 Make this locking compatible with that of the new tip/cu: we still try 
the old-style UUCP locks (this is harmless, since pppd must run as root,
but should perhaps be removed later) but now also try to flock the device
node, and error out if it fails.
 2006-04-03 16:16:00 +00:00
agc
9be1dc8d96 Use the correct type for the length argument to lba2cdb. 2006-04-02 10:46:47 +00:00
agc
8b20725dfb Fix a (repeated) obvious bug in the tracing functions. 
Modify the return values of some boolean functions to be 1 for success, 0
for failure, rather than 0 and -1 respectively.
 2006-04-02 09:36:57 +00:00
christos
8de5cf0e33 Coverity CID 2639: Fix obvious bug in loop handling. Using and freeing the 
wrong pointer.
 2006-04-02 01:10:39 +00:00
christos
2e0077c305 Add more coverity assertions. If this does not work, I will have to follow 
a different tactic.
 2006-04-02 00:53:56 +00:00
agc
cf0dd67053 Provide a bit more information in the error and warning routines - needed 
since variadic macros were removed.
 2006-03-31 23:22:24 +00:00
christos
46940789af Bye bye cdk. Moved via repository copy to othersrc/dist/cdk 2006-03-31 17:40:18 +00:00
christos
995a3df3f0 PR/33174: Wolfgang Stukenbrock: dhcpd fails to deliver hostnames for dynamic 
ranges because it is using the wrong universe in the host lookup.
 2006-03-31 17:28:50 +00:00
christos
1d00887f5d Insert coverity annotations [experimental; I don't know if those work 
at the variable declaration level, but we'll see]
 2006-03-29 16:40:50 +00:00
christos
f252e17155 Coverity CID 2486: Fix uninitialized variable 2006-03-29 16:09:53 +00:00
christos
85e2f53c41 Coverity CID 2786: Fix memory leak. 2006-03-29 15:44:19 +00:00
kardel
610b4c0dee dead code: removed (Coverity NetBSD CID 611) 2006-03-29 07:30:30 +00:00
kardel
d6c06e8308 fix as discussed in NTP Bug 584, Coverity NetBSD CID 1510 2006-03-29 07:19:34 +00:00
agc
2171876d1d More portability fixes, mainly for Solaris 9. 2006-03-28 20:03:30 +00:00
agc
f02decf866 Add changes to make the NetBSD iSCSI target compile and run on Solaris 9 
Ultrasparc.
 2006-03-27 22:26:28 +00:00
tron
7a28db2210 Fix build problem caused by last commit. 2006-03-27 10:02:37 +00:00
agc
6e1f35f92e minor cleanup in preparation for porting the NetBSD iSCSI target to Solaris 9. 2006-03-26 23:34:06 +00:00
christos
d20b033359 Coverity CID 1362: Allocate one more element to appease coverity. 2006-03-26 22:08:59 +00:00
christos
f3acb4a69b Coverity CID 1757: Don't leak memory 2006-03-26 22:04:14 +00:00
christos
4820f3f28c Coverity CID 1758: Unconfuse coverity about memory leak. 2006-03-26 22:02:59 +00:00
christos
714883262b Coverity CID 2038 2006-03-26 22:00:23 +00:00
christos
b1987e98f0 Coverity CID 2039: Plug memory leak. 2006-03-26 21:57:14 +00:00
christos
2b5f8cbcc0 Coverity CID 2042: Plug memory leak 2006-03-26 21:53:55 +00:00
christos
59ffb64e52 Coverity CID 2043: Don't leak memory 2006-03-26 21:49:01 +00:00
christos
d06f1825d5 Coverity CID 2044: Don't leak memory. 2006-03-26 21:46:25 +00:00
christos
e4dcd1072c Coverity CID 2399: Move strcpy lower, where it is actually going to be 
used, inside the test of directory != NULL.
 2006-03-26 21:44:05 +00:00
christos
34525befc6 Coverity CID 972: Someone confused && and || again. 2006-03-26 21:38:43 +00:00
he
ce943c094b Fix previous correctly. The "quiet" variable was not local. 
Instead, the problem was declarations which followed a non-declaration
statement, which gcc 2.95 doesn't like, so reshuffle the order.
 2006-03-25 21:56:29 +00:00
peter
a7819c4f5c Coverity CID 2783: Fix dereference of a freed pointer. 2006-03-25 16:06:04 +00:00
rpaulo
c43f7d959b PR 13604: detect and print correct information for 4.4BSD/NetBSD NFS 
filehandles.
The heuristic may or may not be wrong, but no one replied in the
tcpdump-workers mailing list.
Extraction of the fsid information contributed by Chuck Silvers.

Discussed with Chuck Silvers.
 2006-03-25 11:43:53 +00:00
he
9fb6f0e876 Don't default the type of a local variable. Fixes build for vax. 2006-03-23 19:25:09 +00:00
agc
e1d9f9cea5 First stab at implementing INQUIRY for Vital Product Data, aka Page 83 
information in the Solaris initiator, with information taken from
SPC3, T10/1416-D Revision 23, from www.t10.org.

This is untested, work-in-progress.
 2006-03-23 00:01:48 +00:00
christos
8d95e8aad0 Coverity CID 991: Remove useless test. 2006-03-22 04:34:49 +00:00
christos
af542fc05c Coverity CID 563: Kill SUNOS3 case; it is dead code. 2006-03-22 04:30:28 +00:00
christos
ded5be2fff Coverity CID 2746: Remove useless test. 2006-03-22 04:11:15 +00:00
christos
1174f5b4bb Coverity CID 2060: Fix memory leak. 2006-03-22 02:29:42 +00:00
agc
86caa230d8 Actually do something with the SYNC_CACHE command - use fsync_range(2) if 
it's available, falling back to fsync(2) if it's not. Add the necessary
glue to the autoconf scripts.
 2006-03-21 22:56:55 +00:00
agc
cbf5d4f8f5 Abstract out some common code, and place it in the utilities source. 
Get rid of some #ifdef __KERNEL__ abstractions - they're not needed.
 2006-03-21 21:03:14 +00:00
christos
b2f6added5 Coverity CID 577: remove dead code; minburst can never be 0 at this point. 2006-03-21 20:49:54 +00:00
christos
e46022bb52 Coverity CID 1514: Don't access static array beyond the end of it. 
In this case PFTM_MAX == 20 and sizeof(pf_timeouts) / sizeof(pf_timeouts[0])
== 21, using a loop with the size of the array and checking for reaching the
end of the loop via j == PFTM_MAX does not work. Change the loop to use
PFTM_MAX as the upper bound and add an assertion in the code to make sure
that pf_timeouts is large enough. Finally remove last NULL element of the
array so that the array has 20 elements again.
 2006-03-21 20:47:27 +00:00
christos
1a21d9be9f Coverity CID 2057: Don't forget to free tcpopts when you are done. 2006-03-21 20:31:56 +00:00
christos
eca1f0e01b Coverity CID 2491: Fix uninitialized reference. 2006-03-21 20:27:59 +00:00
christos
a674b513c2 Coverity CID 2738: When a symbol with a NULL name is passed, convert it to 
the empty symbol.
 2006-03-21 16:59:09 +00:00
kardel
a1cdcab3c8 buffer overrun: backport fix from NTP project (Coverity NetBSD Scan 8: CID 1509) 2006-03-21 11:12:13 +00:00
kardel
15dc7197ee null deref: fix another case of incomplete list handling (Coverity NetBSD Scan 8: CID 986) 2006-03-21 10:28:25 +00:00
agc
a055fd96f7 Incorporate changes from F. Senault, modified by myself to use 
autoconf glue, to make the NetBSD iSCSI target build and run on
FreeBSD.
 2006-03-20 20:45:07 +00:00
agc
2010c5954a Clean up, mostly to autoconf glue, to check whether syslog(3) exists or not. 2006-03-20 20:25:42 +00:00
christos
6dccf87632 Avoid overflowing static array which c == HAT. 2006-03-19 17:41:55 +00:00
kardel
dbefff2ee4 error handling: check success of open(2) - bail out early (Coverity CID 1282 NetBSD Scan 5) 2006-03-19 07:20:30 +00:00
kardel
24781071d1 null deref: complete linked list handling beginng condition (Coverity CID 986) 2006-03-19 07:02:47 +00:00
christos
57e31ffb5c Coverity CID 1867: Fix memory leak. 2006-03-18 22:39:40 +00:00
christos
a1f97364cb Coverity CID 862: Avoid NULL deref. 2006-03-18 22:37:16 +00:00
christos
73a77c6016 Coverity CID 1476: Add assertion before index operation. 2006-03-18 22:35:42 +00:00
christos
7f112146cb Coverity CID 866: Fix possible NULL deref. 2006-03-18 21:15:50 +00:00
christos
58deb05d13 Coverity CID 865: Fix possible NULL deref 2006-03-18 21:14:09 +00:00
christos
760ba920f3 Coverity CID 867: Fix possible NULL deref. 2006-03-18 21:11:43 +00:00
christos
b2229dcdbc Coverity CID 955: Fix possible NULL deref. 2006-03-18 21:10:12 +00:00
christos
33c12e6be9 Coverity CID 956: Possible NULL pointer deref. 2006-03-18 21:07:47 +00:00
christos
0a7d87f083 Coverity CID 957: Prevent NULL pointer deref. 2006-03-18 21:05:10 +00:00
christos
d9e5b13b10 Coverity CID 2033: Fix memory leak. 2006-03-18 20:48:42 +00:00
christos
6b81e42601 Coverity CID 2358: Although mp2 cannot be NULL here, checking it below for 
NULL is confusing. Check in both places.
 2006-03-18 20:46:23 +00:00
christos
973debfe6f Coverity CID 2359: Possible NULL deref. 2006-03-18 20:43:48 +00:00
christos
f3d47984b8 Coverity CID 2389: Remove extraneous check 2006-03-18 20:40:53 +00:00
christos
7908a85339 Coverity CID 2390: Wrong test; p cannot be NULL. 2006-03-18 20:38:01 +00:00
christos
06bdf1a1e0 Coverity CID 2485: Possible uninitialized variable use. 2006-03-18 20:33:34 +00:00
dsl
55d48ecf23 Remove the unnecessary 'if (found)' to stop Coverty bleating (CID 864).. 2006-03-18 18:05:13 +00:00
kardel
063cb750db mem leak: unreachable code prevented freeing of allocated memory 
(Coverity CID 612 NetBSD Scan 5)
 2006-03-18 15:22:34 +00:00
kardel
012eaf5162 null deref: avoid 0 deref (Coverity CID 987 NetBSD Scan 5) 2006-03-18 14:33:20 +00:00
kardel
36ab9cfe6b buffer bounds: one beyond buffer (Coverity CID 1490 NetBSD Scan 5) 2006-03-18 14:25:17 +00:00
kardel
a07906a5a8 buffer bounds: buffer full condition wrong for bounds check (Coverity CID 1508 NetBSD Scan 5) 2006-03-18 14:18:59 +00:00
kardel
630d3f115c buffer bounds: correct > - >= error for bounds check (Coverity CID 1511 NetBSD Scan 5) 2006-03-18 14:08:29 +00:00
kardel
99c0e2540c buffer bounds: clamp index for epobuf to buffer bounds (Coverity CID 1512 NetBSD Scan 5) 2006-03-18 14:02:13 +00:00
kardel
80b13f6f4e mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5) 2006-03-18 13:44:15 +00:00
kardel
ee0722e2b9 avoid close(-1): don't attempt to cleanup INVALID_SOCKET ( ==-1 ) fd's - would lead to close(-1) and FD_CLR((u_int)-1(!), ...) (Coverity CID 1281 NetBSD Scan 5) 2006-03-18 13:13:25 +00:00
kardel
9429ea9653 null deref: backport current ntp code to fix (Coverity CID 759) 2006-03-18 12:40:48 +00:00
dan
dbd04f2b27 free buf in error path; CID 2061 2006-03-18 12:15:05 +00:00
kardel
58ad32062f Coverity NetBSD scan CID 2055: fallout fix return/fclose -> fclose/return 2006-03-18 09:28:50 +00:00
kardel
e13d171a8e resource leak (fd/mem): fclose() streams on error (Coverity NetBSD scan CID 2055) 2006-03-18 09:26:08 +00:00
kardel
589ea6e802 resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054) 2006-03-18 08:57:25 +00:00
kardel
862343544d resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied ) 2006-03-18 08:09:03 +00:00
christos
f5b7b11e49 Coverity CID 346: Double free. 2006-03-18 04:41:57 +00:00
christos
a7e5a4a743 Coverity CID 347: remove dead code. 2006-03-18 04:39:50 +00:00
christos
dee21a2f06 Coverity CID 586: Remove dead code. 2006-03-18 04:34:41 +00:00
elad
6dceae8a70 Ditch the ugly hardcoded value and do proper bounds checking. 
Addresses CID 1417, found by Coverity.

Hi Darren! is this code maintained?
 2006-03-18 04:12:52 +00:00
christos
06b02ffc92 Coverity CID 1284: Handle -1 return from open(2) 2006-03-18 03:49:37 +00:00
christos
f5b784887f Coverity CID 1462: Static buffer overrun; off by 2. 2006-03-18 03:45:34 +00:00
christos
16fbed8bd1 Coverity CID 1616: Memory leak. 2006-03-18 03:43:13 +00:00
christos
fd8155f293 Coverity CID 1617: Memory leak 2006-03-18 03:39:57 +00:00
christos
67c67fc5bf Coverity CID 2059: Memory leak. 2006-03-18 03:35:41 +00:00
elad
77e1c3c1fc Fix off-by-one, found by Coverity. CID 1466. 2006-03-18 02:35:47 +00:00
elad
3af85b1067 Fix off-by-one found by Coverity, CID 1516. 2006-03-18 02:15:03 +00:00
kardel
9bccbf4462 Coverity fixes: 
CID
687	missing block
988	null pointer deref on shutdown (on open failure - introduced by
	change of contract in ntp_refclock.c)
989	null pointer for private data (could not happen - safeguard anyway)
1513	off by one
2410	misplaced null pointer test
 2006-03-18 00:30:30 +00:00
peter
11f7fb17d4 Fix file descriptor leaks. 
Coverity CID 1681.
 2006-03-17 15:50:44 +00:00
chris
d79b92051d Only dereference b after it has been NULL checked. 
Coverity CID 2398.
 2006-03-17 02:52:56 +00:00
agc
a4c7ca1aeb Get rid of c99isms in the form of variable number of args to CPP macros. 
This should slim down the resulting binaries a fair bit as well.
 2006-03-12 18:47:27 +00:00
agc
7acf73bedf Thanks to Thomas for the prod - update usage message to include all 
supported options.
 2006-03-11 12:09:36 +00:00
wiz
fb778aad1c Compact single letter options in SYNOPSIS. Sort option descriptions. 2006-03-11 11:58:53 +00:00
wiz
674cf041a7 Sort options as in man page. 2006-03-11 11:58:22 +00:00
wiz
93ba37c7ea Add -V to SYNOPSIS; serial comma; sort option descriptions. 2006-03-11 09:21:03 +00:00
he
56dbe819ca If compiling for NetBSD/vax, define boolean_t here before including 
<sys/file.h> with _KERNEL defined.  Also add a 3-line XXX comment
explaining some of why this is done.
Should fix the build problem documented in PR#32907.
Will be documented in doc/HACKS shortly.
Fix discussed with thorpej.
 2006-03-07 18:18:06 +00:00
wiz
e2a71c2aab 'advertisment' -> 'advertisement', from leonardo chiquitto filho 
via jmc@openbsd.
 2006-03-07 18:15:28 +00:00
agc
d4397af4d8 One more off the TODO list, although I hadn't realised it was going to be 
as painful as it was.

Teach GNU autoconf to recognise socklen_t, and use it in the code.
 2006-03-06 20:52:32 +00:00
agc
32306cea7e I have a nasty feeling it's time to sell all my guitars: 
Add some very crude hacks which allow the iscsi-target to work with IPv6:

Mar  5 23:43:45 sys3 iscsi-target: > Discovery login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: < Discovery logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: > Normal login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:48 sys3 iscsi-target: < Normal logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc

These have still to be cleaned up, but this will happen over the next
few days.

Update the TODO list to reflect the current state.
 2006-03-05 23:50:46 +00:00
agc
ff69df84c5 Add IPv6 awareness. 2006-03-04 22:06:26 +00:00
agc
7717b41470 Include version number, passed down from GNU autoconf. 
Add a -V argument to iscsi-target (and iscsi-harness), which will print
the utility name, version number, and destination for all bug reports,
and then exit the utility.

Modify the documentation accordingly.

Re-run autoconf and autoheader to pick up the necessary autoconf glue.
 2006-03-04 21:56:11 +00:00
agc
a70556aee7 Sync example file with reality - this has no effect on NetBSD, since 
configuration files are held in src/etc/iscsi, not src/dist/iscsi.
 2006-03-04 21:53:16 +00:00
agc
132771c158 Remove a file that's unnecessary. 2006-03-04 21:52:00 +00:00
wiz
64506871c4 Drop trailing whitespace. 2006-03-02 22:23:51 +00:00
christos
f696f0c430 Handle slip statistics too. 2006-03-02 17:32:28 +00:00
drochner
8c32a44b4d minor constification, good for WARNS=3 now 2006-02-27 16:00:20 +00:00
drochner
ed755469dd NetBSD adaption: 
-minor cleanup of installed headers
-const pcap_strerror() for consistency
 2006-02-27 15:57:17 +00:00
drochner
f5b56adedc minor constification, good for WARNS=3 now 2006-02-27 15:55:30 +00:00
drochner
431104fb34 avoid shadowing globals, for WARNS=2 2006-02-27 15:53:24 +00:00
drochner
a7dfc7f00f pull in from NetBSD's libpcap: use cloning bpf device on NetBSD 2006-02-27 15:51:38 +00:00
drochner
6dab7ae580 pull in from NetBSD's libpcap: import header for __NetBSD_Version__ 2006-02-27 15:50:09 +00:00
drochner
3c909ce59d import original libpcap-0.9.4 from tcpdump.org, 
with unrelated subdirs omitted
 2006-02-27 15:45:37 +00:00
dyoung
0f0c24e0c7 Print the "bad-fcs" radiotap flag. 2006-02-26 03:04:28 +00:00
dyoung
125170229e Reduce diffs between NetBSD's authoritative radiotap header file 
and TCPDump's.
 2006-02-26 03:04:03 +00:00
wiz
b82f53ae21 Fix typo in comment. 2006-02-25 01:58:39 +00:00
wiz
9096fdfaac Remove superfluous comma. 2006-02-24 21:01:19 +00:00
agc
b95774e6d4 Implement SCSI commands: 
0x1b Load/Unload Sequential
0x4d Log Sense
0x5e (unknown for just now)
0x35 Synchronise cache

as no ops for the present time - reported on current-users by Chavdar
Ivanov as being generated by the Solaris 10 initiator.
 2006-02-24 20:47:30 +00:00
he
127058acaa Include <sys/param.h> explicitly relatively early, so that we pick 
up the definition of MAX earlier, and avoid a redefinition which
GCC 2 isn't very fond of.  Fixes build problem for vax.
 2006-02-22 08:56:46 +00:00
agc
9b7f93748a Add an initial version of the iscsiconfig utility - initially only 
discovery functionality is supported.
 2006-02-20 09:00:05 +00:00
agc
f06c81ed28 Further cleanup. 
Add an initiator_discover() function, and start to break up the monolithic
discovery function that's currently used.
 2006-02-20 08:59:07 +00:00
agc
c9ecbabb62 Clean up, get rid of unused code. 
Add my copyright for the extent, device and target conf file parsing and
manipulation code.
 2006-02-20 08:57:32 +00:00
agc
b8ca8cc0de Clean up a bit - only print the huge stuff if we're debugging. 2006-02-20 08:56:06 +00:00