Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
144,921 Commits 606 Branches 0 Tags 3.1 GiB
f12fd11960
Commit Graph

8543 Commits

Author SHA1 Message Date
phil
4617d0a2bf Kill NULL deref (CID: 871) 
Plug fd leak (not caught by coverity).
 2006-03-21 21:59:56 +00:00
christos
9731df7d2d make this compile again. 2006-03-20 23:13:51 +00:00
dsl
7ee2912cf6 free() intrnamebuf, intrname and intrloc on entry so we don't leak them 
every time initvmstat() is called.
Change intrnamebuf to be static so this works.
Inspired by Coverty CID 2072 (incorrectly) reporting that the memory assigned
to intrnamebuf wasn't being freed.
 2006-03-20 20:36:38 +00:00
elad
cd7d931d2e plug leaks, coverity cids 92, 93. 2006-03-20 17:18:06 +00:00
elad
c080c43ef1 plug leak, coverity cid 98. 2006-03-20 17:03:08 +00:00
elad
3e7dafb547 plug leak, coverity cid 94. 2006-03-20 17:01:26 +00:00
elad
6bceef66d3 - plug leak in generate_guard() 
- plug leak in h_output(), coverity cid 100
 2006-03-20 16:58:13 +00:00
christos
85e611dd01 Goodbye KerberosIV 2006-03-20 04:03:10 +00:00
gdamore
6af224c1b4 Support cross-building tn3270 from other OS' e.g. Solaris by hiding 
_RCS and _COPYRIGHT macros in #ifndef HOST_TOOL, and defining HOST_CPPFLAGS
apropriately for host tools.  Approved by uwe@.
 2006-03-20 01:34:49 +00:00
cube
6a6299eb8f Panic on an unlikely error condition. CID 177. 2006-03-19 23:36:10 +00:00
cube
e50e4ee4b2 Free a nvlist used temporarily. 
Found by Coverity, CID 179 and 180.
 2006-03-19 23:12:59 +00:00
jnemeth
4be1f2c6fd Fix Coverity run 5, issue 1931 -- memory leak. This was noted as being a 
bug by cgilbert.
Approved by christos@.
 2006-03-19 22:52:01 +00:00
cube
11820066f8 Close file on error. CID 176. 2006-03-19 22:34:44 +00:00
cube
8e4130e5ee Fix various resource leaks, all happenning on error situations (IOW, 
shortly before exit(1)).  CIDs 181, 182, 183, 184 and 185.
 2006-03-19 22:27:14 +00:00
cube
3eaff5cb14 Proper resource handling in mkmakefile(). 
Coverity CIDs: 186, 187, 188 and 189.
 2006-03-19 16:27:13 +00:00
wiz
59ba5fe8d1 New sentence, new line. 2006-03-19 10:45:03 +00:00
rtr
739b734996 the preceeding loop does not terminate except in a condition where 
kp != NULL therefore testing if kp is == NULL after it is pointless
coverity 2446 / run 6
 2006-03-19 06:10:22 +00:00
rtr
880b6df674 avoid double fclose() 
coverity 2577 / run 6
 2006-03-19 05:01:48 +00:00
rtr
d9da031351 remove ambiguity in evaluation of conditional expressions and avoid 
double fclose().
coverity 2713 / run 6
 2006-03-19 04:34:19 +00:00
sjg
98b766c482 Fix :P modifier so it actually works as described. 
I.e ${var.c:P} should expand to the absolute path of var.c found via .PATH
 2006-03-19 01:54:21 +00:00
sjg
8af5ec82ab Document an interesting kwirk in := handling of undefined variables. 2006-03-19 01:53:01 +00:00
dsl
1655d9a820 Code to display per-system call counts. 
Very useful to help identify which code is doing 1000s of system calls.
Not built because no one else has a kernel yet, and I need to make
the kernel side configurable.  But I don't want to lose this code....
 2006-03-18 20:31:45 +00:00
dsl
efc0bc90c3 Count both read bytes and write bytes when we are not showing separate read 
and write statistics.  Discovered by go.
Since I broke in in rev 1.31, I guess I'll fix it first!
 2006-03-18 16:48:44 +00:00
dsl
bee1c2beb6 Make the functions that display the top 8 lines externally visible so 
they can be used to head other pages (not ready to commit yet...).
Use puthumanint() for oversize numbers when display_mode is RUN or BOOT (when
very big numbers are to be expected).
Allow an extra column for Csw..Flt.
Adjust some #defines to avoid use of global s & s1.
 2006-03-18 14:58:49 +00:00
dsl
2769bb6a26 Coverty 1212: Avoid close(-1). 2006-03-18 11:15:00 +00:00
dsl
f9603a44ea Coverty 7449: Remove splurious check for 'sep == NULL'. 2006-03-18 11:02:48 +00:00
christos
22983123c5 Coverity CID 2341, 2342: Plug memory leak. 2006-03-18 09:46:35 +00:00
ginsbach
ccae083c7b Fix Coverity CID 1248, negative return from read() passed() to write() 
as a large unsigned value.
 2006-03-18 03:40:51 +00:00
ginsbach
1a75882940 Fix Coverity issue 1236, negative return from read() passed to write() 
as a large unsigned valued when read() is interrupted (errno == EINTR).
 2006-03-17 21:52:41 +00:00
ginsbach
7ee29c7f81 Fix Coverity issue 1564, resource leak, dynamically allocated storage not 
freed before function return.
 2006-03-17 21:19:24 +00:00
elad
cbe6a15c01 Another overrun forgotten in previous commit, also found by Coverity. 
CID 1481.
 2006-03-17 20:44:28 +00:00
elad
ab24a02ffe Fix buffer overrun found by Coverity, CID 1482. 2006-03-17 20:41:02 +00:00
christos
75f03570ec Coverity CID 2719: argvalue can be NULL when passed into functions. 
De-obfuscate by undefining optarg, and check explicitly for NULL before
use.
 2006-03-17 15:39:44 +00:00
rumble
0fe2cb9e42 Ensure that malloc does not return NULL before copying the buffer. 2006-03-17 04:53:55 +00:00
elad
9e505fa94b Fix two off-by-ones found by Coverity. 2006-03-17 01:55:31 +00:00
christos
d8a5b3caf5 warns=4 2006-03-16 23:25:17 +00:00
christos
f04bb5fddb warns=4 2006-03-16 16:49:07 +00:00
dsl
5f31eae781 nJobs and jobTokensRunning are both counting the same thing. 
Kill nJobs and just use the count of tokens in use.
Don't eat job tokens when we are ignoring errors.
 2006-03-15 20:33:19 +00:00
dsl
f26d89e3d9 JOB_FIRST is always set (since we only execute the shell once for every 
target). Nuke it.
 2006-03-13 20:35:09 +00:00
dsl
b85c051fa8 Remove the 'never non-NULL' 'previous' argument to JobStart. 
Looks like it was intended as a minor (and pointless) optimisation to
remove a free() malloc() pair.
Make he comment about the stoppedJobs list more correct.
 2006-03-12 20:14:56 +00:00
dsl
a484dfd693 It isn't possibly to execute any part of job.c that references compatMake 
when it is 'true'.  So delete the unexecutable code.
 2006-03-12 19:14:51 +00:00
dsl
c9b3912b1e Remove most of the code seemed to be there to support 'remote jobs'. 
It isn't clear that it ever worked, if it did it has almost certainly
bitrotted in the last 12 years.  I'm not even sure all the required
components were present.
I suspect it was written to attempt to use a 'farm' of diskless sun3s.
In any case the apparant random assignment fo jobs to other systems doesn't
actually seem like a good idea!
Things like 'distcc' han be used to help slow systems run native builds.
Removing this code also simplifies make, and should let me speed up some of
its processing - without worrying about bitrotting it further.
 2006-03-11 17:18:00 +00:00
christos
bc3a1c6523 PR/33054: Nicolas Joly: id(1) sometimes report a duplicate group when a user 
is not specified. This is because it prints getgid() and getgroups(). If the
getgid() is in the getgroups() set, it was printed twice. This is now detected
and the duplicate printing is avoided.
 2006-03-11 17:16:01 +00:00
wiz
904496fbc8 Markup fixes. 2006-03-11 12:02:20 +00:00
christos
5e6b1075e2 PR/33049: OKANO Takayoshi: Fix the spelling of NetBSD RCS tags. 2006-03-10 15:53:55 +00:00
dsl
5e60bf00ce Avoid calling JobRestartJobs() from the SIGCONT signal handler, instead 
push a byte through the (now badly named) exit_pipe and call JobRestartJobs()
from the main code path when poll() wakes up.
Part of a plan to remove JobSigLock() and the zillions of system calls
it does.
 2006-03-08 22:11:48 +00:00
jnemeth
1a6a87b59b PR/23616: Christian Biere: login might not back-off as expected 2006-03-08 03:09:04 +00:00
jnemeth
2e3c4f59d7 PR/23616: Christian Biere: login might not back-off as expected 2006-03-08 02:49:18 +00:00
hubertf
8c061da318 Xref pwhash(1), 
pointed out by Stefan Schumacher at the Chemnitz Linuxdays
 2006-03-07 01:52:09 +00:00
jnemeth
99089ba6f8 PR/30923: Zafer Aydogan: pam too verbose 
Don't display a different message for root logins on insecure terminals.

Approved by christos@.
 2006-03-06 23:06:18 +00:00