christos
760ba920f3
Coverity CID 867: Fix possible NULL deref.
2006-03-18 21:11:43 +00:00
christos
b2229dcdbc
Coverity CID 955: Fix possible NULL deref.
2006-03-18 21:10:12 +00:00
elad
6c6e841e30
Don't dereference NULL pointer, found by Coverity, CID 954.
2006-03-18 21:09:57 +00:00
christos
33c12e6be9
Coverity CID 956: Possible NULL pointer deref.
2006-03-18 21:07:47 +00:00
christos
0a7d87f083
Coverity CID 957: Prevent NULL pointer deref.
2006-03-18 21:05:10 +00:00
christos
d9e5b13b10
Coverity CID 2033: Fix memory leak.
2006-03-18 20:48:42 +00:00
christos
6b81e42601
Coverity CID 2358: Although mp2 cannot be NULL here, checking it below for
...
NULL is confusing. Check in both places.
2006-03-18 20:46:23 +00:00
christos
973debfe6f
Coverity CID 2359: Possible NULL deref.
2006-03-18 20:43:48 +00:00
christos
f3d47984b8
Coverity CID 2389: Remove extraneous check
2006-03-18 20:40:53 +00:00
christos
7908a85339
Coverity CID 2390: Wrong test; p cannot be NULL.
2006-03-18 20:38:01 +00:00
christos
06bdf1a1e0
Coverity CID 2485: Possible uninitialized variable use.
2006-03-18 20:33:34 +00:00
dsl
1655d9a820
Code to display per-system call counts.
...
Very useful to help identify which code is doing 1000s of system calls.
Not built because no one else has a kernel yet, and I need to make
the kernel side configurable. But I don't want to lose this code....
2006-03-18 20:31:45 +00:00
christos
55303a4a4b
Coverity CID 2307: Possible memory leak.
2006-03-18 20:25:28 +00:00
christos
f04c9de45b
Coverity CID 2306: Possible memory leak.
2006-03-18 20:23:51 +00:00
christos
5ac5bc844b
Coverity CID 1079: Possible NULL deref.
2006-03-18 20:21:50 +00:00
christos
704b63146c
Coverity CID 1080: Possible NULL deref.
2006-03-18 20:20:31 +00:00
christos
6672211d0f
Coverity CID 2432: Dereference before NULL check.
2006-03-18 19:55:49 +00:00
christos
ec39c1a649
Fix compilation.
2006-03-18 19:23:14 +00:00
christos
5900226fad
Lint comment.
2006-03-18 19:22:59 +00:00
matt
170f4f3a59
MALLOC -> malloc
2006-03-18 18:56:19 +00:00
chris
aee09871fa
Fix eeprom == NULL and size test.
...
Fixes Coverity CID 1109: (sc)->eeprom_data tracked as NULL was
dereferenced.
2006-03-18 18:44:16 +00:00
macallan
a7fb3cd241
claim some responsibility
2006-03-18 18:41:09 +00:00
yamt
3aa5cee09f
m_print: fix the previous correctly.
2006-03-18 18:17:19 +00:00
dsl
55d48ecf23
Remove the unnecessary 'if (found)' to stop Coverty bleating (CID 864)..
2006-03-18 18:05:13 +00:00
chris
998afe8b1c
Move check of strp for NULL to the top of the function, if it's NULL
...
release the lock and exit.
It could be argued that we only ever call the function with strp being
valid so the test isn't needed, but that requires the caller not to change,
or be altered/broken.
Fixes Coverity CID 2357, strp deferenced before NULL check.
2006-03-18 17:44:13 +00:00
chris
3b6dcb2526
Fix Coverity CID 1473: Static buffer overrun.
...
Add a counter for the number of pages, so that we print out the ext_pgs
values.
2006-03-18 17:37:17 +00:00
oster
0a0615d52a
dag_h will always be NULL in this case, and thus we can eliminate a
...
bit of dead code. Addresses Coverity CID 728 NetBSD Scan 5.
2006-03-18 17:34:31 +00:00
jmmv
c7259b72b2
Fix apostrophe key on Spanish keyboards.
2006-03-18 17:33:16 +00:00
jmmv
5f4c11af49
WARNS=4
...
One of the changes fixes Coverity CID 2468 (use of uninitialized error
variable in main).
2006-03-18 17:09:35 +00:00
dsl
efc0bc90c3
Count both read bytes and write bytes when we are not showing separate read
...
and write statistics. Discovered by go.
Since I broke in in rev 1.31, I guess I'll fix it first!
2006-03-18 16:48:44 +00:00
kardel
063cb750db
mem leak: unreachable code prevented freeing of allocated memory
...
(Coverity CID 612 NetBSD Scan 5)
2006-03-18 15:22:34 +00:00
dsl
bee1c2beb6
Make the functions that display the top 8 lines externally visible so
...
they can be used to head other pages (not ready to commit yet...).
Use puthumanint() for oversize numbers when display_mode is RUN or BOOT (when
very big numbers are to be expected).
Allow an extra column for Csw..Flt.
Adjust some #defines to avoid use of global s & s1.
2006-03-18 14:58:49 +00:00
kardel
012eaf5162
null deref: avoid 0 deref (Coverity CID 987 NetBSD Scan 5)
2006-03-18 14:33:20 +00:00
bouyer
d663834226
Fix memory leak if we're adding an existing group name.
...
Coverity ID 1568.
2006-03-18 14:33:07 +00:00
jmcneill
aca78114dc
Revert local changes not meant for previous commit.
2006-03-18 14:31:26 +00:00
kardel
36ab9cfe6b
buffer bounds: one beyond buffer (Coverity CID 1490 NetBSD Scan 5)
2006-03-18 14:25:17 +00:00
kardel
a07906a5a8
buffer bounds: buffer full condition wrong for bounds check (Coverity CID 1508 NetBSD Scan 5)
2006-03-18 14:18:59 +00:00
kardel
630d3f115c
buffer bounds: correct > - >= error for bounds check (Coverity CID 1511 NetBSD Scan 5)
2006-03-18 14:08:29 +00:00
kardel
99c0e2540c
buffer bounds: clamp index for epobuf to buffer bounds (Coverity CID 1512 NetBSD Scan 5)
2006-03-18 14:02:13 +00:00
bouyer
9d8928a40d
Fix dead error condition, coverity ID 747.
2006-03-18 13:56:51 +00:00
bouyer
d8a43c47ae
Fix a dead error condition, coverity ID 603.
2006-03-18 13:54:21 +00:00
bouyer
b1dc0ca141
Remove dead code, fixing coverity ID 745. nameiop can only be CREATE
...
or DELETE here. This code got cut-n-pasted from ufs_loolup.c, but
is only used in whiteout support. ext2fs doesn't support whiteout.
2006-03-18 13:49:19 +00:00
kardel
80b13f6f4e
mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5)
2006-03-18 13:44:15 +00:00
kardel
ee0722e2b9
avoid close(-1): don't attempt to cleanup INVALID_SOCKET ( ==-1 ) fd's - would lead to close(-1) and FD_CLR((u_int)-1(!), ...) (Coverity CID 1281 NetBSD Scan 5)
2006-03-18 13:13:25 +00:00
jmcneill
e0476e5490
Check the return value of AUCONV_MALLOC. Fixes a pile of CIDs related to
...
auconv.
2006-03-18 13:12:15 +00:00
jmcneill
a737ed394b
Don't use intarg uninitialized in wsdisplay_usl_ioctl2. Fixes CID 2507
2006-03-18 13:06:38 +00:00
bouyer
f7123013b8
bread() will always return a valid bp. So remplace the (always true) if (bp)
...
with a KASSERT.
Should fix Coverity ID 2444.
2006-03-18 12:48:38 +00:00
dsl
57c63d8912
Avoid indexing beyond the end of a malloced array.
...
Rework loop to be less confusing.
Coverty 519 made me read this code, but this isn't the 'bug' it found.
2006-03-18 12:48:35 +00:00
kardel
9429ea9653
null deref: backport current ntp code to fix (Coverity CID 759)
2006-03-18 12:40:48 +00:00
rtr
b06fd00a81
free buf on error path
...
coverity 190 / run 5
2006-03-18 12:35:41 +00:00