Commit Graph

99 Commits

Author SHA1 Message Date
mschuett 499d95ff35 PR/40563: Takahiro Hayashi: syslogd(8) refers freed pointer on exiting 2009-02-06 21:09:46 +00:00
mschuett c998ee30ad PR/40438: Takahiro Hayashi: syslogd(8) refers freed area 2009-01-22 21:10:52 +00:00
lukem 64d3f79556 sign-compare fixes for amd64 2009-01-22 10:45:35 +00:00
lukem 7e0b2295e7 fix -Wsign-compare issues 2009-01-18 10:35:26 +00:00
christos 433a3ec2f3 fix suseconds_t format. 2008-12-29 03:45:23 +00:00
christos b3ed889133 PR/40043: Geoff C. Wing: syslogd timestamping and protocol parsing deficiencies
Syslogd does not properly handle:

1) the ADDDATE flag which is set with -T invocation and when messages
   come from the kernel.  Other cases where it is set it is ignored
   as timestamping is always done (e.g. logmsg_async())

2) the variable found_ts in check_timestamp().  It would determine
   whether or not the message had a (possibly valid) timestamp, set
   found_ts to true, then ignore that in most cases.  If we can't find
   a timestamp return.

3) messages without a parsable timestamp should get one when outputting
   the BSD syslog format so that a syslog-protocol timestamp isn't
   injected (chopped off with BSD syslog length) giving something like:
    "2008-11-27T15:0 cisco -: 1790:"
     ^ time might have been 2008-11-27T15:02:35.296497+11:00

4) syslog protocol version checking only checked for a leading numeral
   one (1) then skipped two places (presuming a space).  Messages sent
   from some sources (e.g. my cisco) may be
     "1795: Nov 27 04:12:52: %LINEPROTO-5-..."
   which would be chopped to
       "95: Nov 27 04:12:52: %LINEPROTO-5-..."
2008-11-27 20:37:21 +00:00
christos 61a52fac84 PR/39874: Geoff C. Wing: For compatibility trim hostname domains in bsd
output format when matching host lines.
2008-11-07 15:42:01 +00:00
minskim a325bf28ac Remove trailing whitespace. 2008-11-07 07:36:38 +00:00
christos 00f6effc9c use localtime_r 2008-11-04 18:52:25 +00:00
blymn d08a89fb84 Call tzset() to init TZ information for localtime(). 2008-11-04 10:01:56 +00:00
christos 9d5a7031b8 make sure that we memset the struct tm we pass to mktime and set isdst to -1
so that it will figure out if daylight savings is to be applied or not. From
Anon Ymous
2008-11-03 22:59:51 +00:00
christos 79e7aba61d PR/39857: Bernd Ernesti: Fix broken output caused by a wrong offset. From
Martin Schuette.
2008-11-03 02:44:01 +00:00
christos 1c6aec2060 Import syslogd SoC project by Martin Schuette:
- new syslog protocol api syslogp(3) that supports structured data
	  and draft-rfc timestamps
	- reliable tcp connections with queueing
	- encrypted connections
2008-10-31 16:12:18 +00:00
lukem 9c1945664c Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.
2008-07-21 13:36:57 +00:00
dholland 16e3bec279 Clarify how one is supposed to use the pointers returned by getutentries()
(the utmpentry.c code), specifically with respect to who owns them and
when to free them. Now they're owned by utmpentry.c, only. Abolish the
freeutentries() function, which was the wrong abstraction; add instead
endutentries(), which flushes out the internally managed memory.

Update callers as necessary. Some (e.g. talkd) had been leaking memory;
others (e.g. syslogd) had been accidentally freeing and reloading utmp
more often than necessary. There are a couple untidy bits in users and
rwhod that someone should look after sometime, maybe.

Fixes PR bin/35131, which was about talkd's memory leak.
2008-07-13 20:07:48 +00:00
christos 381520cf11 PR/34979: Scott Ellis: Detect 0 length name and skip it instead of infinite
loop.
2006-11-13 20:24:00 +00:00
yamt 6c6dad782f matches_spec: fix a bug so that "+host111,host1" actually matches to host1.
add a simple sanity check.
2006-10-21 09:42:26 +00:00
christos 6ec268c772 PR/30879: Jukka Salmi: syslogd(8) doesn't parse `@' hostname specification
correctly
2006-09-16 17:05:32 +00:00
christos 6051bcc73f PR/28753: Martin J. Laubach: syslogd disables remote logging on non-fatal errors 2006-09-16 16:57:27 +00:00
wiz 8d3165ac32 Sync usage with man page (-b). 2006-09-16 06:34:55 +00:00
christos ca09b578d0 PR/14563: Brian A. Seklecki: syslogd binds udp sockets on all interfaces
Add -b option to pass a bind address.
2006-09-15 20:32:59 +00:00
snj a640fe8c43 It's "its." 2006-04-24 19:00:29 +00:00
pavel 43bd0b5956 PR 32579: Add a -T flag to syslogd, which causes it to use local time for
messages received from the network. Useful for collecting logs from
devices which do not have correct time.

Add it to usage.

Document it, also document that syslogd adds a timestamp with the local
time if it does not recognize the original timestamp field. Bump date.

Approved by wrstuden@.
2006-04-19 21:18:50 +00:00
lukem 1fab072e48 appease gcc -Wuninitialized 2005-06-02 09:42:57 +00:00
christos de883a09a8 Abolish the magic 7, and count iovectors explicitly. 2005-01-09 00:07:27 +00:00
matt c7914c97fe Make syslogd automatically recover from full disks by noticing that the
write error was ENOSPC and either wait for a successfull write or a
different errno.
2004-12-09 00:56:47 +00:00
thorpej 9e47f7b6ef Fix typo that caused priories to compare incorrectly. PR bin/28376 and
bin/28380.  Fix from Geoff Wing.
2004-11-23 14:19:57 +00:00
wiz 1dae5724d8 -u changed to -U when porting from FreeBSD; update comment. 2004-11-19 18:48:18 +00:00
thorpej f30d060939 We have to read the config file the first time after we allocate the
kqueue descriptor, because we set up events after we parse the file.

Unfortuntately, this means that we also have to do the chroot before
we read the config file.  But this is OK -- the config file has to be
in the chroot environment anyway, because it has to be able to get to
it after SIGHUP.

Grrr, all because stupid kqueue descriptors are not inherited across
a fork.  LAME.
2004-11-19 02:51:18 +00:00
thorpej 83f70aba69 Merge the thorpej-syslogd-hack-branch down to the trunk. Enhancements
include:

- Extend the syntax of syslog.conf to allow selections of log destinations
  by comma-separated lists of program name (including kernel-generated
  messages) and originating host name.
- Ability to pipe selected messages through arbitrary filter commands.
- Ability to specify priority comparison operations.
- Improvements to domain name handling.
- Conversion to use kqueue for communication and signal events, eliminating
  all unsafe signal handlers.
- Allow spaces as well as tabs in syslog.conf.
- Log kernel printfs at LOG_NOTICE instad of LOG_CRIT.
- Ability to log facility/priority with a log message.
- Reliability improvements.
2004-11-19 02:18:11 +00:00
dsl 3cca093e74 Add (unsigned char) cast to ctype functions 2004-10-30 15:51:20 +00:00
heas 3114eb2be3 Postpone initial setting of the alarm timer until after the call to daemon(),
as the timer would be cleared by daemon's fork().
2004-10-28 20:04:24 +00:00
wiz 87c2003f7c Add -S to usage. 2004-10-10 09:43:02 +00:00
mycroft ad19a75b36 Don't fsync() kernel messages by default -- enable it with the "-S" flag.
This avoids some seriously gratuitous disk hosage in various cases.

XXX It would probably be better to allow this to be specified in the config
file somehow.
2004-10-08 17:25:52 +00:00
itojun 3e6b951d2a use "volatile sig_atomic_t" for gothup; Havard Eidnes 2004-03-06 20:29:25 +00:00
itojun 451af9862c make SIGHUP handler very small, and call init() from the main poll() loop.
should fix PR bin/24682.
2004-03-06 14:41:59 +00:00
lukem fdffaa3fe5 Implement -r, which prevents syslogd from compressing multiple messages with
the same string into "last message repeated N times", and instead forces
syslogd to write out every message.

Based on '-c' in FreeBSD's syslogd, although a different option letter was
chosen because their syslogd requires '-c -c' to get this functionality,
and we don't have the support for logging to pipes which is what FreeBSD's
syslogd with a single '-c' is related to.
2003-10-17 01:39:25 +00:00
itojun 686afb7f65 safer use of realloc 2003-10-16 06:22:09 +00:00
itojun 4a7fa92f21 no need for explicit '?'; openbsd 2003-09-19 08:24:07 +00:00
agc 326b2259b7 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22366, verified by myself.
2003-08-07 11:25:11 +00:00
itojun b2189acdb8 whitespace fix 2003-05-14 23:58:23 +00:00
itojun 4b641df88a strlcpy audit 2003-05-14 23:53:09 +00:00
itojun 343d3d8f80 die if out-of-range uid/gid is specified. 2002-11-16 03:59:36 +00:00
itojun b5c1ff7fae set IPV6_V6ONLY to 1 to avoid complicated access control issue
(libwrap takes care of it, but just to be sure)
2002-09-24 13:53:54 +00:00
christos d116a0bbd3 add utmpx support; 2002-08-02 02:23:49 +00:00
itojun 6ed8672880 no need for KAME_SCOPEID any longer 2002-06-09 19:59:55 +00:00
wiz 0df8aade00 ANSIfy, and some KNF. Sort options in getopt-switch. Drop some unneeded
include files.
2002-05-25 14:46:01 +00:00
wiz a16dbed217 Sort options in man page, don't mention non-existing '-S' option,
use some more markup and improve existing one.
Sync usage() with man page.
2002-05-25 14:21:02 +00:00
lukem 6206a1d7eb remove commented out debug printf() accidentally committed in the last rev.
noted by YAMAMOTO Takashi<yamt@mwd.biglobe.ne.jp> in private email.
2002-05-02 13:53:10 +00:00
lukem f3c2d5334e logpath_add(): store pointer to strdup(3)ed copy of path provided.
fixes -P /some/file.
2002-01-18 10:27:50 +00:00