Commit Graph

1892 Commits

Author SHA1 Message Date
christos
3e3be60bf3 one less, 6 left. 2013-03-23 16:32:04 +00:00
christos
ab35868474 It is ridiculous to truncate files on character conversions without
warning and a chance for recovery. This patch sets the handler to
copy the character, clear the error and proceed instead of bailing
out.

To replicate:
	- unset LANG
	- Create a file that has ~1000 lines. Put a single bad character
	- '\344' in it, around 2/3rds of the file down. Save it.
	- export LANG=en_US.UTF-8
	- edit the file. Notice there is no error for input conversion,
	  since nvi reads the file opportunistically.
	- :w Boom, the file is truncated.

Alternatively, you can put that character in the first line of the file,
and watch the fireworks. If you like to restore the previous behavior
compile with -DERROR_ON_CONVERT

XXX: Pullup to 6, 5 etc.
2013-01-23 18:51:51 +00:00
rmind
63f8748ee9 ftp-proxy: disable NPF bits for now; it will be re-done. 2012-12-24 01:14:40 +00:00
njoly
c65ba2a0a3 Protect a few more quotes in chat script examples. 2012-11-19 22:31:34 +00:00
plunky
ea7708e17f IPF 5.1.2 is in external/bsd/ipf and sys/external/bsd/ipf now;
these files are obsolete
2012-09-15 18:12:17 +00:00
plunky
72f78fcb94 reinstate "Update ftp-proxy for changes to ipnat_t" from Darren Reed 2012-09-15 17:42:43 +00:00
spz
c168ad8961 Use after free (Coverity 273146) 2012-07-15 09:13:59 +00:00
abs
315046f892 Casting an uint32_t pointer to (long *) may have been acceptable
in the eighties but that time has long past. Minimally invasive
fix using a temporary long variable, so while we can still overflow
at least we're less broken.
2012-06-25 16:47:03 +00:00
wiz
3815d29a7f Finish move of bzip2 from dist/bzip2 to external/bsd/bzip2. 2012-05-07 00:35:25 +00:00
christos
e93329c39c print sizeof() with %zu 2012-04-08 21:18:46 +00:00
wiz
4fe94283f2 Cast argument to unsigned long for i386. 2012-04-08 20:41:18 +00:00
wiz
c1f6ba2db1 Fix a format string error clang found. 2012-04-08 17:04:19 +00:00
wiz
e57903e6cb Sprinkle __dead and __printflike for clang. 2012-04-08 17:04:07 +00:00
christos
dcf51b974e make this work on 64 bit machines; use stdint/inttypes. 2012-04-06 22:41:47 +00:00
he
12d4087930 More c89 prototypes, mostly just filling in void where needed. 2012-03-23 14:49:55 +00:00
joerg
4cd46b4ac8 Add some more __dead as exposed by the recent WARN bumps. 2012-03-22 22:59:43 +00:00
he
2bf75ee57f Add a void to make function declaration c89. 2012-03-22 08:56:52 +00:00
joerg
efa013cb75 Fix format string usage. 2012-02-29 23:42:28 +00:00
joerg
8c3e60d97f Don't use loops with empty body. 2012-02-25 00:13:00 +00:00
christos
698a2b6926 moved to external/bsd 2012-02-18 19:20:43 +00:00
riz
f8a1d7977c Back out the recent import of IPFilter 5.1.1 for the upcoming branch,
which will now have IPFilter 4.1.34.  IPFilter 5.1.1 will be restored
post-branch.

ok: core, releng.
2012-02-15 17:55:03 +00:00
joerg
782395a37e Really skip the current line only if the comment is at the start. 2012-02-03 04:28:55 +00:00
darrenr
9330b4a5e1 Compiler warning on a for loop that does not terminate correctly 2012-02-02 19:18:51 +00:00
martin
493d58c360 More printf format fixes 2012-01-31 08:57:36 +00:00
martin
6954772773 Fix printf formats (those who can't decide wether to use casts or PRI*
macros do both in bogus combination)
2012-01-31 08:43:44 +00:00
darrenr
60a7048ce5 Correct merge error from import. 2012-01-30 20:10:27 +00:00
darrenr
6e01b777b4 Merge error - stale code from HEAD not removed. 2012-01-30 20:08:31 +00:00
darrenr
3646154e14 Lost on import 2012-01-30 19:38:45 +00:00
darrenr
4e1b0345a9 Lost on import 2012-01-30 17:54:34 +00:00
darrenr
9598df00fd Update ftp-proxy for changes to ipnat_t 2012-01-30 16:14:27 +00:00
darrenr
b01ead29e4 Merge IPFilter 5.1.1 into HEAD 2012-01-30 16:12:02 +00:00
darrenr
9c0e9659f2 Import IPFilter 5.1.1 2012-01-30 16:02:57 +00:00
christos
1ed18fbd3b PR/45881: Chavdar Ivanov: nvi copy command copies empty lines.
Move ENTIRE_LINE definition to common.h and have interested parties use it.
2012-01-27 16:41:22 +00:00
christos
236ed3e463 remove error(1) line. 2012-01-21 19:56:46 +00:00
christos
ab450fcb83 make the previous patch compile. 2012-01-21 19:49:56 +00:00
christos
e36a3ef194 PR/10367: Second part.
Restore lost fix:
http://mail-index.netbsd.org/source-changes/2001/09/09/0043.html

Fix a test condition for EOF.
2012-01-21 19:35:02 +00:00
christos
2a21cd4999 PR/10367:
Restore lost fix:
    http://mail-index.netbsd.org/source-changes/2001/09/09/0042.html

Define ENTIRE_LINE to be -1 instead of 0 since we may want to copy 0 characters.
(and use ENTIRE_LINE instead of 0 where appropriate)

This fixes a bug in the dw command with for example:

<cursor>
a b c

~
~
if you hit dw there, only the empty line would be killed but both the empty
line and the subsequent one would be pasted when asked for with P for example.
2012-01-21 19:32:37 +00:00
christos
f5b6285b2a undo previous, it is wrong. 2012-01-21 19:29:41 +00:00
christos
9e2c491108 PR/10367: Mason Loring Bliss: fix delete word near end of file. Patch
from tnozaki.
2012-01-21 17:12:56 +00:00
drochner
8fd6dadaf8 include <netipsec/ipsec.h> rather than <netinet6/ipsec.h> from userland
where possible, for consistency and compatibility to FreeBSD
(exception: KAME specific statistics gathering in netstat(1) and systat(1))
2012-01-04 16:09:40 +00:00
wiz
d62e358d67 Fix typo, from Abhinav Upadhyay. 2012-01-02 00:35:02 +00:00
tnozaki
10248e78d8 use ARG_CHAR_T instead of CHAR_T for integer promotion. 2011-11-23 19:25:27 +00:00
tnozaki
87c8bc2121 use e_key_t instead of u_int. 2011-11-23 19:18:53 +00:00
tnozaki
5a00661245 don't use WEOF directly, for --disable-widechar. 2011-11-23 15:43:39 +00:00
tnozaki
3392bf8c1a don't use L prefix directly, for --disable-widechar. 2011-11-23 14:14:43 +00:00
tnozaki
b70d1274ae reliability fix, merge libc/regex fix to avoid memory exhaust problem. 2011-11-19 17:45:11 +00:00
tnozaki
0556aba958 use ARG_CHAR_T instead of CHAR_T for integer promotion. 2011-11-16 14:24:43 +00:00
tnozaki
dcbcd554a0 nvi cannot display international character(west european accented chars).
reported by Ian D. Leroux at current-users, thanks a lot!
2011-11-14 13:29:07 +00:00
wiz
f4eb12076c add dircategory/direntry for vi, so texinfo stops complaining 2011-11-13 19:53:53 +00:00
drochner
8e6899dea3 Don't allow '/' characters in the "service" argument to pam_start()
The "service" is blindly appended to config directories ("/etc/pam.d/"),
and if a user can control the "service" it can get PAM to read config
files from any location.
This is not a problem with most software because the "service" is
usually a constant string. The check protects 3rd party software
from being abused.
(CVE-2011-4122)
2011-11-09 20:26:41 +00:00