Commit Graph

81318 Commits

Author SHA1 Message Date
cube
5536c0b46c Fix tyop reported by Yoshito Komatsu. 2006-05-21 11:39:27 +00:00
christos
c03d07d01d Put the __insn_barrier() inside the spinloop for the DIAGNOSTIC case, so
that we have a barrier for the DIAGNOSTIC case too.
2006-05-21 06:17:12 +00:00
christos
ce07c2d219 it is attributes no attribute 2006-05-21 05:49:54 +00:00
christos
2bea415e72 remove gcc4 stuff since it is done in bsd.kmod.mk 2006-05-21 05:43:49 +00:00
christos
c52ff7f9d5 Fixes from David Boggs; in his words:
/sys/net/if_spppvar.h says:

	"Lower layer drivers that are always ready to communicate
	(like hardware HDLC) can shortcut pp_up from pp_tls,
	and pp_down from pp_tlf."

	When I follow those instructions, I get a kernel stack
	overflow as soon as I open the HDLC device.

	Here is the loop:
	 sppp_ioctl calls sppp_lcp_open
	 sppp_lcp_open calls sppp_open_event
	 sppp_open_event calls sppp_lcp_tls
	 sppp_lcp_tls calls pp_tls
	 pp_tls is the SHORTCUT to sppp_lcp_up
	 sppp_lcp_up calls spp_lcp_open
	 ...and around we go until the stack overflows.

	The fix is to reverse the order of the action (tls)
	and the state change (from INITIAL to STARTING) in
	sppp_open_event.

	There is a similar loop during closing:
	 sppp_ioctl calls sppp_lcp_close
	 sppp_lcp_close calls sppp_close_event
	 spp_close_event calls sppp_lcp_tlf
	 sppp_lcp_tlf calls pp_tlf
	 pp_tlf is the SHORTCUT to sppp_lcp_down
	 sppp_lcp_down calls sppp_lcp_close
	 ...and around we go until the stack overflows.

	The fix is to reverse the order of the action (tlf)
	and the state change (from STARTING to INITIAL) in
	sppp_close_event.

	Separately, while I was discovering this, I noticed
	that pp_tlf was being called unconditionally rather
	than first checking to see if it is NULL.  pp_tlf
	is a callout from sppp to the hdlc device driver.
	Elsewhere in sppp, this is always checked for NULL
	before calling it, and the comments in if_spppvar.h
	imply that filling it in is optional.

	From spppvar.h:
	"These functions need to be filled in by the lower layer
	(hardware) drivers if they request notification from the
	PPP layer whether the link is actually required."
	This clearly says that pp_tlf and pp_tls are optional
	and so sppp must check before calling them.
2006-05-21 05:09:13 +00:00
christos
a4d71852e0 Put back -Wno-attribute for now since not all archs have been fixed. 2006-05-21 04:53:23 +00:00
christos
3c22b94a4a fix typo 2006-05-21 04:45:35 +00:00
christos
c9904084fe add -fno-strict-aliasing for gcc4 2006-05-21 04:43:58 +00:00
christos
a75306c3a4 Fix strict aliasing issues and while I am here fix a memory leak on error 2006-05-21 04:30:03 +00:00
dan
58c89e46e0 initialise a few "off"s to appease gcc4
these only turned up with -O2 and/or -march=nocona, not with default flags
2006-05-21 01:19:25 +00:00
christos
589a4be805 Add -Wno-pointer-sign for gcc4 2006-05-20 22:22:04 +00:00
christos
57f1eb7d75 XXX: GCC uninitialized 2006-05-20 22:15:20 +00:00
gdt
42ecd6e67d Enable ugensa. 2006-05-20 22:03:56 +00:00
mrg
19ad9e5482 change some variable types from int to size_t, since that's what libsa
dv_strategy() wants for the 6th argument.
2006-05-20 20:38:39 +00:00
mrg
2d245c626f change some char to u_char to match other variables and functions. 2006-05-20 20:37:15 +00:00
christos
d05d5214fe Add another fixup entry Arthur Dimitrelis 2006-05-20 20:32:16 +00:00
mrg
696ab05f50 add (char *) cast to quieten GCC. 2006-05-20 19:40:46 +00:00
elad
b3e7e1b010 Better implementation of PaX MPROTECT, after looking some more into the
code and not trying to use temporary solutions.

Lots of comments and help from YAMAMOTO Takashi, also thanks to the PaX
author for being quick to recognize that something fishy's going on. :)

Hook up in mmap/vmcmd rather than (ugh!) uvm_map_protect().

Next time I suggest to commit a temporary solution just revoke my
commit bit.
2006-05-20 15:45:37 +00:00
rpaulo
d330ad3005 The check for LMC cards should return NULL, not 0.
No functional change.
2006-05-20 14:23:07 +00:00
uwe
64f867a645 Redo previous fix properly. Original code had a typo caused by very similar
function and variable names.  We need to protect tag comparison b/c we don't
want to perform it against an uninitialized tag.
2006-05-20 12:29:57 +00:00
yamt
0f0124d1a9 remove NOLOCKF and use normal NULL instead. 2006-05-20 12:20:55 +00:00
yamt
b22546608e remove an debug printf slipped into the previous. 2006-05-20 12:19:30 +00:00
yamt
a6518311cc fix F_SETLKW deadlock detection, which has been broken since lwpify.
although this doesn't work for processes with multiple lwps, it's better
than not working at all.
2006-05-20 12:06:20 +00:00
yamt
cecc761849 make lockfpool static. 2006-05-20 12:04:21 +00:00
yamt
408b7c1e5c move lockf implementation details from sys/lockf.h to kern/vfs_lockf.c. 2006-05-20 12:02:47 +00:00
mrg
a4efc02595 in code that looks like:
igsfb_pci_is_console(pci_chipset_tag_t pc, pcitag_t tag)
	{
		return igsfb_pci_is_console && (tag == igsfb_pci_constag);
	}

delete "igsfb_pci_is_console &&" as the address of igsfb_pci_is_console
is always true.  thanks gcc4.
2006-05-20 10:31:29 +00:00
yamt
fa971123c3 revive copyright notice for the code derived from libc/locale/utf2.c.
i've asked jdolecek@ about this, but got no reply.
2006-05-20 08:28:27 +00:00
yamt
16dbcd1c54 mountnfs: reject wrongly-sized filehandle for nfsv2. 2006-05-20 07:42:02 +00:00
yamt
eb04c18e83 nqsrv_getlease: call nfs_init() to fix NFSSERVER && !NFS case. 2006-05-20 07:40:56 +00:00
mrg
afda9ed915 initialise pos.x and pos.y to appease GCC4. 2006-05-20 07:09:08 +00:00
mrg
4d86687f13 when casting to assign to a u_char pointer, use (u_char *) not (char *). 2006-05-20 07:08:26 +00:00
mrg
433f408f95 struct filesystem is now struct fs_ops, since i don't know when. 2006-05-20 07:07:40 +00:00
tsutsui
21d08156dc Change range of PCI I/O space for pci_configure_bus(9)
so that viaide(4) works with PCI fixup (not enabled yet).
2006-05-20 03:38:03 +00:00
perseant
0e0bb04d7a Fix a bug in which FINFOs were written with a version number of zero.
Add assertions and add this to the DEBUG fip test in lfs_writeseg.
2006-05-20 01:10:18 +00:00
christos
a58b86d582 Don't use -Wno-attributes for gcc4. All the code has been fixed and it will
just hide bugs.
2006-05-20 00:47:27 +00:00
tsutsui
7ac8789a63 Use cobalt_id to probe com at mainbus. 2006-05-19 19:33:56 +00:00
yamt
c876210968 UVM_MAPFLAG: add missing parens. 2006-05-19 15:08:14 +00:00
tsutsui
5bc5ba3bc0 Use macro defined in <dev/ic/i8259reg.h>. Same binaries are generated. 2006-05-19 13:59:50 +00:00
yamt
b245701ca1 - fix compilation problem for !NFSSERVER && NFS.
pointed by Tom Spindler on source-changes@.
- make nfs_srvdesc_pool static.
2006-05-19 13:53:11 +00:00
markd
d6a59139b0 Add Intel 82801GBM/GHM Serial ATA Controller. 2006-05-19 01:27:00 +00:00
markd
99ff72f2ed regen 2006-05-19 01:24:46 +00:00
markd
95090b8031 Add some devices found on a Dell Latitude D620. 2006-05-19 01:22:58 +00:00
perseant
6e53d31f5c Break out the finfo array manipulation code into two new functions,
lfs_acquire_finfo() and lfs_release_finfo().  Add a debugging check
for zero-length finfo arrays in the segment summary to avoid future
regressions.
2006-05-18 23:15:09 +00:00
imp
4bacc0092a The Intel sight has changed slightly, so tweak wording on how to get the
intel documentation necessary for the ethernet driver.
2006-05-18 20:13:14 +00:00
bouyer
38038ac6c0 Add yet another broken 160Gb seagate drive. I though we had found all of
them ... reported by Damian Lubosch on current-users.
2006-05-18 19:42:09 +00:00
mrg
f599351ef6 quieten GCC uninitialise variable warnings. 2006-05-18 18:45:48 +00:00
christos
747c268e1c Add __weak_reference macro in a way that it works with both gcc < 4 and
gcc == 4. Suggested by dsl.
2006-05-18 17:55:38 +00:00
elad
56a6a2b09b don't break lkms; pointed out by hannken@ and he@, thanks! 2006-05-18 17:35:49 +00:00
elad
b6894eda07 CTLFLAG_IMMEDIATE doesn't do what I thought it did. from yamt@, thanks! 2006-05-18 17:33:18 +00:00
tsutsui
373ffecde6 Add bus_space_*_stream_N() macros, which are identical with non-stream ops. 2006-05-18 15:37:05 +00:00