better error messages if the user tries to use symbolic names such
as "echo" and "echorep" in "ipv6-icmp ... icmp-type ..." rules.
Consider the following rules:
# cat /etc/ipf6.conf
pass in quick proto ipv6-icmp from any to any icmp-type 128
pass in quick proto ipv6-icmp from any to any icmp-type echo
Use of symbolic names give now the following error:
# ipf -Fa -6f /etc/ipf6.conf
2: Unknown ICMPv6 type (echo) specified (use numeric value instead)
The first rule with numeric value will work as expected:
# ipfstat -6hi
0 pass in quick proto ipv6-icmp from any to any icmp-type 128
NOTE: You MUST use numerical values for ICMPv6 types. See
/sys/netinet/icmp6.h for available codes!
ROOT localhost:~> /etc/rc.d/ipfilter reload
Reloading ipfilter rules.
22: Invalid icmp-type (echo) specified
With version 1.7 everything works just fine:
ROOT localhost:~> /etc/rc.d/ipfilter reload
Reloading ipfilter rules.
Set 1 now inactive
this fix ipfstat reported:
0 pass in quick proto ipv6-icmp from any to any
while after this fix:
0 pass in quick proto ipv6-icmp from any to any icmp-type 8
This was just a display bug, the rule worked as expected.
by a memcpy, similar to the patch suggested by jarle@uninett.no in PR 15112.
I'm not sure if the ioctl code should be fixed to deliver this pointer
properly aligned, but this change should not cause any problem and it is
safer this way.
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).
Improved by comments from enami and christos -- thanks!
Heimdal/krb4/KAME changes already fed back, rest to follow.
Inspired by, but not not based on, OpenBSD.
be used with the new clockctl device which enable clock setting by non root
users on behalf of the /dev/clockctl write rights.
This code have not been commited yet to the main ntp tree.
revision 1.3
date: 1999/02/22 02:37:27; author: mrg; state: Exp; lines: +19 -1
if we are chrooting, write a symlink for the pid file so that ndc, etc,
continue to work as normal. this allows named to run in a chroot jail
with zero loss of functionality.
