Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
148,141 Commits 606 Branches 0 Tags 3.1 GiB
c14d23ac86
Commit Graph

1209 Commits

Author SHA1 Message Date
christos
46940789af Bye bye cdk. Moved via repository copy to othersrc/dist/cdk 2006-03-31 17:40:18 +00:00
christos
995a3df3f0 PR/33174: Wolfgang Stukenbrock: dhcpd fails to deliver hostnames for dynamic 
ranges because it is using the wrong universe in the host lookup.
 2006-03-31 17:28:50 +00:00
christos
1d00887f5d Insert coverity annotations [experimental; I don't know if those work 
at the variable declaration level, but we'll see]
 2006-03-29 16:40:50 +00:00
christos
f252e17155 Coverity CID 2486: Fix uninitialized variable 2006-03-29 16:09:53 +00:00
christos
85e2f53c41 Coverity CID 2786: Fix memory leak. 2006-03-29 15:44:19 +00:00
kardel
610b4c0dee dead code: removed (Coverity NetBSD CID 611) 2006-03-29 07:30:30 +00:00
kardel
d6c06e8308 fix as discussed in NTP Bug 584, Coverity NetBSD CID 1510 2006-03-29 07:19:34 +00:00
agc
2171876d1d More portability fixes, mainly for Solaris 9. 2006-03-28 20:03:30 +00:00
agc
f02decf866 Add changes to make the NetBSD iSCSI target compile and run on Solaris 9 
Ultrasparc.
 2006-03-27 22:26:28 +00:00
tron
7a28db2210 Fix build problem caused by last commit. 2006-03-27 10:02:37 +00:00
agc
6e1f35f92e minor cleanup in preparation for porting the NetBSD iSCSI target to Solaris 9. 2006-03-26 23:34:06 +00:00
christos
d20b033359 Coverity CID 1362: Allocate one more element to appease coverity. 2006-03-26 22:08:59 +00:00
christos
f3acb4a69b Coverity CID 1757: Don't leak memory 2006-03-26 22:04:14 +00:00
christos
4820f3f28c Coverity CID 1758: Unconfuse coverity about memory leak. 2006-03-26 22:02:59 +00:00
christos
714883262b Coverity CID 2038 2006-03-26 22:00:23 +00:00
christos
b1987e98f0 Coverity CID 2039: Plug memory leak. 2006-03-26 21:57:14 +00:00
christos
2b5f8cbcc0 Coverity CID 2042: Plug memory leak 2006-03-26 21:53:55 +00:00
christos
59ffb64e52 Coverity CID 2043: Don't leak memory 2006-03-26 21:49:01 +00:00
christos
d06f1825d5 Coverity CID 2044: Don't leak memory. 2006-03-26 21:46:25 +00:00
christos
e4dcd1072c Coverity CID 2399: Move strcpy lower, where it is actually going to be 
used, inside the test of directory != NULL.
 2006-03-26 21:44:05 +00:00
christos
34525befc6 Coverity CID 972: Someone confused && and || again. 2006-03-26 21:38:43 +00:00
he
ce943c094b Fix previous correctly. The "quiet" variable was not local. 
Instead, the problem was declarations which followed a non-declaration
statement, which gcc 2.95 doesn't like, so reshuffle the order.
 2006-03-25 21:56:29 +00:00
peter
a7819c4f5c Coverity CID 2783: Fix dereference of a freed pointer. 2006-03-25 16:06:04 +00:00
rpaulo
c43f7d959b PR 13604: detect and print correct information for 4.4BSD/NetBSD NFS 
filehandles.
The heuristic may or may not be wrong, but no one replied in the
tcpdump-workers mailing list.
Extraction of the fsid information contributed by Chuck Silvers.

Discussed with Chuck Silvers.
 2006-03-25 11:43:53 +00:00
he
9fb6f0e876 Don't default the type of a local variable. Fixes build for vax. 2006-03-23 19:25:09 +00:00
agc
e1d9f9cea5 First stab at implementing INQUIRY for Vital Product Data, aka Page 83 
information in the Solaris initiator, with information taken from
SPC3, T10/1416-D Revision 23, from www.t10.org.

This is untested, work-in-progress.
 2006-03-23 00:01:48 +00:00
christos
8d95e8aad0 Coverity CID 991: Remove useless test. 2006-03-22 04:34:49 +00:00
christos
af542fc05c Coverity CID 563: Kill SUNOS3 case; it is dead code. 2006-03-22 04:30:28 +00:00
christos
ded5be2fff Coverity CID 2746: Remove useless test. 2006-03-22 04:11:15 +00:00
christos
1174f5b4bb Coverity CID 2060: Fix memory leak. 2006-03-22 02:29:42 +00:00
agc
86caa230d8 Actually do something with the SYNC_CACHE command - use fsync_range(2) if 
it's available, falling back to fsync(2) if it's not. Add the necessary
glue to the autoconf scripts.
 2006-03-21 22:56:55 +00:00
agc
cbf5d4f8f5 Abstract out some common code, and place it in the utilities source. 
Get rid of some #ifdef __KERNEL__ abstractions - they're not needed.
 2006-03-21 21:03:14 +00:00
christos
b2f6added5 Coverity CID 577: remove dead code; minburst can never be 0 at this point. 2006-03-21 20:49:54 +00:00
christos
e46022bb52 Coverity CID 1514: Don't access static array beyond the end of it. 
In this case PFTM_MAX == 20 and sizeof(pf_timeouts) / sizeof(pf_timeouts[0])
== 21, using a loop with the size of the array and checking for reaching the
end of the loop via j == PFTM_MAX does not work. Change the loop to use
PFTM_MAX as the upper bound and add an assertion in the code to make sure
that pf_timeouts is large enough. Finally remove last NULL element of the
array so that the array has 20 elements again.
 2006-03-21 20:47:27 +00:00
christos
1a21d9be9f Coverity CID 2057: Don't forget to free tcpopts when you are done. 2006-03-21 20:31:56 +00:00
christos
eca1f0e01b Coverity CID 2491: Fix uninitialized reference. 2006-03-21 20:27:59 +00:00
christos
a674b513c2 Coverity CID 2738: When a symbol with a NULL name is passed, convert it to 
the empty symbol.
 2006-03-21 16:59:09 +00:00
kardel
a1cdcab3c8 buffer overrun: backport fix from NTP project (Coverity NetBSD Scan 8: CID 1509) 2006-03-21 11:12:13 +00:00
kardel
15dc7197ee null deref: fix another case of incomplete list handling (Coverity NetBSD Scan 8: CID 986) 2006-03-21 10:28:25 +00:00
agc
a055fd96f7 Incorporate changes from F. Senault, modified by myself to use 
autoconf glue, to make the NetBSD iSCSI target build and run on
FreeBSD.
 2006-03-20 20:45:07 +00:00
agc
2010c5954a Clean up, mostly to autoconf glue, to check whether syslog(3) exists or not. 2006-03-20 20:25:42 +00:00
christos
6dccf87632 Avoid overflowing static array which c == HAT. 2006-03-19 17:41:55 +00:00
kardel
dbefff2ee4 error handling: check success of open(2) - bail out early (Coverity CID 1282 NetBSD Scan 5) 2006-03-19 07:20:30 +00:00
kardel
24781071d1 null deref: complete linked list handling beginng condition (Coverity CID 986) 2006-03-19 07:02:47 +00:00
christos
57e31ffb5c Coverity CID 1867: Fix memory leak. 2006-03-18 22:39:40 +00:00
christos
a1f97364cb Coverity CID 862: Avoid NULL deref. 2006-03-18 22:37:16 +00:00
christos
73a77c6016 Coverity CID 1476: Add assertion before index operation. 2006-03-18 22:35:42 +00:00
christos
7f112146cb Coverity CID 866: Fix possible NULL deref. 2006-03-18 21:15:50 +00:00
christos
58deb05d13 Coverity CID 865: Fix possible NULL deref 2006-03-18 21:14:09 +00:00
christos
760ba920f3 Coverity CID 867: Fix possible NULL deref. 2006-03-18 21:11:43 +00:00
christos
b2229dcdbc Coverity CID 955: Fix possible NULL deref. 2006-03-18 21:10:12 +00:00
christos
33c12e6be9 Coverity CID 956: Possible NULL pointer deref. 2006-03-18 21:07:47 +00:00
christos
0a7d87f083 Coverity CID 957: Prevent NULL pointer deref. 2006-03-18 21:05:10 +00:00
christos
d9e5b13b10 Coverity CID 2033: Fix memory leak. 2006-03-18 20:48:42 +00:00
christos
6b81e42601 Coverity CID 2358: Although mp2 cannot be NULL here, checking it below for 
NULL is confusing. Check in both places.
 2006-03-18 20:46:23 +00:00
christos
973debfe6f Coverity CID 2359: Possible NULL deref. 2006-03-18 20:43:48 +00:00
christos
f3d47984b8 Coverity CID 2389: Remove extraneous check 2006-03-18 20:40:53 +00:00
christos
7908a85339 Coverity CID 2390: Wrong test; p cannot be NULL. 2006-03-18 20:38:01 +00:00
christos
06bdf1a1e0 Coverity CID 2485: Possible uninitialized variable use. 2006-03-18 20:33:34 +00:00
dsl
55d48ecf23 Remove the unnecessary 'if (found)' to stop Coverty bleating (CID 864).. 2006-03-18 18:05:13 +00:00
kardel
063cb750db mem leak: unreachable code prevented freeing of allocated memory 
(Coverity CID 612 NetBSD Scan 5)
 2006-03-18 15:22:34 +00:00
kardel
012eaf5162 null deref: avoid 0 deref (Coverity CID 987 NetBSD Scan 5) 2006-03-18 14:33:20 +00:00
kardel
36ab9cfe6b buffer bounds: one beyond buffer (Coverity CID 1490 NetBSD Scan 5) 2006-03-18 14:25:17 +00:00
kardel
a07906a5a8 buffer bounds: buffer full condition wrong for bounds check (Coverity CID 1508 NetBSD Scan 5) 2006-03-18 14:18:59 +00:00
kardel
630d3f115c buffer bounds: correct > - >= error for bounds check (Coverity CID 1511 NetBSD Scan 5) 2006-03-18 14:08:29 +00:00
kardel
99c0e2540c buffer bounds: clamp index for epobuf to buffer bounds (Coverity CID 1512 NetBSD Scan 5) 2006-03-18 14:02:13 +00:00
kardel
80b13f6f4e mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5) 2006-03-18 13:44:15 +00:00
kardel
ee0722e2b9 avoid close(-1): don't attempt to cleanup INVALID_SOCKET ( ==-1 ) fd's - would lead to close(-1) and FD_CLR((u_int)-1(!), ...) (Coverity CID 1281 NetBSD Scan 5) 2006-03-18 13:13:25 +00:00
kardel
9429ea9653 null deref: backport current ntp code to fix (Coverity CID 759) 2006-03-18 12:40:48 +00:00
dan
dbd04f2b27 free buf in error path; CID 2061 2006-03-18 12:15:05 +00:00
kardel
58ad32062f Coverity NetBSD scan CID 2055: fallout fix return/fclose -> fclose/return 2006-03-18 09:28:50 +00:00
kardel
e13d171a8e resource leak (fd/mem): fclose() streams on error (Coverity NetBSD scan CID 2055) 2006-03-18 09:26:08 +00:00
kardel
589ea6e802 resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054) 2006-03-18 08:57:25 +00:00
kardel
862343544d resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied ) 2006-03-18 08:09:03 +00:00
christos
f5b7b11e49 Coverity CID 346: Double free. 2006-03-18 04:41:57 +00:00
christos
a7e5a4a743 Coverity CID 347: remove dead code. 2006-03-18 04:39:50 +00:00
christos
dee21a2f06 Coverity CID 586: Remove dead code. 2006-03-18 04:34:41 +00:00
elad
6dceae8a70 Ditch the ugly hardcoded value and do proper bounds checking. 
Addresses CID 1417, found by Coverity.

Hi Darren! is this code maintained?
 2006-03-18 04:12:52 +00:00
christos
06b02ffc92 Coverity CID 1284: Handle -1 return from open(2) 2006-03-18 03:49:37 +00:00
christos
f5b784887f Coverity CID 1462: Static buffer overrun; off by 2. 2006-03-18 03:45:34 +00:00
christos
16fbed8bd1 Coverity CID 1616: Memory leak. 2006-03-18 03:43:13 +00:00
christos
fd8155f293 Coverity CID 1617: Memory leak 2006-03-18 03:39:57 +00:00
christos
67c67fc5bf Coverity CID 2059: Memory leak. 2006-03-18 03:35:41 +00:00
elad
77e1c3c1fc Fix off-by-one, found by Coverity. CID 1466. 2006-03-18 02:35:47 +00:00
elad
3af85b1067 Fix off-by-one found by Coverity, CID 1516. 2006-03-18 02:15:03 +00:00
kardel
9bccbf4462 Coverity fixes: 
CID
687	missing block
988	null pointer deref on shutdown (on open failure - introduced by
	change of contract in ntp_refclock.c)
989	null pointer for private data (could not happen - safeguard anyway)
1513	off by one
2410	misplaced null pointer test
 2006-03-18 00:30:30 +00:00
peter
11f7fb17d4 Fix file descriptor leaks. 
Coverity CID 1681.
 2006-03-17 15:50:44 +00:00
chris
d79b92051d Only dereference b after it has been NULL checked. 
Coverity CID 2398.
 2006-03-17 02:52:56 +00:00
agc
a4c7ca1aeb Get rid of c99isms in the form of variable number of args to CPP macros. 
This should slim down the resulting binaries a fair bit as well.
 2006-03-12 18:47:27 +00:00
agc
7acf73bedf Thanks to Thomas for the prod - update usage message to include all 
supported options.
 2006-03-11 12:09:36 +00:00
wiz
fb778aad1c Compact single letter options in SYNOPSIS. Sort option descriptions. 2006-03-11 11:58:53 +00:00
wiz
674cf041a7 Sort options as in man page. 2006-03-11 11:58:22 +00:00
wiz
93ba37c7ea Add -V to SYNOPSIS; serial comma; sort option descriptions. 2006-03-11 09:21:03 +00:00
he
56dbe819ca If compiling for NetBSD/vax, define boolean_t here before including 
<sys/file.h> with _KERNEL defined.  Also add a 3-line XXX comment
explaining some of why this is done.
Should fix the build problem documented in PR#32907.
Will be documented in doc/HACKS shortly.
Fix discussed with thorpej.
 2006-03-07 18:18:06 +00:00
wiz
e2a71c2aab 'advertisment' -> 'advertisement', from leonardo chiquitto filho 
via jmc@openbsd.
 2006-03-07 18:15:28 +00:00
agc
d4397af4d8 One more off the TODO list, although I hadn't realised it was going to be 
as painful as it was.

Teach GNU autoconf to recognise socklen_t, and use it in the code.
 2006-03-06 20:52:32 +00:00
agc
32306cea7e I have a nasty feeling it's time to sell all my guitars: 
Add some very crude hacks which allow the iscsi-target to work with IPv6:

Mar  5 23:43:45 sys3 iscsi-target: > Discovery login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: < Discovery logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:45 sys3 iscsi-target: > Normal login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar  5 23:43:48 sys3 iscsi-target: < Normal logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc

These have still to be cleaned up, but this will happen over the next
few days.

Update the TODO list to reflect the current state.
 2006-03-05 23:50:46 +00:00
agc
ff69df84c5 Add IPv6 awareness. 2006-03-04 22:06:26 +00:00
agc
7717b41470 Include version number, passed down from GNU autoconf. 
Add a -V argument to iscsi-target (and iscsi-harness), which will print
the utility name, version number, and destination for all bug reports,
and then exit the utility.

Modify the documentation accordingly.

Re-run autoconf and autoheader to pick up the necessary autoconf glue.
 2006-03-04 21:56:11 +00:00
agc
a70556aee7 Sync example file with reality - this has no effect on NetBSD, since 
configuration files are held in src/etc/iscsi, not src/dist/iscsi.
 2006-03-04 21:53:16 +00:00
agc
132771c158 Remove a file that's unnecessary. 2006-03-04 21:52:00 +00:00
wiz
64506871c4 Drop trailing whitespace. 2006-03-02 22:23:51 +00:00
christos
f696f0c430 Handle slip statistics too. 2006-03-02 17:32:28 +00:00
drochner
8c32a44b4d minor constification, good for WARNS=3 now 2006-02-27 16:00:20 +00:00
drochner
ed755469dd NetBSD adaption: 
-minor cleanup of installed headers
-const pcap_strerror() for consistency
 2006-02-27 15:57:17 +00:00
drochner
f5b56adedc minor constification, good for WARNS=3 now 2006-02-27 15:55:30 +00:00
drochner
431104fb34 avoid shadowing globals, for WARNS=2 2006-02-27 15:53:24 +00:00
drochner
a7dfc7f00f pull in from NetBSD's libpcap: use cloning bpf device on NetBSD 2006-02-27 15:51:38 +00:00
drochner
6dab7ae580 pull in from NetBSD's libpcap: import header for __NetBSD_Version__ 2006-02-27 15:50:09 +00:00
drochner
3c909ce59d import original libpcap-0.9.4 from tcpdump.org, 
with unrelated subdirs omitted
 2006-02-27 15:45:37 +00:00
dyoung
0f0c24e0c7 Print the "bad-fcs" radiotap flag. 2006-02-26 03:04:28 +00:00
dyoung
125170229e Reduce diffs between NetBSD's authoritative radiotap header file 
and TCPDump's.
 2006-02-26 03:04:03 +00:00
wiz
b82f53ae21 Fix typo in comment. 2006-02-25 01:58:39 +00:00
wiz
9096fdfaac Remove superfluous comma. 2006-02-24 21:01:19 +00:00
agc
b95774e6d4 Implement SCSI commands: 
0x1b Load/Unload Sequential
0x4d Log Sense
0x5e (unknown for just now)
0x35 Synchronise cache

as no ops for the present time - reported on current-users by Chavdar
Ivanov as being generated by the Solaris 10 initiator.
 2006-02-24 20:47:30 +00:00
he
127058acaa Include <sys/param.h> explicitly relatively early, so that we pick 
up the definition of MAX earlier, and avoid a redefinition which
GCC 2 isn't very fond of.  Fixes build problem for vax.
 2006-02-22 08:56:46 +00:00
agc
9b7f93748a Add an initial version of the iscsiconfig utility - initially only 
discovery functionality is supported.
 2006-02-20 09:00:05 +00:00
agc
f06c81ed28 Further cleanup. 
Add an initiator_discover() function, and start to break up the monolithic
discovery function that's currently used.
 2006-02-20 08:59:07 +00:00
agc
c9ecbabb62 Clean up, get rid of unused code. 
Add my copyright for the extent, device and target conf file parsing and
manipulation code.
 2006-02-20 08:57:32 +00:00
agc
b8ca8cc0de Clean up a bit - only print the huge stuff if we're debugging. 2006-02-20 08:56:06 +00:00
agc
c40774dc2e We don't ever run the tests in the kernel, so get rid of a whole lot of 
"#ifdef __KERNEL__"
 2006-02-20 08:55:06 +00:00
agc
56abe96063 By popular request, modify the IQN to: 
"iqn.1994-04.org.netbsd.iscsi-target"
 2006-02-16 23:16:05 +00:00
agc
b37fe4757b Update the targets(5) manual page to reflect the new syntax. 2006-02-16 19:29:28 +00:00
agc
ec095879d4 Introduce a backwards compatible change to the targets configuration 
file.

The new file specifies whether targets should be presented as readonly
or read-write.

If a target is marked as read-only, don't allow any writes to be made
to it.

Also, add syntax recognition of "any" and "all" in the netmask recognition
code.
 2006-02-16 19:19:38 +00:00
agc
14ba470694 when looking for the target name supplied by the initiator during full-phase 
login, break out of the loop immediately a match is found.

only syslog information if it's available
 2006-02-15 10:29:18 +00:00
agc
c963d486fc Present multiple targets properly 2006-02-14 20:08:37 +00:00
pooka
f8ed783b2b some new signatures provided by Sergey Svishchev in private email 2006-02-13 22:57:55 +00:00
agc
e1b73336e6 Discovery masking has been implemented 2006-02-12 15:53:34 +00:00
agc
9a2c5d1a2e Sync the manual page with reality after adding the netmask functionality 2006-02-12 15:48:17 +00:00
agc
ba1e98d16d Check that the initiator address is allowed to discover targets. 
Log a LOG_INFO error if an initiator attempts to discover targets it
shouldn't be.
 2006-02-12 15:36:54 +00:00
agc
890f7ccd9f minor cleanup - no functional change. 2006-02-12 15:35:00 +00:00
agc
a31b31cf51 keep a reference to the device target information in the globals structure 2006-02-12 15:34:29 +00:00
agc
e48ae9ed1d use a proper prototype for allow_netmask 2006-02-12 15:33:26 +00:00
agc
cfc7ed417d Add functionality for matching netmasks with addresses 2006-02-12 14:49:40 +00:00
agc
a0d5cb1f08 make this conform to latest sources 2006-02-12 14:48:49 +00:00
agc
a63dd2456e we moved the port number back to the command line from the targets file some 
time ago, reflect that in the manual page.
 2006-02-09 23:36:48 +00:00
agc
0a7d1d9211 Break out the files relating to storage extents, devices and targets into 
a separate source file.
 2006-02-09 23:08:31 +00:00
agc
3d80f87df2 Add a section explaining about the use of CHAP authentication in the test 
harness.
 2006-02-09 16:40:49 +00:00
agc
f8e2bf3e6d Get rid of parts not needed for the iSCSI target and test harness. 2006-02-09 16:39:56 +00:00
he
0dc5f4be3b Print __uint64_t variables with PRIu64, not with lld. 
Fixes build on alpha and probably other LP64 platforms.
 2006-02-09 15:11:40 +00:00
agc
9d3ba7cac4 Use the ISCSI_NTOHL macro in place of a straight ntohl(), so that this 
can be abstracted away per platform.
 2006-02-09 08:55:00 +00:00
mrg
5f90d3d8b1 - use <inttypes.h> and PRIu64 in many places. 
- don't try to use the return value of NTOHL().

fixes sparc64 build problems.
 2006-02-09 08:46:43 +00:00
agc
6a86b29b9d Fix some wordos in the FAQ. 2006-02-08 21:42:45 +00:00
agc
7cfbac6bcd Remove a file committed in error. 2006-02-08 20:43:13 +00:00
agc
33645f4ad2 Import the distribution files for the iSCSI target, developed from the 
original Intel code (BSD-licensed) in othersrc, by myself.

This provides an iSCSI target implementation in userland, as well as a
test harness which also runs in userland.

The iSCSI target has been tested with version 1.06 of the Microsoft
initiator, as well as with its own test harness.
 2006-02-08 18:56:14 +00:00
christos
a58881f52e resolve conflicts 2006-02-05 16:28:55 +00:00
christos
25010febb3 Import am-utils; changes in ChangeLog. 
Summary:
  - bound string operations
  - better detection of filesystem names
  - pawd call now gets the resolved directory in the rpc

All our local changes have been submitted and incorporated.
 2006-02-05 16:12:04 +00:00
xtraeme
0511c26dfa openpam_dynamic(): add missing '/' between OPENPAM_MODULES_DIR and 
the pam's name module, otherwise it will try to load the module as:

"/usr/lib/security<pam_module>"

Before christos' update we were using PAM_SOPREFIX = "/usr/lib/security/"
with the last '/', now we aren't. So be SAFE and add it to avoid
future problems.
 2006-02-05 05:39:49 +00:00
christos
aad78462b6 resolve conflicts 2006-02-05 02:37:45 +00:00
christos
70d3347b2d Import figwort: for changes read the HISTORY file. 2006-02-05 02:32:33 +00:00