Commit Graph

8592 Commits

Author SHA1 Message Date
tls b8dc57b8d9 If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ...  exit to errx.  Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).
2006-04-02 06:11:45 +00:00
tls 82222cd3ac Default to no parity instead of even parity. OpenBSD made this change
long ago, and I think it makes sense.
2006-04-02 04:28:38 +00:00
tls 685d2e5048 Default the "raisechar" value (for the insane old case-mapping) to NULL.
As the same change in the OpenBSD tree says, "if you are crazy enough
to want it, then it can be turned on in /etc/remote."
2006-04-02 04:25:36 +00:00
christos df58c5cd15 Coverity CID 1660: Plug memory leaks. 2006-04-02 04:17:08 +00:00
tls 8139858166 Default baud rate to 9600 (was 1200) to match Taylor cu. 2006-04-02 04:10:54 +00:00
tls 7d1bef10da Add the rest of the speeds listed in termios.h. This is not, perhaps, as
sensible as the way OpenBSD supports arbitrary speeds; but we hardly add
new speeds often and this change is a lot less invasive.
2006-04-02 04:02:00 +00:00
christos ceb6edafa6 Coverity CID 922: Fix check against NULL. 2006-04-02 03:50:38 +00:00
christos 472d6fbe72 Coverity CID 878: Remove impossible tests against NULL pointers. 2006-04-02 03:47:26 +00:00
christos 999d9f8f32 Coverity CID 1181: Protect access against NULL. 2006-04-02 03:40:06 +00:00
christos 002be29d1a Coverity CID 2290: Fix memory leak. 2006-04-02 03:33:55 +00:00
christos 095e4da292 Coverity CID 1204: Prevent negative index. 2006-04-02 03:29:17 +00:00
christos 6e2787485e Coverity CID 2336: Fix memory leak. 2006-04-02 03:19:34 +00:00
tls 40bdc77642 Change manual page (as OpenBSD did) to reflect the actual arrangement of
file descriptors with ~C, instead of some weird ancient arrangement.

Document ~+ as a synonym for ~C.
2006-04-02 03:15:02 +00:00
tls b389579aca Add "~+" as a synonym for "~C" for Taylor cu compatibility. 2006-04-02 03:10:54 +00:00
christos 8533275dab Remove bogus debugging code I accidentally committed. 2006-04-02 00:15:53 +00:00
christos 46c0b8e98a PR/26804: Jason Thorpe: Make PT_DUMPCORE require the process to be PT_ATTACH'ed
first so that it is stopped and there are no races.
2006-04-01 22:34:00 +00:00
jmmv 43e0f4ee96 Fix cross-reference to grep(1). 2006-04-01 16:12:23 +00:00
cherry fb4fa95282 xlint for ia64 2006-04-01 09:39:47 +00:00
rtr 75de03412e cast line_len to (int) to avoid warn. 2006-04-01 06:36:58 +00:00
rtr df14d9f34e revert previous to previous as it was correct 2006-04-01 06:31:43 +00:00
rtr f738eedb64 change printf format from "%.*s" to "%.8s"
have to conclude it was what was actually intended in the previous change
2006-04-01 06:26:31 +00:00
christos e052a053e4 Add some coverity allocation comments, and change the way the allocator
functions work. When they allocate storage that needs to be freed, instead
of setting a boolean, set the pointer to be freed. Plug some more memory
leaks found by inspection.
2006-03-31 21:58:08 +00:00
dsl 33369a0245 There is no need to count jobs and job tokens.
If we don't create the job pipe, use the '-j n' option to limit the number
of tokens we will remove from the pipe.
2006-03-31 21:05:34 +00:00
christos ec5cc02622 Coverity CID 544: Fix memory leak. 2006-03-31 20:30:46 +00:00
dsl ec40cf92c2 Rewrite parallel() so that it uses fgetln() instead of fgets() so that
horrid nasty things don't happen when the input lines are the same size
as the buffer.
Simplify by using an array of 'FILE *' instead of a linked list so that
is possible to appease coverty (SID:1598) by freeing the memory.
Also fclose() the input lines when they are consumed.
Code still modifies optarg strings....
2006-03-31 18:59:52 +00:00
dsl 0720992d8c KNF prior to fixing all the buffer overruns....
Coverty highlighted something else that doesn't matter!
2006-03-31 17:20:07 +00:00
dsl 3db763ccc3 MCDelSet() contains an infinite loop!
I suspect it has never, ever, ever been asked to delete anything that exists.
Also neither it, nor MCDelMsg() below free() the set and msg structures.
Found by Coverty SID:54
2006-03-30 20:32:10 +00:00
dsl e4573e12e3 Simplify the way the end of a singly linked list is followed (for adding
items) so it is more obvious that we aren't going to indirect through
a null pointer.
Fixes coverty SID:101
2006-03-30 19:53:58 +00:00
dsl 4c18b91e3e If fgetln() returns a buffer that isn't terminated by \n, free the temporary
buffer inside the loop.  Fixes coverty CID:1674.
(This should only happen at EOF, so the loop SHOULD terminate.)
While here always output a newline at the end of the input data even when
the last (unterminated) line doesn't contain a separator.
2006-03-30 19:17:44 +00:00
rpaulo a0713f21de ANSIfy. de-P. 2006-03-29 15:40:49 +00:00
yamt 01ef02441c pull the following change from OpenBSD
and bump date of the manpage.

    date: 2003/09/20 18:15:32;  author: millert;  state: Exp;  lines: +4 -2
    Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
    Based on PR 3411 from Matthew Gream
    Also document "tandem" variable (XON/XOFF) in tip man page.
2006-03-29 12:37:59 +00:00
cube c002406624 Fix a broken conditional that confused coverity. It cannot happen, anyway.
CID 178.
2006-03-29 09:16:36 +00:00
ginsbach a8cd0ffcee - Change where variable substitution is done when processing traditional
include statements so that if a variable expands to more than one file
  name make will "do the right thing".
- Add additional debug print

Reviewed by christos.
2006-03-28 17:41:35 +00:00
joerg 3e3d6f89bd Query kernel for maximum argument size instead of using ARG_MAX. 2006-03-28 14:27:41 +00:00
christos 3b6811d33b PR/33123: Murray Armfield: standards compliance & glob.h
Certain fields in glob.h need to be size_t; fix this and version glob(3).
    http://www.opengroup.org/onlinepubs/000095399/basedefs/glob.h.html
2006-03-26 18:11:22 +00:00
hubertf 517eb6559a Remove unused variable 'salt'
Found by code inspection in one of my classes, not via Coverity :)

OK'd by christos
2006-03-26 16:45:33 +00:00
jld 42ddba8762 Correct logic error in wildcard handling, which was causing the
day-of-month on normal entries to always be treated as a wildcard.

Specifically, "if (x&(y|z))" is equivalent to "if ((x&y)||(x&z))", not
"if ((x&y)&&(x&z))", which latter is clearly what was intended.
2006-03-24 23:30:08 +00:00
wiz 7ee6cdd959 Serial comma, remove unnecessary .Pp. 2006-03-24 00:14:23 +00:00
reed 909919ef8b Briefly document output of the modstat utility.
(And update document date.)
2006-03-23 23:59:38 +00:00
reed 04a9318e11 Changing a comment only because the module interface version
is not 1 anymore.
2006-03-23 23:52:35 +00:00
wiz 02b5f03672 Remove some more old kerberos4 code. Simplify usage. 2006-03-23 23:49:07 +00:00
wiz eb525bd07c Remove some more old kerberos4 code. 2006-03-23 23:44:15 +00:00
wiz 54cd24faa5 Get rid of more Kerberos 4 code. 2006-03-23 23:33:28 +00:00
wiz f5a1361a8f Remove some more kerberosIV references. 2006-03-23 21:48:18 +00:00
christos a6ee606509 gcc says case is missing, coverity says case not reached. Appease both. 2006-03-22 16:16:59 +00:00
christos f88156c66b PR/33128: Martin Husemann: When login in on the console, SIGABRT is ignored
Both SIGINT and SIGABRT should be restored before executing the shell.
2006-03-22 15:36:49 +00:00
christos ec4e36f798 Coverity CID 46: Remove dead code. 2006-03-22 02:17:52 +00:00
christos 4b41923ad3 Coverity CID 198: Remove dead code if INT_MAX == LONG_MAX 2006-03-22 02:14:03 +00:00
christos ec166aba55 Coverity CID 199: make sure that rtp is not NULL before dereferencing. 2006-03-22 02:08:55 +00:00
phil 4617d0a2bf Kill NULL deref (CID: 871)
Plug fd leak (not caught by coverity).
2006-03-21 21:59:56 +00:00