handle can be used as an input to the MD interrupt_distribute implementation
so we are forced to return the handle we got back from intr_establish().
Upshot is that the input to bcm2835_icu_fdt_disestablish() is ambiguous for
shared IRQs, rendering them un-disestablishable.
While here, make sure to actually bump the intr_refcnt, and add an
assertion on the value we get back from bcm2835_icu_fdt_decode_irq().
word but the current "active" media.
The user-set media word is one of the ifmedia_entry's ifm_media(A) that
ifm_cur points to (e.g. IFM_AUTO). It can be taken as ifmediareq's ifm_current
entry. The current active media word is the ifm_media(B) entry of struct
ifmedia (e.g 1000baseTX-FDX as the result of auto negotiation). It can be
taken as ifmediareq's ifm_active entry.
struct ifmedia_entry {
TAILQ_ENTRY(ifmedia_entry) ifm_list;
u_int ifm_media; /* IFMWD: description of this media */ /* A */
u_int ifm_data; /* for driver-specific use */
void *ifm_aux; /* for driver-specific use */
};
struct ifmedia {
u_int ifm_mask; /* IFMWD: mask of changes we don't care */
u_int ifm_media; /* IFMWD: current active media word */ /* B */
struct ifmedia_entry *ifm_cur; /* current user-selected media */
TAILQ_HEAD(, ifmedia_entry) ifm_list; /* list of all supported media */
ifm_change_cb_t ifm_change; /* media change driver callback */
ifm_stat_cb_t ifm_status; /* media status driver callback */
};
So:
in kernel SIOCGIFMEDIA(ifmediareq)
-----------------------------------------------------------------
user-setting: ifm->ifm_cur->ifm_media ifm_current
current active: ifm->ifm_media ifm_active
It would be good to rename some members to make those meaning clear.
common/main already sources them, so there's no point to process the
file again *after* the document has been formatted. Put it to SRCS so
that we still depend on it.
Divert only the .Ti lines to the TOC file. Keep the rest, it may
contain useful messages (like the empty line bug in macros that was
messing up page numbers).
TODO: Since we already depend on groff extensions, we should just use
.open/.write to emit the TOC directly. But commit this for now in
case I run out of round tuits.
That avoids an empty line in the input (which didn't look empty, but
for troff it really was) that causes a break.
I don't remember enough linear algebra to understand what happened,
but that also fixes off by one in some page numbers in the TOC.
I missed them b/c I tested on sparc notes and sparc/install is stuck
in the 90s and doesn't include common/sysinst. Now that all emitted
.Ti have properly quoted arguments we can revert TOCPROC to simple
grep.
While here convert .Te and .To to also use $* so we we can also drop
quoting from their calls in common/sysinst now. Don't actually drop
those quotes yet though, as we probably can further simplify the call
sites by emitting the headings automatically instead of duplicating
them.
Don't set the default value not in the attach function. Instead, set the
default value (MII_ANEGTICKS) first in the beginning of the
mii_phy_add_media(). The function already has the code to change the value to
MII_ANEGTICKS_GIGE if it's gigabit capable.
- Remove extra pmf_device_register() call. It's done in mii_phy_add_media().
- simplify TOC handling and remove arg limit (from uwe)
- use Lk with explicit anchor text in some places
- do not allow official release builds when we can not derive the
proper date from the buildid
For this purpose, PT_[GS]ETXMMREGS are added to amd64/ptrace.h. These
are intended for internal usage for COMPAT_NETBSD32, and therefore not
exposed to userland.
Thanks to kamil, mgorny, and pgoyette for their kind review!
XXX
pullup to netbsd-9
Remove duplicate (incorrect) version of the .Lk macro, so the
earlier (fancier and functional) definition survives.
For now simply comment it out. Sometime later this one should be
removed - but the two have been present since these macros were
first imported (1999) so leaving this visible (but removed) a
little longer shouldn't hurt.
I (believe) this one is the only duplicate of this form.
With this change the Lk macro in doc2html should work as it is designed
(but does not call other macros, and can only have punctuation following
the URL and (optional) anchor args (2nd arg is the anchor if it isn't
punctuation).
Tested by martin@
maxv