jnemeth
1124e30e6e
Coverity CID 3027: possible dereference of NULL pointer.
...
Also don't bother zero'ing memory immediately before reading the
.SYS file into it and check for errors while reading the file.
2006-05-26 09:25:27 +00:00
jnemeth
14902917f6
Remove redundant check for end of list wrapping around on itself.
...
It this were to actually happen, then others parts would go into
infinite loop. Also, fix KNF. Found while checking Coverity
CID 3784.
2006-05-26 02:16:17 +00:00
christos
e4dddba9c6
typo s/fp/fpw/
2006-05-25 03:17:43 +00:00
christos
862f4856b8
typo s/fp/fpw/
2006-05-25 03:17:26 +00:00
christos
cc17521d3c
Coverity CID 2959: Check before deref dammit.
2006-05-25 03:03:39 +00:00
christos
785022eb47
Coverity CID 2984: Static array overrun.
2006-05-25 03:02:25 +00:00
christos
df7031b876
Add missing semicolon.
2006-05-25 02:53:10 +00:00
christos
57ff0c4946
remove dup &&
2006-05-25 02:50:50 +00:00
christos
fdb8821322
Coverity CID 1455: Make sure that we don't overrun the array.
2006-05-25 02:48:09 +00:00
rpaulo
024ed52e7d
Add missing #endif.
2006-05-25 02:40:58 +00:00
christos
a43996b8ca
Coverity CID 783: Add an assertion for a NULL deref.
2006-05-25 02:37:38 +00:00
rpaulo
4264348cac
Beautify.
2006-05-25 02:35:50 +00:00
christos
79fc501cb4
Coverity CID 2294: Fix memory leak.
...
While here remove some bogus casts.
2006-05-25 02:35:32 +00:00
christos
1716cd4ef4
Coverity CID 1070: Check for NULL deref that cannot happen.
2006-05-25 02:33:16 +00:00
rpaulo
3a387eb457
Time to remove __P().
2006-05-25 02:32:56 +00:00
christos
25b83d98a5
Coverity CID 3653: Fix memory leak.
2006-05-25 02:31:38 +00:00
rpaulo
d5c00ee8c6
Now it uses the RFC 3542 API.
2006-05-25 02:21:59 +00:00
christos
830feeb9f3
use memcpy instead of bcopy.
2006-05-25 02:10:53 +00:00
christos
f5e466e11a
Coverity CID 2537: Avoid double free, and random free. how did this work?
2006-05-25 02:05:40 +00:00
christos
e86e72d9a8
Coverity CID 3194: Avoid NULL deref.
2006-05-25 02:01:40 +00:00
christos
180ca89a2b
Coverity CID 3195: ifdef out dead code.
2006-05-25 01:58:39 +00:00
christos
e30bfd160d
Coverity CID 3396: Fix file pointer leak.
2006-05-25 01:51:21 +00:00
christos
fb0d335338
Coverity CID 3377: Fix memory leak on error.
2006-05-25 01:49:30 +00:00
christos
d8050237b6
Coverity CID 1188: Don't check for NULL just to log and then die
...
de-referencing; return instead.
2006-05-25 01:44:28 +00:00
christos
4aafa6340a
Coverity CID 1189, 1190: Don't check for NULL just to log and then die
...
de-referencing; return instead.
2006-05-25 01:43:58 +00:00
christos
6388d5cc98
Coverity CID 1191, 1192: Don't check for NULL allocation, just to log it
...
and then die dereferencing. Return instead.
2006-05-25 01:41:13 +00:00
christos
43c323928f
Coverity CID 2718: Avoid using free'd memory.
2006-05-25 01:38:41 +00:00
christos
76c4e27a2a
Coveriy CID 797: Avoid NULL deref.
2006-05-25 01:22:53 +00:00
christos
c94cfed796
Coverity CID 2282: Fix memory leak.
2006-05-25 01:20:21 +00:00
christos
64274c3774
Coverity CID 754: Fix erroneous check. How could this ever work?
2006-05-25 01:18:59 +00:00
christos
c0dd54b15c
Coverity CID 3214: Check getrawpartition return code.
2006-05-25 00:42:23 +00:00
christos
2046b10b5b
Coverity CID 601: Remove unused code.
2006-05-25 00:37:03 +00:00
christos
75aa3e0d4e
Coverity CID 3308: Free the head of the group list, not the tail.
2006-05-25 00:33:24 +00:00
christos
bd00756294
Coverity CID 2524: Return error instead of trying to allocate random bytes
...
from the stack.
2006-05-25 00:27:56 +00:00
christos
323f38bde6
Coverity CID 2751: Avoid NULL deref.
2006-05-25 00:25:00 +00:00
christos
ddd7ee439d
Coverity CID 830: Avoid NULL deref.
2006-05-25 00:21:52 +00:00
christos
ede17ba69d
Coverity CID 3322: Fix memory leak.
2006-05-25 00:19:27 +00:00
christos
dabaab767f
Coverity CID 1463: Change code to unconfuse coverity.
2006-05-25 00:16:48 +00:00
christos
4eb1ef0701
PR/3205: Remove dead code.
2006-05-25 00:12:31 +00:00
christos
2a8477a7f9
Coverity CID 1860: Plug memory leak.
2006-05-25 00:07:59 +00:00
christos
aa0a3ef501
Sprinkle static and use err/errx/warn instead of fprintf/perror
2006-05-25 00:05:45 +00:00
christos
d62ef54061
Coverity CID 1442: Update the table, and use the table size instead of
...
hard-coded constant; fixes static buffer overflow.
2006-05-24 23:51:39 +00:00
christos
4f8217f507
Coverity CID 796: Add an extra test to pacify coverity.
2006-05-24 23:44:34 +00:00
christos
aecdec648e
Coverity CID 834: Add a test to pacify coverity.
2006-05-24 23:43:11 +00:00
christos
84a9244669
Coverity CID 1753: don't leak fp's.
2006-05-24 23:41:44 +00:00
christos
ecae799d9b
Coverity CID 803, 804, 805: Avoid NULL deref.
2006-05-24 23:34:59 +00:00
christos
6968fdf466
Coverity CID 1464: fix static overrun by returning an error.
2006-05-24 22:30:15 +00:00
christos
0b53fe2b9f
Coverity CID 3233: Be nice and close the file you opened.
2006-05-24 22:08:53 +00:00
christos
675ee2be81
Coverity CID 2460,2459,2458,2457: Don't allocate smaller chunks, it is not
...
worth it, and it makes coverity mad. Also check the return of malloc, and
allocate using variables instead of types as the sizeof arg.
2006-05-24 22:07:42 +00:00
christos
10dfada83b
Coverity CID 1321: False -gative detection.
2006-05-24 21:47:25 +00:00
christos
2a741c25dc
Coverity CID 3777: Free envp in the success case too.
2006-05-24 21:43:43 +00:00
christos
bcab7c84bf
Coverity CID 3778: set tmp to NULL to shutup coverity.
2006-05-24 21:42:25 +00:00
christos
bc796bc129
Coverity CID 1567: Fix memory leak.
2006-05-24 21:39:33 +00:00
christos
4c1a6c8705
Coverity CID 3671: Cast close to void and don't close negative fds.
2006-05-23 01:36:36 +00:00
christos
1dc235cd39
Coverity CID 2448: Remove extra NULL check.
2006-05-23 01:29:31 +00:00
christos
ae76bda7d7
Coverity CID 3227, 3226: Don't leak fd's
2006-05-23 01:23:49 +00:00
christos
ce35e5d7d7
Coverity CID 1567: Don't leak memory.
2006-05-23 01:18:19 +00:00
christos
1c2d89173e
Coverity CID 2534: Avoid use after free; this cannot really happen, but
...
coverity cannot figure it out.
2006-05-23 01:16:33 +00:00
uwe
5ea47b2f6b
That cast doesn't need to add const.
2006-05-22 20:17:03 +00:00
uwe
5efcb4b549
Use proper cast instead of gagging gcc4 with -Wno-pointer-sign.
2006-05-22 20:06:54 +00:00
mrg
ad76e73707
apply -Wno-pointer-sign to tp.c.
2006-05-22 07:36:52 +00:00
christos
1ab2316281
use warn/warnx instead of perror/fprintf
...
use get/set progname.
2006-05-21 19:26:43 +00:00
christos
fb4d7a1a6e
- fix pointer problems and unsigned int -> int confusion that lead to
...
undetected errors.
- factor out the socket creation code so that we don't have 4 copies.
- add -p <port> argument
- fix the majority of the lint problems.
- change all the strncpy's to strlcpy's.
2006-05-20 20:03:28 +00:00
christos
b956bc8c52
Add a man page derived from the one in the distribution.
2006-05-15 02:17:43 +00:00
christos
588239e93e
We don't have a man page yet.
2006-05-15 00:58:46 +00:00
dyoung
bfd03b170f
Build and install wpa_passphrase, the utility for making a WPA
...
pre-shared key (PSK) from an SSID (802.11 "network name") and a
secret passphrase.
2006-05-14 19:51:15 +00:00
dyoung
c0ef0302c7
If ioctl(SIOCS80211) fails, tell which operation was attempted,
...
and the ioctl length.
2006-05-14 19:49:22 +00:00
simonb
b8fb2aedbe
Sync rc.d file list with etc/rc.d/Makefile, adding ftpd, hostapd, and
...
irdaattach.
2006-05-14 15:46:40 +00:00
christos
ebebb0245d
Another uninitialized var XXX: GCC
2006-05-14 01:26:34 +00:00
christos
87e155c5c7
rename alloc() to emalloc().
2006-05-13 22:34:50 +00:00
christos
01caf31f3a
Cleanup KNF, WARNS=4.
...
Phew, this started just to make set() static so that coverity does not get
confused.
2006-05-13 20:46:15 +00:00
tron
2d77f6d3d5
Add "iscsi" target which install the iSCSI configuration files.
...
This will stop e.g. "/etc/security" complaining about these files
missing after a sucessful run of "postinstall"
2006-05-12 12:43:28 +00:00
tron
ef526ff868
Check for and install "/etc/rc.d/iscsi_target".
2006-05-12 07:16:47 +00:00
mrg
bf869c6019
apply -Wno-pointer-sign to print-802_11.c as well.
2006-05-12 02:00:46 +00:00
mrg
e13fd87f5f
use -Wno-pointer-sign with GCC4.
2006-05-12 01:54:57 +00:00
mrg
132e581078
remove a couple of extra externs
2006-05-12 01:54:32 +00:00
mrg
accf138991
netbsd authunix_create() actually takes an array of int not gid_t.
2006-05-12 01:28:34 +00:00
mrg
3479c0a6a2
can't fit "256" in an 8bit value, don't have a switch case for it.
2006-05-12 01:27:27 +00:00
mrg
126f7e1139
since ar_tha() can return NULL, don't pass it directly to functions
...
that expect real addresses. explicitly KASSERT() that it is not
NULL in the kernel and just avoid using it userland.
(the kernel could be more defensive about this, but, until now it
would have just crashed anyway.)
2006-05-12 01:20:33 +00:00
mrg
16efbf8575
don't do the -Wno-pointer-sign dance for host programs.
2006-05-12 01:18:25 +00:00
mrg
43419a069b
sprinkle a little (char *) to quell GCC4.
2006-05-11 23:50:15 +00:00
mrg
aadd7d4847
sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4.
2006-05-11 23:16:28 +00:00
mrg
2a5124235b
if we are going to cast the 3rd argument to accept_info_request(),
...
use the right type.
2006-05-11 21:17:02 +00:00
mrg
4a7d55e29a
our recvfrom() uses socklen_t *.
2006-05-11 19:25:28 +00:00
tron
203b156add
Include "bsd.own.mk" to get the definition of "HAVE_GCC".
2006-05-11 10:32:37 +00:00
mrg
86533d64ca
sprinkle some -fno-strict-aliasing with GCC4.
2006-05-11 09:08:09 +00:00
mrg
10c621b36e
sprinkle some -Wno-pointer-sign for now.
2006-05-11 08:55:10 +00:00
mrg
9f5cbae0f8
res_search() takes u_char * as 4th argument - pass one.
2006-05-11 08:44:56 +00:00
mrg
757868b20a
include <string.h>
2006-05-11 08:44:07 +00:00
mrg
953a812e66
le64 "big endian" is not printable by PRIu64 - cast via (u_int64_t).
2006-05-11 08:43:16 +00:00
mrg
c6d4b90983
use -fno-strict-aliasing with GCC4.
2006-05-11 08:41:07 +00:00
mrg
c48f394145
assign to wd.wd_recvtime rather than casting a pointer to it
...
to a time_t pointer to call time(3).
2006-05-11 08:40:28 +00:00
mrg
74e0882190
rs_data is u_char *, so assign it from a u_char *.
2006-05-11 08:38:38 +00:00
mrg
c23edde436
inet_ntop() wants char[] not u_char[].
2006-05-11 08:37:24 +00:00
mrg
9aae0c27f9
u_char -> char for several things:
...
- inet_ntop()
- if_indextoname()
- variable assignment matching
char -> u_char in one place for variable assignment matching
2006-05-11 08:35:47 +00:00
mrg
5b2e2e784b
use -fno-strict-aliasing for dump.c with GCC4
2006-05-11 07:20:19 +00:00
mrg
8f1fc6cc86
use -fno-strict-aliasing for utils.c with GCC4
2006-05-11 07:19:33 +00:00
mrg
58d1fc7bc5
use -fno-strict-aliasing with GCC4.
2006-05-11 07:17:41 +00:00
mrg
c90e965e45
only do the previous for GCC4
2006-05-11 07:15:17 +00:00
mrg
fde08302e9
use -Wno-pointer-sign and -fno-strict-aliasing for now.
2006-05-11 07:13:24 +00:00