Commit Graph

62 Commits

Author SHA1 Message Date
lukem a9a927dd92 adapt to ${CC_WNO_ADDRESS_OF_PACKED_MEMBER}
Simplify CWARNFLAGS to use ${CC_WNO_ADDRESS_OF_PACKED_MEMBER}
which works for both clang and gcc, and remove compiler-specific
equivalents.
2023-06-03 21:26:27 +00:00
lukem c4b7a9e794 bsd.own.mk: rename GCC_NO_* to CC_WNO_*
Rename compiler-warning-disable variables from
	GCC_NO_warning
to
	CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.
2023-06-03 09:09:01 +00:00
lukem f937c412f3 bsd.own.mk: rename to CC_WNO_ADDRESS_OF_PACKED_MEMBER
Provide a single variable
	CC_WNO_ADDRESS_OF_PACKED_MEMBER
with options for both clang and gcc, to replace
	CLANG_NO_ADDR_OF_PACKED_MEMBER
	CC_NO_ADDR_OF_PACKED_MEMBER
	GCC_NO_ADDR_OF_PACKED_MEMBER

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.
2023-06-03 08:52:53 +00:00
andvar 2bf8145d4f s/enougth/enough/ 2023-03-17 17:12:54 +00:00
mrg a2d1542565 add some new uses of existing GCC_NO_* variables for warning issues.
remove an no longer relevant for gcc7 workaround (works fine in both
gcc9 and gcc 10.)
2021-04-12 02:54:07 +00:00
mrg cb93b81028 add support for new GCC 9 warnings that may be too much to fix
right now.  new address-of-packed-member and format-overflow
warnings have new GCC_NO_ADDR_OF_PACKED_MEMBER amd
GCC_NO_FORMAT_OVERFLOW variables to remove these warnings.

apply to a bunch of the tree.  mostly, these are real bugs that
should be fixed, but in many cases, only by removing the 'packed'
attribute from some structure that doesn't really need it.  (i
looked at many different ones, and while perhaps 60-80% were
already properly aligned, it wasn't clear to me that the uses
were always coming from sane data vs network alignment, so it
doesn't seem safe to remove packed without careful research for
each affect struct.)  clang already warned (and was not erroring)
for many of these cases, but gcc picked up dozens more.
2020-09-06 07:20:26 +00:00
joerg 3345ee081b lineno, states and allocated should be owned by the parser 2020-04-23 00:29:00 +00:00
maxv 2b4397de4a sync with reality 2019-08-13 09:48:24 +00:00
gutteridge 03f48fcb5b pf.boot.conf: remove lingering references to dhclient(8), and while
here, capitalize acronyms. Addresses part of PR misc/53669.
2019-02-17 20:45:47 +00:00
hauke 01510a9c7f Enable carp packets early during boot, to avoid gratuitous failovers.
Okayed by christos@
2017-05-26 15:40:27 +00:00
joerg f9c2736326 Disable a couple of warnings until further investigation. 2017-01-11 12:19:43 +00:00
christos 8ee626c9fa improve error messages (remove \n, use __func__, etc) 2015-06-16 23:04:13 +00:00
christos 0bcb0c670a use strtonum from libc 2015-01-29 03:31:35 +00:00
christos 0a77b69ab6 fix unused variable warnings. 2013-10-19 17:16:37 +00:00
christos f7b110e4f0 no need for the end macros anymore 2013-04-10 22:21:53 +00:00
rmind 5b97ba65a8 Disable -DWITH_NPF for now; will be converted to BPF mechanism. 2013-02-09 15:36:40 +00:00
plunky 19ea14f457 does not need -I${NETBSDSRCDIR}/sys/dist/ipf here, the include files
are installed in /usr/include/netinet
2012-09-15 17:46:25 +00:00
christos 55c6b3796e don't include pcap/bpf.h 2011-12-21 22:18:43 +00:00
joerg bec77c5f43 Use __dead 2011-08-31 13:32:36 +00:00
joerg a216da57a6 Default to -Wno-sign-compare -Wno-pointer-sign for clang.
Push -Wno-array-bounds down to the cases that depend on it.
Selectively disable warnings for 3rd party software or non-trivial
issues to be reviewed later to get clang -Werror to build most of the
tree.
2011-05-26 12:56:24 +00:00
joerg 5b79cac715 No input needed 2011-05-24 13:41:53 +00:00
rmind 3bb326c464 Fix sun2 builds. Noted by joerg@. 2011-02-04 00:19:51 +00:00
rmind 07ac07d35f NPF checkpoint:
- Add libnpf(3) - a library to control NPF (configuration, ruleset, etc).
- Add NPF support for ftp-proxy(8).
- Add rc.d script for NPF.
- Convert npfctl(8) to use libnpf(3) and thus make it less depressive.
  Note: next clean-up step should be a parser, once dholland@ will finish it.
- Add more documentation.
- Various fixes.
2011-02-02 02:20:24 +00:00
christos 976857bd1b fix build. 2010-12-13 01:44:25 +00:00
wiz 6f43bcda13 Remove trailing whitespace and dot in Nd. 2010-05-09 14:02:10 +00:00
degroote c4b8685918 Add missing license 2010-05-09 12:45:19 +00:00
wiz 95b209a8cf Sort options, standardize SYNOPSIS, slight rewordings. Use more markup. 2010-05-08 11:29:40 +00:00
degroote ca38e323d1 Add support for pfs(8)
pfs(8) is a tool similar to ipfs(8) but for pf(4). It allows the admin to
dump internal configuration of pf, and restore at a latter point, after a
maintenance reboot for example, in a transparent way for user.

This work has been done mostly during my GSoC 2009

No objections on tech-net@
2010-05-07 17:41:57 +00:00
degroote 2d48ac808c Import pfsync support from OpenBSD 4.2
Pfsync interface exposes change in the pf(4) over a pseudo-interface, and can
be used to synchronise different pf.

This work was part of my 2009 GSoC

No objection on tech-net@
2009-09-14 10:36:48 +00:00
lukem a3417b09b0 WARNS=1 for pf 2009-04-23 05:25:06 +00:00
lukem d877c4c3c0 Enable WARNS=4 by default, except for:
cpuctl  dumplfs  hprop  ipf  iprop-log  kadmin  kcm  kdc  kdigest
	kimpersonate  kstash  ktutil  makefs  ndbootd  ntp  pppd  quot
	racoon  racoonctl  rtadvd  sntp  sup  tcpdchk  tcpdmatch  tcpdump
	traceroute  traceroute6  user  veriexecgen  wsmoused  zic
(Mostly third-party applications)
2009-04-22 15:23:01 +00:00
peter 430b2da1d5 Install /etc/pf.os with 444 permissions.
Modify postinstall(8) to always upgrade /etc/pf.os.

Suggested by Luke Mewburn in PR/35188.
2008-06-20 17:04:45 +00:00
yamt fff57c5525 merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@.  requested by core@
2008-06-18 09:06:25 +00:00
tron 07347616e8 Use "ipv6-icmp" instead of "icmp6" to allow loading these rules again.
Patch supplied by Daniel Horecki in PR bin/36874.
2007-09-02 15:28:43 +00:00
tls 4147a3c54a Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry.  RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros.  Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default.  Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
2007-05-28 12:06:17 +00:00
christos 3a4d16937d compile a file with -Wno-stack-protector since it is using __cmsg_alignbytes()
for a variable on the stack.
2006-11-09 20:33:25 +00:00
christos 1ec0eb6725 remove openlog_r/syslog_r; we now have it. 2006-10-26 10:18:31 +00:00
drochner 741f357fc1 Build libpcap-0.9.4 from src/dist.
While there are some open issues, particulary wrt support of old
NetBSD-specific interfaces, it is better to get the code some public
testing before NetBSD-4 is branched.
2006-04-25 18:36:44 +00:00
reed de56c0d123 Fix mispelling in a comment. 2006-01-10 20:53:24 +00:00
peter 9c1da17e90 pf needs to be started after the network is up, because some pf rules
derive IP address(es) from the interface (e.g "... from any to fxp0").
This however, creates window for possible attacks from the network.

Implement the solution proposed by YAMAMOTO Takashi:
Add /etc/defaults/pf.boot.conf and load it with the /etc/rc.d/pf_boot
script before starting the network. People who don't like the default
rules can override it with their own /etc/pf.boot.conf.
The default rules have been obtained from OpenBSD.

No objections on: tech-security
2005-08-23 12:12:56 +00:00
peter df0caa2637 Remove (pf)spamd. Its right to exist in NetBSD has been questioned since it
appeared and whether it's really part of pf or not is still unclear. Looking
at the other *BSDs it seems that they have left out spamd when importing pf,
and now we do that too. Also, the name conflicted with another more popular
used tool, after the rename to pfspamd it was left with completely unusable
documentation which apparently no-one wanted to fix.

A port of the latest spamd will be imported into pkgsrc soon.

Suggested by several people, no objections on last proposal on tech-userlevel.
2005-06-27 20:32:39 +00:00
tron 92570d0dfc Remove copy of manual page created during build. 2005-04-19 08:42:54 +00:00
tron 20442260d4 Remove copy of manual page created during build. 2005-04-13 17:51:12 +00:00
jwise 58015a4d36 Finally, spamlogd -> pfspamlogd, for consistency. 2005-04-12 14:44:10 +00:00
jwise f876c1012e spamd.conf is now pfspamd.conf. 2005-04-12 14:39:39 +00:00
jwise 200b4f7e06 Now that we can override the name of /etc/spamd.conf, make it /etc/pfspamd.conf. 2005-04-12 14:36:15 +00:00
jwise 88573cf3f3 Pass in path to /etc/spamd.conf in CPPFLAGS. 2005-04-12 14:34:57 +00:00
jwise a8293ab76d Now that we can specify the chroot location, make it /var/chroot/pfspamd. 2005-04-12 14:23:26 +00:00
jwise aac5bfbda9 Pass in a value for SPAMD_CHROOT in CPPFLAGS, to specify the path to the
chroot dir spamd will use.
2005-04-12 14:21:20 +00:00
jwise d32dabfd88 Per discussion on tech-userlevel and tech-security, install `spamd',
`spamd-setup', and `spamdb' as `pfspamd', `pfspamd-setup', and `pfspamdb'.

To quote Steven M. Bellovin:

  This [having a program in basesrc with the same name as a widely used and
  completely different program in pkgsrc] is a seriously bad idea; it
  violates the rule of least surprise.  That's bad enough in normal
  situations; here, we're talking about security.  You do *not* want to
  confuse people about security features; they're hard enough to get right
  as is.
2005-04-11 22:34:18 +00:00