Commit Graph

7356 Commits

Author SHA1 Message Date
rillig dd57c37d01 mount_portal: fix lint warnings about extern and empty declarations 2023-04-04 20:39:36 +00:00
ryo 65f9de9e0d commonize case block 2023-04-02 18:15:24 +00:00
ryo 60536c5379 don't pass add=1 to print_tree() when displaying by specifying nodes.
For example, "sysctl -w kern.mbuf=" had been displayed extra node names in the MIB.
 # sysctl -w kern.mbuf=
 kern.mbuf.mbuf.msize = 512
 kern.mbuf.mbuf.mclbytes = 2048
 :
2023-04-02 18:11:26 +00:00
chs 8f4d5a45a2 Apply this commit from FreeBSD:
commit 6bae6625e0e06816c80ac4971dfccf0643abe3f0
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:   Wed Aug 17 14:19:59 2022 -0700

    Improve handling of missing '.' and '..' in UFS directories.

    The UFS filesystem expects to find '.' and '..' as the first two entries
    in a directory. The kernel's UFS name cache can become quite confused
    when these two entries are not present as the first two entries.

    Prior to this change, when the fsck_ffs(8) utility detected that
    '.' and/or '..' were missing, it would report them, but only offered
    to replace them if the space at the beginning of the directory was
    available. Otherwise it was left to the system administrator to
    move the offending file(s) out of the way and then rerun fsck_ffs(8)
    to create the '.' and '..' entries.

    With this change, fsck_ffs(8) will always be able to create the '.'
    and/or '..' entries. It moves any files in the way elsewhere in the
    directory block. If there is no room in the directory block to which
    to move them, they are placed in the lost+found directory.

    Reported by:  Peter Holm
    Sponsored by: The FreeBSD Foundation
2023-03-27 22:53:37 +00:00
mlelstv 6029abdb95 Fix parser for carp state.
The state values are uppercase words INIT, BACKUP and MASTER.
2023-03-26 01:04:16 +00:00
simonb 1145fafc6f In "devlist" mode, exit with a 0 return code if any nvme devices are
found, rather than exiting with 1 return code always.
2023-03-05 23:24:06 +00:00
kre 5747acc12f Fix a typo in a newly added comment.
Someone please tell me why these things become obvious only after
the code has been committed!

NFC
2023-03-01 15:18:18 +00:00
kre 5a71a00fea When processing swapon -a (or swapctl -A, or swapctl -U) ignore lines in
fstab that have nothing to do with swapping (fs_type is neither "sw" nor "dp")
before running getfsspecname() on the fs_spec field of the line.

This avoids entries like this:

NAME=OFTEN_UNCONNECTED   /local/archived ffs     rw,log,noauto    0 0

in fstab from generating spurious error messages when the wedge named
is not currently connected to the system - that is the drive on which the
wedge exists is not connected, or not powered on.   "noauto" handles that
for some other uses, the "0"s in fs_freq and fs_passno work for other uses,
but swap{on,ctl} never look at those fields (not for this purpose).

Non "sw"/"dp" lines were being ignored anyway, but not until (a little) later.
2023-03-01 15:15:56 +00:00
andvar 19c1490f61 fix some typos in comments. 2023-02-27 22:00:25 +00:00
andvar 45db36d858 s/superblok/superblock/ in comment. 2023-02-26 22:55:02 +00:00
uwe 295421a2f9 shutdown(8): markup fixes 2023-02-15 13:05:21 +00:00
uwe c1371239a4 shutdown(8): fix -width cargo cult 2023-02-15 10:31:52 +00:00
jschauma 653e2a3e27 adjust width of flag arg to align more nicely 2023-02-15 01:55:16 +00:00
mlelstv e66f4605a1 Data units read/written are counted in 1000s of 512 bytes.
Convert to human-readable value.
2023-02-02 08:21:32 +00:00
mlelstv 19722ca2cf Use opendisk when looking for filesystem type, otherwise the detection
only works if the correct device path is given as an argument.
2023-01-24 08:09:37 +00:00
mlelstv 3e7f0f50ca Work on swapped-endian FFS. 2023-01-24 08:05:07 +00:00
kre 4bc7e3cb63 Use %zu rather than %lu to print a size_t (should fix i386 build).
But, philosophical question, shouldn't the product of two size_t
variables really be an area_t, or something like that?
2023-01-14 17:01:10 +00:00
christos 4616d0425d catch up with sign changes in the fs.h 2023-01-14 12:12:50 +00:00
chs 908deb24fa ufs: more signed/unsigned fixes
Fix the previous signed/unsigned fixes to build on 32-bit,
including applying this commit from FreeBSD:

  commit 2d34afcd04207cf3fa3d5b7f467a890eae75da41
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:   Sun Oct 25 21:04:07 2020 +0000

    Use proper type (ino_t) for inode numbers to avoid improper sign extention
    in the Pass 5 checks. The manifestation was fsck_ffs exiting with this error:

      ** Phase 5 - Check Cyl groups
      fsck_ffs: inoinfo: inumber 18446744071562087424 out of range

    The error only manifests itself for filesystems bigger than about 100Tb.

    Reported by:  Nikita Grechikhin <ngrechikhin at yandex.ru>
    MFC after:    2 weeks
    Sponsored by: Netflix
2023-01-08 05:25:24 +00:00
chs f298a94b73 ufs: fixed signed/unsigned bugs affecting large file systems
Apply these commits from FreeBSD:

  commit e870d1e6f97cc73308c11c40684b775bcfa906a2
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:   Wed Feb 10 20:10:35 2010 +0000

    This fix corrects a problem in the file system that treats large
    inode numbers as negative rather than unsigned. For a default
    (16K block) file system, this bug began to show up at a file system
    size above about 16Tb.

    To fully handle this problem, newfs must be updated to ensure that
    it will never create a filesystem with more than 2^32 inodes. That
    patch will be forthcoming soon.

    Reported by: Scott Burns, John Kilburg, Bruce Evans
    Followup by: Jeff Roberson
    PR:          133980
    MFC after:   2 weeks

  commit 81479e688b0f643ffacd3f335b4b4bba460b769d
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:   Thu Feb 11 18:14:53 2010 +0000

    One last pass to get all the unsigned comparisons correct.


In additional to the changes from FreeBSD, this commit includes quite a few
related changes to appease -Wsign-compare.
2023-01-07 19:41:29 +00:00
hannken 7b77b9376c Change getdiskinfo() to no longer infer the partition from the device name.
Since 2016-06-16 we create disk devices "<type><<unit>" as an alias
for "<type><<unit><part>" where "<part>" is the raw partition.
These devices are treated as invalid partitions and a zero geometry
is returned.

Take the partition from "st_rdev" instead.

Fix for PR kern/57134: st_size of stat on vnd raw partition sometimes
is 0, causing newfs to fail
2023-01-02 16:08:13 +00:00
chs fc887601fd mount_nfs: add missing "A" to getopt string 2022-12-21 19:00:52 +00:00
chs 062d5b230d tunefs: clarify that "-a" refers to NFSv4 ACLs 2022-12-19 21:13:16 +00:00
chs b04cd074cb apply this commit from FreeBSD:
commit 9dda00df7e8f9279a43d92758df6a7e10a9aed95
  Author: Chuck Silvers <chs@FreeBSD.org>
  Date:   Mon Dec 12 08:14:17 2022 -0800

      restore: fix restore of NFS4 ACLs

      Changing the mode bits on a file with an NFS4 ACL results in the
      NFS4 ACL being replaced by one matching the new mode bits being set,
      so when restoring a file with an NFS4 ACL, set the owner/group/mode first
      and then set the NFS4 ACL, so that setting the mode does not throw away
      the ACL that we just set.

      Reviewed by:    mckusick
      Differential Revision:  https://reviews.freebsd.org/D37618
2022-12-12 16:53:30 +00:00
chs a932562d1e apply this change from FreeBSD:
commit c028393d7072f1f88efd8d6e6c77bb9b15b3f3b6
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:   Fri Apr 11 21:48:14 2008 +0000

      Correctly set file group when restore is run by a user other than root.
2022-12-10 18:49:44 +00:00
christos 98f1b42d37 fix sign. 2022-12-01 14:42:12 +00:00
christos 1bf8465593 Add a sanity check for the ip header length (from FreeBSD) 2022-12-01 14:40:53 +00:00
knakahara f66ad936b7 ifconfig(8) support unnumbered flag. 2022-11-25 08:41:05 +00:00
mlelstv 27a040a8a9 Big-Endian fixes. 2022-11-22 00:25:52 +00:00
mlelstv 0bf6d48843 Fix destroying and moving GPT header also for truncated/extended
images.
2022-11-20 11:57:02 +00:00
martin 1b5f3a1b0a Fix clearing of permissions when finding unexpected extended attributs
for swapped endian file systems. Ok: chs
2022-11-18 07:41:31 +00:00
martin 2627930cb6 Make the "non-zero exattr fields" message show the inode number. 2022-11-17 18:57:16 +00:00
chs 87ba0e2a31 Restore backward compatibility of UFS2 with previous NetBSD releases by
disabling support in UFS2 for extended attributes (including ACLs).
Add a new variant of UFS2 called "UFS2ea" that does support extended attributes.
Add new	fsck_ffs operations "-c	ea" and	"-c no-ea" to convert file systems
from UFS2 to UFS2ea and	vice-versa (both of which delete all existing extended
attributes in the process).
2022-11-17 06:40:38 +00:00
andvar 8a36802c94 fix various typos in comments and one output message. 2022-10-31 21:22:05 +00:00
rillig 29f817563f mount_cd9660: remove unhandled option -i from getopt
Found by lint. While here, fix the other lint warning as well, as lint
still doesn't know that exit(3) doesn't return normally.
2022-10-16 16:26:35 +00:00
andvar c3ad0bdd7e fix various typos in documentation and comments.
mainly in words functionality, functional, function.
2022-10-15 21:53:21 +00:00
riastradh 811e9ec794 wdogctl(8): Minor tweak suggested by a passing umarell.
Plus another wording improvement.
2022-09-23 12:35:00 +00:00
uwe 7bdf691e15 wdogctl(8): fix -width in previous 2022-09-22 21:40:42 +00:00
riastradh 30c75eaa64 wdogctl(8): Rework prose and markup in man page.
No functional change.
2022-09-22 14:02:45 +00:00
riastradh 9b5a6c4d5c cgdconfig(8): Restore loop for password re-entry for non-shared keys.
Fixes mistake in previous which changed the semantics in the case
where _no_ keys are shared.
2022-09-13 10:14:32 +00:00
riastradh 4b3ee8b4fa cgdconfig(8): Gracefully handle failed verification with shared keys.
The first time each key is verified, if verification fails, we chuck
the failed key and try again with passphrase re-entry.

But if a key has already been verified, and verification fails,
assume something is wrong with the disk and fail.
2022-08-30 08:48:41 +00:00
mlelstv 1736420841 fix 32bit builds 2022-08-28 11:32:19 +00:00
hgutch ec184f3bfb Change back various occurrences of \*[Le], \*[Ge] (less/greater equal)
and \*(ua (upwards arrow) to literal "<=", ">=" and "^" whenever
appropriate (e.g., in code examples).
2022-08-28 10:48:15 +00:00
mlelstv c6dcfc105b Fix writing of corrected fsinfo.
Continue when fsinfo has been rewritten.
2022-08-28 10:20:25 +00:00
mlelstv 100b2229a1 Add REPORT_LUNS command. 2022-08-21 12:44:16 +00:00
mlelstv 657333c966 When extracting properties, don't bail for non-existent or invalid path
elements, but continue with next properry.
2022-08-21 07:51:30 +00:00
nat 5fc22d500a Revert to previous as the atf tests are still failing. 2022-08-17 23:36:48 +00:00
nat 5f38985994 Use existing address when setting parameters.
No need to specify address every time when setting broadcast address or
netmask.

Hopefully successfully re addresses PR bin/10911.
2022-08-17 12:35:10 +00:00
nat 2d7b3c2cc9 Revert to previous as atf tests were failing. 2022-08-16 22:31:24 +00:00
nat 728612bd0e No need address every time to specify broadcast and netmask.
Previously ifconfig would fail silently.

Addresses PR bin/10911.
2022-08-16 10:47:10 +00:00