aac1ec24ab
Adventure(6) should check for errors (e.g. disk full or quota
...
exceeded) when writing out saved games. Do so!
Patch supplied by Joseph Myers <jsm28@cam.ac.uk> in PR 8016
1999-07-17 20:02:48 +00:00
d5f85ed9c9
The patch below improves the security of the game atc(6), by having it
...
open the score file at the start and then drop all setgid privileges
while keeping a (close-on-exec) file descriptor open to it. In order
to allow this the static data files have to be made world readable.
In addition a potential buffer overrun with corrupted score files is
avoided by more careful use of scanf (note that SCORE_SCANF_FMT is
defined alongside the definition of the relevant structure).
Submitted in PR 8015 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-17 19:57:03 +00:00
fbaff02b26
Add two .Els that nroff was complaining to miss.
1999-07-17 19:48:40 +00:00
dceb24647b
This patch (a) makes arithmetic(6) revoke any setgid privileges it got
...
from dm; (b) marks an unused parameter as such.
Submitted in PR 8014 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-17 19:11:30 +00:00
adf74b1e92
This patch cleans up the handling of the variable `saved' in
...
adventure(6). The handling of this variable is somewhat confusing,
since it is used for two different purposes (controlling the time
required before a saved game can be restored, and controlling various
aspects of dwarf behaviour); in fact, it is also declared twice in
hdr.h. Except possibly when saving a game fails, these uses can never
interfere; when used for controlling dwarf behaviour, we always have
saved == -1. This can be better understood with reference to the
original PDP-10 FORTRAN source (URL in patch, since hdr.h references
the comments of the FORTRAN as still relevant to this version) of
which the C version is a direct translation: the wrong value for
`saved' meant that someone was cheating and had bypassed normal
initialisation. Saving was done by halting and telling the user to
save their core image, so the question of carrying on after saving
failed to open the output file did not arise.
This patch separates the uses of `saved' into uses of two separate
variables.
Closes PR 8005 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-16 01:38:20 +00:00
24d3aaa397
Const poisoning.
...
Patch submitted in PR 7993 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-14 22:52:07 +00:00
4502aed41f
This patch fixes a -Wcast-qual warning in wump(6).
...
Submitted in 7994 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-14 22:49:27 +00:00
9c8243f4e2
Fix scoring, submitted in PR 7992 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-14 22:46:21 +00:00
12a0758a42
From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
...
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.
1999-07-14 17:42:13 +00:00
148eb780dc
This patch makes fish(6) honour PAGER for viewing the instructions.
...
The detailed behaviour follows POSIX.2. A similar patch for wump(6)
which was accepted is in bin/6699. Fish does not need any setgid
privileges it gets from dm, so this patch also moves the gid resetting
earlier.
Reported in PR 7986 by Joseph Myers <jsm28@cam.ac.uk>
1999-07-14 17:30:21 +00:00
c1f52f97cd
From PR 7988 by Joseph Myers <jsm28@cam.ac.uk>: use the symbolic
...
name SEEK_SET for values which end up as the third argument of
fseek(), rather than a hard-coded 0.
1999-07-14 17:23:53 +00:00
76139748e2
From PR 7985 by Joseph Myers <jsm28@cam.ac.uk>:
...
games/adventure/setup.c fails to check for errors when writing its
output. This means that, if the disk fills up at this point during a
build, it would nevertheless fail to return an error status.
1999-07-14 17:21:03 +00:00
3365b567da
man page rewritten into -mandoc by dholland@eecs.harvard.edu; from PR7861
1999-06-27 04:35:42 +00:00
605ec8abd1
Fixi uninit vars warnings.
1999-05-16 00:15:46 +00:00
4cb49d76cc
Add missing prototypes
1999-05-16 00:03:35 +00:00
18dfb39e84
Add -A for automatic playing mode.
...
Make the score file MI
1999-05-15 23:56:35 +00:00
8e5038f0a3
Fix Y2K buffer overflow (from OpenBSD).
1999-04-25 19:08:34 +00:00
a9a6e776fa
Buffer overflow fix (from OpenBSD)
1999-04-24 22:09:06 +00:00
a2ed16d0dd
initscr() returns a pointer, compare return value with NULL and not
...
an int.
Compatible with other versions of curses.
1999-04-18 03:30:12 +00:00
4e92840504
Don't frob the interals of a WINDOW*, use the mvinch() macro.
1999-04-18 03:29:01 +00:00
b22750720f
change:
...
.Sh "SEE ALSO"
to:
.Sh SEE ALSO
The doc macros check for the latter (actually just for 'SEE' as the first
argument to .Sh) to set the section header SEE ALSO flag, which modifies
some behaviour (e.g. references done with .Rs/.Re).
1999-04-06 04:54:19 +00:00
190c71aa67
s/SETUIDGAME/SETGIDGAME/ - catch up with the rest of the world.
1999-04-05 08:04:48 +00:00
4924ddc041
defined(attron) does not mean there is a <term.h>
1999-03-29 05:12:39 +00:00
dab3a74af9
Fix object recognition, per PR 6048 by Joseph S. Myers <jsm28@cam.ac.uk>.
1999-03-25 16:46:08 +00:00
d1407362ba
More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
...
so we shouldn't override it with versions in the manpages. Many more to
come.
1999-03-22 18:43:46 +00:00
0a265153fb
Newline and usage cosmetics from Soren S. Jorvang <soren@t.dk> PR7205
1999-03-22 06:12:23 +00:00
7e1c62baf8
set MKLINT=no. noted by NAKAJIMA Yoshihiro <nakayosh@kcn.ne.jp>
1999-03-13 23:17:46 +00:00
55f3a4b91b
Fix .Bl/.El imbalance.
1999-03-10 09:29:08 +00:00
868ca23db4
remove NOPROG (nothing uses it). however, set MKOBJ=no if appropriate
1999-02-13 23:53:56 +00:00
dcab0210a0
convert from NOxxx= to MKxxx=no.
...
include <bsd.own.mk> if testing a MKxxx variable.
1999-02-13 02:54:17 +00:00
6372fa90cc
Remove unneeded "mips compiler bug" workaround from original code imported
...
in 1994.
1999-02-11 02:34:24 +00:00
b0ed16a714
tgetent() handles const correctly in current
1999-02-10 17:08:06 +00:00
752e969da2
Add __attribute__() to a variable. From PR 6557, after discussion with
...
Joseph S. Myers <jsm28@cam.ac.uk>
1999-02-10 12:38:54 +00:00
92932dfcc8
The patch below makes the game backgammon(6) use `const' where
...
appropriate. It also removes some obsolete, unused code to check the
number of users on the system (obsoleted by dm); removes a prototype
for an unused function that was removed earlier; and removes a control
character from one message that was I think intended to clear the
screen on some particular terminal (though I can't find the comment to
that effect in any of the BSD source trees I have handy) but no longer
serves any useful purpose.
From PR 6580 by Joseph Myers <jsm28@cam.ac.uk>.
Also contains two more patches, one in teachgammon/tutor.h (by Joseph)
and one in common_source/fancy.c (by me).
1999-02-10 12:29:47 +00:00
ce3b092b6d
Only invoke pager given in $PAGER if output goes to a tty, feed pager
...
via stdin, per PR 6699 by Joseph Myers <jsm28@cam.ac.uk>
1999-02-10 01:44:34 +00:00
bd8be7848a
Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>
1999-02-10 01:36:50 +00:00
24f809b060
The game sail(6) has a function Write() which is used both with
...
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.
The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.
Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.
1999-02-10 00:45:45 +00:00
c7bcded63e
The patch below does some minor cleanup of adventure(6): an additional
...
use of const I missed in bin/6041; avoiding a signed/unsigned warning;
marking an unused parameter as such; revoking setgid privileges
(including the saved gid) rather than setuid ones; includes and
function prototypes in setup.c; the string passed to err() should not
end with a `.'. Together with the patch sent concerning adventure's
EOF handling, this synchronises adventure(6) in NetBSD with the Linux
port of the NetBSD games.
Via PR 6557 by Joseph Myers <jsm28@cam.ac.uk>
1999-02-10 00:29:21 +00:00
08ab0f321a
The game adventure(6) handles EOF on standard input rather
...
ungracefully. The patch, derived from OpenBSD, improves this
handling.
Sent in in PR 6556 by Joseph Myers <jsm28@cam.ac.uk>.
1999-02-10 00:11:28 +00:00
6cfbee5947
only show preview if the -p option is given
1999-01-03 17:13:51 +00:00
13aa60478d
document morse's decode option -d
1999-01-03 17:12:28 +00:00
f42c52bee6
Add previewing of next shape. Old (previous) behaviour can be
...
restored by compiling with NO_PREVIEW defined.
1999-01-03 02:00:17 +00:00
1c7a4fb141
Remove obsolete header file. Fixes PR bin/6700 by Joseph S. Myers.
1999-01-02 15:47:55 +00:00
16a09f01ca
tweaks to pass DESTDIR to subprograms when it is defined in /etc/mk.conf
...
but is not in the environment.
1998-12-06 09:06:45 +00:00
f16cf517fe
typo.
1998-12-05 21:09:23 +00:00
ca027085f0
Fix spelling of `Churchill' in 3 places
1998-11-20 03:35:31 +00:00
d5f8b67ebe
Add support for decoding of morse code.
1998-11-18 14:22:32 +00:00
51755c03b2
fix usage
1998-11-18 09:06:26 +00:00
a9d35e8322
constify, per PR 6150 by Joseph Myers <jsm28@cam.ac.uk>
1998-11-10 13:43:30 +00:00
6d265b3268
constify, per PR 6148
1998-11-10 13:01:31 +00:00
30b3ea8d71
make objdir-aware
1998-11-09 15:30:10 +00:00
b569ddabe9
don't install in /usr/share if NOSHARE is defined
1998-09-29 07:33:20 +00:00
ad506eb7a0
Fix args processing of backgammon and teachgammon, closes pr 5345 by
...
David Brownlee.
1998-09-15 13:43:34 +00:00
bd946d241e
constify (PR#6151, once more by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-14 09:30:57 +00:00
006cc8ac96
return error on errors (PR#6147 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-14 09:29:08 +00:00
4e4187282a
constify, as per PR#6136 by Joseph Myers <jsm28@cam.ac.uk>
1998-09-14 09:13:46 +00:00
6f55e2e275
remove x bit from save files (PR#6077)
1998-09-13 15:41:34 +00:00
b0178f6b01
Remove unused function and mark non-returning ones(PR#6076, #6144 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:31:07 +00:00
1c9494f62b
mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:27:25 +00:00
3aca90fd78
fix bug w/ negative numbers, mark non-returning functions (PR#6142+6144 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:24:57 +00:00
ade2d3629c
add sanity checks when saving/restoring games (PR#6138 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:24:41 +00:00
878ef9cb13
check for malloc failures (PR#6136 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:24:09 +00:00
9e7f2724b9
some cleanups as per PR#6082 by Joseph Myers <jsm28@cam.ac.uk>
1998-09-13 15:23:40 +00:00
f92ae4adb5
remove unused files (PR#6083 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:22:57 +00:00
dd397c841b
remove unused function return values (PR#6079 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:21:36 +00:00
3f1f74edef
Saved games can NOT be restored by executing the save file (PR#6077)
1998-09-13 15:21:05 +00:00
0056c879de
Replace special handling of \r by using ICRNL (PR#6078 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:20:31 +00:00
9713f31f7c
Remove unused function (PR#6076 by Joseph Myers <jsm28@cam.ac.uk>)
1998-09-13 15:19:35 +00:00
5795fc4c70
Make dm ignore TZ; PR#6073 by Joseph Myers <jsm28@cam.ac.uk>
1998-09-13 12:34:43 +00:00
4e1357c739
constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>
1998-09-13 00:07:24 +00:00
6d6da27a53
Correct attribution as pointed out in pr 6114 by Jim Wise.
1998-09-12 22:49:12 +00:00
aaae79a78d
Make the helper programs compile right in a cross-compiling environment.
1998-09-12 19:05:48 +00:00
4d8c1c95f9
add main() prototype
1998-09-11 14:51:18 +00:00
441ff4f749
fix prototype, PR#5867
1998-09-11 14:28:28 +00:00
923fd93941
use symbolic constant for open(), PR#5867
1998-09-11 14:26:19 +00:00
9a9bb90e33
fix main() prototype, per PR#5867
1998-09-11 14:25:22 +00:00
eb2507ecb2
fix prototype, per PR#5867
1998-09-11 14:11:57 +00:00
3fd99e1631
fix prototypes, per PR#5867
1998-09-11 14:09:27 +00:00
0ef663b102
fix prototype of mon_sees(), per PR#5867
1998-09-11 14:07:51 +00:00
d4741e5a86
be more precise for PI, as per PR5867
1998-09-11 14:07:04 +00:00
e1627357ea
use symbolic constants for signals & open(2), as per PR#5867
1998-09-11 13:54:08 +00:00
c31c912667
remove unneeded typedef for TTYB, as per PR#5867
1998-09-11 13:46:30 +00:00
f52826a170
fix main() prototype, as per PR#5867
1998-09-11 13:42:03 +00:00
20de87e848
fix main() prototype, as per PR#5867
1998-09-11 13:19:50 +00:00
5f5c04f636
remove unused args from main(), as per PR#5867
1998-09-11 13:16:05 +00:00
f90c041018
fix typo, as per PR#5867
1998-09-11 13:06:30 +00:00
4ccf0d9755
better define PI, plus improve prototype (PR#5867)
1998-09-11 12:53:28 +00:00
4e2ece1035
remove main() prototype, as per PR 6867
1998-09-11 12:46:26 +00:00
e5512611f3
Fix typo, closes pr 6137 by Joseph Myers.
1998-09-10 21:50:35 +00:00
04afeca685
Add braces to make the new egcs happy.
1998-08-30 09:19:36 +00:00
767fe0a0b4
Use symbolic names for signals(!), open(2)-constants, ...
...
Fix applied as per PR 6058 by Joseph Myers <jsm28@cam.ac.uk>
1998-08-29 22:53:03 +00:00
5d3d6c7da3
Use symbolic constants for seek(), open(). Fixed as per PR 6057 by
...
Joseph Myers <jsm@octomino.demon.co.uk>.
1998-08-29 22:47:56 +00:00
d5ad059d0d
Remove unused function and unnecessary prototypes, as per PR 6050 by
...
Joseph Myers <jsm28@cam.ac.uk>
1998-08-29 22:40:07 +00:00
ed8412ad2b
Improved signal handling as per PR 6051 by
...
Joseph Myers <jsm@octomino.demon.co.uk>
1998-08-29 20:19:56 +00:00
e16198b7d4
DTRT if "give" is invoked without arguments. Fix contributed by Joseph S.
...
Myers <jsm28@cam.ac.uk>, closeds PR 6049.
1998-08-29 19:58:12 +00:00
62afb47308
Don't allow empty "give" command (without arguments).
...
Fixes PR 6049 by Joseph Myers <jsm@octomino.demon.co.uk>.
1998-08-28 00:44:31 +00:00
814a994a5e
Replace some homegrown string-functions with standard-<string.h>-macros.
...
Reported by Joseph Myers <jsm28@cam.ac.uk> in PR 6028.
1998-08-24 22:26:23 +00:00
5f3ed2ad7d
Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.
1998-08-24 22:07:37 +00:00
13091fe5b7
Untakable objects are marked with NULL pointers, not empty strings,
...
resulting in core dumps. Fixed as per PR 6006 by Joseph Myers
<jsm28@cam.ac.uk>.
1998-08-24 00:25:32 +00:00
2f4d86d39f
Propperly note place-change, as reported in PR 6008 by Joseph Samuel Myers
...
<jsm28@cam.ac.uk>
1998-08-24 00:22:45 +00:00
hubertf