Commit Graph

165 Commits

Author SHA1 Message Date
mrg 084c052803 quell GCC 4.1 uninitialised variable warnings.
XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..
2006-05-10 21:53:14 +00:00
mrg bc2e62d3b8 change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.
2006-05-09 20:30:15 +00:00
mrg 0c37c63edc change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.
2006-05-09 20:18:05 +00:00
christos 9a02e676ef Coverity CID 1301: Return early if we could not open /dev/null 2006-03-22 02:23:11 +00:00
christos aa1540d7a7 Coverity CID 2742: Avoid NULL deref. 2006-03-21 21:50:44 +00:00
christos 55303a4a4b Coverity CID 2307: Possible memory leak. 2006-03-18 20:25:28 +00:00
christos f04c9de45b Coverity CID 2306: Possible memory leak. 2006-03-18 20:23:51 +00:00
christos 5ac5bc844b Coverity CID 1079: Possible NULL deref. 2006-03-18 20:21:50 +00:00
christos 704b63146c Coverity CID 1080: Possible NULL deref. 2006-03-18 20:20:31 +00:00
christos 6672211d0f Coverity CID 2432: Dereference before NULL check. 2006-03-18 19:55:49 +00:00
christos 2044d4f590 Coverity CID 2671: Fix use of ifp after free. 2006-03-17 16:58:09 +00:00
wiz 1ad8067cb3 Fix typos, reported by Alexey Dobriyan ("Gathered from Linux"),
forwarded by jmc@openbsd.
2006-02-25 00:58:34 +00:00
christos 2c6eadc9ce Move WARNS=3 to the Makefile.inc, and add a little const to the remaining
programs that did not compile before.
2005-06-27 01:00:04 +00:00
xtraeme 4ad9c5a867 Kill __P(). 2005-02-05 13:47:19 +00:00
mycroft fc82ea195f PR 9431: if rnh_addradd() fails, total_routes will be wrong. 2004-07-06 23:36:24 +00:00
wiz de7136f83b usage: -F was missing the /mask part. Based on PR 26063
by Kouichirou Hiratsuka.
2004-07-06 16:43:18 +00:00
wiz a63a57aa28 Remove unimplemented and undescribed -p option from usage and man page
SYNOPSIS. Noted by Jeff Ito.
2004-05-17 15:38:20 +00:00
wiz 0a1db66278 Remove option letter from getopt string, since it does not
have a case handler below. From aaron@openbsd.
2004-05-13 00:18:46 +00:00
christos f29f4783da constification lossage (hi gimpy) 2004-04-21 19:01:17 +00:00
christos 7ed7713848 From Vernon Schryver:
Wolfgang Solfrank has explained the problem with router discovery
in `routed` in a way I can understand.

Let's assume that the configured preference of the interface is 5.
This gets converted to 0x80000005 through the use of the UNSIGN_PREF
macro.  Later on, this value gets put into the PREF macro, which
compares it against the interface metric(s) (let's assume those
values to be 0 for now).  Of course the 0x80000005, cast to int,
is much less than 0, so the clamping rule is triggered, which
gives us a value of 1.  This is then converted via SIGN_PREF into
0x80000001 and put into the message.  Certainly, this isn't what
was intended.
2004-03-27 20:50:43 +00:00
enami b3f1752123 Initialize an uninitialized variable. 2003-11-14 01:31:24 +00:00
wiz bc0e64144c Correct error in previous, noted by Nick Hudson. 2003-09-23 12:14:49 +00:00
wiz 47190e80b8 Consistently use 'RFC 1234' instead of 'RFC1234' or 'RFC-1234'.
From jmc@openbsd.
2003-09-07 16:22:20 +00:00
itojun e2c411ce3c use arc4random 2003-09-06 12:42:00 +00:00
itojun d9be8318c9 avoid FD_SET overrun. from openbsd 2003-08-13 08:51:05 +00:00
itojun efb986d740 sprintf can return negative 2003-07-12 14:36:07 +00:00
itojun e97be76fa1 strcat -> strlcat 2003-07-03 03:04:04 +00:00
itojun 16435cdb98 strcpy/sprintf cleanup. from openbsd 2003-04-21 08:54:42 +00:00
itojun 3fbac68bea use snprintf. there are more... 2003-04-15 08:20:17 +00:00
itojun 64e132e781 array seems too small 2003-04-15 07:37:34 +00:00
wiz 990562bfef .Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.
2003-02-25 10:34:36 +00:00
wiz cb647c5704 Sort sections, new sentences begin on new lines, add a missing line,
fix a typo.
2002-12-18 19:20:05 +00:00
thorpej cd81fc31ea Avoid strict alias warnings. 2002-12-06 02:18:37 +00:00
agc 19cc8c4892 Fix compilation problems on non-i386. 2002-12-01 08:19:48 +00:00
christos f93fe60ac0 sync with routed 2.27 2002-11-30 04:04:23 +00:00
wiz 09cbac4e7f New sentence, new line. From Robert Elz. 2002-10-03 15:41:44 +00:00
itojun e93a4e6b0f bitmask operation mistake audit (s/&&/&/). from openbsd 2002-08-08 15:10:51 +00:00
wiz d30d25dc1a Spelling fixes, from Sergey Svishchev in kern/16650. 2002-05-12 15:48:36 +00:00
msaitoh 039616e700 don't override LDSTATIC if NOPIC is defined. 2002-04-23 08:19:15 +00:00
ross dc5571b22e Generate <>& symbolically. I'm avoiding .../dist/... directories for now. 2002-02-08 01:21:55 +00:00
wiz 65c4d36952 Use mdoc macros instead of man ones. 2002-01-21 18:23:09 +00:00
wiz 49e6214ed8 Punctuation fix, sort sections, lose a .Pp. 2001-11-16 12:09:19 +00:00
wiz bb03964e95 Sort SEE ALSO. 2001-11-16 11:31:30 +00:00
lukem cbbd79f700 fix -Wshadow warnings 2001-11-02 05:30:56 +00:00
kleink d8ad923577 "kernel switch ipforwarding" -> "sysctl net.inet.ip.forwarding". 2001-10-01 10:31:45 +00:00
wiz 4c99916337 va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.
2001-09-24 13:22:25 +00:00
wiz b2935aaaf6 Drop argument of .Os. 2001-06-05 11:24:51 +00:00
wiz 73f545bb5b Drop arguments of .Os. 2001-06-05 11:22:41 +00:00
wiz ccb6f40539 Improve usage of `comprise' according to Webster and misc/10893
by Jim Bernard.
2001-05-06 12:29:18 +00:00
wiz 14dbdf5518 Negative exit code cleanup: Replace exit(-x) with exit(x).
As seen on tech-userlevel.
2001-04-06 11:13:45 +00:00