FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.
This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.
This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.
Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
to a 2-clause licence (retaining UCB clauses (1) and (2)), per PR
22409 from Joel Baker, approved by Theo de Raadt, and ratified by
myself - the only discrepancy being the handling of the original
clause 3 in src/usr.sbin/yppoll/yppoll.c.
Remove dom_server_port from struct _dom_binding. It's never initialised
and used in only one place, where dom_server_addr.sin_port was probably
intended.
__CONCAT("foo","bar");
actually works to concantate strings, it's because the preprocessor expands
it into "foo""bar" as separate strings, and then ANSI string concatenation
is performed on that. It's more straightforward to just use ANSI string
concatenation directly, and newer GCCs complain (rightly) about misuse
of token pasting.
Messages will still be printed to stderr if ypbind is started in debug mode.
- Don't exist if none of the servers listed in
/var/yp/binding/<domainname>.ypservers are reacheable. It's a temporary
failure that can be recovered from.
* cleanup for -Wall
* use __RCSID
the following were inspired by openbsd:
* only allow connections from reserved ports
* implement -insecure, which turns off the above restriction (required
for sunos 3.x and ultrix)
* prevent more than 100 domains from being bound at once, preventing
a denial of service attacks
This is a compromise between the Solaris 2.5 naming of this file
(/var/yp/binding/domain/ypservers and /var/yp/binding/domain/vers)
and traditional NetBSD naming (/var/yp/binding/domain.vers).
Changing to the Solaris naming makes the C library incompatible
with ypbind. While it's easy to change the C library, I don't feel
right about introducing a gratuitous incompatibility.
The current name (/var/yp/domain/ypservers) conflicts with the name
of the YP map listing slave servers for a domain.
Per discussion w/ Chris Demetriou and Luke Mewburn.
of YP servers a client should bind to, mostly verbatim, but slightly
modified for better semantics when nagging servers if a ypset has been
issued. Default to broadcast mode if no .ypservers file is present.
Documentation changes to match, slightly tweaked by Scott Reynolds and
myself.
Closes PR #1759.
- check malloc returns
- null terminate strncpy() strings
- use snprintf instead of sprintf
- pass the right arguments to the right functions
- check usage
- use err(3) and warn(3) instead of printfs.
christos