Commit Graph

50 Commits

Author SHA1 Message Date
dholland 69c3e9d213 Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?
2009-08-13 06:59:37 +00:00
dholland e63a3e7105 Assorted minor cleanup:
- use stdbool.h (partly)
  - move extern declarations of data to header files
  - use right types for calloc() wrapper
  - remove bogus casts on return values
  - remove excessive Pascal-style parentheses in conditionals
  - a couple const fixes
  - fix some typos in comments
2009-08-13 05:53:58 +00:00
dholland 7d59a3fee1 pass -Wshadow 2009-08-13 04:09:53 +00:00
dholland 72efe4fb6f Sprinkle const. 2009-08-13 03:50:02 +00:00
dholland 6c23c8ddec woops (doh!) 2009-08-13 03:10:03 +00:00
dholland f42113e362 Whitespace. 2009-08-13 03:07:49 +00:00
dholland b74af21b24 sprinkle static 2009-08-13 02:10:50 +00:00
lukem c1ceae17f0 Enable WARNS=4 by default for usr.bin, except for:
awk  bdes  checknr  compile_et  error  gss  hxtool  kgetcred  kinit
	klist  ldd  less  lex  locale  login  m4  man  menuc  mk_cmds
	mklocale  msgc  openssl  rpcgen  rpcinfo  sdiff  spell  ssh
	string2key  telnet  tn3270  verify_krb5_conf  xlint
2009-04-14 22:15:16 +00:00
lukem 98e5374ccb Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.
2008-07-21 14:19:20 +00:00
lukem 5d427989ff Convert to raise_default_signal(3). 2007-10-05 07:27:41 +00:00
lukem 9159f5b246 Support an explicit Q_error return from inquire(), which is returned
if there was an error on reading the reply.
Stops an infinite loop if you ^D the query.
2007-07-19 05:43:23 +00:00
christos 3d98aa3f4b fix spelling of accidentally; from Zapher 2006-11-24 19:37:02 +00:00
peter e263dfd62f WFORMAT is no more... 2006-10-08 17:52:28 +00:00
christos c1cd33addf Coverity CID 2331: Plug memory leak. 2006-04-09 19:27:22 +00:00
christos 5d96bf2cf0 Coverity CID 2333: Fix memory leak. 2006-04-09 19:21:26 +00:00
wiz e3fc4b66c3 Spell the plural of suffix "suffixes", not "suffices".
Inspired by PR 24400 by Todd Vierling.
2004-02-13 17:56:17 +00:00
agc 89aaa1bb64 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22365, verified by myself.
2003-08-07 11:13:06 +00:00
itojun 31d51579a3 get rid of strsave(), use strdup directly 2003-07-14 11:09:19 +00:00
itojun d91f80a702 the function is equivalent to strdup. 2003-07-14 09:41:27 +00:00
perry d60896ecaf users's -> user's (from Igor Sobrado in PR misc/19700) 2003-03-31 01:53:27 +00:00
wiz 990562bfef .Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.
2003-02-25 10:34:36 +00:00
wiz eaf8f8a4e5 Remove #ifndef'd __STDC__ code. ANSIfy. 2002-05-26 22:41:20 +00:00
ross 8bd7cb6a69 Edit -mdoc usage.
* There is no -indent option to .Bd or .Bl, although you would
  never know that from its frequent use in this tree. There is a
  "-offset indent" combination that makes sense, and you can certainly
  say "-width indent".

* Also, you can't markup the -width option argument, tho you CAN
  use a callable macro. So "-width Ar filename" doesn't make sense,
  but either "-width Ar" or "-width filename" does, as might something
  like "-width xxfilename" for a little extra space.

* There are a lot of needlessly complex hanging tag macros in man4 used
  to create simple item lists. Those should be simplified one of these
  days before someone copies and edits yet another man4 page.
2002-02-07 03:15:06 +00:00
wiz f22f495d0a Use standard headers, drop a .Pp. 2001-12-01 19:08:56 +00:00
wiz 4c99916337 va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.
2001-09-24 13:22:25 +00:00
wiz 40ac848024 Fix various misspellings of compatible/compatibility. 2001-06-11 01:50:48 +00:00
wiz e4c86f49f9 Replace some .Xr to non-existing man pages with .Ic (since we don't
even have the matching programs).
2001-05-08 17:18:04 +00:00
christos e0475d14f3 fix redundant and nested decls 2001-02-05 01:44:07 +00:00
christos e9de7ed611 fix a multitude of core dumps because most functions were not checking
the length of the word list.
2000-11-15 19:54:43 +00:00
christos 6941b7e8a4 strcmp returns an int not a ptr so don't compare to NULL 2000-11-15 19:54:12 +00:00
is 135600f947 More format string cleanup by sommerfeld. 2000-10-11 14:46:00 +00:00
mjl ec1d133cd3 Eliminate hard coded buffer sizes in fgets() statements, use
strlcpy() to avoid buffer overflows, increase filename buffer
to MAXPATHLEN. (from OpenBSD)
2000-01-14 06:53:48 +00:00
kleink 513b25c0e9 For temporary files' pathnames, check $TMPDIR before falling back to _PATH_TMP. 1999-11-06 15:11:46 +00:00
christos 32d3ded9b3 Fix serious bug with string overruns that caused error to coredump randomly
on NetBSD, and each time on other OS's. Also 0 -> NULL or 0 -> '\0' where
appropriate.
1999-05-15 19:05:13 +00:00
sommerfeld fcfb860733 Don't assume isspace(0) == 1 1999-05-15 18:46:27 +00:00
garbled 9e44e9b578 More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages.  Many more to
come.
1999-03-22 18:16:34 +00:00
christos c3203395bd char -> unsigned char 1998-11-06 23:06:38 +00:00
wsanchez d2b96d3f77 Get rid of multiply defined common symbols
langauge should be language in error.h
1998-10-08 01:29:27 +00:00
mrg e37e81a273 remove unused extern. 1998-03-30 02:19:45 +00:00
mrg 66f7b9fd72 fix compile warnings on the alpha. 1997-10-19 14:05:56 +00:00
lukem 397a8a0855 WARNSify (big job!), fix .Nm usage 1997-10-18 14:44:21 +00:00
pk f6d87734a6 NULL => 0 (Arne Juul; PR#3629) 1997-05-17 19:40:47 +00:00
lukem 4e01c5d008 use mkstemp() instead of mktemp() 1997-03-22 03:42:57 +00:00
mikel 43d35f1fb2 fix typo; from Saitoh Masanobu in PR misc/3199. 1997-02-11 06:01:54 +00:00
christos 49a4e14351 Handle long lines without core-dumping. 1995-09-10 15:55:13 +00:00
jtc 71bb6dda25 Sync with 4.4lite2 1995-09-02 05:57:23 +00:00
mycroft e9d867ef50 Add RCS identifiers. 1993-08-01 17:54:45 +00:00
mycroft dfb9caab49 Add RCS indentifiers. 1993-08-01 07:32:48 +00:00
mycroft 690cae8181 Add RCS indentifiers. 1993-07-31 15:17:49 +00:00
cgd a6cd7e84d0 added, from net/2 (patch 119). 1993-04-09 12:58:06 +00:00