Commit Graph

604 Commits

Author SHA1 Message Date
christos d067817eea From Jilles Tjoelker:
Do not move the cursor for ed-delete-next-char in emacs mode.
This makes ed-delete-next-char suitable for mapping to the <Delete> key.
Behaviour in vi mode is unchanged (for 'x').
2012-03-24 20:08:43 +00:00
matt fa835e8c8b These directories default to WARNS?=5 2012-03-21 05:37:42 +00:00
matt 6fb2a3179f Use C89 functions definitions. 2012-03-21 05:34:54 +00:00
matt f9113d007b Use C89 functions definitions.
Remove use of __P
2012-03-21 05:33:26 +00:00
christos 9b25b03245 include the NULL in the argv conversion 2012-03-11 21:15:25 +00:00
christos 75b1bb5aad use arraycount 2012-03-11 21:14:56 +00:00
christos 3c15bad9a7 PR/45843: Henning Petersen: Fix resource leak on error. 2012-01-16 14:57:45 +00:00
christos ae5295ee5d Add coverity annotations about unreachable code (Kamil Dudka) 2011-11-18 20:39:18 +00:00
christos e83c752c92 Add missing * 2011-11-18 20:38:42 +00:00
christos 36e7768bff Initialize termbuf (Kamil Dudka) 2011-11-18 20:32:00 +00:00
christos cfca73c1f8 Initialize res (Kamil Dudka) 2011-11-18 20:30:01 +00:00
christos d24c721eac check for negative return of ct_visual_char (Kamil Dudka) 2011-11-18 20:25:48 +00:00
christos e09907eccd Off by one in allocation could cause buffer overflow (Kamil Dudka) 2011-11-18 20:24:21 +00:00
christos 9bee9dd870 remove unrecheable code (Kamil Dudka) 2011-11-18 20:22:03 +00:00
christos 872b7bf4a3 easier with an int for now. 2011-11-16 01:45:10 +00:00
christos 749960097c Since Width() is used only for display purposes we don't want to pass -1 for
unprintable characters.
2011-11-15 23:54:14 +00:00
christos 6a96f344c7 Fixed misplaced parenthesis (Nirbhay Choubey) 2011-10-23 17:37:55 +00:00
christos b6f308812d fixed warnings where wint_t is unsigned. 2011-10-04 15:27:04 +00:00
christos 8c9fc8838c fix broken change (parenthesis in the wrong place). From Nirbhay Choubey 2011-10-03 14:09:38 +00:00
christos f02b490980 include <wchar.h> if we don't have wcsdup() 2011-09-28 14:08:04 +00:00
plunky 2b8aaed8cd NULL does not need a cast, here 2011-09-16 16:13:16 +00:00
christos 3d802cf59d re-enable -Wconversion 2011-08-16 16:25:15 +00:00
christos 436299cdac need err.h now 2011-08-04 14:33:05 +00:00
joerg 98ea74e048 Only use -Wconversion if GCC is actually the active compiler. 2011-08-02 17:22:02 +00:00
tron 67fb973487 Don't use "-Wconversion" with GCC 4.5 which will complain about all the
expressions where signed variables are converted to unsigned in an
expression e.g. "size_t foo = sizeof(something) * int_var;".
2011-07-30 10:07:27 +00:00
christos c11bd863f5 pass -Wconversion 2011-07-29 23:44:44 +00:00
christos 1237974a30 - fix unused params
- unconditionalize vis.h
2011-07-29 20:58:07 +00:00
christos f46176b9a9 better autoconf results 2011-07-29 20:57:34 +00:00
christos f4bf097e85 add -Wunused-parameter
Is that the right way? Perhaps WARNS=5?
2011-07-29 20:56:58 +00:00
christos 7ecb1ef25e kill ifdef notdef 2011-07-29 15:20:39 +00:00
christos b71bed95b3 KNF return (\1); -> return \1; 2011-07-29 15:16:33 +00:00
christos a13cd75612 kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations. 2011-07-28 20:50:55 +00:00
christos 56eac9ea53 fix unused variable warnings on systems without _r functions 2011-07-28 17:33:55 +00:00
christos df86a66a1c handle systems without getpwent_r 2011-07-28 17:33:39 +00:00
joerg 4104b0e782 Sync compat defines to unbreak build.
XXX Do a proper config.h update from configure
2011-07-28 05:18:43 +00:00
christos 7da8639ecc whitespace 2011-07-28 03:52:19 +00:00
christos 02479cacb5 whitespace 2011-07-28 03:48:46 +00:00
christos 47b4c27f8c whitespace and comments 2011-07-28 03:44:36 +00:00
christos d47f958456 Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.
2011-07-28 01:56:26 +00:00
christos 8cf227343c - check and don't cast malloc return
- more wide function use
2011-07-28 01:08:58 +00:00
christos 98c7cbebbc term -> terminal
XXX: need to rename key_ too.
2011-07-28 01:05:20 +00:00
christos 78cb86e064 regen 2011-07-28 01:05:00 +00:00
christos fd46b57ee4 avoid shadowed variable 2011-07-28 01:04:41 +00:00
christos 5fc21e9736 use vis.h from . 2011-07-28 00:54:26 +00:00
christos b210596944 eliminate alloca for portability
portable getpw{nam,uid}
2011-07-28 00:50:23 +00:00
christos 82edb784c6 term -> terminal
eliminate MAXPATHLEN
2011-07-28 00:49:18 +00:00
christos 0c0f23399c - fix memory allocation botch in wide strings
- check mbstowcs return code
2011-07-28 00:48:21 +00:00
christos e63c844a17 term -> terminal 2011-07-28 00:45:50 +00:00
christos 885062da0b more portability defines 2011-07-28 00:45:30 +00:00
christos c2c011fc82 term -> terminal 2011-07-28 00:45:14 +00:00
christos adb2121e55 term -> terminal
fix wide function confusion
2011-07-28 00:44:35 +00:00
christos f375da6e14 include config.h for all c files. 2011-07-28 00:43:53 +00:00
christos b723d6a65c include vis.h from dot. 2011-07-28 00:43:33 +00:00
christos df2309ca73 fix confusion with wide functions. 2011-07-28 00:43:12 +00:00
christos 5bf2e3dbda fix narrow compilation 2011-07-27 13:18:20 +00:00
christos 32d7653d74 - don't leave cursor dangling on memory failure or after clearing the list
- compute the string length to be strvis'ed after the string is encoded
2011-07-27 02:23:29 +00:00
christos c76d71fc1a fix buffer growing code. 2011-07-27 02:18:30 +00:00
christos 0da54e076e add history testing code. 2011-07-27 02:18:00 +00:00
christos 3021376b9c don't stop reading after empty lines from: Nirbhay Choubey 2011-07-26 21:03:17 +00:00
christos 047570cb9a make obvious what we are trying to do... 2011-07-09 23:54:39 +00:00
tron f5c0fd2c7b Try to fix build of port where "char" is unsigned. 2011-07-09 16:04:34 +00:00
christos c6c51b75eb Support other non-latin1 single byte character sets.
From: Alexander Barkov and Nirbhay Choubey at oracle dot com
2011-07-08 15:54:56 +00:00
mrg 0a0dd75b65 add some XXX'd -Wno-foo if HAVE_GCC >= 45.
XXX: someone should look at these.
2011-06-21 02:32:55 +00:00
mrg 493d341048 various build fixes for gcc 4.5. from chuq. XXX i'm not sure all of
these work properly wtf pointer aliasing, but there are no casts at
least...

the lib/libpuffs/puffs_priv.h is definately a real bug fix.

from chuq.
2011-06-20 09:11:16 +00:00
wiz d489035474 Markup consistency, from YOMURA Masanori. Add serial comma. 2011-04-25 22:47:27 +00:00
bouyer 6d537d7313 Fix use-after-free. Discovered by running tests with MALLOC_OPTIONS=J
(should this be the default for tests ?), pointed out by njoly@
2011-03-20 12:36:14 +00:00
christos c0ee155271 Fix argument for EL_EDITOR from Jess Thrysoee 2011-02-27 01:51:37 +00:00
joerg 9674b81ed9 Introduce __weakref_visible to handle the different required visibility
for weak references. GCC 4.2+ and Clang require static, older GCC wants
extern. Change __weak_reference to include sym. This requires changes
the existing users to not reuse the name of the symbol, but avoids
further differences between GCC 4.1 and GCC 4.2+/clang.
2011-02-22 05:45:05 +00:00
christos 01d6c84859 PR/44599: Steven Vernon: libedit acts as if no data read if editmode is turned
off because nread is uninitialized in the edit disabled case.
2011-02-18 20:53:05 +00:00
joerg 6f7bc0c1ed Deal with changes in the weak_reference semantic in GCC 4.2 and later. 2011-02-17 16:44:48 +00:00
christos 28ef40ccbd fix pasto 2011-01-28 03:41:52 +00:00
christos b2ce31d086 don't turn on editing if stdout is not a tty. 2011-01-27 23:11:40 +00:00
christos 7350622ee8 off by one in fetching history data. From: Gerry Swislow 2011-01-16 03:05:51 +00:00
wiz 3d3c5d42cb Observe the following spelling:
- wide character (noun)
- wide-character (adjective)

Inspired by jmc@OpenBSD.
2010-12-16 17:42:25 +00:00
dholland eb1ab8ee50 Improve previous to avoid changing the interface of an externally
exposed function. (But note that this function is neither documented
nor declared in any installed header file, and it probably should not
be externally exposed.) Related to PR 44183, closes PR 44186.
2010-12-06 00:05:38 +00:00
dholland 574c2fc5a2 add const, from PR 44183. 2010-12-02 04:42:46 +00:00
dholland 92417c82c1 Fix up bodgy code for printing completion matches; it used to sometimes
skip entries, print (null), run off the end of the array, or occasionally
receive SIGSEGV, and now will, hopefully at least, do none of that.

Based in part on the patch in PR 44183 from Sergio Acereda; I also
did some tidyup and fixed it to print top-to-bottom first like ls(1).
2010-12-02 04:35:17 +00:00
christos a85c37d8d9 don't increment i twice in the loop. From Michael Byrnes 2010-11-15 21:24:31 +00:00
christos 9bc86f7706 PR/43998, PR/44021: In narrow history emulation, don't treat UTF-8 character
sets specially as far as history goes since we always need to do the conversion
from narrow [history] to wide [editline].
2010-11-04 13:53:12 +00:00
christos f70a466a92 fix fd leak found by Igor Zinovik 2010-10-23 23:27:40 +00:00
christos b354315033 unbreak readline history. 2010-09-16 20:08:51 +00:00
christos 7741aae941 setup a callback to be invoked on resize buffers so that readline can
reset rl_line_buffer which unfortunately some applications use it directly.
2010-08-28 15:44:59 +00:00
christos 6e1c968db3 provide rl_on_newline 2010-08-04 20:29:18 +00:00
christos 0ccb4e68f8 refresh only on SIGCONT not SIGWINCH from Edward Sheldrake 2010-07-21 18:18:52 +00:00
christos c157529beb retry the read after sigwinch too, from Edward Sheldrake 2010-07-19 17:18:13 +00:00
christos cbd798c94b tidy up memory allocation and don't unnecessarily print "./" before names. 2010-06-01 18:20:26 +00:00
christos ca8b6091c1 Use the same hack for Solaris and MacOS/X. This is not right, we only really
support UTF-8, but it will get us going until this is fixed properly.
From Jess Thrysoee
2010-04-20 02:01:13 +00:00
christos 72c00e4a7a \033 is more portable than \e still. 2010-04-18 21:17:47 +00:00
christos df810c5405 ffs needs strings.h 2010-04-18 21:17:22 +00:00
christos d29e250074 shame on solaris that is the last OS not supporting $() 2010-04-18 21:17:05 +00:00
christos 839bac947e From Jess Thrysoee
- Fix wint_t to Int confusion
2010-04-15 00:57:33 +00:00
christos 5443e9b772 From Jess Thrysoee
- use nl_langinfo to test for UTF-8, because some locales are UTF-8 without
     reflecting it in their names.
2010-04-15 00:56:40 +00:00
christos a5b37ffc65 From Jess Thrysoee
expose ct_enc_width()
2010-04-15 00:55:57 +00:00
christos 939651fa2b From Jess Thrysoee
- NARROW_HISTORY and IGNORE_EXTCHARS should not take effect if locale is UTF-8
- account for multi byte char length in
2010-04-15 00:52:48 +00:00
christos b77d4fa5c5 From Jess Thrysoee: call setlocale so we can test UTF-8 2010-04-15 00:50:46 +00:00
christos a9dd944f6b From Jess Thrysoee: add ifndef around def of _GNU_SOURCE 2010-04-15 00:50:03 +00:00
christos f576147073 https://bugzilla.redhat.com/show_bug.cgi?id=575383
Handle EINTR properly.
2010-03-22 22:59:06 +00:00
roy 98eb889579 Userland now builds and uses terminfo instead of termcap.
OK: core@, jdc@
2010-02-03 15:34:37 +00:00
christos 6fbbcd94ce PR/42646: Joachim Kuebart: Shell crashes in libedit when window size changes
(SIGWINCH). Return NULL if el_gets() gets interrupted.
2010-01-20 01:15:52 +00:00
christos 654f9c04e7 Fix wrapper for EL_EDITOR, from Michael L. Hitch 2010-01-19 22:38:08 +00:00