Commit Graph

121 Commits

Author SHA1 Message Date
mrg 75e42fa7da remove most of the remaining HAVE_GCC tests that are always true in
the modern world.
2011-06-20 07:43:56 +00:00
wiz 35d2900127 Quote question mark so it's correctly marked up.
Problem reported by Ryo HAYASAKA in PR 42963.
2010-03-12 09:36:15 +00:00
lukem d877c4c3c0 Enable WARNS=4 by default, except for:
cpuctl  dumplfs  hprop  ipf  iprop-log  kadmin  kcm  kdc  kdigest
	kimpersonate  kstash  ktutil  makefs  ndbootd  ntp  pppd  quot
	racoon  racoonctl  rtadvd  sntp  sup  tcpdchk  tcpdmatch  tcpdump
	traceroute  traceroute6  user  veriexecgen  wsmoused  zic
(Mostly third-party applications)
2009-04-22 15:23:01 +00:00
lukem 35a4cbea60 Compare size_t vs off_t by casting both to uintmax_t 2009-04-18 06:28:19 +00:00
lukem f93f13ab6f fix -Wsign-compare issue on amd64 2009-04-11 12:55:29 +00:00
lukem 7f26f737dc fix -Wcast-qual issues 2009-04-11 12:44:29 +00:00
wiz 88ada6d2b7 Convert to mdoc. Bump date for previous. 2009-04-04 17:29:59 +00:00
perry 4cfab35c9c New feature: "?" for time specifications, means a single time selected at
random from within the range at file read time. Very useful if you
want to avoid having a fleet of machines melt a server by all trying to
contact it at a precise time every morning. See docs for details.

Reviewed by: christos, apb, vixie, others.

XXX apb suggests, quite reasonably, that ?10-16/2 should mean
something like 10,12,14,16 or 11,13,15. I'm too lazy to do it right
now, but it should be done.

XXX vixie suggests, quite reasonably, that if you're using "?" one
should delay randomly by 0-59 seconds. In the modern NTP world, you
could imagine that with a million well synchronized machines the
second just at the minute would be hit quite hard. I'm too lazy to do
it right now, but it should be done.

XXX cron needs to be updated to Vixie's cron 4.1 code.
2009-04-04 16:05:10 +00:00
gmcgarry 3c9a95916d Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC. 2008-08-29 00:02:21 +00:00
matt f09665b707 Fix inconsistent prototype. Do some constification. 2008-02-16 07:26:00 +00:00
wiz ec17d82b0c Describe /var/log/cron. Based on PR 37640 by Randolf Richardson. 2007-12-29 13:21:57 +00:00
martin cabebfa313 Remove -or0s argument - cron should not pretend to be smarter than the
local mail admin. Should fix PR bin/37226.
2007-11-02 14:31:27 +00:00
christos d0e5eb6a35 from Anon Ymous:
Remove a "(void)&" construction: iop is used by the parent
and always set after the vfork().  Also flag some parameters __unused
so this will compile with -Wextra.
2006-12-18 20:11:10 +00:00
christos dae6a9eb32 sprinkle volatile. 2006-10-22 21:00:21 +00:00
christos b01ee2f8e2 Add Auto-Submitted header per RFC 3834 from OpenBSD 2006-08-15 16:18:52 +00:00
elad 51d6ae51f1 mark strcpy as safe 2006-06-17 00:16:13 +00:00
reed 4cfce7b21f Check return value for setgid(), initgroups(), and setuid().
Log error and exit if failure.
2006-06-05 16:41:34 +00:00
christos 842c42957f check the return value of setsid. 2006-06-03 16:02:30 +00:00
christos 2a741c25dc Coverity CID 3777: Free envp in the success case too. 2006-05-24 21:43:43 +00:00
christos bcab7c84bf Coverity CID 3778: set tmp to NULL to shutup coverity. 2006-05-24 21:42:25 +00:00
christos 1ab2316281 use warn/warnx instead of perror/fprintf
use get/set progname.
2006-05-21 19:26:43 +00:00
mrg aadd7d4847 sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4. 2006-05-11 23:16:28 +00:00
mrg 084c052803 quell GCC 4.1 uninitialised variable warnings.
XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..
2006-05-10 21:53:14 +00:00
christos 313c1811bf Coverity CID 1774, 1773: Don't leak open file descriptors or leave temp
file turds on error.
2006-04-25 18:02:02 +00:00
wiz 5d1e8b2745 Fix some typos. 2006-02-25 02:28:55 +00:00
heas be21025dae Set SIGCHLD to SIG_DFL in cron's child; instead of SIG_IGN, which alters the
behavior of wait() causing cron_pclose() to return bogus status and the logging
of bogus status in debug mode.
2005-08-17 22:35:20 +00:00
christos 102bb7e88c - eliminate a goto.
- cast more returns to void.
- use waitpid instead of wait() to wait for our process, not accidentally
  wait for other children.
- return exitstatus only if exited, and return the termination signal otherwise.
2005-07-31 17:52:01 +00:00
he 63104d4c13 Initialize s, name and name_end in load_env() to appease -Wuninitialized.
Marked with XXXGCC for sparc64 (found while compiling for it).

Reviewed by lukem.
2005-06-07 13:43:52 +00:00
chs 7bbdd188e1 appease gcc -Wuninitialized on hp700. 2005-06-05 19:08:28 +00:00
xtraeme 7e70b71d91 Kill __P(), use ANSI function declarations, constify; WARNS=3 2005-03-16 02:53:55 +00:00
christos cf31b04130 PR/10957: Ed Ravin: Cron does not execute the last line in crontab if
the trailing newline is missing. Fix by changing crontab(1) to not
allow installation of crontab files with missing trailing newlines.
2005-03-04 16:46:28 +00:00
christos 36e8d2b792 PR/28744: Ed Ravin: crontab with fewer than 3 comment lines dumps core
in crontab -l.
The problem is that the skip_header code has a side effect of trying to
write to the new temporary cron tab if we run out of comments. Since we
don't have an output file in -l, we core-dump trying to fputc to NULL.
Simplify the logic so that we don't write in the skip_header function,
and we always return the first character after the comment lines to the
caller, skipping the '\n'.
2004-12-22 00:49:14 +00:00
dsl 78f35b774e Add (unsigned char) cast to ctype functions
Add fpurge(stdin) before prompt - unexpected question.
for usr.bin/crontab
2004-10-30 17:14:36 +00:00
dsl cfe7f80ff0 Add (unsigned char) cast to ctype functions 2004-10-29 20:51:11 +00:00
jmmv 25298658a7 Fix indentation of a line in the sample file. 2004-09-02 11:41:27 +00:00
wiz 08abac00be New sentence, new line; use Ev for environment variable;
use "its" where correct; use standard section headers; add missing .Os.
2004-03-20 18:54:33 +00:00
jdolecek ac4f86b471 log also the time when the job finishes (with CMD FINISH tag), and change
the tag for job start log to ``CMD START''

adresses PR bin/22201 by John Hawkinson
2004-03-20 10:42:00 +00:00
jdolecek 098027866f when encoding the command for printing in logs, use strvisx() instead
of homegrown code, and skip leading white space
2004-03-20 10:38:34 +00:00
jdolecek 580f716bfc document -x - adresses PR bin/22201 by John Hawkinson
reference rc.d framework instead of rc/rc.local
sprinkle couple more .Pa's
2004-03-20 10:04:13 +00:00
jdolecek 251e6a062a convert to mandoc, bump date 2004-03-20 09:18:03 +00:00
enami 0790d0f46f Set DO[WM]_STAR if we mean `*' so that @yearly/@monthly/@weekly are
interpreted as documented/expected rather than "0 0 1 1 0-7" /
"0 0 1 * 0-7" / "0 0 1-31 * 0" respectively.  Fixes PR#24547.
2004-02-27 23:22:09 +00:00
jdolecek c98a00090a minor constification 2004-02-07 12:31:15 +00:00
jdolecek 0d3df21f35 use system() to spawn editor, so that it's possible to use EDITOR
setting which includes options; this reinstates functionality lost in rev 1.18
2004-01-04 09:09:56 +00:00
is 0534dcc9c5 Report read errors, too. 2003-12-07 16:50:43 +00:00
is 2ee5b37e8f rewind() does an implicit clearerr(), as demanded by e.g. 1003.1. Thus,
we have to check for writing errors before rewind()ing.
2003-12-03 13:12:53 +00:00
atatat 4e34961a55 Jobs specified for @reboot are only popped into the job queue at cron
startup time ("reboot" of cron, not the system), so okay_to_go() must
always say they are good to go.  Otherwise they never will.  All other
meta-timetags pertain to regular times, so they are (or were)
unaffected.

Problem noted by tron and successfully assigned to me by perry.
2003-08-13 03:51:15 +00:00
agc 326b2259b7 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22366, verified by myself.
2003-08-07 11:25:11 +00:00
hubertf e7469f38ad In "crontab -l", suppress the header lines, just as "crontab -e" does.
OK'd by Christos Zoulas and Paul Vixie.
Fixes PR 21705.
2003-06-23 22:36:02 +00:00
christos c7e6b87cad PR/3713: Aaron Brown: crontab fails with signals.
While I am here eliminate forking a shell for the editor.
2003-04-20 01:24:05 +00:00
jdolecek d70973544d use setproctitle() instead of uppercasing ProgramName
this makes the ps display nicer, and also avoids uppercasing the cron program
name in logs
idea from FreeBSD
2003-04-10 14:14:15 +00:00