Commit Graph

125 Commits

Author SHA1 Message Date
matt 05f7d79518 Fix incorrect prototype. 2008-02-16 07:26:54 +00:00
pooka 584065ec56 Check against errors when reading trace device. CID 4561. 2007-09-08 15:34:23 +00:00
tls 4147a3c54a Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry.  RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros.  Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default.  Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
2007-05-28 12:06:17 +00:00
hubertf 889da1779b * Don't include headers twice
* Remove a few trailing whitespaces
 * Rearrange and join to one #if for some headers

Patch contributed by Slava Semushin <slava.semushin@gmail.com>
in private mail.
2007-01-16 17:32:04 +00:00
hubertf a383094e4a Remove duplicate #include <errno.h>
From Slava Semushin <slava.semushin@gmail.com> in private mail
2007-01-16 12:07:08 +00:00
christos 0bc3d9d62f Coverity CID 3792: Avoid double free; while I am here avoid NULL deref. 2006-09-27 21:39:15 +00:00
martin ad53adb7c1 Make "entries" optional - so that `echo system > /etc/isdn/isdnd.rc; isdnd`
works.
2006-05-27 20:11:14 +00:00
christos d62ef54061 Coverity CID 1442: Update the table, and use the table size instead of
hard-coded constant; fixes static buffer overflow.
2006-05-24 23:51:39 +00:00
christos 4f8217f507 Coverity CID 796: Add an extra test to pacify coverity. 2006-05-24 23:44:34 +00:00
christos aecdec648e Coverity CID 834: Add a test to pacify coverity. 2006-05-24 23:43:11 +00:00
christos 84a9244669 Coverity CID 1753: don't leak fp's. 2006-05-24 23:41:44 +00:00
mrg 10c621b36e sprinkle some -Wno-pointer-sign for now. 2006-05-11 08:55:10 +00:00
mrg 0dc9fb54b5 u_char -> char in one place. 2006-05-11 07:08:40 +00:00
mrg 0c37c63edc change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.
2006-05-09 20:18:05 +00:00
elad 615bdca25f Fix three off-by-ones found by Coverity, CID 1489. 2006-03-17 21:10:02 +00:00
elad 0ba17c4726 /dev/i4b -> /dev/isdn. From ulfdoz. 2005-12-26 19:11:17 +00:00
lukem bbd17ef8af Don't attempt to use an uninitialized variable in a debug message.
Detected with gcc -Wuninitialized.
2005-06-02 05:54:44 +00:00
dsl c32255add6 Add (unsigned char) cast to ctype functions
Change validation of -t<number> to use return ptr of strtoul (not isdigit)
2004-10-30 08:31:39 +00:00
dsl 91fe418901 Add (unsigned char) cast to ctype functions 2004-10-30 08:19:30 +00:00
martin 812e909997 Make "local-phone-dialout" optional.
This makes creating standard config files for peers that do not care about
the calling number easy and helps roaming users.
2004-05-06 21:13:28 +00:00
pooka 3c143ba9cd * Make isdnd unlearn that an isdn interface has two B channels, so that it
is possible to support 30-channel primary rate adapters.
  Mostly from jml@cubical.fi via FreeBSD.
* Follow kernel naming trend: bri => isdnif
2004-03-28 20:49:22 +00:00
martin 3259bd6456 Bail out with a proper error message when mandatory configuration entries
are missing. While there improve error messages slightly.
Inspired by PR kern/24807.
2004-03-21 16:31:22 +00:00
jmc 6fe4ead562 Convert to usage of UUDECODE_FILES and standardize on filename extension 2004-03-19 08:07:22 +00:00
grant cacf2d0f45 s/netbsd.org/NetBSD.org/i 2003-11-12 13:31:07 +00:00
itojun fdd3180d27 minor KNFs 2003-10-06 09:43:27 +00:00
itojun e45e8f9d58 use bouded string op as much as possible 2003-10-06 09:18:41 +00:00
itojun d8db5e11b1 sprintf -> snprintf. hints from Thorsten Glaser 2003-10-06 04:19:41 +00:00
itojun c4beb9648d sync w/ header file changes 2003-10-03 23:27:31 +00:00
wiz 1d02c95b43 Bump date for previous (hi antti!). New sentence, new line. 2003-09-25 09:37:32 +00:00
pooka 8ac798e2ed Document the controller/firmware keyword. 2003-09-25 09:21:48 +00:00
pooka fdd5c1261b our isdntrace uses /dev/isdntrc<n>, not /dev/i4btrc<n> 2003-09-11 14:14:31 +00:00
pooka 8446050ba0 Add support for loading firmware to a controller using the firmware
keyword in the controller section (kernel counterpart already exists).

similar to what's in FreeBSD
2003-09-05 13:31:03 +00:00
wiz ff81956eb8 New sentence, new line. 2003-06-27 19:09:02 +00:00
wiz d43e332f1e setup -> set up. 2003-05-14 12:11:03 +00:00
martin 6d77f1d081 Add some error handling for an ioctl - the old code could loop tightly if
the peer closed a socket unexpectedly.
This addresses one of the issues Frank Kardel patched (differently) in
PR kern/21448, after clarification from Frank via private mail.
2003-05-13 07:07:37 +00:00
martin 59b588f4a2 The FIONREAD ioctl() expects an int parameter.
Noticed by Frank Kardel in PR 21448.
2003-05-08 08:35:40 +00:00
martin a9c8af8af0 Passing the address of a timeval.tv_sec to localtime() is wrong on ports
where time_t != long.
From Frank Kardel in PR 21448.
2003-05-08 08:32:39 +00:00
wiz 38ae31a7c0 Fix device names, from Sergey Svishchev in PR 21485. 2003-05-07 08:01:08 +00:00
thorpej b393c94e79 Shuffle a bit to allow some compilers to optimize symbol references
more effectively.

From Ian Lance Taylor.
2003-05-02 04:29:03 +00:00
wiz 1b8a3850d5 A-Law -> A-law. 2003-04-16 12:53:08 +00:00
martin 03b03281c7 Fix buffer overrun noticed by Markus Dolze on the freebsd-isdn mailing
list.
2003-04-06 21:07:09 +00:00
wiz 68caa698b2 Respect the law: Use A-law and mu-law as spellings as far as easily possible.
Inspired by Igor Sobrado in PR 19680.
2003-04-06 18:20:07 +00:00
wiz 990562bfef .Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.
2003-02-25 10:34:36 +00:00
wiz b517ab4402 .Nm still needs "". 2003-02-23 23:40:47 +00:00
wiz 45ad5c9584 successful with only one l. 2003-01-06 12:46:05 +00:00
thorpej 0f8f1290fe Avoid conflict with reserved identifier "log". 2002-12-06 15:00:14 +00:00
mycroft f90ffa1f0c select() -> poll() 2002-09-20 15:23:06 +00:00
mycroft bead6c7cd4 Use STDIN_FILENO/STDOUT_FILENO as appropriate. 2002-09-20 15:23:05 +00:00
mycroft 1ae4d43ce6 select() -> poll() 2002-09-20 15:15:49 +00:00
pooka 87a8e425d5 make usrdevicenames match reality better
from Ilpo Ruotsalainen
2002-09-13 14:29:15 +00:00