Commit Graph

13456 Commits

Author SHA1 Message Date
mrg
e9aad8d696 avoid assert() and simply return errors. 2017-06-03 21:31:14 +00:00
mrg
99f85f4578 update copyright strings. 2017-06-03 21:28:48 +00:00
maya
f4f257830c Don't prefix include guards by _, suggested by riastradh 2017-05-31 22:02:06 +00:00
maya
42fe4e0ac7 The previous change might actually be less generic.
prepend by _MAKE, to be sure.
2017-05-31 21:15:47 +00:00
maya
0de6456123 Use less generic include guards 2017-05-31 21:07:03 +00:00
riastradh
ef315f7931 Remove MKCRYPTO option.
Originally, MKCRYPTO was introduced because the United States
classified cryptography as a munition and restricted its export.  The
export controls were substantially relaxed fifteen years ago, and are
essentially irrelevant for software with published source code.

In the intervening time, nobody bothered to remove the option after
its motivation -- the US export restriction -- was eliminated.  I'm
not aware of any other operating system that has a similar option; I
expect it is mainly out of apathy for churn that we still have it.
Today, cryptography is an essential part of modern computing -- you
can't use the internet responsibly without cryptography.

The position of the TNF board of directors is that TNF makes no
representation that MKCRYPTO=no satisfies any country's cryptography
regulations.

My personal position is that the availability of cryptography is a
basic human right; that any local laws restricting it to a privileged
few are fundamentally immoral; and that it is wrong for developers to
spend effort crippling cryptography to work around such laws.

As proposed on tech-crypto, tech-security, and tech-userlevel to no
objections:

https://mail-index.netbsd.org/tech-crypto/2017/05/06/msg000719.html
https://mail-index.netbsd.org/tech-security/2017/05/06/msg000928.html
https://mail-index.netbsd.org/tech-userlevel/2017/05/06/msg010547.html

P.S.  Reviewing all the uses of MKCRYPTO in src revealed a lot of
*bad* crypto that was conditional on it, e.g. DES in telnet...  That
should probably be removed too, but on the grounds that it is bad,
not on the grounds that it is (nominally) crypto.
2017-05-21 15:28:36 +00:00
abhinav
ae7adf81e7 Correct the man page reference 2017-05-18 16:33:57 +00:00
roy
12d2934b32 _ti_database now includes the database extension so don't duplicate it. 2017-05-16 09:21:54 +00:00
sevan
1f7af9ec92 Remove more _KERNTYPES definitions in rump components. 2017-05-11 13:20:02 +00:00
sevan
6b31f116cc With the removal of HAVE_REGISTER_T from rumpuser_port.h, _KERNTYPES does not
need to be defined. This allows register_t to be typedef'd to RUMP_REGISTER_T
without conflict, as highlighted in PR kern/52206.
2017-05-11 04:33:14 +00:00
sjg
cd14dec36c Main_SetObjdir: ensure buf2 is in scope 2017-05-10 22:26:14 +00:00
sevan
979875ac74 Revert previous change so builds can resume.
_KERNTYPES needs to be defined for NetBSD builds to succeed.
_KERNTYPES must not be defined for buildrum.sh builds to succeed.
2017-05-10 08:48:46 +00:00
sevan
9204518573 Do not define _KERNTYPES as this breaks build with buildrump.sh due to
conflicting types for register_t.
Closes PR kern/52206
Steered in the right direction by christos.
2017-05-10 01:11:51 +00:00
christos
9a21bc9318 fix the tools build. reported by Utkarsh Anand 2017-05-05 12:21:28 +00:00
roy
55c5fc2560 Remove __VALGRIND__ guard .... just clean up. 2017-05-04 14:07:33 +00:00
roy
e04b9c5743 Whitespace and formatting. 2017-05-04 13:53:36 +00:00
abhinav
5652c781e4 Teach man -p to respect the MANPATH environment variable and the -M option.
Currently, `man -p` generates its output based on the value of the _default tag
in man.conf. However, man(1) modifies its search path based on the value of the
MANPATH variable and the list of directories specified via the -M option. In such
a case, `man -p` does not represent the correct search path. This commit intends
to fix this.

This change has the side effect that now the output of `man -p` will also include
the machine class specific subdirectories (such as man8/x86), while previously it
did not. The output would include subdirectories only for those machine classes
which are specified in the man.conf file.

Also, with this change, it is possible to run makemandb(8), by setting MANPATH
environment variable (e.g. env MANPATH=/usr/share/man makemandb).

Patch reviewed by wiz@
2017-05-02 14:19:23 +00:00
christos
3cc72f8888 reset signal handler before returning. 2017-05-02 03:29:14 +00:00
abhinav
28a2c1c134 Free the buffer allocated by getline(3).
ok christos.
2017-04-30 13:45:06 +00:00
abhinav
be698a8c12 Add missing words. 2017-04-30 09:00:49 +00:00
abhinav
bf229e85c5 Fix comment indentation at couple of places: Use \t instead of space 2017-04-27 09:31:50 +00:00
pgoyette
a6cdaa71c9 Add crypto stuff on top of what we already have, rather than replacing! 2017-04-22 05:32:40 +00:00
christos
f067861335 fix conditional 2017-04-21 23:49:17 +00:00
christos
1b32fecb19 new libarchive need crypto. 2017-04-21 23:06:18 +00:00
sjg
63284db849 Str_Match: fix closure tests for [^] and add unit-test. 2017-04-21 22:15:44 +00:00
joerg
c57cca78b1 Use libarchive 3.x interface and not obsolete 2.x versions. 2017-04-20 13:11:35 +00:00
sjg
28591a203d We cannot tollerate things like trailing /.. etc in .CURDIR
so only accept -C arg "as is" if it contains no relative components.
2017-04-20 03:57:27 +00:00
sjg
d5e210c750 We cannot use buf as both src and destination for snprintf. 2017-04-19 04:54:17 +00:00
maya
2d8e6e9f14 Use correct header for SIZE_MAX. from a.rin 2017-04-17 13:29:07 +00:00
riastradh
eeefcaaf18 Omit needless XXX comment. 2017-04-17 00:02:45 +00:00
riastradh
9719b6dc16 Justify the last unjustified assertion here.
Sprinkle a few more assertions to help along the way.

(Actually, it was justified; I just hadn't made explicit the relation
to the value of fdpos that all two callers specify.)
2017-04-16 23:50:40 +00:00
riastradh
9b8e93bfa9 Emphasize that MAX_WINDOW_SIZE is bounded by the maximum uint32_t.
Since we store window sizes in uint32_t, the maximum had better fit
in uint32_t!
2017-04-16 23:43:57 +00:00
riastradh
f4d0632c19 Plug memory leak.
CID 978372
2017-04-16 21:39:49 +00:00
riastradh
b682286be9 Plug memory leak in ParseTraditionalInclude. 2017-04-16 21:38:38 +00:00
riastradh
a882a64c0e Plug memory leak.
CID 978370
2017-04-16 21:37:37 +00:00
riastradh
91528f07b9 Make it clearer that this is not a memory leak.
CID 978369
2017-04-16 21:35:08 +00:00
riastradh
ffc8790f33 Plug memory leak in JobPrintCommand.
CID 978366
2017-04-16 21:23:43 +00:00
riastradh
ea5fc7e0b0 Plug memory leaks in Dir_FindFile.
CID 978364
2017-04-16 21:14:47 +00:00
riastradh
eeadb7df8c Clarify that assignment is for effect, not truth of value.
CID 977502
2017-04-16 21:04:44 +00:00
riastradh
0b16a13b06 Guarantee no arithmetic overflow. 2017-04-16 21:03:13 +00:00
riastradh
c2373570bc Replace dead conditional by assert.
CID 975995
2017-04-16 20:59:04 +00:00
riastradh
76e0a5c432 Check fcntl return values out of paranoia.
CID 975277
CID 975278
2017-04-16 20:57:14 +00:00
riastradh
bef219d9d2 Check return value of fseek.
CID 975275
CID 975276
2017-04-16 20:49:09 +00:00
riastradh
73e03a372c Assert archive member syntax. Cite who guarantees it. 2017-04-16 20:38:18 +00:00
dholland
3e81c5349d nowadays function specifiers go in declaration_specifiers
(not after the declarator)
2017-04-16 20:20:24 +00:00
riastradh
dcafbc2650 Factor out parts of cached_realpath.
This wacky API confused Coverity (CID 1405167) and is no good for
human readers either.
2017-04-16 20:14:49 +00:00
maya
f79348a46a Use bmake_malloc where we don't test the return value of malloc currently.
Appeases coverity.
2017-04-16 20:00:58 +00:00
riastradh
9660a1b334 Use, don't kludge, MAKE_ATTR_UNUSED.
CID 1300234
CID 1300237
CID 1300238
CID 1300245
CID 1300255
CID 1300267
CID 1300284
2017-04-16 19:53:58 +00:00
christos
62446aa148 Redo the statistics through an indirection array and put the definitions
of the arrays in pfkeyv2.h so that they are next to the index definitions.
Remove "bogus" comment about compressing the statistics which is now fixed.
2017-04-13 16:38:31 +00:00
sjg
66fdc11da2 Add test case for :M[^A-Z] 2017-04-13 16:23:39 +00:00