Commit Graph

1354 Commits

Author SHA1 Message Date
groo cdb6398a72 Credit Alan Perlis for ``give him a lollipop'' programming language quote.
Hat tip: Jerry Leichter.
2006-04-26 00:52:21 +00:00
christos 1ce9f4326d Coverity CID 3032: Prevent double free: Next to the call of page_more()
there is a comment saying /* does fclose */, but the next line calls
fclose(fp);. Go figure.
2006-04-24 20:08:54 +00:00
snj a640fe8c43 It's "its." 2006-04-24 19:00:29 +00:00
snj bf5ceaae16 It's "its." 2006-04-24 18:00:53 +00:00
drochner d8da09bdaf fix buffer overflow (CVE-2006-1744), from Debian 2006-04-20 10:57:26 +00:00
groo bfdee53d40 Grammar nit. Never mind that it's still not true. 2006-04-06 19:47:23 +00:00
christos a7a74df4fa Coverity CID 2788: If no room gets returned, don't try to place a monster. 2006-04-02 00:13:29 +00:00
christos 8710461ab4 Coverity CID 2791: Fix file pointer leak. 2006-04-02 00:08:12 +00:00
jnemeth e61c7de467 Coverity CID 2452: possible negative array index; CID 1518 and CID 1517: possible overrun of static array 2006-03-30 05:04:22 +00:00
jnemeth 1c3223f073 Coverity CID 1288: possible negative array index 2006-03-30 04:41:15 +00:00
jnemeth 67f465476e Coverity CID 993: dereference of NULL pointer 2006-03-30 04:27:24 +00:00
jnemeth cc2349eefc Coverity CID 1293: not checking for an error return 2006-03-30 04:19:38 +00:00
jnemeth fa4599a211 Coverity CID 1287: not checking for error return 2006-03-30 04:10:04 +00:00
jnemeth 995d4b331f Coverity CID 1327: check for error return 2006-03-30 01:32:27 +00:00
jnemeth a3fb5aa745 Bah! Compare, don't assign! 2006-03-30 01:31:13 +00:00
jnemeth dce307414d Coverity CID 1328: check for error return 2006-03-30 01:28:46 +00:00
jnemeth f413c2ba58 Coverity CID 1326: check for error return 2006-03-30 01:25:52 +00:00
jnemeth db7b70f433 Fix Coverity issue 891 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:21:07 +00:00
jnemeth 83f277c49a Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
Approved by Christos@.
2006-03-29 01:19:51 +00:00
jnemeth 2ad8d2c6cd Fix Coverity issue 2584 -- USE_AFTER_FREE and issue 889 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:18:39 +00:00
christos 93eceea780 Add missing parens. 2006-03-22 15:24:52 +00:00
christos 549b5ed9d1 Simplify (Masao Uebayashi) 2006-03-22 05:03:10 +00:00
christos 8b7bfd1f64 Coverity CID 692: Another && that should be ||. Boy... 2006-03-22 04:24:14 +00:00
christos 1990635dbb Coverity CID 558: && should be obviously || 2006-03-22 04:22:05 +00:00
christos df3594a46a Coverity CID 2735: Remove dead code. 2006-03-21 20:25:55 +00:00
christos dd3fe9b2dc Coverity CID 2737: Handle linked-lists properly. Use calloc instead of malloc
so that we don't end up storing garbage accidentally and the next pointer is
initialized. If there is an inconsistency in the file abort instead
of dereferencing NULL.
2006-03-21 17:14:15 +00:00
rtr 90b0b10c77 remove duplicate #include <stdlib.h> 2006-03-20 12:32:21 +00:00
he 3ac2299da5 Now that we use exit(2), we need to include <stdlib.h> for its definition. 2006-03-19 12:09:39 +00:00
christos c08f926ecb include <stdlib.h> to get a prototype for exit 2006-03-19 06:02:50 +00:00
christos e92d4ac1fa Coverity CID 1197: Don't pass -1 to close. 2006-03-19 01:00:35 +00:00
christos 4140928aa1 Coverity CID 1467: Elide static buffer overflow. 2006-03-19 00:56:12 +00:00
christos 989c7cd825 Coverity CID 868: Fix possible NULL deref (after INFTIM passes :-) 2006-03-19 00:50:28 +00:00
christos 2197ff9156 Coverity CID 980: Prevent an impossible NULL point deref. 2006-03-19 00:41:46 +00:00
christos 0e8c6c24b2 Coverity CID 2073: Fix memory leak. 2006-03-19 00:37:15 +00:00
christos 0255deb434 Coverity CID 999: Prevent NULL deref. 2006-03-19 00:32:18 +00:00
christos d7b2adb029 Coverity CID 695: Remove impossible condition. This changes the scoring as
it was probably intended originally.
2006-03-19 00:29:27 +00:00
christos c29d845a03 Coverity CID 998: Possible NULL pointer deref. Actually this was a bug
where a house to be sold would be skipped. Change the sell loop to be like
the buy side loop.
2006-03-19 00:19:31 +00:00
christos ad05902b98 fix typo 2006-03-19 00:18:47 +00:00
christos a195251302 Coverity CID 1004: Fix NULL deref. 2006-03-19 00:05:05 +00:00
christos db0d71974c Coverity CID 1005: Fix NULL deref and incorrect variable use. 2006-03-19 00:03:18 +00:00
christos abe5f75745 Coverity CID 1443: Prevent static overrun. 2006-03-19 00:00:19 +00:00
christos f25329586b Coverity CID 827: Prevent NULL pointer deref. 2006-03-18 23:54:17 +00:00
christos 02549e79e2 Coverity CID 1699: Fix memory leaks. 2006-03-18 23:51:51 +00:00
christos ffe2beb426 Coverity CID 2544: Fix memory leak. 2006-03-18 23:44:05 +00:00
christos f09b76be8d Coverity CID 1786: Close file. 2006-03-18 23:38:12 +00:00
christos f80221a1cd Coverity CID 570: Remove impossible check. 2006-03-18 23:35:51 +00:00
christos 44fa0e017a Coverity CID 1195: Check for possible negative index. 2006-03-18 23:33:38 +00:00
christos 8319a6a7da Coverity CID 777: Fix NULL pointer deref and de-obfuscate code. 2006-03-18 23:31:19 +00:00
christos c873d1eb57 Coverity CID 1230: Remove spurious close(). 2006-03-18 23:25:30 +00:00
christos e0b976a0ae Coverity CID 1294: Avoid negative variable used as index. 2006-03-18 23:23:33 +00:00
christos 2a67d42737 Coverity CID 1295: Don't allow cchose to return a negative number. It is
used as an index.
2006-03-18 23:14:45 +00:00
rtr 969e2244d4 fclose() open FILE * even though we are returning to fail anyway.
silences coverity, CID 1590 / run 5
2006-03-18 09:40:46 +00:00
rtr 0c0f6ae5dc don't access out of bounds element of static alloc array.
found by Coverity, CID 1519 / Run 5

XXX possible that intention was to start with i = 0.
2006-03-18 05:16:46 +00:00
abs a3edf3e145 If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up
2006-03-18 01:43:52 +00:00
abs e0d5463807 add more "ifdef notdef" around unused sections - addresses Coverity CID 564 2006-03-17 23:36:38 +00:00
abs b4f3ebd201 Add a missing bp->b_score not null check - addresses Coverity CID 1003 2006-03-17 23:34:37 +00:00
abs 2c2c60a0ef if getpwuid() returns null, print out the uid rather than dereferencing
Addresses Coverity CID 930
2006-03-17 23:22:59 +00:00
abs f0ff12503e Fix overrun in players[] array. Addresses Coverty CID 1457 2006-03-17 23:15:02 +00:00
abs b317f83344 If getpwuid() returns null, its not usually a good idea to dereference
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
2006-03-17 23:11:47 +00:00
abs f4f2f41178 Call fclose() appropriately if there is a problem with the save file.
Coverty CID 2063
2006-03-17 23:04:01 +00:00
simonb 5cfbf7bf76 Use MKPRIVATELIB instead of NOLINKLIB/NOMAN/NOPIC/NOLINT. 2006-02-25 12:04:23 +00:00
simonb feaaa5ed4c Change DPADD from LIBTERM (which doesn't exist) and LIBCOMPAT (which it
doesn't use) to LIBTERMCAP (which it does use).
2006-02-25 11:56:51 +00:00
wiz f19f5c87cc Fix typo in the instructions. 2006-02-25 02:06:08 +00:00
wiz 5fcd22e873 Remove duplicate and uncredited "Plan for the Improvement of English
Spelling", which is also in the file "fortunes".
2006-02-25 01:40:22 +00:00
jnemeth df4822d1f0 Correct The Hitchhiker's Guide to the Galaxy entry about dolphins as per
page 119 of the book.
2006-02-20 03:00:27 +00:00
elad c53cd0c067 moduli utils moved from games to usr.bin. 2006-01-24 19:01:45 +00:00
elad c1ef323e1a Remove qsiefe/qsafe from games. Will be put back in usr.bin. 2006-01-24 18:51:20 +00:00
wiz cfebedec7e Bump date for previous. 2006-01-22 21:22:30 +00:00
wiz 5e86832ad4 Drop trailing whitespace. Remove superfluous .br. 2006-01-22 00:32:54 +00:00
elad 271a419065 better handle ^d in getinp(), so we dont loop endlessly.
i have no idea why i wanted to play this game.
2006-01-20 21:40:08 +00:00
elad 202106feb9 oops, make this install to /usr/games and not /...
noted by hannken@, thanks.
2006-01-20 14:19:31 +00:00
elad d4bdf04e28 Descend to moduli too. 2006-01-19 23:25:19 +00:00
elad 0e71d2c846 Add qsieve and qsafe, two programs used for generating the moduli file.
These were written by William Allen Simpson and submitted in PR 21983,
and are added with minor adjustments and nits from christos@ and myself.

Approved by christos@ and groo@.
2006-01-19 23:23:58 +00:00
garbled 19fe295582 Fix some minor buglets in wump:
1) Don't put two pits in the same room.
2) Don't put bats and pits in the same room.  (you will never hit the bat)
3) Don't start the player in a room with a pit or bad, if possible.  Some
caves are so crowded the loop may go on forever, so we give up after 100
tries to put them in a safe location (as long as it's not with the wumpus).
4) Make the manpage reflect reality WRT the default number of rooms.

Bug #3 pointed out by salo.
2006-01-19 21:20:35 +00:00
garbled b2fc76e5cb Apply patch from PR bin/26501 to fix hang in wump if you play too many
games in a row.  Also modify change made in rev 1.18 to work correctly.
take_action() returns 1 if the player dies, causing the game to allways
exit after any death, now the game correctly asks if the player would
like to play again.
2006-01-19 20:15:31 +00:00
christos 1e463fb58d Simplify error checking. 2005-11-19 18:01:42 +00:00
rillig c64619d462 Replaced one instance of err() with errx(), as the value of errno might not
be correct at that time.
2005-11-19 14:22:21 +00:00
mjl 7c7f1fe0ab Typos, duplicate words, consistent formatting. 2005-10-29 22:49:36 +00:00
mjl 4866f93355 Remove trailing spaces, double spaces between words, fix some typos. 2005-10-29 22:35:41 +00:00
mjl 6b25b3147c Correct typos. 2005-10-29 17:04:10 +00:00
rillig 40245fbcfd Removed the unnecessary #include <ctype.h>. 2005-10-18 20:13:04 +00:00
rpaulo 4b939f034f Fix two lines which were broken by previous commit. Noticed by Thomas
Klausner.
2005-10-12 15:33:41 +00:00
rpaulo 099795b92c misc/31566: Jaap Boender: update African and Asian capitals to the
current situation.
2005-10-12 15:14:27 +00:00
rillig 1e30fb707b Added an empty line to conform to KNF. 2005-10-08 18:18:18 +00:00
wiz 0c305c1a7e Drop trailing whitespace. 2005-09-15 02:10:37 +00:00
wiz d9f5a9df01 Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.
2005-09-15 02:09:41 +00:00
perry 995abc5571 Sulfur|Sulphur -> Sul[f|ph]ur 2005-08-14 21:19:35 +00:00
perry 2b5ff6359d Sulfur -> Sulfur | Sulphur 2005-08-14 21:17:37 +00:00
perry 5b7baeda3b er, forgot the C{a}esium change in the last 2005-08-14 20:31:34 +00:00
perry 0874287eda 1) Update atomic weights.
The weights here are taken from
     http://www.iupac.org/publications/pac/2003/7508/7508x1107.html
   and have been rounded to four significant figures in all cases.
   In the case of elements that have no isotopes stable enough for
   reasonable measurement, numbers have been updated from Zumdahl,
   "Chemistry", Fifth edition and are presented (as before) in parentheses.
2) Cesium is now C{a}esium
3) A number of new elements have been added at the end of the periodic
   table.
2005-08-14 20:28:25 +00:00
perry a2a84a1ed5 Aluminum -> Alumin{i}um
Aluminium is really the official name, but doing it this way allows
entry of either answer.
2005-08-14 19:34:50 +00:00
perry 4156b28f30 Sulphur -> Sulfur
Although the traditional spelling in commonwealth countries is
"Sulphur", the official IUPAC name of the element is "Sulfur", and
even the Royal Society of Chemistry now spells it "Sulfur".
2005-08-14 17:45:17 +00:00
rpaulo 07b524b43f Added a missing '-' in score list output. 2005-08-10 19:21:21 +00:00
rpaulo b0282a1ea0 Pass lint(1). 2005-08-10 17:53:28 +00:00
rpaulo 16a8e8c2e7 Enable WARNS=3. 2005-08-10 17:52:56 +00:00
rpaulo 279b6fba65 Fixed an output bug where a new-line was added due the usage of puts(3). 2005-08-10 16:10:51 +00:00
rpaulo e58060915c Pass lint(1). 2005-08-10 14:02:26 +00:00
rpaulo 2c43d92fd8 Enable WARNS=3. 2005-08-10 14:02:10 +00:00
christos e31432ec85 add a new style cast to memcpy. 2005-08-09 15:17:41 +00:00
rpaulo dc2f26bcaa Enable WARNS=3 and pass lint(1).
ok christos@
2005-08-09 09:15:23 +00:00