fe5990acd7
Print time_t as long long, not long.
2008-02-24 05:16:46 +00:00
6dc3dcbc38
Use strtoll rather than strtol to read the -r argument, so it will work
...
for wider time_t. Also mark a timed-related y2038 lossage for whenever
someone figures out the best way to shoot timed.
2008-02-24 04:49:45 +00:00
9b21141213
Set "ftent" to NULL in in ftree_arg() after we call fts_close(), so that
...
it isn't used later on in ftree_sel() after it's been free'd.
OK christos@ (and for the interesting test case).
2008-02-18 15:54:48 +00:00
4498b1fe25
Fix inconsistent definitions
2008-02-15 17:26:06 +00:00
f04ccd71b4
Set unique mode for the history, so that repeating a command doesn't
...
spam the history.
2008-02-13 12:57:16 +00:00
da86f0e587
Add a CPUID keyword; idea and some of the code from Anon Ymous
2008-02-10 17:47:59 +00:00
899c734b12
Conform to XCU Section 2.8.2 (Exit Status for Commands)
2008-01-21 06:43:03 +00:00
76e0b9a57a
Code cleanup:
...
- Removed case '?' before default in switch
- Don't forget to close opened decriptors when malloc() fails
- Hold vfork() result in variable with pid_t type (instead of int)
Sent ages ago by Slava Semushin <php-coder@altlinux.ru> in private mail.
2008-01-16 11:43:34 +00:00
cfdef6ecba
Teach set_ftime about symbolic links, because it has to know: on some
...
Linux systems, when we build as a tool we think we have lutimes but it
doesn't work on some filesystems at runtime. A bit ugly but effective
and without use of AC_TRY_RUN in the tool build. Tidier (than mine)
set_ftime reorganization from christos.
2008-01-10 04:24:51 +00:00
2ecdf58c2c
Remove systrace. Ok core@.
2007-12-31 15:31:24 +00:00
ef266ed897
Wordo fix, noted by jmc@openbsd.
2007-12-28 14:32:50 +00:00
ac14332299
Fix argument confusion, noted by drochner.
2007-12-27 12:59:56 +00:00
0c0bc4573a
__attribute__((__noreturn__)) to __dead
2007-12-24 16:11:50 +00:00
16d01d9a96
prtstat: PRIdMAX -> jd as suggested by Joerg Sonnenberger.
2007-12-22 00:23:36 +00:00
c7bc0cd0aa
don't cast 64bit values to u_long.
2007-12-21 06:43:26 +00:00
90ee124aaf
This should have been all on one line anyway - and hey, it fixes my build
...
issue.
2007-12-18 07:25:00 +00:00
8b0f9554ff
convert __attribute__s to applicable cdefs.h macros
2007-12-15 19:44:37 +00:00
bcf893f432
use __RCSID()
2007-12-12 22:55:42 +00:00
861900d761
Fix typo in comment.
2007-12-02 21:36:44 +00:00
73f0c10536
Minimally sort options; use Dq; new sentence, new line.
2007-12-02 21:14:49 +00:00
2da3ed1c7d
Minimally sort options; use Dq.
2007-12-02 21:13:23 +00:00
8e547d329f
Compat pecoff uses the standard netbsd system call interface.
2007-11-10 14:41:51 +00:00
2f3bd6bcd6
netbsd32_SYS_MAXSYSCALL -> NETBSD32_SYS_MAXSYSCALL
2007-11-09 15:40:42 +00:00
acce89e796
Improve -l description. From jmc@openbsd.
2007-11-07 22:36:35 +00:00
bb6c89afbf
Kill another use of PZERO.
2007-11-06 00:44:46 +00:00
e942f6d60e
PR/37243 - Joerg Niendorf -- fixup botched addition of -i option
2007-10-29 11:22:59 +00:00
d13505e0de
Add missing -e option. From OpenBSD.
2007-10-26 17:45:26 +00:00
5952a904ed
- Add -0 and -V to pax_usage().
...
- Add -k to tar_usage().
2007-10-26 16:38:12 +00:00
82c330f342
Remove extra space from -T option in SYNOPSIS.
2007-10-26 16:35:59 +00:00
e2c7784538
Sync SYNOPSIS with usage() (correct location of -P).
2007-10-26 16:31:16 +00:00
c710611df5
Add -N to usage.
2007-10-26 16:21:25 +00:00
eaef8d4ad7
Touching up the permissions to preserve set-ID bits is appropriate
...
only in the case where the destination did not previously exist, and
necessary only when -p isn't given.
Closes PR bin/30188.
2007-10-25 03:51:14 +00:00
ea03f830b4
make -s alter the default format rather than doing parsefmt.
...
it allows users to use -o to replace it later.
2007-10-24 12:10:11 +00:00
54aef6aada
Rename "csh.a" (the appendix of the document) to csh.ap: the .a suffix
...
is a bit of a nuisance when using cvs import and export and, of course,
clashes with .a for library archive as well.
2007-10-18 18:26:31 +00:00
db822d2217
Convert to using raise_default_signal(3).
2007-10-05 07:22:23 +00:00
8b19d01fcd
Needs errno.h if !gcc.
2007-09-15 14:33:05 +00:00
6fc16fbc88
Document "emul" keyword. Fixes PR 36935.
...
Also sort list of keywords, and bump date.
2007-09-09 10:35:32 +00:00
37ac06be56
add a keyword "lname", to print l_name.
2007-09-01 16:54:39 +00:00
8e0c5879e7
- Cleanup for sleep.c:
...
+ mark two functions as static
+ remove case '?' in switch() before default
+ use return instead of exit() in main() function
+ use constants EXIT_SUCCESS/EXIT_FAILURE instead of 0/1
- In man sleep(1):
+ cleanup example
Patch submitted by Slava Semushin <php-coder@altlinux.ru> in private email.
2007-08-18 00:41:52 +00:00
16b3db7a9b
Fix some grammatical errors in man pages.
...
Patch supplied by Joerg Niendorf in PR misc/36707, thanks.
2007-07-30 18:01:41 +00:00
bd8009e530
Don't call P_ZOMBIE(struct kinfo_proc2), it's p_stat field contains
...
lwp states, not process states!
Since the times are filled with zeros for zombie processes the check
before assuming teh process time is zero is moot - delete it.
Fix the other chact to test the p_realstat.
Fixer PR kern/36295
2007-07-28 17:05:50 +00:00
fede0a77fc
kill MFSNAMELEN
2007-07-17 20:03:10 +00:00
b79c2ef26a
no need to have cshbool; just make them int
2007-07-16 18:26:09 +00:00
94ae12d450
Fix '-Ph' segfault; from Greg Woods
2007-07-16 14:39:53 +00:00
ec01a4a425
PR/36650: Michael van Elst: Get rid of bool, because csh uses bool as a small
...
int.
2007-07-16 14:07:00 +00:00
593a9183f0
Rename bool -> cshbool; despite the name, bool actually holds values other
...
than 0 or 1. Fixes PR/36650.
2007-07-16 02:26:50 +00:00
7b060c43f2
exposure of bool elsewhere in the code requires the addition of stdbool;
...
in addition, proc.c cleverly has a variable that was initially defined "int",
but had in the actual declaration "bool". oops.
2007-07-10 00:30:23 +00:00
84c48917b8
spacing fixes from Geoff Wing
2007-07-03 14:39:47 +00:00
b7fac28c5b
In sig_cleanup(), attempt to reset the signal handler to the default
...
and raise the appropriate signal, so the correct wait status is
returned to the parent.
2007-07-03 10:20:09 +00:00
4cac80e3e4
In the SIGINT handler, explicitly display a summary and then raise the
...
default SIGINT handler to exit, rather than exit(0) and relying upon the
atexit() to display the summary.
Per SUS6.
2007-07-03 05:25:25 +00:00
7893935666
remove descriptions of some states. ('A', 'S', '>')
...
- they are wrong. (madvise is not vadvise)
- they don't exist anymore.
2007-06-25 00:24:01 +00:00
3c769789fa
PR/36534: Greg A. Woods: test(1) doesn't do -r and -w quite right
...
Use stat(2) instead of access(2) per POSIX.
2007-06-24 18:54:58 +00:00
2554aff24b
PR/36531: Greg A. Woods: another very helpful DEBUG TRACE() call for execve()
...
failures in /bin/sh
2007-06-24 18:36:23 +00:00
205a4b0786
PR/36536: Greg A. Woods: stty(1) should mention tty(4)
2007-06-24 18:03:00 +00:00
57bbaf572b
PR/36546: Aleksey Cheusov: problems with 8-bit input in /bin/ksh, needs to
...
call setlocale()
2007-06-24 18:00:49 +00:00
c1686632e0
PR/36535: Greg A. Woods: rm(1) should present user:group the same way as
...
chown(8) et al
2007-06-24 17:59:31 +00:00
546dff6580
PR/36533: Greg A. Woods: minor doc fixes for sh(1)
2007-06-24 17:57:56 +00:00
98d594125d
PR/36541: Greg A. Woods: fix -P option, and add solaris -g option.
2007-06-24 01:52:46 +00:00
9a8238c82f
Remove a "CFLAGS+=-g" that seems to have snuck in with no good reason.
2007-06-22 03:24:16 +00:00
8da3353686
Fix sh -c 'true && ! true | false; echo $?'
...
Add some more TRACE((...)) calls to aid such debugging.
Fixes PR bin/36435
Clearly no one tried this test when the changes of rev 1.31 and 1.44 were done!
2007-06-07 20:57:59 +00:00
7dd0dd9e6b
modify a comment in previous change
2007-06-06 13:21:28 +00:00
8c64f063a1
Apply SODA Nuriyuki's patch for multibyte support.
...
Based on soda-revised2.patch (in private mail) with a change from
soda on tech-userlevel.
Ok christos@.
2007-06-05 17:48:19 +00:00
4147a3c54a
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
...
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.
This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.
This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.
Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
2007-05-28 12:06:17 +00:00
35d9d3fddf
Make sure we don't run over the end of the argument array while scanning
...
for input. This can happen if we have a unary not without an argument. When
we scan for the argument, we are already at the NULL element of the argument
array. Then when we scan ahead for a -a or -o, we end up testing the next
element after the NULL.
2007-05-24 18:47:08 +00:00
41d09357f2
Instead of putting a full copy of realpath here, use the system's realpath.
2007-05-24 18:18:43 +00:00
a59f86365c
coverity CID 4378: fix bogus comparison that lead into dead code.
2007-05-16 20:49:35 +00:00
8e85c1baf1
Use the same wording for '-p' as for other file related tests.
2007-05-15 22:00:51 +00:00
206f418235
PR/36275: john at iastate dot edu: tar -s modifies symlink targets
...
- This is explained in a comment in pat_rep.c inside mod_name(). I did not
want to change the default behavior, so I added another modifier "s" which
when set, the pattern will not modify the symlink destination.
- While here I fixed another bug that was introduced before by the fix in
PR/35257 where the renaming was happening twice since we called rep_name
twice.
- Finally if we are renaming hard of soft-link targets print the renames for
those too.
2007-05-04 21:19:36 +00:00
8ce1f4fff2
fix typos
2007-04-29 20:23:34 +00:00
135e711f26
bump date.
2007-04-23 18:41:11 +00:00
702d1ca548
PR/36194: Greg A. Woods: add a '-V' flag to pax for verbose summary without
...
listing (and other minor fixes)
2007-04-23 18:40:22 +00:00
4796b4c1d9
escape * and - properly
2007-04-13 00:40:11 +00:00
3851cea520
Use IEC 60027-2 prefixes for 2^n based prefixes.
2007-04-13 00:38:45 +00:00
06519c05da
PR/36092: B K: algorithmic inefficiency in bin/test/test.c:t_lex
...
test(1) scans for "operators" linearly in an array using strcmp() to
find a match. Since the list of "operators" is fixed, split them
into one and two character ones, and ones that start with a `-' and
ones they don't. This way we can optimize the compare function to
just check for one or two characters. Sort and use bsearch(3). We
could have used a single sorted array and bsearch(3), to save some
complexity, but I decided to be a bit fancier.
2007-03-28 01:47:25 +00:00
faafdc7e21
Document that shell arithmetic now uses intmax_t. Document that
...
variables in shell arithmetic don't need "$" signs.
2007-03-25 06:56:43 +00:00
1a20cbd95e
WARNS=4
2007-03-25 06:30:37 +00:00
91ce988bec
Make /bin/sh use intmax_t (instead of int) for arithmetic in $((...)).
2007-03-25 06:29:26 +00:00
548cdc0050
s/intialized/initialized/
2007-03-17 13:51:46 +00:00
7ce5824ba3
Remove unused ctype.h
...
From: Slava Semushin <php-coder@altlinux.ru>
2007-03-10 01:16:17 +00:00
bbe065310a
EROFS is not a critical error in a "mkdir -p".
2007-03-08 17:01:30 +00:00
c2a791c7b8
mm, void * arithmetic.
2007-03-04 09:23:32 +00:00
271dc0c3c3
No functional changes. Cleanup time printing code so it can be used
...
elsewhere in the tree.
2007-02-24 21:29:13 +00:00
f5e7ca2447
Revert the changes done after newlock2 merge, except for the removal of
...
the now unused LSDEAD state. The current kernel headers are now
source-compatible with pre-newlock2 kernel headers again.
Approved by Andrew Doran.
2007-02-17 22:49:56 +00:00
9da5e43f4d
Since interpreting ELF binaries as shell scripts is not very useful, and
...
since the current error message is less than helpful, improve it.
2007-02-15 12:02:59 +00:00
75cf88ee58
Allow files whose name starts with a dash be moved across filesystem
...
boundaries.
This fix was inspired by the recent -froot zero day exploit for Solaris.
2007-02-15 09:57:16 +00:00
8966ad6a93
Further changes to use compat process flags mapped by sysctl. To be
...
revisited soon.
2007-02-10 18:20:12 +00:00
401499f30e
Sync with kernel changes introduced by merging the newlock2 branch.
2007-02-09 22:08:48 +00:00
4977bdb149
Remove 'l'. Those who do not learn from history are doomed to repeat it.
2007-02-08 03:57:53 +00:00
d8ec0012f2
fix bug
2007-02-07 22:17:46 +00:00
de788b88f5
Many users needlessly maintain the alias 'l' (or 'll') for 'ls -l'. We
...
should ease the burden on our users and supply a default system which is
modern and has a full complement of the features they expect (or even some
they don't -- more features don't hurt any one after all).
Suggested by perry@ in <87wt2uxhbx.fsf@snark.piermont.com> and submitted
for discussion to some NetBSD developers, who suggested that rather than
my own idiosyncratic 'll', 'l' was a much better name.
It may prove possible to merge this code with 'ls' in the future.
2007-02-07 21:56:07 +00:00
d6cabf29ac
Initial import of colorls to add 'l' functionality to system.
2007-02-07 21:43:44 +00:00
cd788d025e
* Prevent out-of-bounds read tsptype if a packet with
...
an unknown msg_type is received.
* Check the received packet size.
* Use strncpy() instead of strlcpy() so that we don't
send gibberish from the stack.
* No need to bind().
* htons()/htonl() use uint16_t/uint32_t not u_short/u_long.
2007-02-04 22:21:53 +00:00
1b1ee3c7ce
Use size_t not int for strlen().
2007-02-04 22:11:13 +00:00
622f4b424e
Applied patch by Arto Huusko from PR bin/24753 to append a slash to "."
...
and ".." instead of skipping over them fixing completion for patterns
like ".*" and "..*".
2007-01-28 22:30:12 +00:00
26a246a095
* Escape '?', '[', ']' like other meta characters.
...
* Partial fix for completion when '[' is in the way.
* Addresses PR bin/22846.
2007-01-28 20:20:25 +00:00
ecc8aad21d
Committed patch from PR bin/34755: Append a slash when expanding ~user
...
to user's home directory.
2007-01-28 20:01:02 +00:00
330b2b8ebd
Improve wording of -a description. From FreeBSD via Zafer Aydogan.
2007-01-28 09:56:13 +00:00
e977a74585
Fix for PR bin/35432:
...
* The flags "crtux" are mutually exclusive for tar.
* The flags "ipt" and "oA" are mutually exclusive for cpio.
2007-01-16 19:06:41 +00:00
30760cbdc7
PR/35410: Valeriy E. Ushakov: /bin/sh mishandles shell function definitions
...
with function names that are not plain words
1. remove the escape annotations from the function name.
2. check if the function has a valid name before storing it.
2007-01-13 18:58:26 +00:00
555693c1aa
- Applied patch from PR bin/35408 by Andreas Wiese.
...
- Use EXIT_FAILURE instead of 1.
- Use return instead of exit() at the end of main().
- Use sizeof() instead of BUFSIZ.
2007-01-13 11:51:59 +00:00
1d470e84d6
fix whitespace nits (space -> tab)
2006-12-26 00:13:24 +00:00
bda881e00b
Add -E to SYNOPSIS. Fix typo. Bump date for previous.
2006-12-23 09:43:47 +00:00
a54fe38a0d
fix a volatile variable; from Anon Ymous
2006-12-18 00:37:33 +00:00
3697550e70
Don't depend on lubutil if we're building host tools. Fix tools build on
...
non-NetBSD hosts.
2006-12-16 12:59:16 +00:00
6f4d1070fd
pass lint; from Anon Ymous
2006-12-15 22:45:34 +00:00
f6dadfcd98
fix an unused variable warning. From Anon Ymous
2006-12-15 20:22:33 +00:00
32232db57f
remove two (void)&foo; which are ot needed. From Anon Ymous
2006-12-15 20:22:06 +00:00
d9cd708017
PR/35257: Andreas Gustafsson: tar(1) opens excluded files
...
Apply the file modification function in the input files so that we can
de-select matched patterns.
2006-12-14 23:18:11 +00:00
0a97c3f688
Complete the move of string_to_flags() and flags_to_string() from the
...
bin/ls sources to libutil:
o Bump libutil minor version number
o Fix uses to include <util.h> to pick up the function definitions
o Fix most uses of flags_to_string() to release the now-malloc()ed result
2006-12-14 20:09:35 +00:00
29ff6ed16a
The "#ifdef UNUSED_BLOCK" in stat_flags.c wasn't so unused after
...
all -- it was used by the mtree source. So, instead do an "#ifdef
MTREE", and define that one when building mtree.
2006-12-14 17:54:19 +00:00
78509e7f31
Pass lint. From Anon Ymous
2006-12-14 14:15:26 +00:00
7700f97e62
Use C99 initializer.
2006-12-10 17:33:01 +00:00
ddbf1b0dd9
Sync with OpenBSD systrace 1.6d.
...
XXX: Some of the compat-linux systrace is disabled.
From elad.
2006-12-10 01:22:02 +00:00
1730a98675
Drop trailing whitespace.
2006-11-26 16:40:44 +00:00
5c056f6785
s/apparant/apparent/, from Zafer.
2006-11-24 22:54:47 +00:00
3d98aa3f4b
fix spelling of accidentally; from Zapher
2006-11-24 19:37:02 +00:00
ab56b9a702
getdate -> parsedate
2006-11-20 20:33:33 +00:00
c8226bf504
getdate is in libutil.
2006-11-17 22:11:28 +00:00
583dd15916
no names in params.
2006-11-15 17:00:09 +00:00
8ddd07b65e
fix build with objdirs
2006-11-15 16:59:52 +00:00
aa62ece776
Add -d option, similar to gnu date.
2006-11-15 16:55:18 +00:00
5d27a9d665
Add -j flag to not actually change the clock, just parse the date given
...
(if any) and then display it in the format given. Matches similar -j
flag functionality in FreeBSD/OpenBSD.
Change requested by George Georgalis on netbsd-users.
While I'm here, disambiguate the letters in the date string, by using
the same option letters as used by strftime(3).
2006-11-15 03:10:01 +00:00
ccc92a707d
fix the sort order too.
2006-11-14 20:27:10 +00:00
ce725e8fad
Fix signal list generation, from Jukka Salmi
2006-11-14 19:10:55 +00:00
28fb298561
Added missing F_GETLK, F_SETLK, F_SETLKW to print_fcntlcmd().
2006-11-12 23:29:37 +00:00
d0a868f481
Add support for printing the emulation of the process.
2006-10-29 22:32:53 +00:00
1d3c56521c
Applied patch from PR bin/34790 so that ~/.kshrc is mentioned.
2006-10-24 18:30:25 +00:00
5b08cf393d
c99 initializer
2006-10-16 00:43:00 +00:00
18243309bd
c99 initializers
2006-10-16 00:37:55 +00:00
272937609b
sprinkle volatile.
2006-10-16 00:36:19 +00:00
3fccf7e09e
c99 initializers
2006-10-16 00:31:47 +00:00
573bd5e5dd
add missing inititializer
2006-10-16 00:11:22 +00:00
d2bca38017
use c99 initializers
2006-10-16 00:07:32 +00:00
88e26c5a37
sprinkle volatile
2006-10-15 23:57:21 +00:00
640b35e022
c99 initializers
2006-10-15 23:55:30 +00:00
dd94284f1e
Add -i to usage.
2006-10-13 20:37:10 +00:00
9dedcd8f8b
Remove trailing whitespace.
...
Remove a partially duplicated sentence.
2006-10-09 21:31:29 +00:00
93bbf8101f
PR/32759: Ulrich Heilmann: Output of cat -s -n is wrong
...
Applied patch from David A. Holland, thanks!
2006-10-08 21:52:56 +00:00
e7fd82468c
Make it clear that multiple sort keys may be specified.
...
Closes PR 34271.
2006-10-07 10:22:21 +00:00
cf245f1ee7
PR/22799: Hiramatsu Yoshifumi: Add -i option to /bin/ln
...
Slightly modified patch applied, thanks!
2006-10-07 10:05:25 +00:00
ed23b39f46
PR/34265: dieter roelants: pax truncates archive when appending fails.
...
Patch applied, thanks!
2006-10-07 09:53:20 +00:00
9b5118f13d
PR/28450: David H. Gutteridge: date(1) does not validate its input and
...
accepts and processes impossible dates
Patch applied, thanks!
2006-10-07 09:34:46 +00:00
ab28bede4c
Prefix "Syntax Error" with the program name, if the command name is not
...
available. At least this way we get an idea of what program gives us the
message.
2006-10-04 15:00:38 +00:00
103401b052
Avoid .No if easily possible.
2006-10-03 02:15:16 +00:00
9ff8e2d57f
Add some markup missed in previous.
2006-10-02 20:54:27 +00:00
7c5fcf623a
Set the width in the correct data structure. (Fix error in previous.)
2006-10-02 18:43:13 +00:00
b9f435a549
Document changes to -o and -O options, and improve markup.
2006-10-02 17:57:01 +00:00
d9463bc15b
* When all columns are given null customised headers, the blank header
...
line is not printed at all. This is specified in P1003.1-2004
(SUSv3), and is useful.
* Customised headers may contain embedded space, commas and equals
signs. To specify multiple customised headers, use multiple -o or -O
options. This is specified (for "-o", not for "-O") in P1003.1-2004
(SUSv3), and is useful.
* When a column is given a null (blank) customised header, it keeps its
default minimum width. This is specified in P1003.1-2004 (SUSv3), and
seems harmless.
* Fix a bug that made it impossible to print the same keyword multiple
times, with different customised headers each time. (Previously, the
last customised header was used for all instances of the keyword.)
* Make the behaviour of "-O" more useful. The first -O option adds
the default keywords only if there have not yet been any formatting
options, and multiple -O options now insert their keywords in adjacent
positions. Now {ps -j -O %cpu} is like {ps -j} with one extra column;
Previously, it would have had all the columns implied by "-j", plus
all the default columns, plus the extra column specified by "-O".
* Convert from home-grown linked lists to SIMPLEQ lists.
Discussed in tech-userlevel.
2006-10-02 17:54:35 +00:00
7eef11b485
Revert previous (==) - not worth the trouble.
2006-09-24 13:24:08 +00:00
8fea60435c
PR/34499: mac at S dot culver dot net: ls allocates more memory than needed
...
Applied patch, thanks!
2006-09-23 19:54:53 +00:00
f090cf7468
PR/33396: Christian Biere: Global Warming may be caused by mv(1)
...
Applied patch, thanks!
2006-09-23 16:54:13 +00:00
0331d1430a
Use macro for HTML output.
2006-09-23 11:24:44 +00:00
dff6308718
Bump date for previous.
2006-09-23 11:22:10 +00:00
acd3797c82
PR/16827: Giorgos Keramidas: addition of EXAMPLES section to
...
basesrc/bin/cat.1
Applied patch, thanks!
2006-09-23 00:01:39 +00:00
cfbe6aa48d
PR/33635: Anne Bennett: Document 'a' and 'A' flags in ls(1).
...
strmode(3) already documented these, so use the description from there.
2006-09-22 23:00:32 +00:00
f9278bfbec
Allow '==' as synonym to '=', just like our ksh and bash do.
...
This also affects the sh(1) builtin test command.
2006-09-22 22:15:24 +00:00
b41feff50f
fixes for installing into a case insensitive $DESTDIR
...
when files may have hard links to a a name that only differs by case
- change install to unconditionally remove its temporary file
when installing hard links with -r. This avoids problems when
built with posix rename(2) semantics and reinstalling an existing
hard link.
- rework hard link targets in bsd.man.mk and bsd.links.mk
to use makefile constructs instead of shell constructs
- always reinstall hard links that may have case conflicts, even
when MKUPDATE=yes, this ensures that they get added to METALOG
- remove man pages which were hard linked to themselves in libform
- remove improper hard link command for existing man page in libkrb5
- fix libl's makefile to include bsd.lib.mk at end
- remove shell quoting in link target for test's [.1 man page
2006-09-11 22:24:09 +00:00
1719403bf2
Fix typo, update date.
...
Fixes PR/34472
2006-09-04 20:30:36 +00:00
ccd5bfd356
fix formatting of df -h; from Zafer.
2006-09-04 16:32:57 +00:00
e41d3cdc7d
Bump date for previous.
2006-09-03 00:24:05 +00:00
1763875ada
New sentence, new line. Bump date for previous.
2006-09-02 23:28:32 +00:00
10ed3a58a9
factor out the code that does numeric parsing into a function and check for
...
errors properly.
2006-09-02 20:00:09 +00:00
e442e57e36
Add description on "discard" character.
...
Sort control characters by the Vxxx numbers in termios.h.
2006-09-02 15:10:22 +00:00
0590732532
Document new -P behaviour
2006-08-25 11:08:50 +00:00
c9432db8c8
Only remove the file if the file can be successfully
...
overwritten. Old code would remove the file regardless of
whether the overwrite was successful or not.
New behaviour:
carpy: {12} touch moo ; chmod 444 moo
carpy: {13} ls
moo
carpy: {14} rm -P moo
rm: moo: -P was specified but file could not be overwritten
carpy: {15} ls
moo
carpy: {16}
ok: christos@, joerg@ & tech-userlevel@
2006-08-25 11:00:40 +00:00
c58b829dda
Set the 'not a parameter' flag when we skip initial whitespace.
...
Otherwise:
./sh -c 'x=" "; for a in $x; do echo a${a}a; done'
is processed as a single empty parameter (instead of no parameters).
Should fix the breakage I introdiced in rev 1.75 and PR/34256 and PR/34254
2006-08-22 18:11:42 +00:00
06cdcd1106
PR/34255: dieter roelants: Remove mention of -p f.
2006-08-22 17:42:19 +00:00
a6fdd24769
- detect buffer overflow.
...
- if we have a trailing slash, don't add another one.
2006-08-21 23:09:50 +00:00
413b7762c2
Rework the code changes from revisions 1.69, 1.70 and 1.74 so that the code
...
behaves correctly.
As far as I can tell, "x$@y" now expands correctly, as does IFS=:; set -$IFS.
Fixes PR/33472 (again) and PR/33956
2006-08-21 21:30:14 +00:00
eae5877e02
from zafer: you can have either -k or -h but not both since it does not make
...
sense.
2006-08-21 19:08:47 +00:00
b65b7f50b1
-h and -[mgk] are mutually exclusive. Only use the last specified. [from zafer]
...
Use one variable instead of 3 flags to hold the scale, so that we don't have
to reset each flag.
2006-08-21 19:05:14 +00:00
e6c35f2090
2 fixes from Elad:
...
1. fix the symlink issue mentioned in:
http://marc.theaimsgroup.com/?l=openbsd-tech&m=115513754417683&w=2
2. handle socket(2) versioning.
2006-08-21 01:35:11 +00:00
a0cb2a839d
don't include program name when calling err()
2006-08-17 10:03:53 +00:00
d59f01f8fb
initialize dne variable in the beginning, then move the resetting of
...
this variable down into the second (ie post-order) pass to make cp
pass all regression tests again.
2006-08-15 23:03:51 +00:00
af4d285682
Avoid errors like "cp: /foo/bar/directory" exists if cp(1) is used to
...
copy multiple directories and the first one doesn't exist in the
target directiry but another one (e.g. the second) does.
2006-08-15 13:06:02 +00:00
1775a62964
Fix sentence fragment that somehow got into the long comment about rm -P.
2006-08-14 20:38:13 +00:00
8c4dec8fa5
don't call get/set progname when we are a shell built-in.
2006-08-04 19:07:55 +00:00
c338573fdf
use getprogname() instead of argv[0], because some programs that execv, pass
...
the full path in argv[0] instead of just the basename. In reality, those
programs should be fixed (hello gdb for example).
2006-08-04 14:38:58 +00:00
8a487b533d
PR/34055: Kevin Massey: Date uses a fixed 1K buffer for strftime
...
but does not check when strftime fails because the buffer is too small.
Our implementation of strftime does not NUL terminat the buffer
on failure (it does not have to; the results are undefined), so
garbage gets printed. Use a dynamically allocated buffer instead.
2006-07-23 20:39:10 +00:00
471c8a8e68
return functionality backed out yesterday after fixing the bug I had
...
introduced before. A regression test will be added to src/regress
shortly.
2006-07-16 16:22:24 +00:00
d8c803bc48
The last commit introduced a bug. Revert until that's found and fixed.
2006-07-15 20:42:55 +00:00
2b5fd7fd97
As suggested on tech-userlevel:
...
"-R" claims:
-R [...] Created directories have the same mode as the corre-
sponding source directory, unmodified
by the process' umask.
Make this actually true.
In addition, make '-P' (no symbolic links are followed) apply even if
'-R' is not specified. This allows users to overwrite symbolic links
with files and/or to copy symbolic links over a file without indirecting
through the link (ie a copy of a link turns the target into a link, not
a copy of the file pointed to by the source).
2006-07-15 02:09:47 +00:00
334f3f5949
apply a little -O0 with GCC4 and vax...
2006-07-01 05:54:35 +00:00
67a8ed80ce
PR/33834: Bucky Katz: Crossbuild on FC5:sort doesn't handle '+' field
...
specifications
2006-06-27 12:27:27 +00:00
a8b3562160
PR/33775: YAMAMOTO Takashi: /bin/sh doesn't accept "(" before case patterns
2006-06-20 15:57:44 +00:00
84b3179a34
Adapt date(1), the netsettime function, to new return value from socket(2)
...
when the address family is unsupported.
2006-06-14 16:35:16 +00:00
460f8d8a0c
PR/33699: Kevin Massey: use strlcpy to prevent stack overflows.
2006-06-11 16:15:20 +00:00
0e765f005a
When expanding "$@" add a \0 byte after the last argument (as well as all
...
the earlier ones) so that a separator is added before it when it is empty.
This wasn't needed before a recent change that chenged the behaviour of
trailing whitespace IFS characters.
Fixed PR/33472
2006-05-20 13:57:27 +00:00
62faec262e
Don't free random memory; thanks gcc-4.
2006-05-14 01:09:03 +00:00
a7679aa75e
Fix two uninitialized variables with XXX: GCC.
2006-05-14 01:05:42 +00:00
c5d3cabfdd
Coverity CID 3365: Fix inverted logic!
2006-05-13 21:58:51 +00:00
f88f667da4
Coverity CID 3367, 3368: Avoid NULL deref.
2006-05-13 21:54:13 +00:00
4f633ea02a
Coverity CID 3368: Fix memory leak.
2006-05-13 21:48:00 +00:00
16464dcda5
Coverity CID 3369: Fix memory leak.
2006-05-13 21:42:45 +00:00
2701e5b9be
Coverity CID 3330: Initialize uninitialized variable.
2006-05-13 21:22:32 +00:00
78b76e5792
Coverity CID 3331: Remove impossible test.
2006-05-13 21:18:57 +00:00
e80f354dab
Coverity CID 3384: Don't close -1.
2006-05-13 19:47:22 +00:00
aadd7d4847
sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4.
2006-05-11 23:16:28 +00:00
084c052803
quell GCC 4.1 uninitialised variable warnings.
...
XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..
2006-05-10 21:53:14 +00:00
4d375f236f
rename exp2() to csh_exp2(). (bah, we don't even have an exp2())
2006-05-10 21:14:48 +00:00
15dc85722d
Make the change for bin/31548 to set $PWD on shell startup non-fatal if
...
the current directory doesn't exist.
2006-05-04 11:16:53 +00:00
ec2162bd79
Avoid double free.
2006-04-27 13:25:21 +00:00
6ce96df0b7
Coverity CID 2993: Fix memory leak.
2006-04-24 20:00:31 +00:00
8a8f572953
Coverity CID 2994: Don't leak memory in the perm case.
2006-04-24 19:58:20 +00:00
f2ec0dc9a2
Coverity CID 2995: Fix memory leak.
2006-04-24 19:53:08 +00:00
a640fe8c43
It's "its."
2006-04-24 19:00:29 +00:00
bf5ceaae16
It's "its."
2006-04-24 18:00:53 +00:00
da09d1a838
PR/33281: Martin J. Laubach: Prevent core-dump on "echo abc | { }". bash
...
prints and error and ksh prints nothing. We go the ksh way.
2006-04-18 14:44:05 +00:00
c5d25686e0
PR/22995: Sergey Svishchev: If we are cd'ing around and we have directories
...
with relative paths, convert the directories to absolute paths, so that
restoring timestamps does not fail.
2006-04-16 16:20:21 +00:00
9244f58a4e
translate sendmsg so that tools like nslookup will show remote addresses;
...
i waited for three years and nobody did this; had to do it myself :-(
2006-04-16 05:19:02 +00:00
fed8136a4e
add new system calls (__lstat30 and __stat30) that should have been added
...
for argument translation in Systrace
2006-04-15 20:35:24 +00:00
6236eeb27a
Don't free str; it is used in pat_add. Noted by: Kouichirou Hiratsuka
2006-04-14 16:57:01 +00:00
3598f93379
Fix date (no leading zero), fix xref: sticky(7) not (8).
2006-04-08 22:39:39 +00:00
b338995776
Address PR 30374 as suggested in there:
...
"Modify the man page to match the behaviour of "ls -q",
(done by yamt@ previously)
...
modify both the behaviour and documentation for "ls -b" and "ls -B" to
make spaces readily apparent. This could be done by adding VIS_WHITE
to the flags passed to strvis(3) in the safe_print() function in
src/bin/ls/util.c."
'ls -b' now yields foo\sbar (whitespace) foo\tbar (tab) foo\rbar (CR).
'ls -B' now yields foo\040bar foo\011bar foo\015bar.
2006-04-08 22:28:06 +00:00
3dc055fb76
s/non-graphic/non-printable/ to match with the code.
2006-04-08 12:04:22 +00:00
0346684a3d
save the home directory.
2006-04-05 23:10:16 +00:00
868accdb18
Coverity CID 1836: Free Source after return from shell.
2006-04-01 23:39:58 +00:00
c28f114217
Coverity CID 1844: Add annotations for aresize.
2006-04-01 23:36:28 +00:00
0ad4767103
Coverity CID 1829: Fix memory leak.
2006-04-01 23:34:43 +00:00
c4378122a1
Don't leak memory if RJUST|LJUST is specified. This might fix a whole bunch
...
of Coverity issues, but we'll wait until the next run :-)
2006-03-29 15:51:00 +00:00
dcbe086f64
correct coverity model.
2006-03-26 21:36:13 +00:00
7e2f55514f
Coverity CID 1755: Add fts_close() in traverse.
2006-03-22 16:20:34 +00:00
6365ef6a81
Change previous to assert that the index is within bounds only when the
...
index actually used.
2006-03-22 16:12:19 +00:00
4bd79d53a1
Oops, the previous change was not entirely correct since we were checking
...
the wrong byte.
2006-03-22 01:45:08 +00:00
80f67fa272
Coverity CID 879: Don't increment bits before checking it for NULL.
2006-03-21 23:50:09 +00:00
3351d69442
Add coverity model annotations
2006-03-21 23:40:49 +00:00
0c6d11b6a4
Coverity CID 2736: Remove 16 bit int compat code.
2006-03-21 16:46:44 +00:00
eab2cd7c2b
Coverity CID 1827: Plug memory leak.
2006-03-20 20:20:07 +00:00
85e611dd01
Goodbye KerberosIV
2006-03-20 04:03:10 +00:00
59586f9983
Coverity CID 1606: Plug memory leak.
2006-03-19 19:12:23 +00:00
a8846ec5ac
Coverity CID 2734, 2731: Use after free; resource leak
2006-03-19 19:06:39 +00:00
bb7bab2df4
Coverity CID 877: Prevent NULL deref.
2006-03-18 07:24:40 +00:00
c8a3069e94
Coverity CID 1484: Static buffer overrun.
2006-03-18 07:23:07 +00:00
3cf8c179a3
Coverity CID 1763: Plug memory leak.
2006-03-18 07:09:08 +00:00
e889898c95
Coverity CID 1766: Plug memory leak.
2006-03-18 07:02:16 +00:00
f3ffb9c969
Coverity CID 1760: Plug memory leak.
2006-03-18 06:54:46 +00:00
4d7c6251da
Coverity CID 1228: protect against calling close with negative value.
2006-03-18 06:29:21 +00:00
dcfc467f4d
Coverity CID 872: Possible NULL deref.
2006-03-18 06:24:26 +00:00
ee17e957e3
Coverity CID 343: Rework code so that we don't write after the end of the
...
array. The end effect is the same though.
2006-03-18 05:43:47 +00:00
2ed09657c9
Coverity CID 345: Add missing free's.
2006-03-18 05:40:28 +00:00
eb903308f2
Coverity CID 1559: Fix memory leak.
2006-03-18 05:33:31 +00:00
3e359756c9
Coverity CID 620: Remove dead code.
2006-03-18 05:25:56 +00:00
f6828859fa
Coverity CID 890: Possible NULL pointer deref.
2006-03-18 05:23:08 +00:00
169a269417
Coverity CID 1329: Possible NULL deref.
2006-03-18 05:17:36 +00:00
f127f217fb
Fix Coverity CID 1863, 1864; resource leak, bp not freed when !okname()
...
before function return and/or bp overwritten by malloc().
2006-03-18 04:44:49 +00:00
c8593a1a3c
Wrap long lines.
2006-03-18 00:35:02 +00:00
dfd65180e1
Don't try to dereference pw when it's NULL.
...
Fixes Coverity CID 900.
2006-03-18 00:32:34 +00:00
6dcaf25d17
Free allocated space upon failure.
...
Fixes Coverity CID 1661.
2006-03-18 00:14:50 +00:00
c75c0a8549
Change a return to "goto out" so that fclose will be called.
...
Fixes Coverity CID 1881.
2006-03-18 00:12:02 +00:00
96b1a913a5
Call fts_close() at the end of rm_tree().
...
Fixes Coverity CID 1670.
2006-03-17 23:55:42 +00:00
5653b43bfd
Coverity CID 1226: Remove bogus close call.
2006-03-17 22:48:10 +00:00
1006977549
Coverity CID 1324: Check adrof return; not really possible.
2006-03-17 22:38:44 +00:00
65b5013e95
Coverity CID 2356: Remove bogus test !*argv; also cleanup string usage.
2006-03-17 22:30:11 +00:00
b807e41c56
Coverity CID 1762. Fix resource leak.
2006-03-17 22:24:28 +00:00
94f9c01465
Coverity CID 610: Dead code
2006-03-17 22:20:31 +00:00
df8cbb182e
Coverity CID 2479: Clarify confusion about uninitialized variable in the
...
presence of setjmp/vfork.
2006-03-17 17:20:47 +00:00
2174dda221
Handle asprintf failing to allocate.
2006-03-17 14:43:11 +00:00
88f1652fe8
Handle asprintf returning NULL.
2006-03-17 14:37:14 +00:00
3ad5f13d80
Handle malloc returning NULL.
2006-03-17 13:53:31 +00:00
a329a6a0ae
Fix Coverity issue 1754. Call fts_close() after we're done copying.
2006-03-17 06:22:30 +00:00
3ebb7ce790
Correct a check for an index being in bounds for a static array.
2006-03-17 00:02:30 +00:00
d5d0c11532
Make the -s flag of fc work correctly. Ensure that only one command is specified
...
and ensure that we break out of the loop after executing it.
With the previous code, because the re-executed command was added to the
history, it would think that it still had to execute it, leading to an infinite
loop.
The last thing which differs from ksh is that we get the "fc -s " command into
the history, but this is actually rather a feature in my humble opinion.
To test:
$ echo hello
$ fc -s ec
<infinite loop or correct behaviour>
2006-03-06 00:09:22 +00:00
cde6642bee
PR/32931: Johan Veenhuizen: cat(1) does not clear the EOF indicator for
...
stdin in cooked mode.
2006-02-26 19:44:24 +00:00
1ad8067cb3
Fix typos, reported by Alexey Dobriyan ("Gathered from Linux"),
...
forwarded by jmc@openbsd.
2006-02-25 00:58:34 +00:00
b419a25464
Ensure we exit with an error if we don't actually do anything.
...
There are a lot of tty_warn(0,...) and syswarn(0,...) which probably ought
to be tty_warn/syswarn(1,...) to force an error exit. However some are
used in interactive parts (eg opening a continuation archive) where there
is a separate retry loop.
So we just pass a failure code out to main() - how quaint!
This should now cause the NetBSD build to fail when gzip tries to write
to a non-existant directory.
(I suspect there are still many errors that don't get reported correctly.)
2006-02-11 11:04:57 +00:00
cdec4ac10c
Change all the 'return(x)' to 'return c'.
...
Makes some other searches I want to do a bit easier.
2006-02-11 10:43:17 +00:00
885e558785
Actually exit with error if we cannot open("."), make it more obvious that
...
we exit with error on signals.
2006-02-11 10:35:19 +00:00
ef3fea8531
Solaris mkdir on an automounted component returns ENOSYS. Go figure.
...
Good choices whould have been EROFS, EEXIST, EACCES, EISDIR...
2006-01-31 19:25:20 +00:00
262cdfcbd7
Start 'You have mail in' with a capital Y.
2006-01-15 18:16:30 +00:00
f909cee7d7
PR/23688: don't say we're printing in 1k-blocks if -h was also specified.
2006-01-13 14:07:57 +00:00
01db637894
Bump date for progress=n description change.
2006-01-12 21:42:11 +00:00
b7d86f5e4c
In "dd progress=N", let the value of N control how often
...
to print a "." to stderr. Previously, any non-zero
value behaved like "progress=1".
PR 24300
Approved by christos
2006-01-09 10:17:05 +00:00
d2169f9f6e
obey umask as it used to be before the "mkstemp and then rename" change.
2006-01-04 22:02:11 +00:00
6ac601d8c4
Add error printing for ENAMETOOLONG. Partially addresses PR bin/13850 .
...
The actual bug mentioned in that PR no longer exists, but it does cause:
~~~~~: error 63
Which this fix cleans up.
2006-01-02 19:10:33 +00:00
9d002bc47d
Give systrace its own version of realpath() that does what it wants,
...
call it intercept_realpath().
Unbreaks systrace.
2005-12-31 12:33:41 +00:00
ea2078818f
TOG require that 'set +o' output the options in a form suitable for
...
restoring them - make it so.
2005-12-13 17:44:18 +00:00
fe8b349524
Add xref to chflags(1). From Andre Luiz de Oliveira in PR 32265.
2005-12-09 20:27:02 +00:00
d0d28f16f5
If we get EACCES from mkdir, try to stat() it, and if it is ok, we keep going.
...
Fixes problem with IRIX.
2005-12-06 19:11:15 +00:00
e60beff86b
Don't change the name of the directory we are going to 'cd' to just because
...
we decide to remove a leading "./" when deciding whether to print the name.
Stops 'cd .//tmp' ending up the same as 'cd /tmp'.
Fixes PR/30735
2005-11-26 21:44:43 +00:00
f85aae5649
PR/32103: Zafer Aydogan: Fix references to obsolete fstatfs and getfsstat
2005-11-18 05:04:24 +00:00
95355c05c7
- Better detect pathname overflow (from FreeBSD)
...
- Change destination normal file detection to match with FreeBSD
- Trim trailing slashes from source filenames so that cp foo/ == cp foo
2005-11-16 22:42:12 +00:00
83fd12c4fb
add "uaddr" and improve text for "laddr".
2005-11-11 17:06:22 +00:00
58c15fb5d1
add a keyword for the uarea address. very useful with crashdumps.
2005-11-05 19:27:24 +00:00
c952ef6b81
PR/31923: Sergey Svishchev: pax-as-tar ignores -k, overwrites existing files
...
Fix from Onno van der Linden
2005-11-01 23:43:27 +00:00
0386433d98
Somehow missed this in the last commit, where I only changed the commentary
...
to reflect the actual change (plus minor nits). So here's the actual change:
Rather than '-h' suppressing '-s' when using '-l', make it display
the blocks used in human readable form, as suggested by Alan Barrett
and Daniel Carosone.
(Missing bits spotted, as usual, by wiz@.)
2005-10-31 14:13:33 +00:00
2fc1513987
The emulation for these should be "native", not "netbsd".
...
Noted by Ray Lai.
2005-10-26 21:17:23 +00:00
ea274fd69c
Rather than '-h' suppressing '-s' when using '-l', make it display
...
the blocks used in human readable form, as suggested by Alan Barrett
and Daniel Carosone.
2005-10-26 02:24:22 +00:00
fd4c891ff8
Remove the "" -> "." target conversion kludge.
2005-10-24 12:59:07 +00:00
3478ebe108
document that -h makes -l suppress -s.
...
(Ie 'ls -lhs' == 'ls -lh')
2005-10-23 20:52:47 +00:00
c9981d258c
PR/27140: "sleep time" doesn't error out.
...
Apply fix from Dheeraj Reddy.
2005-10-17 10:11:46 +00:00
509c72ef94
- Don't output 'src -> dst' when -v and there was an error.
...
- Mark usage as noreturn, and remove extraneous exit.
- Pass lint.
Reported by Liam Foy.
2005-10-15 18:22:18 +00:00
ff54312f75
Honor the COLUMNS variable even when producing output not to a terminal,
...
as long as a specific format (that could use COLUMNS) was requested.
This makes
env COLUMNS=50 ls -C > file
not surprise the user who clearly wanted some specific output in the file.
2005-10-14 16:02:26 +00:00
8d6ffce2ad
PR/31548: Alexander Rigbo: $PWD not set when shell starts up, before pwd
...
or cd get executed.
2005-10-10 21:14:42 +00:00
803ccc7cb0
Bump date for previous.
2005-10-10 20:46:17 +00:00
98615dcf47
Document that '-g' overrides -1, -C, -m, and -x, but is _always_
...
overridden by '-l', even if '-g' was specified last.
2005-10-10 20:30:34 +00:00
c05266af8a
fix setmode error handling.
2005-10-01 20:23:54 +00:00
16547af71a
Fix setmode error handling.
2005-10-01 20:22:29 +00:00
037f0a7b03
Now that setmode() is fixed, handle errors with err instead errx.
2005-10-01 20:09:18 +00:00
964f98e703
Make slightly more portable without extra conditionals needed:
...
- Use getpgrp() rather than getpgid(0).
(getpgrp() is already used elsewhere in this same file.)
- Use waitpid(-1, a, b) rather than wait3(a, b, NULL).
2005-09-30 18:57:55 +00:00
469d38dbae
Don't leave arcn->org_name pointing to ftent->fts_path, if we being cpio
...
then ftent is freed just below. Take a copy of the name and point org_name
at the copy.
Should fix PR/30627 (the fix in the PR will break pax and tar!)
2005-09-24 17:05:21 +00:00
dholland