Commit Graph

35 Commits

Author SHA1 Message Date
itojun
d80101c91c Allocate vis_user on the stack instead of using malloc(). This
way we don't have to worry about malloc() failure.  Also closes
a memory leak since vis_user was never free()d.  Lack of malloc()
checking pointed out by Peter Werner.
from openbsd
2002-09-25 04:57:59 +00:00
itojun
89b1e287f7 find_user() in process.c does an unbounded copy into a destination
buffer that is smaller in size than the source buffer.

also, there is no guarantee that any of the string components of
the request packet are null terminated.

in some cases, not all elements of the response buffer are
explicitly set. specifically pad and addr. a talk client can spy to
see which host is talking to which host by sending out regular
packets, to which talkd responds without clearing the addr element.

from xs@kittenz.org
2002-09-19 14:39:51 +00:00
lukem
e3b1a0e70b use NETBSDSRCDIR as appropriate 2002-09-19 03:17:50 +00:00
christos
7d62d2a173 utmpx support 2002-08-20 13:56:50 +00:00
enami
96924d78ee Lineup comment and remove unnecessary whitespaces. 2002-03-04 01:40:56 +00:00
enami
71706b65e7 Use \a instead of embedding raw control-G character. 2002-03-04 01:37:52 +00:00
christos
a0e25e1408 PR/5631: Rumi Szabolcs: Make talk work without COMPAT43 2001-09-27 14:38:58 +00:00
wiz
89a9190994 syslogd(8), not syslog(8). 2001-04-04 09:56:56 +00:00
cgd
65a1026492 convert to use getprogname() 2001-02-19 22:43:42 +00:00
christos
20d53d3990 fix nested extern 2001-02-04 22:14:13 +00:00
tv
7781da70d5 Formatting nit: add a space. 2000-10-17 20:55:36 +00:00
itojun
4a32e44ffe make sure big_buf is big enough to hold line terminations.
if all the lines have N_CHARS of characters, we will write up
	N_CHARS * N_LINES + (3 + 2 * N_LINES) + 1
of bytes.
2000-10-10 12:38:54 +00:00
garbled
f124765044 More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages.  Many more to
come.
1999-03-22 18:25:43 +00:00
mrg
2beab49a06 - use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames
1998-07-06 06:45:41 +00:00
mrg
687403aa7a - clean up some more cruft
- support "talkd -l" for extra (syslog(3)) logging
- fix error in previous announce.c change
- use getopt
- add (missing) -d and -l descriptions to man page
1998-07-04 19:31:05 +00:00
mrg
750ef3b29d - use S_IWGRP over 020
- KNF
- ensure we don't overflow a buffer (don't think it would anyway).
- favour snprintf over sprintf (and varargs versions)
1998-07-03 11:54:08 +00:00
kleink
f604523fb6 Need <time.h> for localtime() prototype. 1998-04-01 14:51:54 +00:00
enami
e50ac59ba3 Fix .Nm usage. 1997-10-20 02:53:32 +00:00
mrg
2268d2dfb3 merge lite-2 Makefiles (rcsids), and turn on WARNS for all of libexec. 1997-10-08 09:07:11 +00:00
christos
1a1bf9f574 Use WARNS=1 1997-07-06 22:52:28 +00:00
christos
cc36d26be2 Install as ntalkd 1997-06-29 19:22:04 +00:00
christos
c030b3a0c2 We are not going to be running as root anymore, so no need to check for that. 1997-06-29 19:19:15 +00:00
christos
30b8660384 - use ttymsg from libutil
- clean warnings
- PR/3778: Eric Fischer: talkd should find the least idle terminal
1997-06-29 19:13:01 +00:00
christos
5a6c78298f Merge in lite-2 1997-06-29 18:01:12 +00:00
explorer
c80b5ae409 Doh! MAXHOSTNAMELEN, not MAXHOSTNAME 1997-01-29 10:30:14 +00:00
explorer
143a02016e Allow local hostname to be longer than 32 characters, and make certain it will
fit in the buffer space provided.  Also, ensure null termination.
1997-01-29 03:21:01 +00:00
rat
c8b88b5da7 Use snprintf(3) when printing into arrays allocated on the stack.
Patch submitted by David Holland <dholland@hcs.HARVARD.EDU>
1996-07-17 18:46:58 +00:00
cgd
788733b7a9 typeof(timeval.tv_sec) != time_t 1995-06-07 17:14:21 +00:00
cgd
a59d6b2cae stdlib.h for protos 1994-12-23 15:59:21 +00:00
cgd
ae9172d6cd specify man pages the new way. 1994-12-22 09:57:51 +00:00
glass
e34b72b0cb vis(3)ify remote user name. Fixes bug 589. Fix basically as submitted by matthew green 1994-12-21 20:03:48 +00:00
mycroft
e9d867ef50 Add RCS identifiers. 1993-08-01 17:54:45 +00:00
mycroft
dfb9caab49 Add RCS indentifiers. 1993-08-01 07:32:48 +00:00
mycroft
cda4f8f6ee Add RCS identifiers. 1993-08-01 05:37:30 +00:00
cgd
61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00