Commit Graph

50 Commits

Author SHA1 Message Date
aymeric
c79f400cf4 In sink(), upon error, avoid multiple replies to the source as this
would lead to a desynchronization of the protocol and further files or
directories to be ignored or corrupted.

Reported by Daniel Goujot, Georges-Axel Jaloyan, Ryan Lahfa, and David Naccache.
2020-05-06 18:15:40 +00:00
chs
e9b012a310 allocate a separate buffer in each call to sink().
reusing the buffer across recursive calls just doesn't work right.
2012-05-07 15:22:54 +00:00
dholland
83b3dbf601 Fix up seriously borked mallocing of a static buffer, which seems to
have been this way since at least 4.4. This will still dump core if
malloc fails on the first trip through, instead of on any malloc
failure, but should otherwise behave much more reasonably.
2009-08-31 07:11:16 +00:00
lukem
2fe2731d3f Remove the \n and tabs from the __COPYRIGHT() strings. 2008-07-20 00:52:39 +00:00
christos
9655f5c24c PR/38755: murray armfield: /bin posix programs missing setprogname and/or
setlocale
2008-05-26 14:21:08 +00:00
dholland
fe5990acd7 Print time_t as long long, not long. 2008-02-24 05:16:46 +00:00
christos
6f4d1070fd pass lint; from Anon Ymous 2006-12-15 22:45:34 +00:00
christos
32232db57f remove two (void)&foo; which are ot needed. From Anon Ymous 2006-12-15 20:22:06 +00:00
christos
85e611dd01 Goodbye KerberosIV 2006-03-20 04:03:10 +00:00
ginsbach
f127f217fb Fix Coverity CID 1863, 1864; resource leak, bp not freed when !okname()
before function return and/or bp overwritten by malloc().
2006-03-18 04:44:49 +00:00
christos
6310b59691 sprinkle a little const, and now everything compiles with WARNS=3 2005-06-26 19:10:48 +00:00
ginsbach
0d1bfba8c7 Add mechanism for escaping IPv6 address strings, since they already
contain colons.  Idea from Solaris rcp(1).
2005-03-11 02:55:23 +00:00
wiz
165812e4cb Add -4 and -6 to usage. 2005-03-09 17:09:39 +00:00
ginsbach
25e3a7ec6d - Support -4 and -6. Approved by christos. 2005-03-09 03:11:21 +00:00
xtraeme
0b39b8da10 Kill __P(), use ANSI function declarations. 2005-02-17 15:17:44 +00:00
martin
abe6f9dc47 Remove duplicate include, fixes PR bin/25018 from Jeff Ito. 2004-04-02 09:08:55 +00:00
jdolecek
cf0f7c2614 IPv6 support, based on src/usr.bin/rsh/rsh.c rev. 1.13
fixes PR bin/24940 by Manuel Bouyer
2004-03-28 08:18:25 +00:00
agc
b5b2954259 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22249, verified by myself.
2003-08-07 09:05:01 +00:00
itojun
e45b6fad8e include des.h, not kerberosIV/des.h 2003-07-23 21:10:36 +00:00
itojun
674baed7e1 misuse of strncpy. PR 21201 from Christian Biere. 2003-04-16 07:10:00 +00:00
ragge
0ccd7cbd86 It's a very bad habit to store file sizes in int's, so change it to off_t
instead. Obviously noone has tried to rcp files larger than 2GB.
2002-11-22 21:46:02 +00:00
wiz
1815854042 __STDC__ is always defined on NetBSD. 2002-05-25 23:29:16 +00:00
wiz
4c99916337 va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.
2001-09-24 13:22:25 +00:00
lukem
f819878ce7 use more standard %ll_ in favour of %q_ 2001-01-04 15:39:50 +00:00
drochner
85cbf55d16 Since our gcc doesn't warn about NULL format strings anymore, we can
fix the incorrect err(1, "%s", "") et al.
Closes PR bin/7592 by cgd.
1999-11-09 15:06:30 +00:00
scottr
cf184145f7 Make this compile ifdef KERBEROS. 1999-02-17 06:45:38 +00:00
christos
09fb774d70 s/MODEMASK/RCPMODEMASK/
From Darrin Jewell.
1998-11-05 14:00:58 +00:00
christos
040da092ae char -> unsigned char
work around missing futimes.
1998-11-04 19:43:50 +00:00
mycroft
ee9e50eacb Be more retentive about use of NOTREACHED and noreturn. 1998-07-28 11:41:40 +00:00
mycroft
9dc385beb1 Delint. 1998-07-28 05:31:22 +00:00
mycroft
620e5b5b8b Deal with GCC warnings. 1998-02-03 07:48:32 +00:00
christos
b021feb71d PR/4284: Tatoku Ogaito: rcmd(3) get be called with getpwent(3) results as
arguments, leading to memory corruption.
1997-10-21 13:47:17 +00:00
mycroft
2d6dc609e6 Use futimes(2).
Send microseconds over the wire, rather than just 0.
1997-10-19 13:12:04 +00:00
lukem
7ff9d68cb5 - cleanup use of .Nm in man page
- getopt returns -1 not EOF
1997-09-14 08:17:11 +00:00
thorpej
fc68ce7e4e Cast some printf arguments to keep the compiler happy on the Alpha. 1997-07-30 05:07:22 +00:00
christos
e800d25ed8 Fix compiler warnings
Add WARNS=1
1997-07-20 20:47:31 +00:00
jeremy
59f8247d38 Fix incorrect use of name vs. pwd->pw_name and wrong logic in strdup() test.
[PR/3718]
1997-06-07 07:11:34 +00:00
mrg
66bc7bd651 fix PR#3710, reported by Tatoku Ogaito <tacha@trap.fukui-med.ac.jp>.
- don't pass pw->pw_name into functions; make a copy.
1997-06-05 16:10:46 +00:00
mrg
bf5e0e4892 use rcmd(); garbage collect junk. 1997-05-27 07:09:51 +00:00
mrg
6992846f36 use orcmd() for now. 1997-05-26 15:18:25 +00:00
jtc
429c5e2f3b Rename struct timespec fields to conform to POSIX.1b 1996-02-01 00:02:24 +00:00
cgd
6ff461a4e8 actually do the import. rcp appears to have been previously imported
but not merged(?!?!?).
1995-03-21 08:18:58 +00:00
mycroft
705a6ebacb Use S_IS*(). 1995-01-30 19:39:36 +00:00
mycroft
f5ad44b6ac Use S_IS*(). 1995-01-30 19:30:13 +00:00
cgd
5dad143982 from James Jegers <jimj@miller.cs.uwm.edu>: quiet -Wall, and squelch
some of the worst style errors.
1994-12-04 07:11:37 +00:00
cgd
a689451976 more off_t 1994-03-27 10:28:21 +00:00
mycroft
8542364e07 Add RCS identifiers. 1993-08-01 18:49:50 +00:00
cgd
06be60083d changed "Id" to "Header" for rcsids 1993-03-23 00:22:59 +00:00
cgd
346aa5dd48 added rcs ids to all files 1993-03-22 08:04:00 +00:00
cgd
61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00