Commit Graph

144786 Commits

Author SHA1 Message Date
jmcneill a737ed394b Don't use intarg uninitialized in wsdisplay_usl_ioctl2. Fixes CID 2507 2006-03-18 13:06:38 +00:00
bouyer f7123013b8 bread() will always return a valid bp. So remplace the (always true) if (bp)
with a KASSERT.
Should fix Coverity ID 2444.
2006-03-18 12:48:38 +00:00
dsl 57c63d8912 Avoid indexing beyond the end of a malloced array.
Rework loop to be less confusing.
Coverty 519 made me read this code, but this isn't the 'bug' it found.
2006-03-18 12:48:35 +00:00
kardel 9429ea9653 null deref: backport current ntp code to fix (Coverity CID 759) 2006-03-18 12:40:48 +00:00
rtr b06fd00a81 free buf on error path
coverity 190 / run 5
2006-03-18 12:35:41 +00:00
dan 1c8b9fae53 CIDs 2649, 2650: buf used after free 2006-03-18 12:35:19 +00:00
blymn 8426a88bc7 Fix resource leak if malloc of tb->data failed.
Whitespace cleanup.
2006-03-18 12:18:15 +00:00
dan dbd04f2b27 free buf in error path; CID 2061 2006-03-18 12:15:05 +00:00
peter 13b0033a9d Describe the peter-altq branch. 2006-03-18 11:45:41 +00:00
dsl 46b640e7c6 Coverty 521: fclose() temporary file used when editing label. 2006-03-18 11:38:59 +00:00
dsl 2769bb6a26 Coverty 1212: Avoid close(-1). 2006-03-18 11:15:00 +00:00
dsl 1ec8e10fce Coverty 7449: Change 'return (0)' to 'goto done' so we free(bootstrapbuf)
before exiting with error.
2006-03-18 11:08:19 +00:00
dsl f9603a44ea Coverty 7449: Remove splurious check for 'sep == NULL'. 2006-03-18 11:02:48 +00:00
bouyer d3f24ba785 __wdcwait_reset(): if we hare there we have a wdc pointer, so no need to check
if wdc is not NULL here at all (we were doing it after wdc has been
dereferenced anyway).
Coverity ID 2441.
2006-03-18 10:59:58 +00:00
jnemeth 216a33af30 Fix Coverity run 5, issue 2022 -- memory leak.
Approved by christos@.
2006-03-18 10:53:17 +00:00
dan ccd53bd92b reform a loop to be prettier and appease coverity CID 2618 2006-03-18 10:41:24 +00:00
jnemeth 79787ff03b Fix Coverity run 5, issue 2021 -- memory leak.
Approved by christos@.
2006-03-18 10:22:46 +00:00
jnemeth 1f89beeb43 Fix Coverity run 5, issue 1966 -- memory leak
Approved by christos@.
2006-03-18 10:19:09 +00:00
jnemeth f358706242 Fix Coverity run 5, issue 2498 -- uninitialized variable
Fix Coverity run 5, issue 707 -- unreachable code
Approved by Christos.
2006-03-18 10:06:16 +00:00
christos 6edcc275a1 Coverity CID 2297: Fix memory leak. 2006-03-18 09:51:08 +00:00
christos 22983123c5 Coverity CID 2341, 2342: Plug memory leak. 2006-03-18 09:46:35 +00:00
rtr 969e2244d4 fclose() open FILE * even though we are returning to fail anyway.
silences coverity, CID 1590 / run 5
2006-03-18 09:40:46 +00:00
christos a46f31170d Coverity CID 1668: Plug memory leak. 2006-03-18 09:31:36 +00:00
kardel 58ad32062f Coverity NetBSD scan CID 2055: fallout fix return/fclose -> fclose/return 2006-03-18 09:28:50 +00:00
christos c66ab9a1d0 Coverity CID 1666: Plug memory leak. 2006-03-18 09:28:23 +00:00
kardel e13d171a8e resource leak (fd/mem): fclose() streams on error (Coverity NetBSD scan CID 2055) 2006-03-18 09:26:08 +00:00
christos c5f39d86c2 Coverity CID 1667: Plug memory leak 2006-03-18 09:19:02 +00:00
christos 53c1263c37 Coverity CID 1662: Memory leak. 2006-03-18 09:15:57 +00:00
christos 87113ce74b Coverity CID 597: remove dead code. 2006-03-18 09:09:41 +00:00
christos 78f7dbe212 Coverity CID 1216: Prevent negative index use. 2006-03-18 09:07:05 +00:00
christos 62bb88223c Coverity CID 806: Prevent NULL deref 2006-03-18 09:02:08 +00:00
kardel 589ea6e802 resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054) 2006-03-18 08:57:25 +00:00
dsl df7e187ccb Appease Coverty CID 7449. Avoid close(-1) in error path. 2006-03-18 08:36:50 +00:00
kardel 862343544d resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied ) 2006-03-18 08:09:03 +00:00
tsutsui 969544860e Don't put .reginfo into .bss but prepare an independent section for it
so that new ld(1) no longer dies on link as PR/33011.

Still ld(1) coredump problem should be fixed, IMO.
2006-03-18 07:29:53 +00:00
simonb 6c79cda5ae Coverity CID 2466 - Fix a GCC uninitialised variable warning in a way
that (hopefully!) keeps coverity happy too.
2006-03-18 07:27:50 +00:00
christos bb7bab2df4 Coverity CID 877: Prevent NULL deref. 2006-03-18 07:24:40 +00:00
christos c8a3069e94 Coverity CID 1484: Static buffer overrun. 2006-03-18 07:23:07 +00:00
christos 3cf8c179a3 Coverity CID 1763: Plug memory leak. 2006-03-18 07:09:08 +00:00
christos e889898c95 Coverity CID 1766: Plug memory leak. 2006-03-18 07:02:16 +00:00
christos f3ffb9c969 Coverity CID 1760: Plug memory leak. 2006-03-18 06:54:46 +00:00
christos 4d7c6251da Coverity CID 1228: protect against calling close with negative value. 2006-03-18 06:29:21 +00:00
christos dcfc467f4d Coverity CID 872: Possible NULL deref. 2006-03-18 06:24:26 +00:00
rumble 43d45c06c6 Note that for asprintf and vasprintf it is more portable to check for
a -1 return, rather than ret being set to NULL on error.

From Otto Moerbeek.
2006-03-18 05:46:04 +00:00
christos ee17e957e3 Coverity CID 343: Rework code so that we don't write after the end of the
array. The end effect is the same though.
2006-03-18 05:43:47 +00:00
christos 2ed09657c9 Coverity CID 345: Add missing free's. 2006-03-18 05:40:28 +00:00
christos eb903308f2 Coverity CID 1559: Fix memory leak. 2006-03-18 05:33:31 +00:00
christos 3e359756c9 Coverity CID 620: Remove dead code. 2006-03-18 05:25:56 +00:00
christos f6828859fa Coverity CID 890: Possible NULL pointer deref. 2006-03-18 05:23:08 +00:00
christos 169a269417 Coverity CID 1329: Possible NULL deref. 2006-03-18 05:17:36 +00:00