Commit Graph

160211 Commits

Author SHA1 Message Date
xtraeme
2ce86bd863 Align drive state string like other sensor types. 2007-07-05 14:11:08 +00:00
xtraeme
84b0b63b4c Before checking sensor type:
- check if if its state is invalid
- print the 'N/A' string and continue

This avoids code duplication.
2007-07-05 14:08:37 +00:00
xtraeme
5310357612 Adapt to the recent changes to the acpiacad(4) and acpibat(4) drivers. 2007-07-05 13:53:21 +00:00
isaki
265ca0b1f3 Add cache information of, at least, Celeron M (no processor number).
Reviewed by tsutsui@ on port-i386.
2007-07-05 13:51:37 +00:00
xtraeme
7233bc845c Print invalid state with 'N/A' for Indicators, like any other sensors.
We follow the following scheme now:

value_cur set => ON
value_cur not set => OFF
invalid state => N/A
2007-07-05 13:51:28 +00:00
xtraeme
65811978f4 Final round, after more comments from yamt and cube:
For indicators, if sensor is valid but it should report that it is
in disabled state (OFF), just set value_cur to 0 without changing its
state.
2007-07-05 13:47:46 +00:00
pooka
0e40108103 * reorder calls to get results processed even if our I/O descriptors
go back to zero
* don't give up on the read-side of an fd if there is still unreceived data
2007-07-05 12:27:39 +00:00
xtraeme
615572e484 acpibat_print_stat(): in the 'charging' indicator sensor, check its state
to select the correct string rather than using value_cur.
2007-07-05 12:14:18 +00:00
xtraeme
ada961ab89 Print 'N/A' for invalid sensors rather than an asterisk, with the
exception of Indicator sensors.

Indicator sensors now will print "ON" if they are in valid state, or
"OFF" if they are in invalid state.
2007-07-05 12:11:05 +00:00
xtraeme
194be74536 Use only one Indicator sensor when the battery is connected/disconnected
and another one only for charging/discharging.
2007-07-05 12:08:45 +00:00
xtraeme
61142f7829 Use only one sensor to report if the AC Adapter is connected or not,
rather than using two: one when is connected and another one is
disconnected.
2007-07-05 12:07:40 +00:00
dsieger
8ffca41e9b Fix two typos. Reported by Ray Phillips via NetBSD WWW feedback form. 2007-07-05 08:25:04 +00:00
pooka
c22b16280d wsize is size_t = unsigned and should be printed with %zu instead
of %zd.  cosmetics for PR 36591 by khorben.
2007-07-04 23:18:49 +00:00
dsl
513b927545 It seems that min(16,16) isn't a compile time constant.
So don't bother limiting the local arrays to NGROUPS, just use 16.
2007-07-04 21:59:16 +00:00
rumble
0bbb4e920d Clamp down tigher on the bound around 'numextents'. Add a few comments
to make it clearer what we're tracking.
2007-07-04 20:20:30 +00:00
xtraeme
96deb6cebd By popular demand, do not skip sensors with invalid state. Print them
with an asterisk, as was suggested by Greg. A. Woods.

Example:

$ ./envstat -dlm0 -s "CPU Fan,System Fan,Aux Fan"
     System Fan:       *
     CPU Fan:       1308 RPM
     Aux Fan:          *
$

Except Integer and Driver sensors, which shouldn't need that.
2007-07-04 19:56:02 +00:00
rumble
0aef936cbe Additional fixes/enhancements:
1) Comply with the way buffercache(9) is intended to be used. Now we
       read in single blocks of EFS_BB_SIZE, never taking in variable
       length extents with a single bread() call.

    2) Handle symlinks with more than one extent. There's no reason for
       this to ever happen, but it's handled now.

    3) Finally, add a hint to our iteration initialiser so we can start
       from the desired offset, rather than naively looping through from
       the beginning each time. Since we can binary search the correct
       location quickly, this improves large sequential reads by about
       40% with 128MB files. Improvement should increase with file size.
2007-07-04 19:24:09 +00:00
xtraeme
933c2e67b5 Set the state on sc->sc_sensor[0].state and not append it,
envsys2 doesn't use bits for the state member.
2007-07-04 19:12:42 +00:00
xtraeme
60ed581de9 There's no need to set the "envsys-description" property in the
driver's dictionary anymore, because with envsys2 you can change
descriptions.
2007-07-04 19:00:43 +00:00
xtraeme
1492e24783 There's no need to get initial sensor data before registering the driver
to the sysmon_envsys(9) framework, because at register time, the
framework will get initial data by itself.
2007-07-04 18:56:16 +00:00
rumble
1798f1d8df Fix a significant performance bug in efs_read:
When reading a file, we would erroneously iterate to the next extent
before having filled the entire uio request. This lead to unnecessary
extent iteration and excessive calls to efs_read.

Sequential read performance has doubled in the uncached case and
quadrupled when data is buffered.
2007-07-04 18:40:18 +00:00
christos
d4e1d48f81 Anon Ymous says that this should fix the lwp display core-dump. 2007-07-04 18:27:46 +00:00
xtraeme
a7874cd432 Remove the max limit in the refresh value for the refresh_value sysctl,
use whatever you want within the limits of an integer.

Suggested by garbled@ and freza@.
2007-07-04 17:48:16 +00:00
bouyer
7135c1aad2 Start with all sensors in ENVSYS_SINVALID state, and switch to ENVSYS_SVALID
(or other, depending on result) once the sensor has been read.
This way envstat(8) won't show sensors which have not yet their correct value.
2007-07-04 17:36:17 +00:00
xtraeme
c51a1c15bf Add the CODE REFERENCES section. 2007-07-04 17:35:20 +00:00
xtraeme
501645e90d Fix the example that used -s without -d, found by hira@. 2007-07-04 17:16:15 +00:00
xtraeme
5e67825d91 Improve description about the -s flag, it must be used with -d. 2007-07-04 17:15:03 +00:00
xtraeme
edbf497407 mfi_sensor_gtredata:
- There's no need to set edata->units again, it was set already before.
- Remove the last ENVSYS_SVALID assignment that overrides previous
  assignments (found by mhitch@).
2007-07-04 17:07:04 +00:00
xtraeme
68bb919d1f Fix the old ENVSYS_GTREDATA ioctl if there are sensors with invalid
state. Enable all sensors by default as valid and current valid data and
if there is one that is in invalid state, mark current data as not valid.

This matches the behaviour with the old API. Also, this fixes the problem
with ipmi(4) reporting bogus values with sensors in invalid state using
the old envstat(8).

Note that this only happened when using the old envstat(8).
2007-07-04 16:30:18 +00:00
njoly
5e14b40722 Add amd64 specific debug files.
Fix build.sh release for amd64 with MKDEBUG=yes
2007-07-04 13:23:11 +00:00
tls
f3c35fd211 After looking at FreeBSD 6 again -- we were also failing to copy the
send and receive timeouts.  Fix this.
2007-07-04 07:17:11 +00:00
tls
d11e46a459 Copy SNDLOWAT and RCVLOWAT socket options to accepted socket, so applications
can rely on all socket options being propagated from the listen socket as
the manual page says (and as everything but Linux has always done).  FreeBSD 6
fixes this the same way, but this bug appears elsewhere and is...Old.
2007-07-04 07:13:13 +00:00
yamt
511f2bb7af add svhlabel.debug. 2007-07-04 02:04:26 +00:00
xtraeme
6aec6c2829 s/cur_tre/edata/ => should fix the build error reported by rjs@. 2007-07-04 00:32:35 +00:00
xtraeme
d3cbee92fb ipmi_sensor_status: if state is ok return ENVSYS_SVALID and not
ENVSYS_WARN_OK, the latter is deprecated on envsys2.
2007-07-03 23:13:12 +00:00
briggs
fd02762f07 Add (commented-out) support for IPMI on amd64--pretty much copied straight
from i386.
2007-07-03 23:05:26 +00:00
briggs
c42d6c37ad Use PRIx64 for a 64-bit quantity instead of llx in a debug print. 2007-07-03 22:58:07 +00:00
xtraeme
e719333534 Document the sysctl node to change the refresh value of the callout
function that monitors the sensors.
2007-07-03 22:47:20 +00:00
xtraeme
ccae4b9276 Erm, fix previous: 6min != 5min... 2007-07-03 22:38:20 +00:00
xtraeme
be7048ebd1 Make the refresh value of the callout function (that monitors the sensors)
configurable via sysctl. By default it uses 10 seconds, but it can be changed
between 1 second and 5 minutes.

$ sysctl -d kern.envsys
kern.envsys.refresh_value: wait time in seconds to refresh sensors being monitored
$
2007-07-03 22:33:36 +00:00
christos
2d14013f2c Support for VIA Esther (From FreeBSD) 2007-07-03 17:07:54 +00:00
joerg
06b3ace137 Add a note that tools have to be re-installed. 2007-07-03 16:35:47 +00:00
joerg
dbfc63fcce Rename nbinstall to ${MACHINE_GNU_PLATFORM}-install as it calls the
target strip. Don't pass down strip as it is not needed any longer.
2007-07-03 16:29:24 +00:00
christos
84c48917b8 spacing fixes from Geoff Wing 2007-07-03 14:39:47 +00:00
yamt
da0717150b add yield(9). 2007-07-03 12:16:51 +00:00
yamt
c793425299 sort 2007-07-03 12:15:31 +00:00
yamt
2025659d20 update and document yield(). 2007-07-03 12:14:24 +00:00
nakayama
0c74dffd74 Add strndup(3) to libnbcompat, since estrndup(3) added into efun.c calls it. 2007-07-03 12:11:09 +00:00
tsutsui
b3b62c0dff Don't clear BSS even if ksyms(4) is not configured. 2007-07-03 10:31:57 +00:00
lukem
b7fac28c5b In sig_cleanup(), attempt to reset the signal handler to the default
and raise the appropriate signal, so the correct wait status is
returned to the parent.
2007-07-03 10:20:09 +00:00