Commit Graph

144662 Commits

Author SHA1 Message Date
peter 96b1a913a5 Call fts_close() at the end of rm_tree().
Fixes Coverity CID 1670.
2006-03-17 23:55:42 +00:00
tls 2ebe53e4ac Add one more buffer pool, for 512-byte buffers. On the one hand, most
systems will never, ever need this -- because they use 8k/1k or even,
these days, 16k/2k or 32k/4k filesystems.  On the other hand, when you
do need this, you *really* need it: on anoncvs.netbsd.org, for instance,
where /tmp is 4k/512 and the filesystem contains tens or even hundreds
of thousands of single-frag directories, this essentially doubles the
efficiency of the allocator.  Since the overhead of keeping one extra
pool around is minimal, just add it by default.
2006-03-17 23:43:37 +00:00
abs e0d5463807 add more "ifdef notdef" around unused sections - addresses Coverity CID 564 2006-03-17 23:36:38 +00:00
abs b4f3ebd201 Add a missing bp->b_score not null check - addresses Coverity CID 1003 2006-03-17 23:34:37 +00:00
rpaulo 7122043ef9 0 > len ==> len < 0 2006-03-17 23:29:20 +00:00
christos 5a57baa413 don't use MALLOC with a non-constant size; use malloc instead. 2006-03-17 23:29:07 +00:00
christos ee3808b74f prevent using MALLOC when size is not const. 2006-03-17 23:27:12 +00:00
rpaulo 86cd5b8af4 0 > len ==> len < 0 2006-03-17 23:26:06 +00:00
abs 2c2c60a0ef if getpwuid() returns null, print out the uid rather than dereferencing
Addresses Coverity CID 930
2006-03-17 23:22:59 +00:00
tls a67eab5ee4 From Konrad Schroeder, in response to strange df output on anoncvs.netbsd.org:
We were returning the wrong value for free space.  Now we're not.
2006-03-17 23:21:01 +00:00
abs f0ff12503e Fix overrun in players[] array. Addresses Coverty CID 1457 2006-03-17 23:15:02 +00:00
abs b317f83344 If getpwuid() returns null, its not usually a good idea to dereference
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
2006-03-17 23:11:47 +00:00
dsl c3e43200eb A couple of the xxx.inc files are non-standard.
My sed script didn't update them properly!
Also man.inc isn't a source make file.
2006-03-17 23:10:48 +00:00
abs f4f2f41178 Call fclose() appropriately if there is a problem with the save file.
Coverty CID 2063
2006-03-17 23:04:01 +00:00
christos 5653b43bfd Coverity CID 1226: Remove bogus close call. 2006-03-17 22:48:10 +00:00
christos 1006977549 Coverity CID 1324: Check adrof return; not really possible. 2006-03-17 22:38:44 +00:00
christos 65b5013e95 Coverity CID 2356: Remove bogus test !*argv; also cleanup string usage. 2006-03-17 22:30:11 +00:00
christos b807e41c56 Coverity CID 1762. Fix resource leak. 2006-03-17 22:24:28 +00:00
christos 94f9c01465 Coverity CID 610: Dead code 2006-03-17 22:20:31 +00:00
ginsbach 1a75882940 Fix Coverity issue 1236, negative return from read() passed to write()
as a large unsigned valued when read() is interrupted (errno == EINTR).
2006-03-17 21:52:41 +00:00
christos d3e8815a4a Add proper DT_NEEDED dependencies. From Jukka Salmi 2006-03-17 21:43:16 +00:00
peter 9665e92dcd Remove unreachable code (res could never be NULL here).
Fixes Coverity CID 712.
Ok by lukem@.
2006-03-17 21:28:21 +00:00
peter ee7f54fae4 Set file to NULL after calling fclose().
Fixes Coverity CID 2669.
Ok by lukem@.
2006-03-17 21:26:55 +00:00
peter 243139ee37 Make sure that "su" is initialized before dereferencing it.
Fixes Coverity CID 1075.
Ok by lukem@.
2006-03-17 21:24:33 +00:00
ginsbach 7ee29c7f81 Fix Coverity issue 1564, resource leak, dynamically allocated storage not
freed before function return.
2006-03-17 21:19:24 +00:00
elad 615bdca25f Fix three off-by-ones found by Coverity, CID 1489. 2006-03-17 21:10:02 +00:00
elad 35ad67c75e Fix off-by-one found by Coverity, CID 1485. 2006-03-17 21:01:02 +00:00
elad 7d1c72d85d Fix off-by-one found by Coverity, CID 1486. 2006-03-17 20:48:09 +00:00
dsl 0ab764f9ff Don't add every source directory to the -I path.
Instead use CPPFLAGS.file to add the relevant directory for each file.
Removes about 4000000 failed open() system calls from the libcrypto build,
and reduces the compile time (on my system) from 154 seconds to 115 seconds.
The arch/*/*.inc files need similar treatment.
2006-03-17 20:47:45 +00:00
elad cbe6a15c01 Another overrun forgotten in previous commit, also found by Coverity.
CID 1481.
2006-03-17 20:44:28 +00:00
elad ab24a02ffe Fix buffer overrun found by Coverity, CID 1482. 2006-03-17 20:41:02 +00:00
xtraeme 4a4be4e854 Match the VIA VT8237 chipset, too. ok'ed by jmcneill 2006-03-17 19:52:35 +00:00
perseant 16cb5d93b2 Make it compile again. 2006-03-17 19:24:08 +00:00
dsl 87f04837fb Fix build breakage, split assignment and test for ease of reading. 2006-03-17 19:18:33 +00:00
wiz e59b4b68e0 Sort a bit. 2006-03-17 18:44:07 +00:00
macallan e60d56080c mention xorg 7.0 import 2006-03-17 17:47:57 +00:00
hubertf dc01675c5a Put check if "best" is empty back into the right place, messed up
in previous commit.
Noted by yamt@
2006-03-17 17:46:44 +00:00
christos df8cbb182e Coverity CID 2479: Clarify confusion about uninitialized variable in the
presence of setjmp/vfork.
2006-03-17 17:20:47 +00:00
christos 14ebd4f381 Appease Coverity CID 2527; not a bug. 2006-03-17 17:17:00 +00:00
christos fca770b32a Appease Coverity CID 2580 [not a bug] 2006-03-17 17:06:30 +00:00
christos 227e68b656 free memory on allocation failure. 2006-03-17 17:04:22 +00:00
christos 2044d4f590 Coverity CID 2671: Fix use of ifp after free. 2006-03-17 16:58:09 +00:00
tnozaki e01718f7f1 do not use LS0/LS1 but SI/SO. 2006-03-17 16:37:10 +00:00
tnozaki 2a441a26bc fix invalid charset-bit. 2006-03-17 16:25:06 +00:00
hubertf 2b40d43066 Fix minor ressource leak
Coverity CID 1855
OK'd by thorpej
2006-03-17 16:14:48 +00:00
uebayasi 8572d2c144 Stop using linker scripts on all sh3 ports.
The only information to be compensated is text section start address.
The default value is set arch-wise as DEFTEXTADDR.  Each kernel config
can override the default value by setting TEXTADDR.

Tested on COMPUTEXEVB (evbsh3).

Reviewed By:	uwe
2006-03-17 16:06:51 +00:00
rumble e948e1b17f Check for allocation failures in malloc, calloc, realloc, asprintf, and
vasprintf and try to handle them.
2006-03-17 15:53:46 +00:00
ginsbach f44127c4ef Fix Coverity issue 2281, resource leak, function return without freeing
dynamically allocated storage.
2006-03-17 15:53:29 +00:00
peter 11f7fb17d4 Fix file descriptor leaks.
Coverity CID 1681.
2006-03-17 15:50:44 +00:00
christos 75f03570ec Coverity CID 2719: argvalue can be NULL when passed into functions.
De-obfuscate by undefining optarg, and check explicitly for NULL before
use.
2006-03-17 15:39:44 +00:00