christos
58deb05d13
Coverity CID 865: Fix possible NULL deref
2006-03-18 21:14:09 +00:00
christos
760ba920f3
Coverity CID 867: Fix possible NULL deref.
2006-03-18 21:11:43 +00:00
christos
b2229dcdbc
Coverity CID 955: Fix possible NULL deref.
2006-03-18 21:10:12 +00:00
christos
33c12e6be9
Coverity CID 956: Possible NULL pointer deref.
2006-03-18 21:07:47 +00:00
christos
0a7d87f083
Coverity CID 957: Prevent NULL pointer deref.
2006-03-18 21:05:10 +00:00
christos
d9e5b13b10
Coverity CID 2033: Fix memory leak.
2006-03-18 20:48:42 +00:00
christos
6b81e42601
Coverity CID 2358: Although mp2 cannot be NULL here, checking it below for
...
NULL is confusing. Check in both places.
2006-03-18 20:46:23 +00:00
christos
973debfe6f
Coverity CID 2359: Possible NULL deref.
2006-03-18 20:43:48 +00:00
christos
f3d47984b8
Coverity CID 2389: Remove extraneous check
2006-03-18 20:40:53 +00:00
christos
7908a85339
Coverity CID 2390: Wrong test; p cannot be NULL.
2006-03-18 20:38:01 +00:00
christos
06bdf1a1e0
Coverity CID 2485: Possible uninitialized variable use.
2006-03-18 20:33:34 +00:00
dsl
55d48ecf23
Remove the unnecessary 'if (found)' to stop Coverty bleating (CID 864)..
2006-03-18 18:05:13 +00:00
kardel
063cb750db
mem leak: unreachable code prevented freeing of allocated memory
...
(Coverity CID 612 NetBSD Scan 5)
2006-03-18 15:22:34 +00:00
kardel
012eaf5162
null deref: avoid 0 deref (Coverity CID 987 NetBSD Scan 5)
2006-03-18 14:33:20 +00:00
kardel
36ab9cfe6b
buffer bounds: one beyond buffer (Coverity CID 1490 NetBSD Scan 5)
2006-03-18 14:25:17 +00:00
kardel
a07906a5a8
buffer bounds: buffer full condition wrong for bounds check (Coverity CID 1508 NetBSD Scan 5)
2006-03-18 14:18:59 +00:00
kardel
630d3f115c
buffer bounds: correct > - >= error for bounds check (Coverity CID 1511 NetBSD Scan 5)
2006-03-18 14:08:29 +00:00
kardel
99c0e2540c
buffer bounds: clamp index for epobuf to buffer bounds (Coverity CID 1512 NetBSD Scan 5)
2006-03-18 14:02:13 +00:00
kardel
80b13f6f4e
mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5)
2006-03-18 13:44:15 +00:00
kardel
ee0722e2b9
avoid close(-1): don't attempt to cleanup INVALID_SOCKET ( ==-1 ) fd's - would lead to close(-1) and FD_CLR((u_int)-1(!), ...) (Coverity CID 1281 NetBSD Scan 5)
2006-03-18 13:13:25 +00:00
kardel
9429ea9653
null deref: backport current ntp code to fix (Coverity CID 759)
2006-03-18 12:40:48 +00:00
dan
dbd04f2b27
free buf in error path; CID 2061
2006-03-18 12:15:05 +00:00
kardel
58ad32062f
Coverity NetBSD scan CID 2055: fallout fix return/fclose -> fclose/return
2006-03-18 09:28:50 +00:00
kardel
e13d171a8e
resource leak (fd/mem): fclose() streams on error (Coverity NetBSD scan CID 2055)
2006-03-18 09:26:08 +00:00
kardel
589ea6e802
resource leak (fd/mem): close stream when errors occur (Coverity NetBSD Scan CID 2054)
2006-03-18 08:57:25 +00:00
kardel
862343544d
resolve CID 808 for the general case (code didn't trigger it - constant strings were supplied )
2006-03-18 08:09:03 +00:00
christos
f5b7b11e49
Coverity CID 346: Double free.
2006-03-18 04:41:57 +00:00
christos
a7e5a4a743
Coverity CID 347: remove dead code.
2006-03-18 04:39:50 +00:00
christos
dee21a2f06
Coverity CID 586: Remove dead code.
2006-03-18 04:34:41 +00:00
elad
6dceae8a70
Ditch the ugly hardcoded value and do proper bounds checking.
...
Addresses CID 1417, found by Coverity.
Hi Darren! is this code maintained?
2006-03-18 04:12:52 +00:00
christos
06b02ffc92
Coverity CID 1284: Handle -1 return from open(2)
2006-03-18 03:49:37 +00:00
christos
f5b784887f
Coverity CID 1462: Static buffer overrun; off by 2.
2006-03-18 03:45:34 +00:00
christos
16fbed8bd1
Coverity CID 1616: Memory leak.
2006-03-18 03:43:13 +00:00
christos
fd8155f293
Coverity CID 1617: Memory leak
2006-03-18 03:39:57 +00:00
christos
67c67fc5bf
Coverity CID 2059: Memory leak.
2006-03-18 03:35:41 +00:00
elad
77e1c3c1fc
Fix off-by-one, found by Coverity. CID 1466.
2006-03-18 02:35:47 +00:00
elad
3af85b1067
Fix off-by-one found by Coverity, CID 1516.
2006-03-18 02:15:03 +00:00
kardel
9bccbf4462
Coverity fixes:
...
CID
687 missing block
988 null pointer deref on shutdown (on open failure - introduced by
change of contract in ntp_refclock.c)
989 null pointer for private data (could not happen - safeguard anyway)
1513 off by one
2410 misplaced null pointer test
2006-03-18 00:30:30 +00:00
peter
11f7fb17d4
Fix file descriptor leaks.
...
Coverity CID 1681.
2006-03-17 15:50:44 +00:00
chris
d79b92051d
Only dereference b after it has been NULL checked.
...
Coverity CID 2398.
2006-03-17 02:52:56 +00:00
agc
a4c7ca1aeb
Get rid of c99isms in the form of variable number of args to CPP macros.
...
This should slim down the resulting binaries a fair bit as well.
2006-03-12 18:47:27 +00:00
agc
7acf73bedf
Thanks to Thomas for the prod - update usage message to include all
...
supported options.
2006-03-11 12:09:36 +00:00
wiz
fb778aad1c
Compact single letter options in SYNOPSIS. Sort option descriptions.
2006-03-11 11:58:53 +00:00
wiz
674cf041a7
Sort options as in man page.
2006-03-11 11:58:22 +00:00
wiz
93ba37c7ea
Add -V to SYNOPSIS; serial comma; sort option descriptions.
2006-03-11 09:21:03 +00:00
he
56dbe819ca
If compiling for NetBSD/vax, define boolean_t here before including
...
<sys/file.h> with _KERNEL defined. Also add a 3-line XXX comment
explaining some of why this is done.
Should fix the build problem documented in PR#32907.
Will be documented in doc/HACKS shortly.
Fix discussed with thorpej.
2006-03-07 18:18:06 +00:00
wiz
e2a71c2aab
'advertisment' -> 'advertisement', from leonardo chiquitto filho
...
via jmc@openbsd.
2006-03-07 18:15:28 +00:00
agc
d4397af4d8
One more off the TODO list, although I hadn't realised it was going to be
...
as painful as it was.
Teach GNU autoconf to recognise socklen_t, and use it in the code.
2006-03-06 20:52:32 +00:00
agc
32306cea7e
I have a nasty feeling it's time to sell all my guitars:
...
Add some very crude hacks which allow the iscsi-target to work with IPv6:
Mar 5 23:43:45 sys3 iscsi-target: > Discovery login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar 5 23:43:45 sys3 iscsi-target: < Discovery logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar 5 23:43:45 sys3 iscsi-target: > Normal login from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
Mar 5 23:43:48 sys3 iscsi-target: < Normal logout from iqn.1994-04.org.NetBSD.iscsi-initiator:agc on 7f00:1::1002:cbc
These have still to be cleaned up, but this will happen over the next
few days.
Update the TODO list to reflect the current state.
2006-03-05 23:50:46 +00:00
agc
ff69df84c5
Add IPv6 awareness.
2006-03-04 22:06:26 +00:00