4ce0dc3a15
Fix an issue introduced with the prop_stack change: It's not a good idea to
...
return a 3-value enum from a function declared to return bool. This broke
the recurse case for prop_object_equals(). Instead, declare the object type
equals routine to return a _prop_object_equals_rv_t.
Give the same treatment to the object type free routines: declare them to
return a _prop_object_free_rv_t, and consistently check those return values
againt the enum type.
Tidy up some whitespace while we're here.
2008-08-03 04:00:12 +00:00
1d49730690
Fix a typo.
2008-08-03 03:11:28 +00:00
154fe9b1d9
Don't convert cpuid_t through int while testing it for being in range.
...
(Might truncate it, for one thing. Also, if the shift result is < 0 the
demons have already flown out of our nose.)
Fixes some -Wsign-compare warnings.
2008-07-27 05:47:56 +00:00
9dfcfe5db5
Add few KASSERTs.
2008-07-14 01:07:39 +00:00
94bc3febe6
Changes to make lint STFU.
2008-06-30 20:54:19 +00:00
5a4f0c6b2b
Change tree op members/typedefs to rbto_compare_* from rb_compare_*
2008-06-30 20:14:09 +00:00
48717a981d
Move rb.c from sys/lib/libkern to common so it can be in both libc and libkern.
2008-06-30 19:03:59 +00:00
d6c32b235a
+atomic_cas_*_ni
2008-06-23 10:33:52 +00:00
7a21650601
Install manual pages for the atomic ops.
2008-06-23 10:22:40 +00:00
d6e5879de3
Be consistent in how cpuset_nentries is computed in the kernel and
...
in user-land. This fixes the user-land part. Now "cpuctl identify 0"
gives a result instead of getting EINVAL from the set-affinity syscall.
2008-06-22 21:49:31 +00:00
54ccd4a6fa
kcpuset_isset: remove if-check. It is not reasonable for kernel,
...
saves few cycles, and it is better for CPU cache.
2008-06-22 03:24:31 +00:00
dfeefcdcb8
Separate cpuset and kcpuset, and only use the bits in userland. Requested
...
by yamt
2008-06-22 00:05:09 +00:00
e0e4b153c9
_prop_rb_tree_insert_node() now returns true/false to indicate if the
...
insertion succeeded. Update existing usage that arranges for insertions
to always succeed to assert that they do.
2008-06-17 21:29:47 +00:00
ddbb9c58dd
We don't need any of this in standalone mode.
2008-06-16 13:02:08 +00:00
04608dd0bf
little more lint
2008-06-16 02:53:32 +00:00
834ef62012
make lint happy
2008-06-16 02:30:03 +00:00
481ae1556f
- Add general cpuset macros.
...
- Use kcpuset name for kernel-only functions.
- Use cpuid_t to specify CPU ID.
- Unify all cpuset users.
API is expected to be stable now.
2008-06-16 01:41:20 +00:00
7d902495c2
cpuset_create: check the return value of calloc().
2008-06-15 23:45:51 +00:00
8f8073542b
- cpuset_create: pass correct argument to sysctl(3).
...
- Constify few variables.
2008-06-15 23:41:39 +00:00
b46ed27e5c
Hook into sys
2008-06-15 20:35:11 +00:00
849fbad5b6
cpuset related functions, shared between the kernel and userland.
2008-06-15 20:33:50 +00:00
46c5658a32
Sort SEE ALSO.
2008-06-04 07:46:48 +00:00
9b09c481c8
Add prop_array_util functions to proplib. This code is copied/changed
...
prop_dictionary_util.
From manual page
The prop_array_util family of functions are provided to make getting and
setting values in arrays more convenient in some applications.
OK by mjf@ and freza@.
2008-06-03 20:18:24 +00:00
b95cd5a6fe
Fix typo.
...
OK by martin@.
2008-06-02 09:27:04 +00:00
6740bb5440
enable profiling of assembly functions.
2008-05-25 15:56:11 +00:00
75b1a2ec18
fix recursive read-lock bugs found by lockdebug and reported
...
by Geoff C. Wing and others. ok'ed by Jason Thorpe.
an earlier version was tested by Sverre Froyen.
PR/38732 from oster@.
2008-05-24 14:32:48 +00:00
6787eedebd
revert the recent "use trylock to hide locking errors" changes
...
and their associated changes, in particular, the following versions.
prop_array.c 1.13-1.16
prop_dictionary.c 1.25-1.28
prop_object_impl.h 1.21-1.25
ok'ed by core@.
2008-05-24 14:24:04 +00:00
848e7ffe8c
In prop_data_create_data(blob, len), if len == 0, allocate no memory
...
for blob, and leave pd_mutable set to NULL. In this way, avoid
tripping over the assertion in prop_data_data_nocopy().
2008-05-15 21:23:33 +00:00
e70ab693a2
Change the argument of _PROP_RWLOCK_TRYRDLOCK() to the lock member and not
...
its address to be consistent with all the other macros.
2008-05-07 10:16:41 +00:00
2916b940f8
Replace _prop_rwlock_tryrdlock() by a macro _PROP_RWLOCK_TRYRDLOCK().
...
This avoids build failures in stand alone binaries (e.g. bootloaders)
where there is no "pa_rwlock" member in the "_prop_array" structure.
2008-05-07 10:01:50 +00:00
4ec02db9e9
Fix a "#define<tab><tab>" that crept in to previous.
2008-05-07 05:40:01 +00:00
35fe7cdcf1
prop_object_iterator_next() and prop_object_iterator_reset() were
...
acquiring the rwlock recursively in some paths.
Introduce _prop_rwlock_tryrdlock() and use it in these functions, so
that the rwlock is *always* acquired once, while here add some
_PROP_RWLOCK_OWNED asserts to verify.
This definitely fixes the "locking against myself" panics.
2008-05-06 22:57:26 +00:00
d69a8a8939
Xref prop_dictionary_util(3).
2008-05-06 17:23:38 +00:00
771a05b730
Do not acquire the rwlock recursively in prop_{array,dictionary}_iterator_reset()
...
when prop_{array,dictionary}_copyout_ioctl() is called.
Introduce _PROP_RWLOCK_OWNED() which is a KASSERT(rw_lock_held(lock))
and use it in those two functions, also acquire the rwlock in other
places where it is required now.
This fixes a LOCKDEBUG panic "locking against myself", as reported by
Geoff C. Wing in current-users@.
2008-05-06 13:52:51 +00:00
78eb84d14c
whitespace.
2008-05-03 05:43:05 +00:00
9093441576
rename END to ENDLABEL. i'll use END for other purpose. ok by Andrew Doran.
2008-05-03 05:40:21 +00:00
11a6dbe728
Convert TNF licenses to new 2 clause variant
2008-04-30 13:10:46 +00:00
2be642537b
Make this compile (missing register prefix).
2008-04-30 09:59:42 +00:00
9ba64b51be
Assembly _atomic_cas_up() for mips. PR lib/38482.
2008-04-30 00:17:34 +00:00
4e2c4c42b4
Implement _atomic_cas_up() in assembly code as the compiler cannot be
...
trusted to generate fully restartable code sequences.
Addresses lib/38482 for ARM and m68000.
2008-04-29 20:57:50 +00:00
3028e483e4
Convert to new 2 clause license
2008-04-29 06:53:00 +00:00
ce099b4099
Remove clause 3 and 4 from TNF licenses
2008-04-28 20:22:51 +00:00
99adca9efa
Use %xcc for 64-bit comparisons.
2008-04-09 12:49:05 +00:00
c3b0f346ec
Fix pasto.
2008-04-06 04:01:56 +00:00
7dfcdee2a2
Use .c version atomic ops for m68010.
2008-04-05 22:28:36 +00:00
73e50f111b
Do like the non-__OPTIMIZE_SIZE__ variant, and compile memset() unless
...
BZERO is defined, instead of requiring MEMSET to be defined.
Avoids violating the principle of least astonishment, and also fixes
the build of stand/ and kernels for (at least) alpha.
2008-03-29 14:03:22 +00:00
a58a2cddc0
Make the size-optimized memset() actually conform to the man page
...
by returning the first arg.
2008-03-29 12:25:32 +00:00
f5c2801052
Add /* __OPTIMIZE_SIZE__ */ comments on relevant #else and #endif lines.
...
Also change some #ifdef to #if defined() for consistency.
2008-03-26 06:19:36 +00:00
9f2bc34fb9
bcopy does not return ptr.
2008-03-25 23:23:34 +00:00
93f951ce0d
fix #ifdefs for BCOPY
2008-03-25 23:16:29 +00:00
thorpej