Commit Graph

1288 Commits

Author SHA1 Message Date
jnemeth
f413c2ba58 Coverity CID 1326: check for error return 2006-03-30 01:25:52 +00:00
jnemeth
db7b70f433 Fix Coverity issue 891 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:21:07 +00:00
jnemeth
83f277c49a Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
Approved by Christos@.
2006-03-29 01:19:51 +00:00
jnemeth
2ad8d2c6cd Fix Coverity issue 2584 -- USE_AFTER_FREE and issue 889 -- FORWARD_NULL.
Approved by christos@.
2006-03-29 01:18:39 +00:00
christos
93eceea780 Add missing parens. 2006-03-22 15:24:52 +00:00
christos
549b5ed9d1 Simplify (Masao Uebayashi) 2006-03-22 05:03:10 +00:00
christos
8b7bfd1f64 Coverity CID 692: Another && that should be ||. Boy... 2006-03-22 04:24:14 +00:00
christos
1990635dbb Coverity CID 558: && should be obviously || 2006-03-22 04:22:05 +00:00
christos
df3594a46a Coverity CID 2735: Remove dead code. 2006-03-21 20:25:55 +00:00
christos
dd3fe9b2dc Coverity CID 2737: Handle linked-lists properly. Use calloc instead of malloc
so that we don't end up storing garbage accidentally and the next pointer is
initialized. If there is an inconsistency in the file abort instead
of dereferencing NULL.
2006-03-21 17:14:15 +00:00
rtr
90b0b10c77 remove duplicate #include <stdlib.h> 2006-03-20 12:32:21 +00:00
he
3ac2299da5 Now that we use exit(2), we need to include <stdlib.h> for its definition. 2006-03-19 12:09:39 +00:00
christos
c08f926ecb include <stdlib.h> to get a prototype for exit 2006-03-19 06:02:50 +00:00
christos
e92d4ac1fa Coverity CID 1197: Don't pass -1 to close. 2006-03-19 01:00:35 +00:00
christos
4140928aa1 Coverity CID 1467: Elide static buffer overflow. 2006-03-19 00:56:12 +00:00
christos
989c7cd825 Coverity CID 868: Fix possible NULL deref (after INFTIM passes :-) 2006-03-19 00:50:28 +00:00
christos
2197ff9156 Coverity CID 980: Prevent an impossible NULL point deref. 2006-03-19 00:41:46 +00:00
christos
0e8c6c24b2 Coverity CID 2073: Fix memory leak. 2006-03-19 00:37:15 +00:00
christos
0255deb434 Coverity CID 999: Prevent NULL deref. 2006-03-19 00:32:18 +00:00
christos
d7b2adb029 Coverity CID 695: Remove impossible condition. This changes the scoring as
it was probably intended originally.
2006-03-19 00:29:27 +00:00
christos
c29d845a03 Coverity CID 998: Possible NULL pointer deref. Actually this was a bug
where a house to be sold would be skipped. Change the sell loop to be like
the buy side loop.
2006-03-19 00:19:31 +00:00
christos
ad05902b98 fix typo 2006-03-19 00:18:47 +00:00
christos
a195251302 Coverity CID 1004: Fix NULL deref. 2006-03-19 00:05:05 +00:00
christos
db0d71974c Coverity CID 1005: Fix NULL deref and incorrect variable use. 2006-03-19 00:03:18 +00:00
christos
abe5f75745 Coverity CID 1443: Prevent static overrun. 2006-03-19 00:00:19 +00:00
christos
f25329586b Coverity CID 827: Prevent NULL pointer deref. 2006-03-18 23:54:17 +00:00
christos
02549e79e2 Coverity CID 1699: Fix memory leaks. 2006-03-18 23:51:51 +00:00
christos
ffe2beb426 Coverity CID 2544: Fix memory leak. 2006-03-18 23:44:05 +00:00
christos
f09b76be8d Coverity CID 1786: Close file. 2006-03-18 23:38:12 +00:00
christos
f80221a1cd Coverity CID 570: Remove impossible check. 2006-03-18 23:35:51 +00:00
christos
44fa0e017a Coverity CID 1195: Check for possible negative index. 2006-03-18 23:33:38 +00:00
christos
8319a6a7da Coverity CID 777: Fix NULL pointer deref and de-obfuscate code. 2006-03-18 23:31:19 +00:00
christos
c873d1eb57 Coverity CID 1230: Remove spurious close(). 2006-03-18 23:25:30 +00:00
christos
e0b976a0ae Coverity CID 1294: Avoid negative variable used as index. 2006-03-18 23:23:33 +00:00
christos
2a67d42737 Coverity CID 1295: Don't allow cchose to return a negative number. It is
used as an index.
2006-03-18 23:14:45 +00:00
rtr
969e2244d4 fclose() open FILE * even though we are returning to fail anyway.
silences coverity, CID 1590 / run 5
2006-03-18 09:40:46 +00:00
rtr
0c0f6ae5dc don't access out of bounds element of static alloc array.
found by Coverity, CID 1519 / Run 5

XXX possible that intention was to start with i = 0.
2006-03-18 05:16:46 +00:00
abs
a3edf3e145 If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up
2006-03-18 01:43:52 +00:00
abs
e0d5463807 add more "ifdef notdef" around unused sections - addresses Coverity CID 564 2006-03-17 23:36:38 +00:00
abs
b4f3ebd201 Add a missing bp->b_score not null check - addresses Coverity CID 1003 2006-03-17 23:34:37 +00:00
abs
2c2c60a0ef if getpwuid() returns null, print out the uid rather than dereferencing
Addresses Coverity CID 930
2006-03-17 23:22:59 +00:00
abs
f0ff12503e Fix overrun in players[] array. Addresses Coverty CID 1457 2006-03-17 23:15:02 +00:00
abs
b317f83344 If getpwuid() returns null, its not usually a good idea to dereference
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
2006-03-17 23:11:47 +00:00
abs
f4f2f41178 Call fclose() appropriately if there is a problem with the save file.
Coverty CID 2063
2006-03-17 23:04:01 +00:00
simonb
5cfbf7bf76 Use MKPRIVATELIB instead of NOLINKLIB/NOMAN/NOPIC/NOLINT. 2006-02-25 12:04:23 +00:00
simonb
feaaa5ed4c Change DPADD from LIBTERM (which doesn't exist) and LIBCOMPAT (which it
doesn't use) to LIBTERMCAP (which it does use).
2006-02-25 11:56:51 +00:00
wiz
f19f5c87cc Fix typo in the instructions. 2006-02-25 02:06:08 +00:00
wiz
5fcd22e873 Remove duplicate and uncredited "Plan for the Improvement of English
Spelling", which is also in the file "fortunes".
2006-02-25 01:40:22 +00:00
jnemeth
df4822d1f0 Correct The Hitchhiker's Guide to the Galaxy entry about dolphins as per
page 119 of the book.
2006-02-20 03:00:27 +00:00
elad
c53cd0c067 moduli utils moved from games to usr.bin. 2006-01-24 19:01:45 +00:00