Commit Graph

48 Commits

Author SHA1 Message Date
christos 0be3040a8f - use warn/err
- if both users are on the same machine, use the loopback address. This
  allows us to use talkd from inetd listening only to the loopback.
2012-12-29 23:44:22 +00:00
matt d34c2845b8 Use C89 function definitions 2012-03-20 20:34:57 +00:00
joerg 68168df687 ANSIfy + __dead 2011-09-06 18:32:03 +00:00
plunky 9f61b80465 NULL does not need a cast 2011-08-31 16:24:54 +00:00
he 76d4444c78 When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.
2010-02-06 23:45:24 +00:00
lukem c2293a6fbf Fix WARNS=4 issues (-Wcast-qual -Wshadow -Wextra) 2009-04-13 23:43:36 +00:00
lukem 98e5374ccb Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.
2008-07-21 14:19:20 +00:00
tls 4147a3c54a Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry.  RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros.  Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default.  Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
2007-05-28 12:06:17 +00:00
christos e3717c1851 Introduce a TALKHOST environment variable to make talk work through NAT.
From Anon Ymous.
2007-01-08 17:10:59 +00:00
elad 1232ea27c4 PR/18906: roskens at elfin dot net: misc. select() to poll() updates.
Adapted to -current by myself, thanks for the patch!
2006-10-07 17:27:57 +00:00
ginsbach ccae083c7b Fix Coverity CID 1248, negative return from read() passed() to write()
as a large unsigned value.
2006-03-18 03:40:51 +00:00
ginsbach 7ee29c7f81 Fix Coverity issue 1564, resource leak, dynamically allocated storage not
freed before function return.
2006-03-17 21:19:24 +00:00
christos c4445bc71c rename osockaddr to talkd_sockaddr and use that instead. 2005-09-24 16:40:01 +00:00
christos 4d4a846694 PR/24862: Peter Postma: From Andrey Matveev via OpenBSD:
1. use socklen_t instead of int
2. compare socket error return value to == -1 instead of <= 0
2004-03-20 17:07:33 +00:00
jmmv b635f565e7 Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.
2004-01-05 23:23:32 +00:00
agc 89aaa1bb64 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22365, verified by myself.
2003-08-07 11:13:06 +00:00
wiz 7e681f7063 interrupt with two rs. 2003-01-06 13:04:54 +00:00
thorpej 29d4b591ea Avoid strict alias warning. 2002-12-06 03:21:43 +00:00
grant be8ae688ae New sentence, new line. 2002-09-30 11:08:56 +00:00
mycroft aae6c28cf9 null commit 2002-09-23 12:44:34 +00:00
itojun 6248b5281d poll.h, not sys/poll.h 2002-09-23 03:29:10 +00:00
mycroft 675b884ce8 select() -> poll() 2002-09-18 19:16:09 +00:00
wiz 001cc25b44 Drop a .Pp, sort sections. 2001-12-08 19:17:46 +00:00
blymn 531ada40fc Changed deprecated curses function to the new equivalent. 2001-12-07 12:10:09 +00:00
christos b804f806ac PR/5631: Rumi Szabolcs: Make talk work without COMPAT43. 2001-09-27 14:43:31 +00:00
wiz 0a600be867 receive, not recieve 2001-06-12 15:17:10 +00:00
wiz 14dbdf5518 Negative exit code cleanup: Replace exit(-x) with exit(x).
As seen on tech-userlevel.
2001-04-06 11:13:45 +00:00
matt fcd0fb118f Make gcc 2.96 (and maybe earlier) happier. Include <stdlib.h>,<string.>,
etc. as appropriate to get exit,srncmp,abs,abort,etc.
Add -I${.CURDIR} to a few Makefiles
2000-07-03 02:51:12 +00:00
christos 7ccd2afae9 Teach the socket code a few things about this decade (should fix the
problem where COMPAT_43 was required for it to work)
2000-03-02 17:37:46 +00:00
proff 209c8a802a ctrl-g is beep(), not "^G", damnit. strictly for the attention deprived. 1999-08-13 13:52:59 +00:00
garbled 9e44e9b578 More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages.  Many more to
come.
1999-03-22 18:16:34 +00:00
christos 719b192026 sigvec->sigaction 1998-12-19 22:36:11 +00:00
mycroft a405bce56c const poisoning. 1998-07-26 22:26:29 +00:00
mrg 2beab49a06 - use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames
1998-07-06 06:45:41 +00:00
jtc 9a0063c6d6 Simply include -lcurses instead of -lcurses -ltermcap 1998-02-18 22:47:41 +00:00
christos 60315cbc81 Does not need -lcompat 1998-02-02 14:10:45 +00:00
lukem 32a9e65f70 WARNSify, fix .Nm usage, deprecate register, convert select to fd_set 1997-10-20 00:23:14 +00:00
is ab90e48ac0 Use isprint() instead of hardcoded c<' '. This way, as soon as isprint() and
friends are localized, talk will be able to communicate in (e.g.) ISO-8859-1.
Patch by Matthias Scheler (PR bin/2874).
1997-04-21 16:15:32 +00:00
jtc 51207773f0 Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.
1994-12-09 02:14:09 +00:00
deraadt 8ef0a5ca8b don't trounce on argv[1] 1994-04-17 12:31:05 +00:00
cgd 2b12186e93 kill warning/error 1994-03-28 11:17:16 +00:00
cgd 335cfa780f a core is a bad thing to drop; check NULL 1994-01-24 22:03:04 +00:00
mycroft 65caf7fdfd #include <sys/ioctl.h>, to get FIONREAD. 1993-08-14 13:47:51 +00:00
mycroft 330f671351 Use termios rather than sgttyb. 1993-08-10 00:07:05 +00:00
mycroft e9d867ef50 Add RCS identifiers. 1993-08-01 17:54:45 +00:00
mycroft c3e42d1c64 Add RCS indentifiers. 1993-08-01 07:22:47 +00:00
mycroft 75ff3a90bd Add RCS identifiers. 1993-07-30 23:49:23 +00:00
cgd 61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00