Commit Graph

1180 Commits

Author SHA1 Message Date
he c6974f26a9 Use the value-returning variants of the 64-bit endian macros instead
of the argument-tweaking variants (e.g. htobe64 instead of HTOBE64).
2006-05-22 20:48:08 +00:00
christos 663ee5bb90 Coverity CID 2956: Avoid NULL deref. 2006-05-21 17:41:20 +00:00
christos f84c1e59e0 Coverity CID 2958: Avoid NULL deref. 2006-05-21 17:39:10 +00:00
christos a7631b82f6 Coverity CID 2974: Check for negative before assigning to unsigned variable 2006-05-21 17:35:23 +00:00
christos 884667d071 Coverity CID 3491, 3492: Plug memory leaks. 2006-05-21 17:32:23 +00:00
christos 555b8edb2d Coverity CID 3493: Comment out dead code. 2006-05-21 17:26:08 +00:00
christos d159dc82e4 Coverity CID 3494: Plug memory leak. 2006-05-21 17:23:36 +00:00
agc e32a776a5a Adjust the data VPD returns, to work around a problem in the Cisco
initiator (used on Solaris 10 Update 1) - the initiator demands that a
UUID is returned, so give it one.

Add autoconf glue for that, and a compat uuid_create(3) and
uuid_to_string(3).

This still spews a lot of output via the target's syslog, but persevere,
since it does actually make the target work with the Solaris initiator:

	solaris10# format
	Searching for disks...done


	AVAILABLE DISK SELECTIONS:
	       0. c1d0 <DEFAULT cyl 29728 alt 2 hd 64 sec 63>
		  /pci@0,0/pci-ide@1f,1/ide@0/cmdk@0,0
	       1. c2t5d0 <DEFAULT cyl 96 alt 2 hd 64 sec 32>
		  /iscsi/disk@0000iqn.1994-04.org.netbsd.iscsi-target%3Atarget00001,0
	Specify disk (enter its number): ^D
	solaris10# df -k /mnt
	Filesystem            kbytes    used   avail capacity  Mounted on
	/dev/dsk/c2t5d0s0      91407    1041   81226     2%    /mnt
	solaris10# uname -a
	SunOS solaris10 5.10 Generic_118844-26 i86pc i386 i86pc
	solaris10#
2006-05-21 09:26:37 +00:00
mrg 995cc7365d initialise tmp_clock() for GCC4. 2006-05-20 19:22:36 +00:00
drochner 65f32e5703 Make the optimizer use unsigned numbers as the kernel does.
While it is not agreed on that purely unsigned arithmetics is nice,
different behaviour of optimized and unoptimized code is less desirable.
2006-05-17 17:48:36 +00:00
christos e4162ca0f8 XXX: GCC uninitialized. 2006-05-14 23:36:01 +00:00
christos be1c3e616c XXX: GCC uninitialized. 2006-05-14 02:37:46 +00:00
christos 653a86901d XXX: GCC uninitialized 2006-05-14 02:10:41 +00:00
christos e75e0ea2a7 another XXX: GCC uninitialized variable. 2006-05-14 01:31:14 +00:00
christos 9da0166ffa Another uninitialized variables XXX: GCC 2006-05-14 01:30:00 +00:00
christos af2ae0aa2f Initialize rdataset. 2006-05-14 01:18:41 +00:00
christos 386c6259af Coverity CID 3497: Don't try to set the day/month if we did not get them
from the clock.
2006-05-13 23:55:23 +00:00
christos 19a2d0dbea Coverity CID 3197: Don't leak fp. 2006-05-13 22:50:24 +00:00
mrg d1e102b605 match u_char * with u_char[]. 2006-05-11 09:29:39 +00:00
mrg 3394a47b32 move is_zone initialisation earlier to avoid a GCC warning. 2006-05-11 09:28:45 +00:00
mrg 0fa82c2792 move the extern for clktypes[]'s somewhere it's type is defined. 2006-05-11 00:11:25 +00:00
mrg ebd6722e04 ctl_trap[] is not public so don't extern it. 2006-05-11 00:10:54 +00:00
mrg 0eaf0f8b7c #include <sys/param.h> since we want to check __NetBSD_Version__. 2006-05-11 00:08:44 +00:00
mrg 084c052803 quell GCC 4.1 uninitialised variable warnings.
XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..
2006-05-10 21:53:14 +00:00
skrll a9f4c28a3d Fix a bunch of cast lvalues. 2006-05-10 06:24:02 +00:00
mrg 0c37c63edc change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.
2006-05-09 20:18:05 +00:00
kardel e01a907378 NetBSD 22 CID 3049,3075: safeguard against (unlikely to impossible) NULL deref 2006-05-04 08:24:05 +00:00
tron 63cb4a87e2 Cast precision argument for sprintf() to int to fix build problems
on 64-bit platforms.
2006-05-02 10:09:18 +00:00
kardel 70ff37328f handle NULL return from d2i_X509() - NetBSD Run 21 Coverity CID 2979 2006-05-02 09:24:19 +00:00
christos 3e168a2a10 Use the sizeof the field instead of the #define constant. Fixes off-by-one
error.
2006-05-01 18:40:02 +00:00
uwe ee952d9fc0 Use be64toh/htobe64 instead of upper-case versions.
Thanks to lint that caught this on big-endian arches.  Little-endian
compiled, but I guess that converting your loop counter into
big-endian inside the loop is not exactly what you want to do.
2006-04-30 01:07:59 +00:00
christos 70a262c03c Coverity CID 785: Prevent NULL pointer dereference if an appropriate group
is not found.
2006-04-28 19:49:13 +00:00
agc 62b10a5c9c Rather than hardcoding 8 LUNs per disk, use the number for the disc. 2006-04-26 20:31:43 +00:00
agc 84fba20a22 Use the correct opcode for the WRITE6 SCSI command 2006-04-26 20:29:56 +00:00
pavel f705cb5488 We do not support pfsync, so:
- remove xrefs to pfsync(4)
- remove the no-sync keyword from pf.conf(5)
- add a note to pf(4).

Approved by Peter Postma.
2006-04-26 18:14:19 +00:00
pavel e3b35bceeb The "group" keyword is not supported in NetBSD, so:
- add a CAVEATS section to pf(4) and note it
- in the description in pf.conf(5) say it is unsupported
- remove it from the grammar in pf.conf(5).

Approved by Peter Postma.
2006-04-26 17:55:33 +00:00
tron 27048c613e Add missing "const" keywords to match declarations in "pcap.h". 2006-04-26 09:24:33 +00:00
agc 000a68021a + Some minor formatting cleanup in the header files.
+ Properly pad the names with spaces (with thanks to Bill Studenmund)
+ Use the official T10 vendor name, "NetBSD".
+ Minor cleanup in the INQUIRY command
+ Rather than just punting on the REPORT LUNs SCSI command, emulate it
properly.  This change makes the target work with the Solaris initiator:

	AVAILABLE DISK SELECTIONS:
	       0. c1d0 <DEFAULT cyl 29728 alt 2 hd 64 sec 63>
		  /pci@0,0/pci-ide@1f,1/ide@0/cmdk@0,0
	       1. c2t5d0 <DEFAULT cyl 97 alt 2 hd 64 sec 32>
		  /iscsi/disk@0000iqn.1994-04.org.netbsd.iscsi-target%3Atarget00001,0
	Specify disk (enter its number): 1
2006-04-24 21:59:03 +00:00
elad 7cc919d464 fix typo. pr 33344. forwarded to paulus at samba dot org. 2006-04-23 19:01:08 +00:00
pavel 1cca0f0250 correct a typo: configruation -> configuration 2006-04-20 08:37:33 +00:00
darrenr 0df9b5fe68 ipf -Z returns junk and/or can cause a panic (seen on solaris.) 2006-04-18 12:40:49 +00:00
agc 339a11eb23 Bump version to 20060417 for the Mac OS X build fixes (thanks, Jason) 2006-04-18 06:52:59 +00:00
thorpej e82413c3cf disk_read() / disk_write(): Make the temporary pointer a uint8_t *, rather
than a char *.  Eliminates a GCC4 warning.
2006-04-17 16:58:31 +00:00
thorpej 0c7787e9ae Let MD5Update() take a void *, rather than a uint8_t *. Gets rid of a
GCC 4 warning.
2006-04-17 16:49:16 +00:00
thorpej 01de58d459 Test HAVE_STDINT_H and bring in <stdint.h> if defined. 2006-04-17 16:45:02 +00:00
thorpej 57de6c70c3 Pull in config.h to get the definition of HAVE_STDINT_H 2006-04-17 16:44:42 +00:00
thorpej 7dd6393f48 Check for <libkern/OSByteOrder.h>. If it exists, use it to get the
OSSwapBigToHostInt64() definition for HTOBE64().  This now builds on
Mac OS X 10.4.6.
2006-04-17 16:30:00 +00:00
agc f27a3c2c6b Commit regenerated config.h so that the correct version strings are picked
up for NetBSD.
2006-04-16 17:19:50 +00:00
agc 7a2241d682 Regenerate with new version number (20060416) 2006-04-15 23:45:30 +00:00
agc 4819a3749d Fix two other bugs which would manifest themselves on architectures which
aren't quite as forgiving as i386 - when using a 16 bit value, use 16 bit
alignment6, not 32 bit. Makes the NetBSD iSCSI target function perfectly
with the Microsoft initiator when run on Solaris 9 on Sparc.
2006-04-15 23:44:08 +00:00