christos
f5b7b11e49
Coverity CID 346: Double free.
2006-03-18 04:41:57 +00:00
christos
a7e5a4a743
Coverity CID 347: remove dead code.
2006-03-18 04:39:50 +00:00
christos
dee21a2f06
Coverity CID 586: Remove dead code.
2006-03-18 04:34:41 +00:00
elad
6dceae8a70
Ditch the ugly hardcoded value and do proper bounds checking.
...
Addresses CID 1417, found by Coverity.
Hi Darren! is this code maintained?
2006-03-18 04:12:52 +00:00
christos
06b02ffc92
Coverity CID 1284: Handle -1 return from open(2)
2006-03-18 03:49:37 +00:00
christos
f5b784887f
Coverity CID 1462: Static buffer overrun; off by 2.
2006-03-18 03:45:34 +00:00
christos
16fbed8bd1
Coverity CID 1616: Memory leak.
2006-03-18 03:43:13 +00:00
ginsbach
ccae083c7b
Fix Coverity CID 1248, negative return from read() passed() to write()
...
as a large unsigned value.
2006-03-18 03:40:51 +00:00
christos
fd8155f293
Coverity CID 1617: Memory leak
2006-03-18 03:39:57 +00:00
christos
67c67fc5bf
Coverity CID 2059: Memory leak.
2006-03-18 03:35:41 +00:00
elad
77e1c3c1fc
Fix off-by-one, found by Coverity. CID 1466.
2006-03-18 02:35:47 +00:00
matt
ba8a81077b
Fix some double frees / missing frees / use after freed all
...
relating to _rtld_load_object. Fix Coverity CID 2601, 2600.
2006-03-18 02:34:30 +00:00
elad
3af85b1067
Fix off-by-one found by Coverity, CID 1516.
2006-03-18 02:15:03 +00:00
elad
d8af4d8962
Change MAX_BLOCKS for b_prop to MAX_PROPS, as it probably should've been.
...
Fixes overrun found by Coverity, CID 1550.
2006-03-18 02:06:38 +00:00
abs
a3edf3e145
If none of the boarding parties are set do not fall off the end of the
...
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up
2006-03-18 01:43:52 +00:00
dogcow
de119fc4bd
in VNDIOCGET, make sure there's a valid lwp. coverity CID 837.
2006-03-18 01:13:24 +00:00
peter
c8593a1a3c
Wrap long lines.
2006-03-18 00:35:02 +00:00
peter
dfd65180e1
Don't try to dereference pw when it's NULL.
...
Fixes Coverity CID 900.
2006-03-18 00:32:34 +00:00
kardel
9bccbf4462
Coverity fixes:
...
CID
687 missing block
988 null pointer deref on shutdown (on open failure - introduced by
change of contract in ntp_refclock.c)
989 null pointer for private data (could not happen - safeguard anyway)
1513 off by one
2410 misplaced null pointer test
2006-03-18 00:30:30 +00:00
peter
f35a71c317
Update version, maintainer and responsible for pf entry.
...
Prompted by Hubert Feyrer.
2006-03-18 00:26:32 +00:00
peter
6dcaf25d17
Free allocated space upon failure.
...
Fixes Coverity CID 1661.
2006-03-18 00:14:50 +00:00
peter
c75c0a8549
Change a return to "goto out" so that fclose will be called.
...
Fixes Coverity CID 1881.
2006-03-18 00:12:02 +00:00
peter
96b1a913a5
Call fts_close() at the end of rm_tree().
...
Fixes Coverity CID 1670.
2006-03-17 23:55:42 +00:00
tls
2ebe53e4ac
Add one more buffer pool, for 512-byte buffers. On the one hand, most
...
systems will never, ever need this -- because they use 8k/1k or even,
these days, 16k/2k or 32k/4k filesystems. On the other hand, when you
do need this, you *really* need it: on anoncvs.netbsd.org, for instance,
where /tmp is 4k/512 and the filesystem contains tens or even hundreds
of thousands of single-frag directories, this essentially doubles the
efficiency of the allocator. Since the overhead of keeping one extra
pool around is minimal, just add it by default.
2006-03-17 23:43:37 +00:00
abs
e0d5463807
add more "ifdef notdef" around unused sections - addresses Coverity CID 564
2006-03-17 23:36:38 +00:00
abs
b4f3ebd201
Add a missing bp->b_score not null check - addresses Coverity CID 1003
2006-03-17 23:34:37 +00:00
rpaulo
7122043ef9
0 > len ==> len < 0
2006-03-17 23:29:20 +00:00
christos
5a57baa413
don't use MALLOC with a non-constant size; use malloc instead.
2006-03-17 23:29:07 +00:00
christos
ee3808b74f
prevent using MALLOC when size is not const.
2006-03-17 23:27:12 +00:00
rpaulo
86cd5b8af4
0 > len ==> len < 0
2006-03-17 23:26:06 +00:00
abs
2c2c60a0ef
if getpwuid() returns null, print out the uid rather than dereferencing
...
Addresses Coverity CID 930
2006-03-17 23:22:59 +00:00
tls
a67eab5ee4
From Konrad Schroeder, in response to strange df output on anoncvs.netbsd.org:
...
We were returning the wrong value for free space. Now we're not.
2006-03-17 23:21:01 +00:00
abs
f0ff12503e
Fix overrun in players[] array. Addresses Coverty CID 1457
2006-03-17 23:15:02 +00:00
abs
b317f83344
If getpwuid() returns null, its not usually a good idea to dereference
...
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
2006-03-17 23:11:47 +00:00
dsl
c3e43200eb
A couple of the xxx.inc files are non-standard.
...
My sed script didn't update them properly!
Also man.inc isn't a source make file.
2006-03-17 23:10:48 +00:00
abs
f4f2f41178
Call fclose() appropriately if there is a problem with the save file.
...
Coverty CID 2063
2006-03-17 23:04:01 +00:00
christos
5653b43bfd
Coverity CID 1226: Remove bogus close call.
2006-03-17 22:48:10 +00:00
christos
1006977549
Coverity CID 1324: Check adrof return; not really possible.
2006-03-17 22:38:44 +00:00
christos
65b5013e95
Coverity CID 2356: Remove bogus test !*argv; also cleanup string usage.
2006-03-17 22:30:11 +00:00
christos
b807e41c56
Coverity CID 1762. Fix resource leak.
2006-03-17 22:24:28 +00:00
christos
94f9c01465
Coverity CID 610: Dead code
2006-03-17 22:20:31 +00:00
ginsbach
1a75882940
Fix Coverity issue 1236, negative return from read() passed to write()
...
as a large unsigned valued when read() is interrupted (errno == EINTR).
2006-03-17 21:52:41 +00:00
christos
d3e8815a4a
Add proper DT_NEEDED dependencies. From Jukka Salmi
2006-03-17 21:43:16 +00:00
peter
9665e92dcd
Remove unreachable code (res could never be NULL here).
...
Fixes Coverity CID 712.
Ok by lukem@.
2006-03-17 21:28:21 +00:00
peter
ee7f54fae4
Set file to NULL after calling fclose().
...
Fixes Coverity CID 2669.
Ok by lukem@.
2006-03-17 21:26:55 +00:00
peter
243139ee37
Make sure that "su" is initialized before dereferencing it.
...
Fixes Coverity CID 1075.
Ok by lukem@.
2006-03-17 21:24:33 +00:00
ginsbach
7ee29c7f81
Fix Coverity issue 1564, resource leak, dynamically allocated storage not
...
freed before function return.
2006-03-17 21:19:24 +00:00
elad
615bdca25f
Fix three off-by-ones found by Coverity, CID 1489.
2006-03-17 21:10:02 +00:00
elad
35ad67c75e
Fix off-by-one found by Coverity, CID 1485.
2006-03-17 21:01:02 +00:00
elad
7d1c72d85d
Fix off-by-one found by Coverity, CID 1486.
2006-03-17 20:48:09 +00:00