Commit Graph

4296 Commits

Author SHA1 Message Date
christos fbdfb6fbf0 Coverity CID 2753: Free the correct variable. 2006-03-22 16:35:44 +00:00
christos bd5a805fc3 fix compile problem. 2006-03-22 15:45:16 +00:00
christos 86bc6ef985 Coverity CID 786: Avoid NULL dereference. 2006-03-22 02:25:44 +00:00
christos 9a02e676ef Coverity CID 1301: Return early if we could not open /dev/null 2006-03-22 02:23:11 +00:00
christos 7ef824757b Coverity CID 1593: Plug memory leak 2006-03-22 02:21:20 +00:00
pavel d8e5c31820 Clarify and correct the description of the -R (Record Route) flag.
Reviewed by jnemeth, whith help from him.
2006-03-21 22:54:46 +00:00
christos aa1540d7a7 Coverity CID 2742: Avoid NULL deref. 2006-03-21 21:50:44 +00:00
christos b771b70f76 Coverity CID 1601: Fix memory leak. 2006-03-21 21:43:03 +00:00
christos 22eda87ac9 Coverity CID 1603: Fix memory leak. 2006-03-21 21:41:00 +00:00
christos 0c9dfbbbdf Coverity CID 1688: Fix memory leak. 2006-03-21 21:37:34 +00:00
christos 1f5c810a97 Coverity CID 782: Don't dereference NULL was not going to happen, but:
1. return error instead of the trashed errno.
2. don't return -1, but return ENAMETOOLONG.
3. eliminate unused code.
2006-03-21 21:34:01 +00:00
christos 7067dcb9a4 Always check the results of getmntopts() and free them. 2006-03-21 21:11:41 +00:00
pavel c38d26c2d6 Bump date, requested by wiz. 2006-03-21 09:54:12 +00:00
pavel 104eb3fa9f -I does work for unicast pings too (it sets the source address).
With some language help from dsl.
Reviewed by jnemeth.
2006-03-21 09:15:53 +00:00
christos db80529cf2 Delete an obvious free(NULL) pointed out by erh. 2006-03-20 22:44:25 +00:00
christos 731d9b0c04 Coverity CID 2305: Fix memory leak. 2006-03-20 01:51:54 +00:00
christos ef75a584c1 Coverity CID 2301: FIx memory leak. 2006-03-20 01:45:12 +00:00
christos 4b15f35af4 Coverity CID 2302: Free fat if fatal error to avoid leak. 2006-03-20 01:42:47 +00:00
christos 74f7dc651d Coverity CID 2299: Fix memory leak. 2006-03-20 01:37:10 +00:00
christos 16f27d8161 Coverity CID 2298: Fix memory leak. 2006-03-20 01:34:16 +00:00
christos 3401a36160 Coverity CID 2074: Fix memory leak. 2006-03-20 01:30:34 +00:00
christos 635d729786 Coverity CID 1745: Fix memory leak. 2006-03-20 01:27:44 +00:00
christos e5919d97fc Coverity CID 1078: Add assertion check for NULL pointer. 2006-03-20 01:25:14 +00:00
christos 0794bfc81d Coverity CID 2551: Don't use LIST_FOREACH() if you are going to free the
current element (bp) in the body of the loop; the foreach does bp = bp->next;
2006-03-20 01:20:55 +00:00
christos db7722d2a7 Coverity CID 774: Don't increment a pointer *before* testing it for NULL! 2006-03-20 01:06:07 +00:00
christos 9871eb575d Coverity CID's 1853, 1852, 1851: Plug memory leaks. 2006-03-20 01:00:34 +00:00
christos 25207a2398 Coverity CID 1203: Check return code of b64_ntop(). 2006-03-20 00:53:39 +00:00
dan 1fcee3db59 close fp in several error paths, closing Coverity CIDs 1690, 1692.
"go" by go.
2006-03-19 01:57:11 +00:00
christos 55303a4a4b Coverity CID 2307: Possible memory leak. 2006-03-18 20:25:28 +00:00
christos f04c9de45b Coverity CID 2306: Possible memory leak. 2006-03-18 20:23:51 +00:00
christos 5ac5bc844b Coverity CID 1079: Possible NULL deref. 2006-03-18 20:21:50 +00:00
christos 704b63146c Coverity CID 1080: Possible NULL deref. 2006-03-18 20:20:31 +00:00
christos 6672211d0f Coverity CID 2432: Dereference before NULL check. 2006-03-18 19:55:49 +00:00
dsl 57c63d8912 Avoid indexing beyond the end of a malloced array.
Rework loop to be less confusing.
Coverty 519 made me read this code, but this isn't the 'bug' it found.
2006-03-18 12:48:35 +00:00
dsl 46b640e7c6 Coverty 521: fclose() temporary file used when editing label. 2006-03-18 11:38:59 +00:00
christos 6edcc275a1 Coverity CID 2297: Fix memory leak. 2006-03-18 09:51:08 +00:00
dsl df7e187ccb Appease Coverty CID 7449. Avoid close(-1) in error path. 2006-03-18 08:36:50 +00:00
perseant 16cb5d93b2 Make it compile again. 2006-03-17 19:24:08 +00:00
dsl 87f04837fb Fix build breakage, split assignment and test for ease of reading. 2006-03-17 19:18:33 +00:00
christos 2044d4f590 Coverity CID 2671: Fix use of ifp after free. 2006-03-17 16:58:09 +00:00
hubertf 2b40d43066 Fix minor ressource leak
Coverity CID 1855
OK'd by thorpej
2006-03-17 16:14:48 +00:00
rumble e948e1b17f Check for allocation failures in malloc, calloc, realloc, asprintf, and
vasprintf and try to handle them.
2006-03-17 15:53:46 +00:00
rumble e973f66640 Gracefully handle out of memory condition. 2006-03-17 14:50:44 +00:00
elad 6ec9e1c359 Proper bounds check, found by Coverity, CID 1468. 2006-03-17 13:58:27 +00:00
erh e1806cf352 Fix Coverity issue 1579. Check retval from getmntopts(). Use freemntopts(). 2006-03-17 06:51:00 +00:00
chris 4727225848 Fix case where argv wasn't returned or freed.
This fixes Coverity CID 2023.

While here also return NULL if the malloc fails.
2006-03-17 02:48:29 +00:00
elad 21831d5e1d Fix an off-by-one found by Coverity, CID 1456.
I haven't looked, but I suggest security-officer@ looks into it to see if
this may be exploited passively?
2006-03-17 02:31:03 +00:00
hubertf f500b89c3d Free some allocated memory in the failure case when trying to
fetch the panic string.

Fixes Coverity CID 1856.
2006-03-17 01:45:51 +00:00
jnemeth 61f477b7e3 PR/31531: Takahiro Kambe: shutdown(8) quietly exit if execed from login shell 2006-03-07 22:19:55 +00:00
christos 421a9c133c add the 3 opencrypto sysctls. 2006-03-06 00:51:48 +00:00