error = (cmd == SIOCADDMULTI) ?
ether_addmulti(ifr, &sc->sc_ec) :
ether_delmulti(ifr, &sc->sc_ec);
if (error == ENETRESET) {
to this,
if ((error = ether_ioctl(ifp, cmd, data)) == ENETRESET) {
which does the same thing.
(A bazillion is a very large number. This seems to make the i386
ALL kernel smaller by 3kB to 4kB.)
Use ifreq_getaddr() twice in es(4).
Whitespace nits.
identify sockaddr_dl abuse that remains in the kernel, especially
the potential for overwriting memory past the end of a sockaddr_dl
with, e.g., memcpy(LLADDR(), ...).
-> the current names are confusing (didn't change other drivers)
* fix invalid memory access in usbd_transfer (kern/24636)
-> needed for this driver
* fix USB HC detach race condition (kern/32011)
-> main patch needed for this driver, sc_dying changes in other drivers
not necessary but seem right to me
Patch from Matthew Orgass.
http://mail-index.netbsd.org/tech-kern/2007/06/26/0001.html
WQ_PERCPU flag for workqueue and additional argument for workqueue_enqueue()
to assign a CPU might be used. Notes:
- For now, the list is used for workqueue_queue, which is non-optimal,
and will be changed with array, where index would be CPU ID.
- The data structures should be changed to be cache-friendly.
Reviewed by: <yamt>, <tech-kern>
USB problems - just return in detach if the softc appears not to be
filled in completely.
(This is a common problem with usb and probably other drivers which
support detach; we need some API support to deal with this cleanly.)
Add vendors and products from FreeBSD/OpenBSD.
- for aue(4):
ADMtek AN986A Ethernet
Add vendor ELCON Systemtechnik and its product Goldpfeil P-LAN
ELECOM LD-USB20
Mobility EasiDock Ethernet
SIIG2 USB TO Ethernet
- for axe(4):
Acer Communications & Multimedia EP-1427X-2 Ethernet
ASIX AX88178 USB 2.0 10/100 Ethernet adapter
ATen UC210T Ethernet
Belkin F5D5055 Ethernet adapter
Billionton USB2AR Ethernet
D-Link DUB-E100 rev B1
Good Way Technology GWUSB2E
I-O DATA ETG-US2
Ethernet port in the JVC MP-PRX1 port replicator.
Add new vender ID for Linksys (LINKSYS4) and its product USB1000
OQO model 01+ Ethernet
- for cdce(4):
Acer Labs M5632 USB 2.0 Data Link
Add vendor Ambit Microsystems and its product NTL 250 cable modem
COMPAQ iPAQ Linux
Add vendor G.Mate Inc. and its product YP3X00 PDA
Two Motorola devices (FreeBSD/OpenBSD don't have the details)
NetChip Linux Ethernet/RNDIS gadgets
- for kue(4):
Silicom Psion Gold Port Ethernet
- for ural(4):
Belkin F5D7051 54g USB Network Adapter
GIGABYTE GN-54G
Siemens Info 54g USB Network Adapter
- for url(4):
AboCom RTL8151
RealTek RTL8151 PNA
ZyXEL Prestige
Remove duplicates.
Whitespace police.
unused in this driver's callbacks, so this is an aesthetic rather than
functional change ("ucom0 at uslsa0" rather than "ucom0 at uslsa0
portno -848524548").
tshiozak