Commit Graph

12231 Commits

Author SHA1 Message Date
martin
d7f55bad98 PR install/54480: when upgrading a system and re-mounting the target /
with proper options, and the installed system does not use NAME= syntax
in fstab(5), use the device name we used to get here, instead of the
name from fstab, it might be different to what the real system calls the
device (compact flash root showing up as wd0 native, but sd? on the
card reader used for updating it right now).

This is an abuse of the upgrade functionality and in general pretty dangerous
when multiple devices are used in the upgraded fstab (e.g. separate /usr),
and it used to work more by accident with the old code.

However, it is a quite usefull way to upgrade tiny systems with compact flash
root, and it used to work - so support it properly (as far as we can).
2019-08-20 06:38:17 +00:00
martin
6bccae72f0 Fix memory leak (found by MKSANITIZER=yes build). 2019-08-18 11:11:48 +00:00
abhinav
b0ca50fb4d PR bin/54343: We want the callback_args.machine to be NULL if it is not present in the DB.
The previous commit fixed the problem of allowing apropos to not crash and
produce output even if the database is missing values for certain mandatory
fields, such as name, section etc. Normally we don't expect those values
to be missing in the database but in case of parsing errors it can happen.

However, the machine architecture is an optional field since not all man pages
are hardware specific so that should be allowed to be set to NULL if not
present in the database.
2019-08-18 09:14:30 +00:00
kamil
0c4f7708cb traceroute: Add indirection of symbol to remove clash with sanitizers
Add indirection and symbol renaming under MKSANITIZER for the linked in
version of getifaddrs.
2019-08-18 04:12:07 +00:00
martin
2b9b247d73 Oops, avoid double free. 2019-08-17 18:08:06 +00:00
martin
31a289cd68 Fix some memory leaks in error paths 2019-08-17 18:03:12 +00:00
martin
1b565566ff PR 54473: fix error prompt when a set file is missing 2019-08-17 17:51:19 +00:00
martin
effa0345f7 Never trust a compiler that predefines i386 as 1 - do the symbol name
concatenation at the make level instead.
2019-08-15 19:53:01 +00:00
martin
3e1d4a8ce3 Replace black voodo linker magic (sometimes failing) with some
makefile + macro magic to trim the list of available machines on size
restricted install media.
2019-08-15 14:06:40 +00:00
christos
2d0aa66b2f PR/54343: Prevent NULL pointers in callback strings; use "*?*" for now to
identify them.
2019-08-15 10:29:07 +00:00
kamil
74a26dbbb0 Add missing extern declaration of ib_mach_emips in installboot
Change added for the consistency with the existing code.
2019-08-15 08:36:09 +00:00
kamil
bffacbd197 Stop defining _rpcsvcdirty in bss and data
_rpcsvcdirty is already defined in the generated code from rpcgen(1).

Detected during the build with Address Sanitizer (MKSANITIZER).
2019-08-15 08:34:19 +00:00
kamil
cb47fa61ba Avoid symbol clashes in usr.sbin/ypserv/ypserv under MKSANITIZER
Remove symbol conflicts for: gethostbyname2
2019-08-15 08:30:19 +00:00
martin
3004d9767f Fix some "partition index" (as used in the abstract interface)
versus disklabel "partition letter" confusion.
2019-08-14 13:58:00 +00:00
martin
b04f4d6257 On architectures that usually do MBR/disklabel, nevertheless deal with
pure/plain disklabel disks, and explicitly offer this as partitioning
option when bootability is not a concern.
2019-08-14 13:02:23 +00:00
martin
6fec679845 When we ask the user to select a partitioning scheme and they refuse
(that is: select "Exit" in the menu), abort installation.
2019-08-14 12:55:35 +00:00
martin
13f836ecb6 Provide some documentation for macros / defines used in the machine
dependent backend parts of sysinst.
2019-08-14 12:49:37 +00:00
martin
736e79ce31 Make sure to completely initialize dynamic menu entries. 2019-08-13 17:57:49 +00:00
maxv
2b4397de4a sync with reality 2019-08-13 09:48:24 +00:00
gutteridge
1e1742aedb npf.7: add xref to npf-params.7
(Adding directly here since this particular file isn't included in
rmind@'s upstream GitHub repo at present.)
2019-08-11 22:27:15 +00:00
rmind
04ad65d955 Adjust some internal NPF APIs:
* npfkern: use the npfk_ prefix.
* NPF portmap: amend the API so it could be used elsewhere.
* Make npf_connkey_t public.
2019-08-11 20:26:33 +00:00
rmind
b7b9a92305 npf-params(7): add more bpf.jit details.
From David H. Gutteridge.
2019-08-11 20:25:14 +00:00
rmind
64b4ec4316 npfctl show/validate: fix couple bugs in multiple table/port representation.
Fixes PR/54122.
2019-08-10 22:23:55 +00:00
rmind
54d339ec04 NPF: fix BPF byte-code generation for a port-range used in a group.
Resolved PR/52609 and PR/54169.
2019-08-08 21:29:15 +00:00
martin
0dfd6624ca Do not even consider to fsck partitions where we do not know the file
system type. Add v7fs support.
2019-08-08 13:45:19 +00:00
martin
62c0076db0 Do not try to fsck partitions we are never going to mount.
Found by Andreas Gustafsson's baremetal test bed.
2019-08-08 11:41:16 +00:00
martin
b8a71b5965 When creating the /etc/fstab for new installs, the sense of the "noauto"
flag was inverted (editor mishap?)
2019-08-07 10:12:32 +00:00
martin
a7267d5357 Support upgrade of systems using NAME= syntax in /etc/fstab.
Make supported file system types dynamic - instead of hardcoding the
available types at compile time, check for available newfs_* helper
binaries in the actual install environment at runtime.
2019-08-07 10:08:04 +00:00
maya
771183eb32 Consistent indentation / whitespace 2019-08-05 13:50:58 +00:00
maya
0189925033 KNF for loops 2019-08-05 13:49:10 +00:00
maya
e203dacf10 Remove duplicate check for curpkt > 13
We already guarantee this above:
        if (numpkts < 1 || numpkts > 13) {
	                return -1;
2019-08-05 13:45:01 +00:00
maya
538e47f18a Avoid read overflows 2019-08-05 13:39:18 +00:00
martin
6477ac5760 Fix copy&pasto: when we find a FFSv1 filesystem, properly record it
that way - so the correct bootblocks get installed on system upgrades.
2019-08-04 10:29:41 +00:00
martin
9b4c571a0a When reading an existing gpt, match the wedges already existing ons
on the parent device, so we can use them directly if we should proceed
with an unmodified partition table.
2019-08-03 14:00:42 +00:00
martin
a8e7688bfa Properly handle partitions that we were requested to mount but not newfs. 2019-08-03 12:09:22 +00:00
martin
43d7f7864c Deal with missing labels when parsing gpt(8) output. 2019-08-02 10:44:22 +00:00
martin
48cbcc51da If we can not fit a planned partition, retry with a bit more slope
in size.
2019-08-01 17:50:16 +00:00
martin
c8d0c58880 PR 54423: complete initialization of install info for user defined partitions 2019-08-01 17:49:12 +00:00
martin
fcf26eb921 PR 54423: fix handling of user defined partitions 2019-08-01 16:48:06 +00:00
martin
6de470330d Do not strip the trailing / on root mounts when evaluation "last mounted
on". Fix some /dev/ and raw vs. block device confusion on system upgrades.
2019-08-01 16:32:06 +00:00
alnsn
4ca911b475 Move case 'f' to go right after case 'F'. 2019-08-01 08:51:52 +00:00
wiz
3bd03214d0 Fix punctuation formatting nits. 2019-07-31 21:50:25 +00:00
alnsn
02e5a7a9c6 Add an option to read entries from a file. 2019-07-31 15:02:39 +00:00
wiz
3afef2ec6e Fix warning in userdel -r.
If the 'rm -rf' works, then the home directory does not exist any more,
and rmdir() on it will return an error (ENOENT). Catch and ignore it.

Avoids:

# useradd -m foo
# userdel -r foo
userdel: Unable to remove all files in `/home/foo': No such file or directory
2019-07-29 09:33:21 +00:00
martin
4c36c108f4 If available, show additional names of foreign partitions in the
size menu. Makes installing on machines with other OSes installed
a lot less confusing.
2019-07-28 16:30:36 +00:00
martin
ed312f011f When merging existing partitions into the planned installation partitions,
keep the separation between the original planned partitions and the
pre-exiting partitions.
Also do not call found partitions "outer" if they are not (but could be)
2019-07-28 16:03:00 +00:00
martin
5b07b744fb Deal with partition types we don't know anything about. 2019-07-28 13:17:46 +00:00
maya
60afe3f8e7 Whitespace 2019-07-27 23:33:09 +00:00
nakayama
aa464b6cac Add option -D to run in the background using daemon(3).
Also changed the message output to using syslog(3).
2019-07-27 20:10:29 +00:00
msaitoh
e3b8d4c830 - AMD CPUID Fn8000_0001d Cache Topology Information leaf is almost the same as
Intel Deterministic Cache Parameter Leaf(0x04), so make new
  cpu_dcp_cacheinfo() and share it.
- AMD's L2 and L3's cache descriptor's definition is the same, so use one
  common definition.
- KNF.

XXX Split some common functions to new identcpu_subr.c or use #ifdef _KERNEK
... #endif in identcpu.c to share from both kernel and cpuctl?
2019-07-26 10:03:40 +00:00