Commit Graph

16 Commits

Author SHA1 Message Date
itojun b39cb313c6 verify strvis() buffer length is enough. make sure string termination before
use.  remove extra ntohs() which is not needed.  from Charles Blundell
2002-11-20 21:01:57 +00:00
itojun 6701e6929b sa_family on wire format is network byteorder
from Alexander Yurchenko <grange@rt.mipt.ru>
2002-10-08 02:50:51 +00:00
itojun 89b1e287f7 find_user() in process.c does an unbounded copy into a destination
buffer that is smaller in size than the source buffer.

also, there is no guarantee that any of the string components of
the request packet are null terminated.

in some cases, not all elements of the response buffer are
explicitly set. specifically pad and addr. a talk client can spy to
see which host is talking to which host by sending out regular
packets, to which talkd responds without clearing the addr element.

from xs@kittenz.org
2002-09-19 14:39:51 +00:00
christos a0e25e1408 PR/5631: Rumi Szabolcs: Make talk work without COMPAT43 2001-09-27 14:38:58 +00:00
cgd 65a1026492 convert to use getprogname() 2001-02-19 22:43:42 +00:00
christos 20d53d3990 fix nested extern 2001-02-04 22:14:13 +00:00
mrg 2beab49a06 - use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames
1998-07-06 06:45:41 +00:00
mrg 687403aa7a - clean up some more cruft
- support "talkd -l" for extra (syslog(3)) logging
- fix error in previous announce.c change
- use getopt
- add (missing) -d and -l descriptions to man page
1998-07-04 19:31:05 +00:00
mrg 750ef3b29d - use S_IWGRP over 020
- KNF
- ensure we don't overflow a buffer (don't think it would anyway).
- favour snprintf over sprintf (and varargs versions)
1998-07-03 11:54:08 +00:00
christos c030b3a0c2 We are not going to be running as root anymore, so no need to check for that. 1997-06-29 19:19:15 +00:00
christos 30b8660384 - use ttymsg from libutil
- clean warnings
- PR/3778: Eric Fischer: talkd should find the least idle terminal
1997-06-29 19:13:01 +00:00
christos 5a6c78298f Merge in lite-2 1997-06-29 18:01:12 +00:00
explorer c80b5ae409 Doh! MAXHOSTNAMELEN, not MAXHOSTNAME 1997-01-29 10:30:14 +00:00
explorer 143a02016e Allow local hostname to be longer than 32 characters, and make certain it will
fit in the buffer space provided.  Also, ensure null termination.
1997-01-29 03:21:01 +00:00
mycroft e9d867ef50 Add RCS identifiers. 1993-08-01 17:54:45 +00:00
cgd 61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00