Commit Graph

23 Commits

Author SHA1 Message Date
dholland
5305281b0c sprinkle static 2009-08-12 08:21:41 +00:00
dholland
a95dd4ab67 don't ignore errors from read(); found by lint 2009-08-03 06:04:12 +00:00
dholland
a4cc1f4f06 Assorted minor cleanups, no functional change:
- u_int* -> uint*
   - don't make private typedefs of system structures
   - use curses TRUE and FALSE only with curses booleans, otherwise
     true and false;
   - includes cleanup
   - group globals in extern.c by functionality

Object file diffs inspected.
2009-07-20 06:39:06 +00:00
dholland
62c771fd10 Whitespace. 2009-07-20 06:00:56 +00:00
dholland
30870bd58b ANSIfy. Use __dead. Object diffs checked. 2009-07-20 05:44:02 +00:00
abs
b317f83344 If getpwuid() returns null, its not usually a good idea to dereference
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
2006-03-17 23:11:47 +00:00
jsm
cb5fd8342e Remove uses of __P. 2004-01-27 20:30:28 +00:00
agc
e5aeb4ea46 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22269, verified by myself.
2003-08-07 09:36:50 +00:00
thorpej
64d8df2f33 Cast pointer diffs to long for printing with %ld. 2000-04-27 19:31:23 +00:00
jdc
d6d7f0531f Fix arguments to *printw(). 2000-04-27 00:30:51 +00:00
mycroft
1f8979f4f7 Don't insert leading 0s in the score display. (HI CHRISTOS!) 2000-04-09 23:02:52 +00:00
jsm
be7d4de5f0 Report scores as auto-bot or not correctly.
Bug report and fix from Malcolm Parsons <malcolm@bits.bris.ac.uk>.
2000-01-20 13:24:11 +00:00
jsm
20e3305006 Fix -Wsign-compare warnings. 1999-09-18 19:38:46 +00:00
jsm
5367f3400c Security improvements for games (largely from or inspired by OpenBSD).
Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor.  If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3.  (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.
1999-09-12 09:02:20 +00:00
jsm
5fb18dd9da Use the symbolic names SEEK_SET' and O_RDONLY' where appropriate in
the games.
1999-09-08 21:57:16 +00:00
jsm
092d313019 Add use of `const' where appropriate to the games.
This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.
1999-09-08 21:17:44 +00:00
christos
4cb49d76cc Add missing prototypes 1999-05-16 00:03:35 +00:00
christos
18dfb39e84 Add -A for automatic playing mode.
Make the score file MI
1999-05-15 23:56:35 +00:00
lukem
130a514f31 deprecate bzero, rindex, etc. use symbolic constants in open() 1997-10-12 14:16:26 +00:00
lukem
9007937fbb WARNSify 1997-10-12 14:09:55 +00:00
cgd
6045e6e034 clean up import 1995-04-22 10:08:46 +00:00
mycroft
8542364e07 Add RCS identifiers. 1993-08-01 18:49:50 +00:00
cgd
61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00