Commit Graph

271 Commits

Author SHA1 Message Date
christos
e9c2d7a015 Add a set_queue_size to avoid more code duplication, and set the queue size
of all tty fd's, not just the ones that we create (the ones that we get passed
in too). Fixes my iPhone -> xl2tpd -> pppd VPN from corrupting packets with
MTU > ~650.
2013-06-24 20:43:48 +00:00
christos
415d109c2c Revert previous. It is too aggressive and might pick the wrong interface
now.
2013-06-08 13:13:34 +00:00
christos
d7a0544b97 - skip addresses that don't have a link address by finding the link address
immediately.
- don't skip v6 only interfaces.
- default to the first interface with a link address or to the best matching
  one, printing a warning if there are more than one.
- consume data after sending messages to the routing socket.
2013-06-07 17:17:14 +00:00
joerg
9edf9a0457 Remove many HAVE_GCC || HAVE_PCC conditionals as the options also apply
to Clang. Add a few cases of HAVE_LLVM for -fno-strict-aliasing.
2012-08-10 12:10:27 +00:00
christos
0049ea08f4 Bump the queue size to 32K 2011-09-24 20:19:39 +00:00
christos
63147c0e32 don't set flags in the wrong fields. 2011-07-24 01:35:15 +00:00
mrg
75e42fa7da remove most of the remaining HAVE_GCC tests that are always true in
the modern world.
2011-06-20 07:43:56 +00:00
joerg
a216da57a6 Default to -Wno-sign-compare -Wno-pointer-sign for clang.
Push -Wno-array-bounds down to the cases that depend on it.
Selectively disable warnings for 3rd party software or non-trivial
issues to be reviewed later to get clang -Werror to build most of the
tree.
2011-05-26 12:56:24 +00:00
mbalmer
428c959348 Fix PR 42923, from Takahiro HAYASHI, thanks. 2011-04-02 10:19:27 +00:00
christos
0fa7bdbba6 PR/42943: Takashi Sogabe: pppd generates invalid netmask 2010-03-10 13:45:39 +00:00
christos
e6f376b325 Fix pppd for ipv6 link-local addresses. Change the prefix length to 72 bits.
Thanks to Nagae Hidetake for providing patches and testing.
2009-11-14 04:47:03 +00:00
christos
39ac8a1e03 - prevent recursive error calls fatal -> die -> cleanup -> sys_cleanup -> cf* ->
fatal/error etc.
- prefix all the errors with __func__.
This allows me to unplug my 3G modem and have pppd exit correctly.
2009-05-24 20:31:25 +00:00
lukem
d877c4c3c0 Enable WARNS=4 by default, except for:
cpuctl  dumplfs  hprop  ipf  iprop-log  kadmin  kcm  kdc  kdigest
	kimpersonate  kstash  ktutil  makefs  ndbootd  ntp  pppd  quot
	racoon  racoonctl  rtadvd  sntp  sup  tcpdchk  tcpdmatch  tcpdump
	traceroute  traceroute6  user  veriexecgen  wsmoused  zic
(Mostly third-party applications)
2009-04-22 15:23:01 +00:00
christos
af069eb3c7 Centralize the ROUNDUP and ADVANCE macro in a header file, give them an
RT_ prefix and use them appropriately, instead of making copies. Make
pppd use the RT_ROUNDUP macro; fixes proxyarp setting on 64 bit hosts.

XXX: All this should be pulled up to 5.0
2009-04-02 21:02:06 +00:00
christos
bd4f4705da remove genmask completely and correctly. 2008-10-25 22:12:20 +00:00
christos
421f72243a don't set RTAX_GENMASK. 2008-10-25 17:48:13 +00:00
gmcgarry
3c9a95916d Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC. 2008-08-29 00:02:21 +00:00
martin
592397db3f Move to standard TNF 2 clause license 2008-05-04 12:59:38 +00:00
martin
ce099b4099 Remove clause 3 and 4 from TNF licenses 2008-04-28 20:22:51 +00:00
tls
e87faddb31 Gross workaround for PR 36390: don't overwrite the stack with zeroes when
using struct sockaddr_dl in an ifreq.
2007-05-27 18:11:38 +00:00
hubertf
889da1779b * Don't include headers twice
* Remove a few trailing whitespaces
 * Rearrange and join to one #if for some headers

Patch contributed by Slava Semushin <slava.semushin@gmail.com>
in private mail.
2007-01-16 17:32:04 +00:00
wiz
3ed1aa9185 Spell "separate" correctly. From Zafer Aydogan. 2006-12-25 18:39:47 +00:00
christos
76c4e27a2a Coveriy CID 797: Avoid NULL deref. 2006-05-25 01:22:53 +00:00
mrg
aadd7d4847 sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4. 2006-05-11 23:16:28 +00:00
mrg
58d1fc7bc5 use -fno-strict-aliasing with GCC4. 2006-05-11 07:17:41 +00:00
christos
62da5ad066 forgot to commit the links to sl* 2006-03-16 16:53:23 +00:00
christos
85d0017934 Initialize loop master to -1 so that we don't accidentally close fd 0; should
fix smb's problem.
2006-01-29 17:52:38 +00:00
christos
f4a430efd2 Use the ppp zlib from net. In preparation for importing zlib-1.2.3.
Unfortunately due to the changes in 1.2.3 that have more fine-grain
states between calls to inflate, we cannot easily adapt it to
packetized mode.
2006-01-14 19:55:11 +00:00
christos
b018a2c29a revert previous. persist does not need to reset the line discipline. (verified
by perry)
2006-01-11 21:16:51 +00:00
christos
c68bc6a017 reset the tty in the normal tty discipline if we persist so that we can
dial again.
2006-01-10 22:57:35 +00:00
christos
36134a63ad - don't leak the ipv6 file descriptor when we close
- fix packet statistics
- don't check errno if n != -1
- check more error conditions
- relinguish the ppp tty when we are on demand mode, fixes demand mode
- ansi prototypes
2005-12-31 08:36:01 +00:00
martin
58a5eedc83 If SMALLPROG is set, do not build in PAM support. While there, depend
USE_INET6 on SMALLPROG/SMALLPROG_INET6 like ftp does it.
This fixes the build of install media (pc532 and sparc64) that include
ppp support.
2005-03-22 22:20:27 +00:00
he
8e8728c45c Introduce PAM_STATIC_LDADD and PAM_STATIC_DPADD. When compiling
with MKPIC=no, possibly because the target does not support shared
libraries, these include libraries required to resolve all symbols
which end up referenced from PAM-using applications.  The libraries
presently required are -lcrypt, -lrpcsvc and -lutil.

Add use of these variables which are currently set up to use PAM,
so that they compile when MKPIC=no.

Also, in the telnetd case, reorder the order of the libraries, so
that libtelnet.a comes before -ltermcap and -lutil, again to fix
link error when MKPIC=no.

Discussed with thorpej and christos.
2005-03-04 20:41:08 +00:00
christos
bc42aa47c9 Add PAM hooks. 2005-02-22 00:34:27 +00:00
cube
88aa34aadf Include <bsd.own.mk> to get NETBSDSRCDIR definition before we use it in
.PATH.  Reported by Geoff Wing.
2005-02-21 06:41:20 +00:00
cube
44a5931b78 Add the compile hook for passwordfd plugin. 2005-02-20 11:14:37 +00:00
cube
f0a7dc0094 Make this use the new pppd version.
A few notes:
	o pppd/sys-bsd.c, pppdump/pppdump.h are local file, they're kept
	  here.  It is the case for the status plugin, too.
	o tdb.[ch] is the TDB implementation we will use, from previous
	  pppd versions.
2005-02-20 11:12:42 +00:00
lukem
7157011597 Only compile in IPv6 support if ${USE_INET6} != "no"
MKINET6 is for providing IPv6 infrastructure.
USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6).
2005-01-10 02:58:58 +00:00
christos
37d722af2b Now that ppp is a cloning interface, detect if we have support for it in
the kernel by examining if it is in the list of cloning devices.
2004-12-05 04:16:22 +00:00
dsl
9efede97a9 Add (unsigned char) cast to ctype functions 2004-10-30 15:04:45 +00:00
christos
28c9afd120 Complete check for packet length, and add verbose errors for malformed
packets.
2004-10-28 17:07:27 +00:00
itojun
e2426ca020 re-enable a length check which was commented out (why?).
http://www.securitylab.ru/49043.html
2004-10-28 07:50:34 +00:00
itojun
981eb66521 cbcp option length is too long, stop parsing.
http://www.securitylab.ru/49043.html
2004-10-28 07:45:21 +00:00
mycroft
b96803cc00 Revert part of rev 1.31. It is *not* necessary to leave the executable
unstripped to load modules.  The symbol table that we strip isn't even loaded
or used by the dynamic linker.
2004-07-21 07:00:27 +00:00
christos
eba562cd86 PR/20066: John F. Woods: Supply a loadable lcpstatus command. 2004-05-13 19:37:58 +00:00
christos
1345b8cdf5 PR/20066: John F. Woods: Add plugin lcp hooks. 2004-05-13 17:31:57 +00:00
christos
18289afe56 PR/21178: Christian Biere: Potential misuse of ctype functions [pppd] 2004-05-13 17:02:32 +00:00
elric
a4f71a0494 np->h_net is not a pointer. 2004-05-09 15:54:59 +00:00
itojun
26e2172ca7 MAX_IFS is no longer needed. Maxim Konovalov 2004-02-28 19:27:49 +00:00
lukem
804acb39e4 be more explicit in describing how the default local IP address is determined 2004-02-22 11:34:16 +00:00