Commit Graph

37 Commits

Author SHA1 Message Date
mrg de11d87641 introduce some common variables for use in GCC warning disables:
GCC_NO_FORMAT_TRUNCATION    -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION  -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW    -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE   -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints.  many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."
2019-10-13 07:28:04 +00:00
christos 2ea5bc272a PR/50454: Timo Buhrmester: Fix wrong allocation for wall(1) -g
Modernize.
2015-11-21 14:59:51 +00:00
joerg b47a64d89e static + __dead 2011-09-06 18:45:21 +00:00
lukem a4b11de136 Fix WARNS=4 issues (-Wcast-qual -Wsign-compare) 2009-04-14 07:54:51 +00:00
dholland 606b73cdb5 Skip over the ":0" entries that gdm, kdm, and unpatched versions of xdm
(ours is patched to not do this) leave in utmp. PR 26168.

I'm doing this by testing for ^:[0-9] in the line field of utmp(x),
rather than by attempting to stat the device name corresponding to the
entry as in Martin's patch, because (1) no valid tty should ever have
a name beginning with a colon, and (2) this way we don't silently skip
over real ttys that should be there but for some reason have disappeared.

(I suppose this might conceivably fail to catch entries for displays
connected via XDCMP; however, ~nobody does that any more and XDCMP is
a security hole anyhow. If anyone's really concerned about this, let
me know.)

In the long run we should look into ways of getting "tty" messages to
users logged in with an X session and no terminal windows open, as
that's probably fairly common for the desktop.
2009-02-15 06:06:55 +00:00
lukem 98e5374ccb Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.
2008-07-21 14:19:20 +00:00
tls 4147a3c54a Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry.  RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros.  Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default.  Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.
2007-05-28 12:06:17 +00:00
christos fc23d32c7d Call check_sender with NULL atime, meaning no strict checking. 2004-10-27 17:49:19 +00:00
agc 89aaa1bb64 Move UCB-licensed code from 4-clause to 3-clause licence.
Patches provided by Joel Baker in PR 22365, verified by myself.
2003-08-07 11:13:06 +00:00
christos 45aed1fbde PR/7713: David Holland: warn if we have mesg n. 2003-04-21 00:05:30 +00:00
lukem aff92a7756 fix minor buglet in previous 2003-03-27 13:21:48 +00:00
lukem b6a63b16dd * Add support for "-g group", to send messages to users in this group.
This option may be specified multiple times, and any user in any of the
  specified groups will receive the message.
  (From OpenBSD, with tweaks from FreeBSD fed back into OpenBSD).

* Ensure that paths are MAXPATHLEN.  (From OpenBSD)

* Display timezone when printing time.  (From FreeBSD PR 17867 via wall.c 1.14)
2003-03-27 13:16:19 +00:00
lukem 5d4973fe97 makefile delint. use NETBSDSRCDIR as appropriate 2002-09-18 14:00:33 +00:00
itojun 2abe377059 defend against malicious line in ut_line, which could cause unwanted
writes to anything under /dev.  revoke setuid/gid privs earlier.
From: xs@kittenz.org
2002-08-16 20:21:48 +00:00
christos c020d65e19 utmpx support. 2002-08-02 01:52:13 +00:00
mjl c5775359ae ANSIfy 2001-01-05 04:06:49 +00:00
mjl d18550fa63 Remove mysterious check for "sleeper" who would not get walled. 2001-01-05 04:00:34 +00:00
taca 20117cd175 - Knf auto variables in modified line by me.
- Print "??" as tty name instead of print nothing.  Suggested by jhawk.
2000-10-02 03:28:42 +00:00
mjl 11ce988357 Increase temporary buffer size not to truncate temp file template. 2000-09-06 10:17:01 +00:00
taca 99ebb8038f - Check return value of ttyname(3) and prevent to pass NULL pointer for
"%s" in printf style format string.
- Use STDERR_FILENO as paramter for ttyname(3).
2000-09-04 15:21:24 +00:00
simonb d88dfea295 Don't declare 'extern opt*' getopt variables. 2000-04-14 06:11:07 +00:00
christos dd3520c061 PR/7664: David Holand: bogus check for mkstemp() return code. 1999-05-29 21:10:43 +00:00
garbled 9e44e9b578 More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages.  Many more to
come.
1999-03-22 18:16:34 +00:00
mycroft af26acbc65 const poisoning. 1998-07-26 23:14:40 +00:00
mrg ed666575e1 ensure hostname fits and is nul-terminated. 1998-07-05 10:12:51 +00:00
lukem a6f32a1d45 use err.h, fix .Nm usage 1997-10-20 03:13:32 +00:00
christos a838817b21 Add WARNS=1 1997-07-01 20:49:59 +00:00
christos c897d730b5 - Cleanup warnings
- Move ttymsg to libutil.h
1997-06-29 18:28:18 +00:00
mrg 23768a9e9a remove possibly dangerous sprintf and strcpy calls. 1997-02-11 08:42:03 +00:00
jtc a8bfd3d17a Merged with 4.4lite
Changed to conform to NetBSD's new RCS Id conventions.
1994-11-17 07:17:53 +00:00
jtc f7c6bf575a Minor tweaks: including header files to bring prototypes into scope,
explicitly declaring function return values, etc. to make gcc -Wall
shut up.
1993-08-27 22:30:10 +00:00
mycroft e9d867ef50 Add RCS identifiers. 1993-08-01 17:54:45 +00:00
mycroft c3e42d1c64 Add RCS indentifiers. 1993-08-01 07:22:47 +00:00
mycroft d0f8d5d2bb Add RCS identifiers. 1993-07-30 22:28:22 +00:00
mycroft f90eda1c1e Fix NULL pointer reference and don't drop character when wrapping. 1993-04-26 14:37:49 +00:00
cgd b9b17c3018 added support for uid `nobody' running wall with -n option (no banner),
for rwalld support.
1993-04-04 16:10:33 +00:00
cgd 61f282557f initial import of 386bsd-0.1 sources 1993-03-21 09:45:37 +00:00