Commit Graph

26 Commits

Author SHA1 Message Date
matt e1a2f47f12 Use C89 function definition 2012-03-21 10:10:36 +00:00
mrg 77c15e81ac add a missing " to a string literal in some #if'd out code that GCC 4.5 found. 2011-06-21 09:35:23 +00:00
christos 88b197ec7f PR/38413: Takahiro Kambe: mt(1) print some junk output when using remote tape
Not all fields are valid in the ioctl to get tape info in the rmt protocol.
Zero out the struct so that we don't print junk.
While here, KNF.
2011-05-31 12:24:33 +00:00
pooka f836d17195 Improve isrmt() check: it cannot be a rmt fd if there are no pipes
open for the fd.  Prevents collision with rumphijack.

Also, prevent potential hyperspace memory access.

Does someone want to write tests for this facility?
2011-02-18 16:10:09 +00:00
enami 8713952936 Move prototype of isrmt() to rmt.h. It is a public interface
described in rmtops(3).
2010-08-31 05:12:35 +00:00
christos 1acc910067 Coverity CID 587: Dead code detected because the loop was using the wrong
variable (rc instead of rv).
2006-03-19 23:05:50 +00:00
christos 44fad74b6a - Pass lint.
- Fix signness problems that confused error detection.
- Avoid possible buffer overflow.
2005-12-05 02:04:16 +00:00
lukem e2d7870626 add RCSID 2003-03-08 07:42:33 +00:00
lukem 6a973ed877 WARNS=2 fixes 2001-11-05 15:10:25 +00:00
wiz 14dbdf5518 Negative exit code cleanup: Replace exit(-x) with exit(x).
As seen on tech-userlevel.
2001-04-06 11:13:45 +00:00
enami badab93fb1 Make this file compile again on alpha; size_t isn't always same size as int. 2001-01-05 05:42:45 +00:00
enami 43ca618d61 More cosmetic changes. 2001-01-05 05:40:38 +00:00
lukem 32dd941f7f convert to ANSI KNF 2001-01-04 15:30:15 +00:00
lukem d896261208 back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.
1999-09-20 04:38:56 +00:00
lukem b48252f365 * use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
  and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

		_DIAGASSERT(path != NULL)
	#ifdef _DIAGNOSTIC
		if (path == NULL) {
			errno = EFAULT;
			return (-1);
		}
	#endif
1999-09-16 11:44:54 +00:00
simonb 42724dd4d2 More trailing white space. 1999-07-02 15:37:33 +00:00
mrg 5f2732ab6d - support RCMD_CMD, ala rcmd(3).
- put paths for rsh and rmt into "pathnames.h"
- document this.
1998-03-08 23:36:46 +00:00
thorpej 6e190eed28 - Convert a few functions to variable arguments so that they can be
prototyped like the functions that they remap (open, fcntl, ioctl).
- Pull in prototypes from <rmt.h>.
1997-10-21 19:58:21 +00:00
mrg 395c20ea27 clean up WARNS on the alpha. 1997-10-10 08:45:29 +00:00
lukem ae6b9c674a WARNSify 1997-10-09 11:58:15 +00:00
mikel e6077a7689 gcc -Wall fixes, including: end unterminated comment (!), add braces
to Ctp and Ptc array initializers, fix sprintf() format in
  _rmt_lseek(), add explicit return type for _rmt_ioctl(), and move
  isrmt() definition so that it's defined before it's used.
1997-06-20 04:24:23 +00:00
mrg 9cd5492c02 - convert unsafe strcpy(), strcat() and sprintf() to the `n' versions.
- some KNF.
1997-01-23 14:01:45 +00:00
thorpej dc06f7ce36 Change an instance of "int" to "unsigned long" (the correct type for
ioctl commands under NetBSD) so that this compiles on the Alpha.
1996-08-13 20:09:50 +00:00
jtc 7693327da9 rsh is now in /usr/bin, not /usr/ucb 1996-08-09 04:17:36 +00:00
jtc 8ee4077ea0 minor changes for better integration into NetBSD 1996-08-09 03:39:00 +00:00
jtc 67ead26177 Remote mag tape library from volume 18 of comp.sources.unix. 1996-08-09 03:35:17 +00:00