Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
100,384 Commits 606 Branches 0 Tags 3.1 GiB
Commit Graph

60 Commits

Author SHA1 Message Date
jdolecek fceac2db48 After showing help, touchwin/wrefresh the stdscr, do not try to do 
that for form subwindow, which may be NULL (or is always, even?).

This fixes SIGSEGV when one goes to
Network related configuration -> Modify the hosts file -> Delete host entries
and presses F1 (Help).
 2002-07-26 08:43:26 +00:00
jdolecek d5d1e7aa6c fgetln() does NOT return NUL-terminated string 
This fixes bin/13624 by Jun-ichiro itojun Hagino
 2002-07-26 07:59:33 +00:00
jdolecek 973b4b497c form_appenditem(): make sure fte->list is initialized 
process_{pre,}form(): g/c unnecessary malloc, plug memory leak
gen_list(): only check ftp->list after realloc()
handle_{pre,}form(): allocate F[] via calloc(3), so that the memory is
     properly zeroed
 2002-07-25 12:42:39 +00:00
jdolecek d675751f34 g/c some pointless malloc()s 2002-07-25 12:39:26 +00:00
jdolecek 5ff2a932b1 launch_subwin(): make sure string 'command' is initialized; malloc may not return 
zeroed memory. This should fix the SIGSEGV part of bin/17718
by Grant Beattie.
 2002-07-25 12:34:09 +00:00
jdolecek 70accc48c9 add XXX comment for piece of very strange code; I don't currently 
want to investigate more
 2002-07-25 12:20:56 +00:00
jdolecek ee3d448cbd Array retrurned by form_fields() is NOT NULL-terminated - use field_count() 
to get amount of fields on the form instead.
This fixes a SIGSEGV problem I encountered, and possibly also the crash part
of bin/17718 by Grant Beattie.
 2002-07-25 09:38:31 +00:00
christos 93756e61ad XXX: this code needs a lot more cleanup... There is no clear malloc/free 
policy and the data dependent initialization is very fragile. I.e.
     the code assumes because the data entry is of type foo, it has
     initialized certain fields and others not.
- make sure list is not NULL before you use it.
- don't realloc on every loop iteration!
- don't increment i when there are short lines; leads to uninitialized
  list[i] entries [fixes bills' core-dump, hi bill!]
 2002-04-02 18:59:54 +00:00
christos 3afdbb7d94 XXX: this code has a lot of bugs and needs further cleanup. 
- don't allocate:
	char *p = malloc(len * sizeof(char *))
  when you mean:
	char *p = malloc(len)
- eliminate duplicated code by creating functions and try not to wrap
- use mvwinnstr instead of mvwinstr
 2002-04-02 18:57:01 +00:00
blymn f987c067b5 do not turn echo on after running a script, otherwise the forms display 
will be messed up by input being echoed.
 2002-02-12 12:21:01 +00:00
wiz 2b666b304a Drop a .Pp, sort sections. 2002-02-02 01:57:35 +00:00
wiz a2d753e3ef Whitespace nits. 2002-01-19 11:44:57 +00:00
thorpej bf0e32f7fc Remove unneeded/unused TREE_ISEMPTY() (which also happens to clash 
with the TREE_ISEMPTY() in menutree.h, which gcc 3.1 correctly warns
about).
 2001-12-31 20:00:40 +00:00
jhawk 521fae39bb .Nm punct => .Nm "" punct 
minor markup fixes.
 2001-12-15 21:21:00 +00:00
wiz 251b3464be heirarchy -> hierarchy 2001-08-24 10:24:45 +00:00
hubertf c5967dbc76 Fix typo: heirarchies 2001-08-24 00:48:48 +00:00
wiz 1e378c4c12 precede, not preceed. 2001-08-20 12:00:46 +00:00
itojun bb65ba4b13 fgetln() does not \0-terminate the result. 2001-08-03 09:18:58 +00:00
garbled c63c221b86 Fix a bug in the multilist noted by Brett Lymn. When nothing was selected 
from the popup, don't populate the field with a NULL buffer.

Edit the TODO list, removing a few fixed items from my bughunt tonight.
 2001-08-01 09:08:55 +00:00
garbled 249cbcd0e5 add two more bugs 2001-08-01 01:02:55 +00:00
garbled 1092eb0c9d Add some known bugs for sushi.. lest I forget them. 2001-08-01 00:53:58 +00:00
wiz 3f9984fc90 `existent', not `existant' 2001-06-19 13:42:07 +00:00
garbled 804fb9a962 Add some stuff and tidy up the TODO list 2001-05-03 07:46:29 +00:00
garbled 6ee451eb01 Oops.. forgot to back a change out 2001-04-06 07:57:05 +00:00
garbled d0d9366447 Back out part of last change. it had an undesired effect. 2001-03-16 12:54:47 +00:00
garbled db9db9cc00 Handle the error case that the script specified in an escript-like form 
function does not exist a little better, rather than dying later in fgetln.
Also fix up a wierd corner case in escript where the programmer forgets
to put in the scriptname.
 2001-03-15 09:10:31 +00:00
garbled dc4794cae1 Fix a few bugs in the handling of INVIS and NOEDIT fields. Mostly having 
to do with very large fields being cut off by the end of the screen.
Also.. change the max-width of an onscreen field to 19 from 21..  I don't
know where I got 21 from.. but it was definately wrong.
 2001-03-14 08:22:00 +00:00
garbled 2566752a91 Add IPV6 and IPV4 field types to sushi. 2001-03-07 10:10:20 +00:00
garbled bde8ce5b17 Change the scripting and logging functions to flip the value, rather than 
require an on/off argument.  Change the little bottom-label so the user
can see what the current value of scripting and logging is at all times.
 2001-03-03 13:54:22 +00:00
cgd c2bdafab79 use getprogname() 2001-02-20 23:51:59 +00:00
garbled 25a0bdc99a Fix handling of the backspace and delete keys when editing a field. 2001-02-01 08:43:46 +00:00
garbled aa592358be Add a popup message telling users how to use the multiple selection and 
list field types, so users aren't mystified when they encounter one.
 2001-02-01 08:29:46 +00:00
garbled 305f1af6ff Major cleanup: 
Add new form keyword, iscript, which allows script generated integer fields.
This uncovered a whole host of bugs, which uncovered a whole host of memory
leaks, which hopefully I've fixed most of now (in this file at least).
 2001-01-31 09:35:42 +00:00
garbled 18d0882a77 Add a function to fetch a list of different package categories that are 
available to the user to install binary packages with.

Modify the function API so it can handle preforms like it is supposed to.
 2001-01-24 09:30:30 +00:00
garbled 1dc7842166 Deal with null returns from script entry field types in a semi-sane manner 2001-01-24 08:29:56 +00:00
garbled 18e0c94727 Fix an off-by one error in run.c having to do with the down arrow, and fix 
some minor display glitches in the form routines.
 2001-01-24 07:46:23 +00:00
garbled 69f61c7f62 Fix the editing popup window so it's actually readable. 2001-01-24 07:23:51 +00:00
garbled fdb7bdb2c0 Fix some bugs pointed out by Brett Lymn where I wasn't checking the return 
value of field_buffer.
 2001-01-24 07:17:10 +00:00
garbled 73ffa92b18 Fix one of the bugs in the TODO list, sushi would die with a bad endpoint 
if you hit enter on one of the blank lines in the main menu.
 2001-01-22 07:12:49 +00:00
garbled b0ee440a2f Update the TODO list a little bit. Add a few items that were brought to 
my attention.
 2001-01-19 07:50:20 +00:00
cgd f762cf8294 for linking, libraries should be named _after_ the libraries that need them. 
In this case, curses should come after cdk & form.
 2001-01-16 02:34:14 +00:00
garbled 3c1becf72b Fix a buffer overrun in the parsing of the searchpaths, and check the return 
values of some curses functions I overlooked.
Pointed out by Brett Lymn in private email.
 2001-01-14 21:23:23 +00:00
christos b420e5eb3e don't include bsd.nls.mk; bsd.prog.mk does it for us. 2001-01-14 06:26:56 +00:00
garbled b4aac50fda Changes to sushi to allow users to bind different keys to the various 
built-in functions.  This allows users to change F1 to say, ^X, in the case
where a function key might not be available, or perhaps is bound to a window
manager.

problem noted by Nathan Williams
 2001-01-10 10:00:29 +00:00
garbled ee3a00e29e de-lint 2001-01-10 03:05:48 +00:00
garbled 259b42afe7 Some cleanups in how help is handled. Now print a dialog box saying that 
help could not be found when no help files are available.  When the help
window dissapears, redraw the screen so the menu isn't invisible.
 2001-01-09 21:38:53 +00:00
garbled 009ea1962a Fix a segfault when the user hits ESC inside the F4 selection box for a 
list field.
 2001-01-09 19:32:35 +00:00
garbled f6177aaaba When dropping out to a shell for the user via F9, use $SHELL if it's 
available, rather than hardcoding /bin/sh.  Problem noted by itojun on
tech-userlevel
 2001-01-09 19:01:57 +00:00
augustss d56c24a854 Make this compile again. 
(Compile before commit...)
 2001-01-09 17:08:47 +00:00
garbled 4ce5fb6f63 Handle finding help for F1 better in the toplevel menu. 
TODO: print a dialog message if help cannot be found.
 2001-01-09 09:41:41 +00:00