Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix range to check to avoid a static buffer overrun, when

Browse Source 
font->encoding == 4, which would cause access past the end of the encodings
array.

Fixes Coverity CID 1446.

Note that perhaps we should actually have an encoding line for
WSDISPLAY_FONTENC_ISO2 which is encoding 4.
This commit is contained in:
chris 2006-03-17 03:21:57 +00:00
parent 8adb45d48c
commit fea7c6a78b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/wsfont/wsfont.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: wsfont.c,v 1.40 2005/12/24 23:41:34 perry Exp $ */
/* $NetBSD: wsfont.c,v 1.41 2006/03/17 03:21:57 chris Exp $ */
/*-
* Copyright (c) 1999, 2000, 2001, 2002 The NetBSD Foundation, Inc.
@ -37,7 +37,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: wsfont.c,v 1.40 2005/12/24 23:41:34 perry Exp $");
__KERNEL_RCSID(0, "$NetBSD: wsfont.c,v 1.41 2006/03/17 03:21:57 chris Exp $");
#include "opt_wsfont.h"
@ -714,7 +714,7 @@ wsfont_map_unichar(struct wsdisplay_font *font, int c)
if (font->encoding == WSDISPLAY_FONTENC_ISO)
return (c);
if (font->encoding < 0 || font->encoding > MAX_ENCODING)
if (font->encoding < 0 || font->encoding >= MAX_ENCODING)
return (-1);
hi = (c >> 8);